On Thu, 28 May 2026 15:56:44 GMT, Volodymyr Paprotski <[email protected]>
wrote:
>> Shawn Emery has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove commented code
>> - Comments from @vpaprotsk
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_poly25519.cpp line 183:
>
>> 181: }
>> 182:
>> 183: __ pop_ppx(rdx);
>
> Oh! this is clever!! nice!
>
> Could you add a comment in the parent function:
> // __ pop_ppx(rdx); // restored in the helper already
>
> ("Clever code should have comments".. lack of 'symmetry' caught my
> attention.. but as long as its noted, don't have a problem)
Haha, thank you for noticing! Done.
> src/hotspot/cpu/x86/stubGenerator_x86_64_poly25519.cpp line 224:
>
>> 222: multiply_25519_scalar(aLimbs, bLimbs, rLimbs, c, bArg, d, b, mask,
>> _masm);
>> 223:
>> 224: __ pop_ppx(r15);
>
> Comment here?
> `// __ pop_ppx(rdx); // restored in the helper already`
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31087#discussion_r3321267130
PR Review Comment: https://git.openjdk.org/jdk/pull/31087#discussion_r3321266856
