On Sat, 30 May 2026 23:36:12 GMT, Shawn Emery <[email protected]> wrote:
>> Curve25519 polynomial arithmetic is performed with intrinsincs implemented >> in GPR related instructions for multiplication and squaring operations >> (methods mult() and square()). Benchmark improvements include: >> >> - X25519 encapsulation: +19% >> - X25519 decapsulation: +19% >> - X25519-MLKEM encapsulation: +12% >> - X25519-MLKEM decapsulation: +15% >> - X22519 key agreement: +19% >> - X25519 key-pair generation: +19% >> - X25519-MLKEM key-pair generation: +13% >> - EdDSA key-pair generation: +20% >> - EdDSA signing: +19% >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shawn Emery has updated the pull request incrementally with one additional > commit since the last revision: > > Add more comments and define constants Marked as reviewed by ascarpino (Reviewer). src/hotspot/cpu/x86/stubGenerator_x86_64_poly25519.cpp line 148: > 146: for (int j = i + 1; j < limbs; j++) { > 147: __ movq(rax, Address(aLimbs, j * 8)); > 148: __ imulq(aArg); // rdx:rax = a * a comment nit. // rdx:rax = a[j] * a[i] ------------- PR Review: https://git.openjdk.org/jdk/pull/31087#pullrequestreview-4414139061 PR Review Comment: https://git.openjdk.org/jdk/pull/31087#discussion_r3344861959
