On Fri, 22 Aug 2025 12:25:24 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Weijun's comments
>
> test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java line 101:
>
>> 99: // P11RSACipher
>> 100: for (String t : TRANSFORMATIONS) {
>> 101: checkModes(t, p);
>
> Can we add the catch and set flag actions in this loop so there is no need to
> change the structure of the test? Something like this:
>
> List<String> skipped = new ArrayList<>();
> for (String t : TRANSFORMATIONS) {
> try {
> checkModes(t, p);
> } catch (SkippedException se) {
> skipped.add(t);
> }
> }
> if (!skipped.isEmpty()) {
> throw new SkippedException("Some tests failed: " + skipped);
> } else {
> System.out.println("All tests passed");
> }
Done in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2296670280
