On Fri, 22 Aug 2025 11:10:39 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> * cleanup
>> * changed tests hiding errors and skips to be different `@test`, so the
>> errors could be thrown
>> * tests affected:
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestKATForGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipherWrap.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyOutputSize.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java
>> - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/Test4512704.java
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changed tests from multiple to one with tracking skipped exception
test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java line 129:
> 127: Cipher.getInstance(t, p);
> 128: } catch (Exception e) {
> 129: throw new SkippedException("Skip " + t + " due to " +
> e.getMessage());
Maybe we can keep the `System.out.println` here. Anyway, make sure all the
messages are visible when there are multiple skips.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2293637025
