On Fri, 22 Aug 2025 12:45:47 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed tests from multiple to one with tracking skipped exception
>
> test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java line 129:
>
>> 127: Cipher.getInstance(t, p);
>> 128: } catch (Exception e) {
>> 129: throw new SkippedException("Skip " + t + " due to " +
>> e.getMessage());
>
> Maybe we can keep the `System.out.println` here. Anyway, make sure all the
> messages are visible when there are multiple skips.
They are printed here later
try {
checkModes(t, p);
} catch (SkippedException skippedException) {
// printing to System.out, so it's easier to see which test it
relates to
skippedException.printStackTrace(System.out);
skipped.add(t);
}
...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2296670831
