On Wed, 11 Sep 2024 20:16:40 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> batch of review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 148: > >> 146: // JDK 17 >> 147: // Also, JEP 305 came out in JDK 14, so we can't declare a >> variable >> 148: // in instanceof either > > Personally I don't care about these restrictions. Backporters can modified to > code to suit their releases. @wangweij: No change necessary. Personal opinion. These comments are here to stave off reviewer comments that may suggest doing it differently and to reflect my choice to ease the job of backporters. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1755707040
