On Fri, 13 Sep 2024 14:54:59 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Now that you have them in `finally`, the cleanup lines you added last time >> can be removed. > > Updated in > https://github.com/openjdk/jdk/pull/20301/commits/e7e5b3e5a017c7b7ce6db3c17ea4c1fca27cd901. Sorry for another round on this. It's still possible that `consolidateKeyMaterial` works fine on `ikms` but throws IKE on `salts`, and this time `inputKeyMaterial` is not cleaned up. Also, is it possible that `consolidateKeyMaterial` throws an IAPE directly so you don't need to catch and wrap? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1759063991
