On Mon, 13 May 2024 16:30:54 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > update @return statement src/java.base/share/classes/javax/crypto/KDFSpi.java line 58: > 56: * The sole constructor. > 57: * <p> > 58: * An {@code AlgorithmParameterSpec} may be specified for PRF > algorithms that s/PRF/KDF/ src/java.base/share/classes/javax/crypto/KDFSpi.java line 72: > 70: protected KDFSpi(AlgorithmParameterSpec algParameterSpec) > 71: throws InvalidAlgorithmParameterException { > 72: this.algorithmParameterSpec = algParameterSpec; Related to above comment about not storing the params, make this ctor do nothing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598822450 PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598824597
