On Mon, 13 May 2024 19:58:27 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 407:
>
>> 405: }
>> 406:
>> 407: public static final class HkdfSHA256 extends HkdfKeyDerivation {
>
> Can these classes be package-private instead of public?
It looks like they must be public, at least with the way things are organized
currently.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599103522
