On Thu, 9 May 2024 15:30:22 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> continued code review comments
>
> src/java.base/share/classes/javax/crypto/KDF.java line 58:
>
>> 56:
>> 57: public final class KDF {
>> 58: private static final Debug debug = Debug.getInstance("jca",
>> "KeyDerivation");
>
> Change to a shorter option name "kdf". Also, add it into the help output of
> `sun.security.util.Debug`.
Done.
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 277:
>
>> 275:
>> 276: // HKDF-Expand(PRK, info, L) -> OKM
>> 277: private SecretKey pseudoRandomKey = null;
>
> Name too long. Just use `prk`.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597019696
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597019966
