On Thu, 9 May 2024 15:13:25 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> disallow null or empty values for ikm/salt rather than silent ignore
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 213:
>
>> 211: /**
>> 212: * Static helper-method that may be used to initialize an {@code
>> ExtractExpand} object
>> 213: * <p>
>
> Do we really need this method since user can already call
> `extract()....andExpand()`?
>
> If this method is removed, then we don't need to check null for `ext` in `new
> ExtractExpand`.
>
> Or, you want to create one `Extract` object and then reuse it multiple times?
It makes sense to leave it for consistency's sake, IMO.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598702032
