On Thu, 9 May 2024 14:11:44 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 40:
>
>> 38: * @since 23
>> 39: */
>> 40: public interface HKDFParameterSpec extends KDFParameterSpec {
>
> Make it `sealed` and its 3 child `final`.
Done. Please resolve if satisfied.
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 50:
>
>> 48: List<SecretKey> ikms = new ArrayList<>();
>> 49: List<SecretKey> salts = new ArrayList<>();
>> 50: SecretKey prk = null;
>
> No `prk` here. In fact, maybe rename `Builder` to `ExtractBuilder`?
Done. Please resolve if satisfied.
Not renaming, since this builder can technically generate an `ExtractExpand`
too.
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 316:
>
>> 314: */
>> 315: public byte[] info() {
>> 316: return info;
>
> return a clone.
Done. Please resolve if satisfied.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595928811
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595928890
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595930025
