On Thu, 21 Sep 2023 15:55:24 GMT, Ben Perez <d...@openjdk.org> wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed copyright, refactored test to get rid of runTest test/jdk/java/security/KeyStore/PKCS12/java.security line 2: > 1: # do not set keystore.type property, so default value will be used > 2: #keystore.type= I think this should not be commented out, otherwise you are still getting the `keystore.type=pkcs12` setting from the `java.security` file in the JDK. To make sure this is working, try temporarily setting this to "foobar" or something random and see if the test fails. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1333494954
