On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez <d...@openjdk.org> wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added test to check that when keystore.type is null it defaults to pkcs12 test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 34: > 32: * KeyStore.getDefaultType() value is related to property value. Expect a > full > 33: * match the value 'keystore.type' and the value of the > 34: * KeyStore.getDefaultType() I don't quite get the summary... Isn't the property value set to null? How can it be full match to KeyStore.getDefaultType()? test/jdk/java/security/KeyStore/PKCS12/java.security line 1: > 1: # override keystore.type property and make it not exist nit: maybe the comment is easier to understand if changed to "do not set keystore.type property, so default value will be used". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331044517 PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331045976
