On Wed, 20 Sep 2023 06:02:52 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added test to check that when keystore.type is null it defaults to pkcs12 > > test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 2: > >> 1: /* >> 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved. > > Where did you get the copyright from? IIRC, there should be a coma after the > year and also copyright for the test file should not have the "Classpath" > thing. I copied it from the CheckDefaults test - is there a more up to date one I should be using? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1331829846
