On Fri, 19 May 2023 16:59:58 GMT, Mark Powers <mpow...@openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8307794 > > Mark Powers has updated the pull request incrementally with four additional > commits since the last revision: > > - Ferenc: comments 2 and 4 > - oops > - Sean's comments > - added @run test/jdk/sun/security/provider/lms/TestLMS.java line 30: > 28: * @summary tests for HSS/LMS provider > 29: * @modules java.base/sun.security.util > 30: * @run testng/othervm TestLMS Why is the test run with `testng`, can this just be `main/othervm`? test/jdk/sun/security/tools/jarsigner/VerifyHSSLMSSignedJar.java line 29: > 27: * @summary verify JAR files signed with HSS/LMS > 28: * @library /test/lib > 29: * @run testng/othervm VerifyHSSLMSSignedJar I don't see anything that is using testng in this test, can we just run as `main/othervm`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1199329785 PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1199322468
