On Thu, 18 May 2023 13:18:12 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8307794 > > test/jdk/sun/security/tools/jarsigner/DisableLMS.java line 26: > >> 24: /* >> 25: * @test >> 26: * @bug JDK-8307794 > > I think the bug here should be what it is testing, which is the HSS/LMS > implementation (JDK-8298127). Same comment for other tests. fixed > test/jdk/sun/security/tools/jarsigner/DisableLMS.java line 28: > >> 26: * @bug JDK-8307794 >> 27: * @summary verify JAR files signed with HSS/LMS >> 28: * @author Wang Weijun > > We don't usually put `@author` labels in code/tests anymore. removed` @author` > test/jdk/sun/security/tools/jarsigner/DisableLMS.java line 39: > >> 37: import java.util.Base64; >> 38: >> 39: public class DisableLMS { > > The name of this test seems too specific, since it also tests a signed JAR > when HSS/LMS is not disabled. Perhaps rename this to `VerifyHSSLMSSignedJar`? renamed to `VerifyHSSLMSSignedJar` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1197973701 PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1197974502 PR Review Comment: https://git.openjdk.org/jdk/pull/13940#discussion_r1197975370
