On Thu, 11 May 2023 19:06:59 GMT, Mark Powers <mpow...@openjdk.org> wrote:
> https://bugs.openjdk.org/browse/JDK-8307794 I suggest the following: 1. Separate the data from the code and put the data to the end of the files (e.g. create a " TestCase[] testCases;" array and let the TestCase class handle the creation of the byte arrays from the hex strings. A testCase can have expected outcome, along with the data, too, that might make the actual testing code more compact. 2. Reformat all the data similarly to the one in DisableLMS.java (about 80 character long lines) - there are some very long lines in HssLms.java and very short ones in TestLMS.java and HssLms.java . 3. Don't us simply LMS in the file names. HSS or HSSLMS would align better with what you are testing. 4. Remove the SHAKE tests (test11-13 in HssLms.java . ------------- PR Comment: https://git.openjdk.org/jdk/pull/13940#issuecomment-1552743471
