Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Marek Marczykowski-Górecki
On Wed, Mar 19, 2025 at 10:43:12AM +0100, Jan Beulich wrote: > On 19.03.2025 10:15, Jan Beulich wrote: > > On 18.03.2025 18:01, Marek Marczykowski-Górecki wrote: > >> --- a/xen/Makefile > >> +++ b/xen/Makefile > >> @@ -411,6 +411,8 @@ ifneq ($(CONFIG_CC_IS_CLANG),y) > >> CFLAGS += -Wa,--strip-loca

Re: [PATCH] x86/mm: Fix IS_ALIGNED() check in IS_LnE_ALIGNED()

2025-03-19 Thread Jan Beulich
On 19.03.2025 15:20, Andrew Cooper wrote: > The current CI failures happen to be a latent bug triggered by a narrow set of > properties of the initrd, which CI encountered by chance. Plus properties of the host memory map. > One step during boot involves constructing directmap mappings for module

Re: [PATCH v6 13/18] system/xen: remove inline stubs

2025-03-19 Thread Anthony PERARD
On Mon, Mar 17, 2025 at 11:34:12AM -0700, Pierrick Bouvier wrote: > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Pierrick Bouvier Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

Re: [PATCH] x86/setup: correct off-by-1 in module mapping

2025-03-19 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 12:21:53PM +0100, Jan Beulich wrote: > If a module's length is an exact multiple of PAGE_SIZE, the 2nd argument > passed to set_pdx_range() would be one larger than intended. Use > PFN_{UP,DOWN}() there instead. > > Fixes: cd7cc5320bb2 ("x86/boot: add start and size fields

Re: [PATCH 0/2] xen: An error handling fix

2025-03-19 Thread Markus Armbruster
Queued for 10.0.

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Jan Beulich
On 19.03.2025 14:40, Marek Marczykowski-Górecki wrote: > On Wed, Mar 19, 2025 at 01:43:59PM +0100, Jan Beulich wrote: >> On 19.03.2025 12:58, Marek Marczykowski-Górecki wrote: >>> On Wed, Mar 19, 2025 at 10:43:12AM +0100, Jan Beulich wrote: On 19.03.2025 10:15, Jan Beulich wrote: > On 18.0

Re: [PATCH] tools/arm: Fix nr_spis handling v2

2025-03-19 Thread Orzel, Michal
On 19/03/2025 15:05, Andrew Cooper wrote: > > > On 19/03/2025 2:01 pm, Alejandro Vallejo wrote: >> On Tue Mar 18, 2025 at 9:00 AM GMT, Michal Orzel wrote: >>> We are missing a way to detect whether a user provided a value for >>> nr_spis equal to 0 or did not provide any value (default is also

Re: [PATCH] x86/PVH: account for module command line length

2025-03-19 Thread Andrew Cooper
On 19/03/2025 11:18 am, Jan Beulich wrote: > As per observation in practice, initrd->cmdline_pa is not normally zero. > Hence so far we always appended at least one byte. That alone may > already render insufficient the "allocation" made by find_memory(). > Things would be worse when there's actual

Re: [PATCH] tools/arm: Fix nr_spis handling v2

2025-03-19 Thread Andrew Cooper
On 19/03/2025 2:01 pm, Alejandro Vallejo wrote: > On Tue Mar 18, 2025 at 9:00 AM GMT, Michal Orzel wrote: >> We are missing a way to detect whether a user provided a value for >> nr_spis equal to 0 or did not provide any value (default is also 0) which >> can cause issues when calculated nr_spis is

Re: [PATCH v9 2/8] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2025-03-19 Thread Mykyta Poturai
On 17.03.25 16:56, Jan Beulich wrote: > On 14.03.2025 14:34, Mykyta Poturai wrote: >> From: Oleksandr Tyshchenko >> >> The main purpose of this patch is to add a way to register PCI device >> (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] >> before assigning that device to

Re: [PATCH] x86/setup: correct off-by-1 in module mapping

2025-03-19 Thread Andrew Cooper
On 19/03/2025 12:15 pm, Roger Pau Monné wrote: > On Wed, Mar 19, 2025 at 12:21:53PM +0100, Jan Beulich wrote: >> If a module's length is an exact multiple of PAGE_SIZE, the 2nd argument >> passed to set_pdx_range() would be one larger than intended. Use >> PFN_{UP,DOWN}() there instead. >> >> Fixes

Re: [PATCH v9 2/8] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2025-03-19 Thread Jan Beulich
On 19.03.2025 16:21, Mykyta Poturai wrote: > On 17.03.25 16:56, Jan Beulich wrote: >> On 14.03.2025 14:34, Mykyta Poturai wrote: >>> From: Oleksandr Tyshchenko >>> >>> The main purpose of this patch is to add a way to register PCI device >>> (which is behind the IOMMU) using the generic PCI-IOMMU

Re: [PATCH v1 3/4] xen/riscv: implement basic aplic_preinit()

2025-03-19 Thread Oleksii Kurochko
On 3/17/25 4:40 PM, Jan Beulich wrote: On 11.03.2025 17:19, Oleksii Kurochko wrote: Based on the code from [1] provided by Romain Caritey from Microchip with some minor changes(): "Based on", to me at least, suggests an import from some other project. The reference looks to be to a Xen tree th

[PATCH] x86/boot: Simplify the expression for extra allocation space

2025-03-19 Thread Andrew Cooper
The expression for one parameter of find_memory() is already complicated and about to become moreso. Break it out into a new variable, and express it in an easier-to-follow way. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/hvm/do

Re: [PATCH 2/4] x86/traps: Move percpu_traps_init() into traps-setup.c

2025-03-19 Thread Jan Beulich
On 17.03.2025 20:20, Andrew Cooper wrote: > Move the declaration from asm/system.h into asm/traps.h. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich > --- a/xen/arch/x86/traps-setup.c > +++ b/xen/arch/x86/traps-setup.c > @@ -3,5 +3,20 @@ > * Configuration of

[PATCH v2] xen/arinc653: call xfree() with local IRQ enabled

2025-03-19 Thread Anderson Choi
xen panic is observed with the following configuration. 1. Debug xen build (CONFIG_DEBUG=y) 2. dom1 of an ARINC653 domain 3. shutdown dom1 with xl command $ xl shutdown (XEN) (XEN) Panic on CPU 2: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() ||

Re: [PATCH 3/7] xen: remove -N from the linker command line

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > It's unclear why -N is being used in the first place. It was added by > commit 40828c657dd0c back in 2004 without any justification. Not really, no. That only moved it from LDFLAGS to an explicit use. Several hops earlier it looks to be 4676bbf96dc8 (

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > Relocations are now applied after having moved the trampoline, That's two entirely different sets of relocations, isn't it? What we generate here is what is to be encoded in the PE binary's .reloc section, for the PE loader to process. And for us to th

Re: [PATCH v1 7/8] xen/console: introduce console_set_focus()

2025-03-19 Thread Denis Mukhin
On Tuesday, March 18th, 2025 at 4:37 PM, dm...@proton.me wrote: > > > Switch console_focus address space from integers mapped to domain IDs to > direct domain IDs, simplifying the console input switching code. > > Introduce console_set_focus() to set the console owner domain identifier. > >

Re: [PATCH] x86/boot: Simplify the expression for extra allocation space

2025-03-19 Thread Andrew Cooper
On 19/03/2025 9:41 pm, Jason Andryuk wrote: > On 2025-03-19 13:13, Andrew Cooper wrote: >> The expression for one parameter of find_memory() is already >> complicated and >> about to become moreso.  Break it out into a new variable, and >> express it in >> an easier-to-follow way. >> >> No function

Re: [PATCH v17 1/2] xen/arm: translate virtual PCI bus topology for guests

2025-03-19 Thread Stewart Hildebrand
On 3/11/25 16:13, Stewart Hildebrand wrote: > diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h > index 807401b2eaa2..e355329913ef 100644 > --- a/xen/include/xen/vpci.h > +++ b/xen/include/xen/vpci.h > @@ -311,6 +311,18 @@ static inline int __must_check vpci_reset_device(struct > pci_de

Re: [PATCH] x86/boot: Simplify the expression for extra allocation space

2025-03-19 Thread Jason Andryuk
On 2025-03-19 13:13, Andrew Cooper wrote: The expression for one parameter of find_memory() is already complicated and about to become moreso. Break it out into a new variable, and express it in an easier-to-follow way. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jason A

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 19.03.2025 11:32, Jan Beulich wrote: > On 18.03.2025 18:35, Roger Pau Monne wrote: >> Relocations are now applied after having moved the trampoline, > > That's two entirely different sets of relocations, isn't it? What we generate > here is what is to be encoded in the PE binary's .reloc sectio

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 19.03.2025 11:46, Jan Beulich wrote: > On 19.03.2025 11:32, Jan Beulich wrote: >> On 18.03.2025 18:35, Roger Pau Monne wrote: >>> Relocations are now applied after having moved the trampoline, >> >> That's two entirely different sets of relocations, isn't it? What we generate >> here is what is

Re: [PATCH 6/7] x86/efi: do not merge all .init sections

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > As a result of relocations now being applied after the trampoline has been > copied into the low 1MB region, there's no need for a single .init section > that's writable, as .init.text is no longer modified. This builds on the confusion of the two diff

[PATCH] x86/PVH: account for module command line length

2025-03-19 Thread Jan Beulich
As per observation in practice, initrd->cmdline_pa is not normally zero. Hence so far we always appended at least one byte. That alone may already render insufficient the "allocation" made by find_memory(). Things would be worse when there's actually a (perhaps long) command line. Skip setup when

Re: [PATCH v1 1/2] docs/xen-headers: use alphabetical sorting for @incontents

2025-03-19 Thread Anthony PERARD
On Tue, Mar 18, 2025 at 06:01:56PM +0100, Marek Marczykowski-Górecki wrote: > From: Frédéric Pierret (fepitre) > > It makes the build reproducible with fileordering flags > > Signed-off-by: Frédéric Pierret (fepitre) > --- > docs/xen-headers | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-19 Thread Jan Beulich
On 18.03.2025 14:05, Oleksii Kurochko wrote: > > On 3/17/25 9:07 PM, Luca Fancellu wrote: >> From: Penny Zheng >> >> ARM MPU system doesn't need to use paging memory pool, as MPU memory >> mapping table at most takes only one 4KB page, which is enough to >> manage the maximum 255 MPU memory region

Re: [PATCH v1 1/2] docs/xen-headers: use alphabetical sorting for @incontents

2025-03-19 Thread Marek Marczykowski-Górecki
On Wed, Mar 19, 2025 at 11:19:33AM +, Anthony PERARD wrote: > On Tue, Mar 18, 2025 at 06:01:56PM +0100, Marek Marczykowski-Górecki wrote: > > From: Frédéric Pierret (fepitre) > > > > It makes the build reproducible with fileordering flags > > > > Signed-off-by: Frédéric Pierret (fepitre) > >

[PATCH] x86/cpu: Validate CPUID leaf 0x2 EDX output

2025-03-19 Thread Jan Beulich
From: Ahmed S. Darwish CPUID leaf 0x2 emits one-byte descriptors in its four output registers EAX, EBX, ECX, and EDX. For these descriptors to be valid, the most significant bit (MSB) of each register must be clear. Leaf 0x2 parsing at intel.c only validated the MSBs of EAX, EBX, and ECX, but l

Re: [PATCH v2 1/4] xen/arm32: Initialize MM specific registers in enable_mmu

2025-03-19 Thread Ayan Kumar Halder
Hi Michal, On 17/03/2025 11:40, Orzel, Michal wrote: On 13/03/2025 19:28, Ayan Kumar Halder wrote: All the memory management specific registers are initialized in enable_mmu. The title is a bit misleading (description does not help too). It's a pure code movement, yet it's not mentioned at al

Re: [PATCH] x86/msi: always propagate MSI writes when not in active system mode

2025-03-19 Thread Jan Beulich
On 18.03.2025 11:45, Roger Pau Monné wrote: > On Tue, Mar 18, 2025 at 11:14:59AM +0100, Jan Beulich wrote: >> On 18.03.2025 09:54, Roger Pau Monné wrote: >>> On Tue, Mar 18, 2025 at 09:36:37AM +0100, Jan Beulich wrote: On 18.03.2025 09:29, Roger Pau Monne wrote: > --- a/xen/drivers/passthr

Re: [PATCH 2/7] x86/mkelf32: account for offset when detecting note segment placement

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > mkelf32 attempt to check that the program header defined NOTE segment falls > inside of the LOAD segment, as the build-id should be loaded for Xen at > runtime to check. > > However the current code doesn't take into account the LOAD program header > s

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Jan Beulich
On 19.03.2025 10:15, Jan Beulich wrote: > On 18.03.2025 18:01, Marek Marczykowski-Górecki wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -411,6 +411,8 @@ ifneq ($(CONFIG_CC_IS_CLANG),y) >> CFLAGS += -Wa,--strip-local-absolute >> endif >> >> +$(call cc-option-add CFLAGS,CC,-ffile-prefi

Re: [PATCH v1 1/8] xen/console: fix trailing whitespaces

2025-03-19 Thread Jan Beulich
On 19.03.2025 00:36, dm...@proton.me wrote: > Remove trailing whitespaces in the console driver. > > No functional change. > > Signed-off-by: Denis Mukhin Acked-by: Jan Beulich

Re: [PATCH 3/3] x86/irq: introduce APIC_VECTOR_VALID

2025-03-19 Thread Jan Beulich
On 19.03.2025 00:42, Denis Mukhin wrote: > On Monday, March 17th, 2025 at 1:30 AM, Jan Beulich wrote: >> On 15.03.2025 02:00, dm...@proton.me wrote: >> >>> Add new symbol APIC_VECTOR_VALID to replace open-coded value 16 in >>> LAPIC and virtual LAPIC code. >> >> >> First a good name is needed to m

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:01, Marek Marczykowski-Górecki wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -411,6 +411,8 @@ ifneq ($(CONFIG_CC_IS_CLANG),y) > CFLAGS += -Wa,--strip-local-absolute > endif > > +$(call cc-option-add CFLAGS,CC,-ffile-prefix-map=$(XEN_ROOT)=.) With this, ... > --- a/xen

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:01, Marek Marczykowski-Górecki wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -411,6 +411,8 @@ ifneq ($(CONFIG_CC_IS_CLANG),y) > CFLAGS += -Wa,--strip-local-absolute > endif > > +$(call cc-option-add CFLAGS,CC,-ffile-prefix-map=$(XEN_ROOT)=.) This is lacking a comma: $

Re: [PATCH 1/7] x86/boot: clarify comment about trampoline_setup usage

2025-03-19 Thread Roger Pau Monné
On Tue, Mar 18, 2025 at 05:45:09PM +, Andrew Cooper wrote: > On 18/03/2025 5:35 pm, Roger Pau Monne wrote: > > Clarify that trampoline_setup is only used for EFI when booted using the > > multiboot2 entry point. > > > > Signed-off-by: Roger Pau Monné > > --- > > xen/arch/x86/boot/head.S | 3 +

Re: [RFC] analysis of runtime xenheap memory allocations

2025-03-19 Thread Andrea Bastoni
On 18/03/2025 01:35, Andrew Cooper wrote: > On 17/03/2025 6:48 pm, Andrea Bastoni wrote: >> Hi, >> >> In the last months we have been working with Stefano's team in AMD at tools >> to >> facilitate the analysis of "anonymous" memory allocations performed at >> "runtime" >> from the shared Xen hea

Re: [PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-19 Thread Mykola Kvach
Hi, On Tue, Mar 11, 2025 at 10:28 PM Julien Grall wrote: > > Hi, > > On 05/03/2025 09:11, Mykola Kvach wrote: > > From: Mykyta Poturai > > > > These functions may be unimplemented, so check that they exist before > > calling to prevent crashes. > > Looking at the cover letter, I see you wrote th

Re: [PATCH 00/16] Suspend to RAM support for Xen on arm64

2025-03-19 Thread Mykola Kvach
Hi, On Wed, Mar 12, 2025 at 12:36 AM Julien Grall wrote: > > Hi, > > On 05/03/2025 09:11, Mykola Kvach wrote: > > This is V1 series from Mirela Simonovic. Ported to 4.16 and with added > > changes > > suggested here > > https://lore.kernel.org/all/CAKPH-NjmaZENb8gT=+fobraycrf01_--6gura2ck9di5wiu

Re: [PATCH 4/7] x86/boot: apply trampoline relocations at destination position

2025-03-19 Thread Frediano Ziglio
On Tue, Mar 18, 2025 at 7:05 PM Frediano Ziglio wrote: > > On Tue, Mar 18, 2025 at 5:36 PM Roger Pau Monne wrote: > > > > Change the order relocations are applied. Currently the trampoline is > > patched for relocations before being copied to the low 1MB region. Change > > the order and instead

Re: [PATCH 02/16] xen/x86: Move freeze/thaw_domains into common files

2025-03-19 Thread Mykola Kvach
On Wed, Mar 5, 2025 at 6:48 PM Jan Beulich wrote: > > On 05.03.2025 10:11, Mykola Kvach wrote: > > From: Mirela Simonovic > > > > These functions will be reused by suspend/resume support for ARM. > > And until then they are going to violate the Misra rule requiring there > to not be unreachable c

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-19 Thread Mykyta Poturai
On 18.03.25 16:26, Jan Beulich wrote: > On 18.03.2025 14:31, Mykyta Poturai wrote: >> On 18.03.25 12:11, Jan Beulich wrote: >>> On 18.03.2025 10:10, Mykyta Poturai wrote: On 15.01.24 11:35, Jan Beulich wrote: > On 14.01.2024 11:01, Mykyta Poturai wrote: >> --- a/xen/include/public/hvm/

Re: [PATCH] x86/PVH: account for module command line length

2025-03-19 Thread Jan Beulich
On 19.03.2025 13:12, Andrew Cooper wrote: > On 19/03/2025 11:18 am, Jan Beulich wrote: >> As per observation in practice, initrd->cmdline_pa is not normally zero. >> Hence so far we always appended at least one byte. That alone may >> already render insufficient the "allocation" made by find_memory

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-19 Thread Luca Fancellu
Hi Jan, > On 19 Mar 2025, at 11:35, Jan Beulich wrote: > > On 18.03.2025 14:05, Oleksii Kurochko wrote: >> >> On 3/17/25 9:07 PM, Luca Fancellu wrote: >>> From: Penny Zheng >>> >>> ARM MPU system doesn't need to use paging memory pool, as MPU memory >>> mapping table at most takes only one 4KB

Re: [PATCH 2/7] x86/mkelf32: account for offset when detecting note segment placement

2025-03-19 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 11:07:33AM +0100, Jan Beulich wrote: > On 18.03.2025 18:35, Roger Pau Monne wrote: > > mkelf32 attempt to check that the program header defined NOTE segment falls > > inside of the LOAD segment, as the build-id should be loaded for Xen at > > runtime to check. > > > > Howev

Re: [PATCH 03/16] xen/arm: introduce a separate struct for watchdog timers

2025-03-19 Thread Grygorii Strashko
On 05.03.25 11:11, Mykola Kvach wrote: From: Mirela Simonovic Introduce a separate struct for watchdog timers. It is needed to properly implement the suspend/resume actions for the watchdog timers. To be able to restart watchdog timer after suspend we need to remember their frequency somewhe

Re: [PATCH 07/16] xen/char: implement suspend/resume calls for SCIF driver

2025-03-19 Thread Grygorii Strashko
On 05.03.25 11:11, Mykola Kvach wrote: From: Mykola Kvach The changes have been tested only on the Renesas R-Car-H3 Starter Kit board. Signed-off-by: Volodymyr Babchuk Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Mykola Kvach --- xen/drivers/char/scif-uart.c | 31 +

Re: [PATCH] x86/PVH: account for module command line length

2025-03-19 Thread Andrew Cooper
On 19/03/2025 12:39 pm, Jan Beulich wrote: > On 19.03.2025 13:12, Andrew Cooper wrote: >> On 19/03/2025 11:18 am, Jan Beulich wrote: >>> As per observation in practice, initrd->cmdline_pa is not normally zero. >>> Hence so far we always appended at least one byte. That alone may >>> already render

Re: [PATCH 06/16] xen/arm: Introduce system suspend config option

2025-03-19 Thread Grygorii Strashko
On 13.03.25 17:37, Jan Beulich wrote: On 05.03.2025 10:11, Mykola Kvach wrote: --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -475,6 +475,17 @@ config ARM64_HARDEN_BRANCH_PREDICTOR config ARM32_HARDEN_BRANCH_PREDICTOR def_bool y if ARM_32 && HARDEN_BRANCH_PREDICTOR +confi

Re: [PATCH v1 1/4] xen/riscv: introduce preinit_xen_time()

2025-03-19 Thread Oleksii Kurochko
On 3/17/25 4:24 PM, Jan Beulich wrote: On 11.03.2025 17:19, Oleksii Kurochko wrote: --- /dev/null +++ b/xen/arch/riscv/time.c @@ -0,0 +1,38 @@ +#include +#include +#include +#include + +unsigned long __ro_after_init cpu_khz; /* CPU clock frequency in kHz. */ +unsigned long __read_mostly boo

Re: [PATCH] x86/setup: correct off-by-1 in module mapping

2025-03-19 Thread Jan Beulich
On 19.03.2025 13:15, Roger Pau Monné wrote: > On Wed, Mar 19, 2025 at 12:21:53PM +0100, Jan Beulich wrote: >> If a module's length is an exact multiple of PAGE_SIZE, the 2nd argument >> passed to set_pdx_range() would be one larger than intended. Use >> PFN_{UP,DOWN}() there instead. >> >> Fixes: c

Re: [PATCH v1 2/2] Strip build path directories in tools, xen and xen/arch/x86

2025-03-19 Thread Jan Beulich
On 19.03.2025 12:58, Marek Marczykowski-Górecki wrote: > On Wed, Mar 19, 2025 at 10:43:12AM +0100, Jan Beulich wrote: >> On 19.03.2025 10:15, Jan Beulich wrote: >>> On 18.03.2025 18:01, Marek Marczykowski-Górecki wrote: --- a/xen/Makefile +++ b/xen/Makefile @@ -411,6 +411,8 @@ ifneq

Re: [PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-19 Thread Jan Beulich
On 19.03.2025 13:01, Mykola Kvach wrote: > Hi, > > On Wed, Mar 5, 2025 at 6:45 PM Jan Beulich wrote: >> >> On 05.03.2025 10:11, Mykola Kvach wrote: >>> --- a/xen/drivers/passthrough/iommu.c >>> +++ b/xen/drivers/passthrough/iommu.c >>> @@ -613,7 +613,7 @@ int __init iommu_setup(void) >>> >>> int

Re: [PATCH] x86/PVH: account for module command line length

2025-03-19 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 12:12:22PM +, Andrew Cooper wrote: > On 19/03/2025 11:18 am, Jan Beulich wrote: > > As per observation in practice, initrd->cmdline_pa is not normally zero. > > Hence so far we always appended at least one byte. That alone may > > already render insufficient the "allocat

Re: [PATCH 1/7] x86/boot: clarify comment about trampoline_setup usage

2025-03-19 Thread Andrew Cooper
On 19/03/2025 8:46 am, Roger Pau Monné wrote: > On Tue, Mar 18, 2025 at 05:45:09PM +, Andrew Cooper wrote: >> On 18/03/2025 5:35 pm, Roger Pau Monne wrote: >>> Clarify that trampoline_setup is only used for EFI when booted using the >>> multiboot2 entry point. >>> >>> Signed-off-by: Roger Pau M

Re: [PATCH 02/16] xen/x86: Move freeze/thaw_domains into common files

2025-03-19 Thread Jan Beulich
On 19.03.2025 13:03, Mykola Kvach wrote: > On Wed, Mar 5, 2025 at 6:48 PM Jan Beulich wrote: >> >> On 05.03.2025 10:11, Mykola Kvach wrote: >>> From: Mirela Simonovic >>> >>> These functions will be reused by suspend/resume support for ARM. >> >> And until then they are going to violate the Misra

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-19 Thread Oleksii Kurochko
On 3/19/25 12:35 PM, Jan Beulich wrote: On 18.03.2025 14:05, Oleksii Kurochko wrote: On 3/17/25 9:07 PM, Luca Fancellu wrote: From: Penny Zheng ARM MPU system doesn't need to use paging memory pool, as MPU memory mapping table at most takes only one 4KB page, which is enough to manage the max

Re: [PATCH v6 13/18] system/xen: remove inline stubs

2025-03-19 Thread Pierrick Bouvier
On 3/19/25 06:56, Anthony PERARD wrote: On Mon, Mar 17, 2025 at 11:34:12AM -0700, Pierrick Bouvier wrote: Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier This was a bad copy-paste, thanks. Reviewed-by: Anthony PERARD Thanks,

Re: [PATCH] x86/boot: Untangle the trampoline copying/entry logic

2025-03-19 Thread Roger Pau Monné
On Tue, Mar 18, 2025 at 08:10:33PM +, Andrew Cooper wrote: > The LRET is detached from the PUSHes which set it up, and this is about to get > worse with the changes to trampoline relocation. For the sake of one variable > read, the complexity is not worth it. > > Reorder the logic to copy the

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-19 Thread Luca Fancellu
> On 19 Mar 2025, at 12:18, Luca Fancellu wrote: > > Hi Jan, > >> On 19 Mar 2025, at 11:35, Jan Beulich wrote: >> >> On 18.03.2025 14:05, Oleksii Kurochko wrote: >>> >>> On 3/17/25 9:07 PM, Luca Fancellu wrote: From: Penny Zheng ARM MPU system doesn't need to use paging memo

Re: [PATCH] x86/setup: correct off-by-1 in module mapping

2025-03-19 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 12:21:53PM +0100, Jan Beulich wrote: > If a module's length is an exact multiple of PAGE_SIZE, the 2nd argument > passed to set_pdx_range() would be one larger than intended. Use > PFN_{UP,DOWN}() there instead. > > Fixes: cd7cc5320bb2 ("x86/boot: add start and size fields

Re: [PATCH v3 6/7] xen: introduce Kconfig ARCH_PAGING_MEMPOOL

2025-03-19 Thread Luca Fancellu
> On 19 Mar 2025, at 12:18, Luca Fancellu wrote: > > Hi Jan, > >> On 19 Mar 2025, at 11:35, Jan Beulich wrote: >> >> On 18.03.2025 14:05, Oleksii Kurochko wrote: >>> >>> On 3/17/25 9:07 PM, Luca Fancellu wrote: From: Penny Zheng ARM MPU system doesn't need to use paging memo

Re: [PATCH 01/16] iommu: Add checks before calling iommu suspend/resume

2025-03-19 Thread Mykola Kvach
Hi, On Wed, Mar 5, 2025 at 6:45 PM Jan Beulich wrote: > > On 05.03.2025 10:11, Mykola Kvach wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -613,7 +613,7 @@ int __init iommu_setup(void) > > > > int iommu_suspend(void) > > { > > -if ( iommu_e

[PATCH] x86/setup: correct off-by-1 in module mapping

2025-03-19 Thread Jan Beulich
If a module's length is an exact multiple of PAGE_SIZE, the 2nd argument passed to set_pdx_range() would be one larger than intended. Use PFN_{UP,DOWN}() there instead. Fixes: cd7cc5320bb2 ("x86/boot: add start and size fields to struct boot_module") Signed-off-by: Jan Beulich --- a/xen/arch/x8

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2025-03-19 Thread Jan Beulich
On 19.03.2025 13:05, Mykyta Poturai wrote: > On 18.03.25 16:26, Jan Beulich wrote: >> On 18.03.2025 14:31, Mykyta Poturai wrote: >>> On 18.03.25 12:11, Jan Beulich wrote: On 18.03.2025 10:10, Mykyta Poturai wrote: > On 15.01.24 11:35, Jan Beulich wrote: >> On 14.01.2024 11:01, Mykyta P

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-19 Thread Jan Beulich
On 19.03.2025 04:03, Stefano Stabellini wrote: > --- a/xen/common/bitmap.c > +++ b/xen/common/bitmap.c > @@ -384,21 +384,26 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap > *xenctl_bitmap, > uint8_t zero = 0; > int err = 0; > unsigned int xen_bytes = DIV_ROUND_UP(nbits, BITS_PE

Re: [PATCH v1 2/4] automation: select APLIC and IMSIC to handle both wired interrupts and MSIs

2025-03-19 Thread Oleksii Kurochko
On 3/17/25 8:40 PM, Andrew Cooper wrote: On 11/03/2025 4:19 pm, Oleksii Kurochko wrote: By default, the `aia` option is set to "none" which selects the SiFive PLIC for handling wired interrupts. However, since PLIC is now considered obsolete and will not be supported by Xen now, APLIC and IMSIC