On 19.03.2025 00:42, Denis Mukhin wrote: > On Monday, March 17th, 2025 at 1:30 AM, Jan Beulich <jbeul...@suse.com> wrote: >> On 15.03.2025 02:00, dm...@proton.me wrote: >> >>> Add new symbol APIC_VECTOR_VALID to replace open-coded value 16 in >>> LAPIC and virtual LAPIC code. >> >> >> First a good name is needed to make such a change. APIC_VECTOR_VALID >> could imo be the name of a predicate macro, but it can't be a mere >> number. > > Do you think something like > > #define APIC_VECTOR_VALID_START 16 > #define APIC_VECTOR_VALID_END 255 > > will be satisfactory names to use?
Maybe. In some of the places the _END one may be awkward to use, though. If you absolutely want to replace those numbers, imo the previously alluded to APIC_VECTOR_VALID() predicate macro may be a better thing to use. Personally, despite generally disliking plain literal numbers, I'm not overly concerned of the ones here. Jan
