On 13.03.25 17:37, Jan Beulich wrote:
On 05.03.2025 10:11, Mykola Kvach wrote:
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -475,6 +475,17 @@ config ARM64_HARDEN_BRANCH_PREDICTOR
config ARM32_HARDEN_BRANCH_PREDICTOR
def_bool y if ARM_32 && HARDEN_BRANCH_PREDICTOR
+config SYSTEM_SUSPEND
+ bool "System suspend support"
+ default y
+ depends on ARM_64
+ help
+ This option enables the system suspend support. This is the
+ mechanism that allows the system to be suspended to RAM and
+ later resumed.
+
+ If unsure, say Y.
I wonder if something like this makes sense to place in an arch-specific
Kconfig. It's also not becoming clear here why only Arm64 would permit it.
Taking into account that
- System suspend-2-ram support on x86 is enabled by default and It's going to
be supported on ARM also;
- follow up patches are adding #ifdef CONFIG_SYSTEM_SUSPEND not only in Arm
specific code;
I think, it deserve to be generic option (in some way), enabled by default on
x86.
Also, Arches can declare that suspend is possible, like ARCH_SUSPEND_POSSIBLE,
then
generic configs would not need to be fixed every time when System suspend-2-ram
enabled
for new arch.
Personally I'd introduce separate arch/Kconfig.power (or common Kconfig.power)
file
for PM options (A least there is also cpufreq/cpuidel, and could be other, PM
specific things).
Best regards,
-grygorii
