[linux-linus test] 183876: trouble: blocked/broken

2023-11-28 Thread osstest service owner
flight 183876 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183876/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH v12 15/37] x86/ptrace: Cleanup the definition of the pt_regs structure

2023-11-28 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:36PM -0700, Xin Li wrote: > -/* Return frame for iretq */ > + > + /* The IRETQ return frame starts here */ > unsigned long ip; > - unsigned long cs; > + > + union { > + u64 csx;// The full 64-bit data slot containing CS > +

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

2023-11-28 Thread Jan Beulich
On 27.11.2023 18:34, Simone Ballarin wrote: > On 27/11/23 16:09, Jan Beulich wrote: >> On 27.11.2023 15:35, Simone Ballarin wrote: >>> On 27/11/23 11:46, Jan Beulich wrote: On 24.11.2023 18:29, Simone Ballarin wrote: > --- a/docs/misra/safe.json > +++ b/docs/misra/safe.json > @@ -2

Re: [PATCH v12 16/37] x86/ptrace: Add FRED additional information to the pt_regs structure

2023-11-28 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:37PM -0700, Xin Li wrote: > FRED defines additional information in the upper 48 bits of cs/ss > fields. Therefore add the information definitions into the pt_regs > structure. > > Specially introduce a new structure fred_ss to denote the FRED flags > above SS selector

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-28 Thread Jan Beulich
On 27.11.2023 18:57, Nicola Vetrini wrote: > On 2023-11-27 15:59, Jan Beulich wrote: >> On 27.11.2023 15:32, Nicola Vetrini wrote: >>> - compat_set_{px,cx}_pminfo in x86/x86_64/cpufreq.c are perhaps >>> declared >>> with an autogenerated header? >> >> I don't think so. Only top-level hypercall han

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-28 Thread Jan Beulich
On 24.11.2023 10:40, Nicola Vetrini wrote: > in xen/lib.h and xen/sort.h there are definitions of the functions > bsearch and sort that have no prior declarations, and therefore are > subject to a violation of MISRA C Rule 8.4. > > I'm wondering whether it would be preferred > > 1. to put a dec

[PATCH v2 2/3] livepatch-build-tools: remove usage of gawk

2023-11-28 Thread Roger Pau Monne
And instead use plain awk. Since plain awk cannot do the conversion from hex to decimal, use the shell (bash) printf to convert the (maybe) hexadecimal output of readelf. Signed-off-by: Roger Pau Monné --- Changes since v1: - Use shell printf to convert. --- livepatch-build | 9 + 1 fi

[PATCH v2 0/3] livepatch-build-tools: fixes for non GNU tools and alignment

2023-11-28 Thread Roger Pau Monne
Hello, The series contains two fixes for using the tools on non GNU environments, plus one extra fix to account for section alignment when calculating old function size. Thanks, Roger. Roger Pau Monne (3): livepatch-build-tools: do not use readlink -m option livepatch-build-tools: remove usa

[PATCH v2 1/3] livepatch-build-tools: do not use readlink -m option

2023-11-28 Thread Roger Pau Monne
Busybox readlink implementation only supports the -f option to follow symlinks, so adjust the logic in order to keep the same behaviour without using the -m option. Singed-off-by: Roger Pau Monné Reviewed-by: Ross Lagerwall --- livepatch-build | 29 - 1 file changed,

[PATCH v2 3/3] livepatch-build-tools: account for section alignment when calculating function size

2023-11-28 Thread Roger Pau Monne
Forcing function section alignment at the compiler level ensures that enough space is present in the text section so that at least a jump can be encoded in the old function body to switch to the newly loaded code payload. Modify create-diff-object to account for any section alignment when calculat

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Oleksii
On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: > On 27.11.2023 20:38, Oleksii wrote: > > On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: > > > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > > > --- a/xen/arch/ppc/include/asm/grant_table.h > > > > +++ /dev/null > > > > @@ -1,5 +0,0 @@

[XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Federico Serafini
Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connection with PFEC_* constants and it is consistent with the use of the parameter within function body. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/i

Re: [PATCH v12 20/37] x86/fred: Disallow the swapgs instruction when FRED is enabled

2023-11-28 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:41PM -0700, Xin Li wrote: > + * Note, LKGS loads the GS base address into the IA32_KERNEL_GS_BASE > + * MSR instead of the GS segment’s descriptor cache. As such, the :verify_diff: WARNING: Unicode char [’] (0x8217 in line: + * MSR instead of the GS seg

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Jan Beulich
On 28.11.2023 10:28, Oleksii wrote: > On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: >> On 27.11.2023 20:38, Oleksii wrote: >>> On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: On 27.11.2023 15:13, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/grant_table.h > +++

Re: [PATCH v12 23/37] x86/fred: Make exc_page_fault() work for FRED

2023-11-28 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:44PM -0700, Xin Li wrote: > From: "H. Peter Anvin (Intel)" > > On a FRED system, the faulting address (CR2) is passed on the stack, > to avoid the problem of transient state. Thus we get the page fault ^^ Please use pa

[PATCH v2 2/5] automation/alpine: add elfutils-dev

2023-11-28 Thread Roger Pau Monne
In preparation for adding some livepatch-build-tools test update the Alpine container to also install elfutils-dev. Signed-off-by: Roger Pau Monné --- automation/build/alpine/3.18.dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/automation/build/alpine/3.18.dockerfile b/automati

[PATCH v2 1/5] x86/livepatch: set function alignment to ensure minimal function size

2023-11-28 Thread Roger Pau Monne
The minimal function size requirements for livepatch are either 5 bytes (for jmp) or 9 bytes (for endbr + jmp). Ensure that functions are always at least that size by requesting the compiled to align the functions to 8 or 16 bytes, depending on whether Xen is build with IBT support. Note that it'

[PATCH v2 5/5] automation: add x86-64 livepatching test

2023-11-28 Thread Roger Pau Monne
Introduce a new gitlab tests for livepatching, using livepatch-build-tools, which better reflects how downstreams build live patches rather than the in-tree tests. The tests applies the dummy in-tree patch example, checks that the patch is applied correctly and then reverts and unloads it. Signed

[PATCH v2 3/5] xen/x86: introduce self modifying code test

2023-11-28 Thread Roger Pau Monne
Introduce a helper to perform checks related to self modifying code, and start by creating a simple test to check that alternatives have been applied. Such test is hooked into the boot process and called just after alternatives have been applied. In case of failure a message is printed, and the h

[PATCH v2 0/5] xen/x86: add testing for self modifying code and livepatch

2023-11-28 Thread Roger Pau Monne
Hello, The following series contains a misc set of fixes and improvements. There's one improvement for the hypervisor to set function alignment for livepatch builds in order to make sure there's always enough space in a function to be live-patched. Following patches attempt to introduce a set of

[PATCH v2 4/5] x86/livepatch: introduce a basic live patch test to gitlab CI

2023-11-28 Thread Roger Pau Monne
Introduce a basic livepatch test using the interface to run self modifying tests. The introduced test relies on changing a function from returning false to returning true. To simplify the burden of keeping a patch that can be provided to livepatch-build-tools, introduce two new files: one contain

Re: [PATCH block/for-next v2 02/16] xen/blkback: use new helper to get inode from block_device

2023-11-28 Thread Roger Pau Monné
On Mon, Nov 27, 2023 at 02:21:02PM +0800, Yu Kuai wrote: > From: Yu Kuai > > Which is more efficiency, and also prepare to remove the field > 'bd_inode' from block_device. > > Signed-off-by: Yu Kuai Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries

2023-11-28 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:45PM -0700, Xin Li wrote: > FRED and IDT can share most of the definitions and declarations so > that in the majority of cases the actual handler implementation is the > same. > > The differences are the exceptions where FRED stores exception related > information on

[xen-unstable-smoke test] 183882: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183882 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183882/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

[PATCH v3 0/6] x86/HVM: load state checking

2023-11-28 Thread Jan Beulich
With the request to convert bounding to actual refusal, and then doing so in new hooks, the two previously separate patches now need to be in a series, with infrastructure work done first. Clearly the checking in other load handlers could (and likely wants to be) moved to separate check handlers as

[PATCH v3 1/6] x86/HVM: introduce hvm_get_entry()

2023-11-28 Thread Jan Beulich
... to accompany hvm_read_entry() when actual copying isn't desirable. This allows to remove open-coded stream accesses from hpet_load(), along with using the helper in hvm_load() itself. Since arch_hvm_load()'s declaration would need changing, and since the function is not used from elsewhere, pu

[PATCH v3 2/6] x86/HVM: split restore state checking from state loading

2023-11-28 Thread Jan Beulich
..., at least as reasonably feasible without making a check hook mandatory (in particular strict vs relaxed/zero-extend length checking can't be done early this way). Note that only one of the two uses of hvm_load() is accompanied with hvm_check(). The other directly consumes hvm_save() output, wh

[PATCH v3 3/6] x86/HVM: adjust save/restore hook registration for optional check handler

2023-11-28 Thread Jan Beulich
Register NULL uniformly as a first step. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v2: New. --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -374,7 +374,7 @@ static int cf_check vmce_load_vcpu_ctxt( return err ?: vmce_restore_vcpu(v, &ctxt); } -H

[PATCH v3 4/6] x86/vPIT: check values loaded from state save record

2023-11-28 Thread Jan Beulich
In particular pit_latch_status() and speaker_ioport_read() perform calculations which assume in-bounds values. Several of the state save record fields can hold wider ranges, though. Refuse to load values which cannot result from normal operation, except mode, the init state of which (see also below

[PATCH v3 5/6] x86/vPIC: vpic_elcr_mask() master bit 2 control

2023-11-28 Thread Jan Beulich
Master bit 2 is treated specially: We force it set, but we don't expose the bit being set to the guest. While right now the read and write handling can easily use the fixed mask, the restore input checking that is about to be put in place wants to use the inverted mask to prove that no bits are und

[PATCH v3 6/6] x86/vPIC: check values loaded from state save record

2023-11-28 Thread Jan Beulich
Loading is_master from the state save record can lead to out-of-bounds accesses via at least the two container_of() uses by vpic_domain() and __vpic_lock(). Make sure the value is consistent with the instance being loaded. For ->int_output (which for whatever reason isn't a 1-bit bitfield), beside

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Luca Fancellu
> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: > > + CC Maintainers > >> On 24 Nov 2023, at 09:48, Luca Fancellu wrote: >> >> This serie aims to add more modularity to some feature that can be excluded >> without issues from the build. >> >> The first patch is already reviewed. >> >> v2

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Mario Marietto
Hello. to try to compile the correct freebsd kernel that's recognized by xen using the Elliott Michell code, are the commands below the correct ones ? $ truncate -s 100G xenvm.img $ mdconfig -f xenvm.img -u 0 $ newfs /dev/md0 $ mount /dev/md0 /mnt $ git clone https://gitlab.com/ehem/freebsd-src.g

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Mario Marietto
oh sorry I'm missing the DESTDIR parameter : $ make -DNO_MODULES KERNCONF=GENERIC TARGET=arm TARGET_ARCH=armv7 DESTDIR=/build buildkernel On Tue, Nov 28, 2023 at 11:41 AM Mario Marietto wrote: > Hello. > > to try to compile the correct freebsd kernel that's recognized by xen > using the El

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: > > > >> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >> >> On 27.11.2023 15:58, Luca Fancellu wrote: On 27 Nov 2023, at 12:20, Jan Beulich wrote: On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beuli

[PATCH v3 0/6] x86emul: misc additions

2023-11-28 Thread Jan Beulich
This series adds support for a number of more or less recently announced ISA extensions. The series interacts mildly (and only contextually) with the AVX512-FP16 one. Note that an intended final patch (to fit in USER_MSR elsewhere, in particular in VMX code) is yet to be written; specifically I hav

[PATCH v3 1/6] x86emul: support LKGS

2023-11-28 Thread Jan Beulich
Provide support for this insn, which is a prereq to FRED. CPUID-wise introduce both its and FRED's bit at this occasion, thus allowing to also express the dependency right away. While adding a testcase, also add a SWAPGS one. In order to not affect the behavior of pre-existing tests, install write

Re: [PATCH] x86/xen: fix percpu vcpu_info allocation

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 08:48:52AM +0100, Juergen Gross wrote: > Today the percpu struct vcpu_info is allocated via DEFINE_PER_CPU(), > meaning that it could cross a page boundary. In this case registering > it with the hypervisor will fail, resulting in a panic(). > > This can easily be fixed by

[PATCH v3 2/6] x86emul: support CMPccXADD

2023-11-28 Thread Jan Beulich
Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() now wants to construct and invoke a stub, make stub_exn available to it via a new field in the emulator state structure. Signed-off-by: Jan Beulich --- v3: Add dependency on LM. Re-base. v2: Use X86_EXC_*. Move past introduc

[PATCH v3 4/6] x86emul+VMX: support {RD,WR}MSRLIST

2023-11-28 Thread Jan Beulich
These are "compound" instructions to issue a series of RDMSR / WRMSR respectively. In the emulator we can therefore implement them by using the existing msr_{read,write}() hooks. The memory accesses utilize that the HVM ->read() / ->write() hooks are already linear-address (x86_seg_none) aware (by

[PATCH v3 3/6] VMX: tertiary execution control infrastructure

2023-11-28 Thread Jan Beulich
This is a prereq to enabling the MSRLIST feature. Note that the PROCBASED_CTLS3 MSR is different from other VMX feature reporting MSRs, in that all 64 bits report allowed 1-settings. vVMX code is left alone, though, for the time being. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86

[PATCH v3 5/6] x86: introduce x86_seg_sys

2023-11-28 Thread Jan Beulich
To represent the USER-MSR bitmap access, a new segment type needs introducing, behaving like x86_seg_none in terms of address treatment, but behaving like a system segment for page walk purposes (implicit supervisor-mode access). Signed-off-by: Jan Beulich --- This feels a little fragile: Of cour

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-28 Thread Nicola Vetrini
On 2023-11-28 09:56, Jan Beulich wrote: On 24.11.2023 10:40, Nicola Vetrini wrote: in xen/lib.h and xen/sort.h there are definitions of the functions bsearch and sort that have no prior declarations, and therefore are subject to a violation of MISRA C Rule 8.4. I'm wondering whether it would be

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Jan Beulich
On 28.11.2023 11:55, Luca Fancellu wrote: > > >> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: >> >> >> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >>> >>> On 27.11.2023 15:58, Luca Fancellu wrote: > On 27 Nov 2023, at 12:20, Jan Beulich wrote: > On 24.11.2023 15:52, Luca Fancell

[xen-unstable test] 183877: tolerable FAIL

2023-11-28 Thread osstest service owner
flight 183877 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183877/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 183855 test-amd64-amd64-xl-qemut-win7-amd64

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 11:27, Jan Beulich wrote: > > On 28.11.2023 11:55, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: >>> >>> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: On 27.11.2023 15:58, Luca Fancellu wrote: >> On 27 Nov 2023,

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Oleksii
On Tue, 2023-11-28 at 10:58 +0100, Jan Beulich wrote: > On 28.11.2023 10:28, Oleksii wrote: > > On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: > > > On 27.11.2023 20:38, Oleksii wrote: > > > > On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: > > > > > On 27.11.2023 15:13, Oleksii Kuroch

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Michal Orzel
Hi Luca, On 28/11/2023 11:36, Luca Fancellu wrote: > > >> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: >> >> + CC Maintainers >> >>> On 24 Nov 2023, at 09:48, Luca Fancellu wrote: >>> >>> This serie aims to add more modularity to some feature that can be excluded >>> without issues from the

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 12:38, Michal Orzel wrote: > > Hi Luca, > > On 28/11/2023 11:36, Luca Fancellu wrote: >> >> >>> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: >>> >>> + CC Maintainers >>> On 24 Nov 2023, at 09:48, Luca Fancellu wrote: This serie aims to add more mod

[PATCH] .gitignore: generalize *.new

2023-11-28 Thread Jan Beulich
It's not only in xen/include/xen/ that we generate (intermediate) *.new files. Signed-off-by: Jan Beulich --- Really I don't think I can spot what *.new we create in that specific directory. xen/include/ certainly has some. --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,7 @@ *.so.[0-9]* *.bin

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Jan Beulich
On 28.11.2023 12:49, Oleksii wrote: > On Tue, 2023-11-28 at 10:58 +0100, Jan Beulich wrote: >> On 28.11.2023 10:28, Oleksii wrote: >>> On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: On 27.11.2023 20:38, Oleksii wrote: > On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: >> On

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 10:46, Federico Serafini wrote: > Uniform declaration and definition of guest_walk_tables() using > parameter name "pfec_walk": > this name highlights the connection with PFEC_* constants and it is > consistent with the use of the parameter within function body. > No functional change

Re: [PATCH v3 02/13] xen/spinlock: reduce lock profile ifdefs

2023-11-28 Thread Juergen Gross
On 24.11.23 18:59, Alejandro Vallejo wrote: Hi, On 20/11/2023 11:38, Juergen Gross wrote:> With some small adjustments to the LOCK_PROFILE_* macros some #ifdefs can be dropped from spinlock.c. Signed-off-by: Juergen Gross --- V2: - new patch V3: - add variable name to macros parameter (Jan B

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Federico Serafini
On 28/11/23 14:00, Jan Beulich wrote: On 28.11.2023 10:46, Federico Serafini wrote: Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connection with PFEC_* constants and it is consistent with the use of the parameter within func

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Andrew Cooper
On 28/11/2023 1:00 pm, Jan Beulich wrote: > On 28.11.2023 10:46, Federico Serafini wrote: >> Uniform declaration and definition of guest_walk_tables() using >> parameter name "pfec_walk": >> this name highlights the connection with PFEC_* constants and it is >> consistent with the use of the parame

Re: [PATCH v3 04/13] xen/spinlock: introduce new type for recursive spinlocks

2023-11-28 Thread Juergen Gross
On 24.11.23 19:59, Alejandro Vallejo wrote: On 20/11/2023 11:38, Juergen Gross wrote: Introduce a new type "rspinlock_t" to be used for recursive spinlocks. For now it is only an alias of spinlock_t, so both types can still be used for recursive spinlocks. This will be changed later, though. S

Re: [PATCH v3 06/13] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

2023-11-28 Thread Juergen Gross
On 24.11.23 20:23, Alejandro Vallejo wrote: On 20/11/2023 11:38, Juergen Gross wrote: Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross --- V2: - ne

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Oleksii
On Tue, 2023-11-28 at 13:53 +0100, Jan Beulich wrote: > On 28.11.2023 12:49, Oleksii wrote: > > On Tue, 2023-11-28 at 10:58 +0100, Jan Beulich wrote: > > > On 28.11.2023 10:28, Oleksii wrote: > > > > On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: > > > > > On 27.11.2023 20:38, Oleksii wrote:

[ovmf test] 183890: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183890 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183890/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d451bba399687b4102459db5a447fc9abb8fdee1 baseline version: ovmf 0e9ce9146a6dc50a35488

Re: [PATCH v3 04/13] xen/spinlock: introduce new type for recursive spinlocks

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:16, Juergen Gross wrote: > On 24.11.23 19:59, Alejandro Vallejo wrote: >> On 20/11/2023 11:38, Juergen Gross wrote: >>> --- a/xen/include/xen/spinlock.h >>> +++ b/xen/include/xen/spinlock.h >> > [snip] >>> @@ -182,8 +191,10 @@ typedef struct spinlock { >>>   #endif >>>   } spinloc

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:17, Andrew Cooper wrote: > On 28/11/2023 1:00 pm, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Roger Pau Monné
On Mon, Nov 27, 2023 at 03:04:30PM -0800, Elliott Mitchell wrote: > BTW Roger Pau Monné, now that Xen 4.18 is out, take a look at the > "royger" branch? I've pushed a bunch of those, there are still some, I've made comments on the branch. I think there isn't much left after the swept I've done.

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:11, Federico Serafini wrote: > On 28/11/23 14:00, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: [RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:34PM +0800, Jiqian Chen wrote: > When a device has been reset on dom0 side, the vpci on Xen > side won't get notification, so the cached state in vpci is > all out of date compare with the real device state. > To solve that problem, this patch add new hypercall to clea

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Mario Marietto
For booting a FreeBSD kernel as a guest OS on XEN,should we install xen 4.18 from source ? On Tue, Nov 28, 2023 at 2:45 PM Roger Pau Monné wrote: > On Mon, Nov 27, 2023 at 03:04:30PM -0800, Elliott Mitchell wrote: > > BTW Roger Pau Monné, now that Xen 4.18 is out, take a look at the > > "royger"

Re: [EXTERNAL] [PATCH v3 2/5] xen: backends: don't overwrite XenStore nodes created by toolstack

2023-11-28 Thread David Woodhouse
On Tue, 2023-11-28 at 01:20 +, Volodymyr Babchuk wrote: > Hi David, > > Thank you for the review > > David Woodhouse writes: > > > [[S/MIME Signed Part:Undecided]] > > On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: > > > Xen PV devices in QEMU can be created in two ways: either

[libvirt test] 183880: tolerable all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183880 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183880/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183861 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: > If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq > and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will > call into Xen, bu

[xen-unstable-smoke test] 183891: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183891 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > if you debug the kernel codes, you will find the irq > numb

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Juergen Gross
On 28.11.23 15:25, Roger Pau Monné wrote: On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi, it is dynamic, and follow the principle of applying first, distributing first. And if you debug the kerne

Re: [PATCH] .gitignore: generalize *.new

2023-11-28 Thread Oleksii
Hi Jan, On Tue, 2023-11-28 at 13:51 +0100, Jan Beulich wrote: > It's not only in xen/include/xen/ that we generate (intermediate) > *.new > files. > > Signed-off-by: Jan Beulich > --- > Really I don't think I can spot what *.new we create in that specific > directory. xen/include/ certainly has

Re: [PATCH v2 08/29] tools/xenlogd: add 9pfs walk request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 1:16 PM Juergen Gross wrote: > > Add the walk request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk 9P2000.u has support for symlinks which you're explicitly not supporting. A symlink would only be present if someone on the backend s

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 03:09:14PM +0100, Mario Marietto wrote: > For booting a FreeBSD kernel as a guest OS on XEN,should we install xen > 4.18 from source ? Please avoid top-posting. I don't think so, I'm not aware of the FreeBSD port requiring a specific version of Xen. I do think the work is

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Jan Beulich
On 24.11.2023 11:41, Jiqian Chen wrote: > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/arch/x86/hvm/hypercall.c > @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) > arg) > { > case PHYSDEVOP_map_pirq: > case PHYSDEVOP_unmap_pirq: > +if (is_hardwa

[ovmf test] 183895: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183895 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183895/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9eec96bd4fc53d7836b5606f2a8bbb10713cc8f5 baseline version: ovmf d451bba399687b4102459

Re: [PATCH v2 09/29] tools/xenlogd: add 9pfs open request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 12:16 PM Juergen Gross wrote: > > Add the open request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

Re: [PATCH v7 2/2] xen/vpci: header: filter PCI capabilities

2023-11-28 Thread Stewart Hildebrand
On 11/17/23 06:44, Roger Pau Monné wrote: > On Wed, Sep 13, 2023 at 10:35:47AM -0400, Stewart Hildebrand wrote: >> Currently, Xen vPCI only supports virtualizing the MSI and MSI-X >> capabilities. >> Hide all other PCI capabilities (including extended capabilities) from domUs >> for >> now, even

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 03:42:31PM +0100, Juergen Gross wrote: > On 28.11.23 15:25, Roger Pau Monné wrote: > > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > > > In PVH dom0, it uses the linux local interrupt mechanism, > > > when it allocs irq for a gsi, it is dynamic, and follow >

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Julien Grall
Hi Michal, On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs, is essential. When enabled, this option causes Xen to panic upon detecting UBSAN failure (as the las

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Juergen Gross
On 28.11.23 17:11, Roger Pau Monné wrote: On Tue, Nov 28, 2023 at 03:42:31PM +0100, Juergen Gross wrote: On 28.11.23 15:25, Roger Pau Monné wrote: On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
Hi Julien, On 28/11/2023 17:14, Julien Grall wrote: > > > Hi Michal, > > On 27/11/2023 15:41, Michal Orzel wrote: >> Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt >> attention to undefined behavior issues, notably during CI test runs, is >> essential. When enabled,

[xen-unstable-smoke bisection] complete build-amd64

2023-11-28 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build/dist-test Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Julien Grall
On 28/11/2023 18:00, Michal Orzel wrote: Hi Julien, On 28/11/2023 17:14, Julien Grall wrote: Hi Michal, On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs,

[XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 5.6

2023-11-28 Thread Federico Serafini
Update ECLAIR configuration to take into account the adopted files and type "ret_t". Update docs/misra/deviations.rst accordingly. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 12 docs/misra/deviations.rst| 16 ++

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:00 pm, Michal Orzel wrote: > Hi Julien, > > On 28/11/2023 17:14, Julien Grall wrote: >> >> Hi Michal, >> >> On 27/11/2023 15:41, Michal Orzel wrote: >>> Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt >>> attention to undefined behavior issues, notably dur

[PATCH] cirrus-ci: update FreeBSD versions

2023-11-28 Thread Roger Pau Monne
FreeBSD 14.0 has already been released, so switch to the release version image, and introduce a FreeBSD 15.0 version to track current FreeBSD unstable (development) branch. Sample output at: https://github.com/royger/xen/runs/19105278189 Signed-off-by: Roger Pau Monné --- .cirrus.yml | 8 +

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
On 28/11/2023 18:09, Julien Grall wrote: > > > On 28/11/2023 18:00, Michal Orzel wrote: >> Hi Julien, >> >> On 28/11/2023 17:14, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Andrew Cooper
On 27/11/2023 2:41 pm, Michal Orzel wrote: > diff --git a/xen/common/ubsan/ubsan.c b/xen/common/ubsan/ubsan.c > index a3a80fa99eec..dd5ee0013648 100644 > --- a/xen/common/ubsan/ubsan.c > +++ b/xen/common/ubsan/ubsan.c > @@ -174,6 +174,10 @@ static void ubsan_epilogue(unsigned long *flags) >

Re: [PATCH] cirrus-ci: update FreeBSD versions

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:11 pm, Roger Pau Monne wrote: > FreeBSD 14.0 has already been released, so switch to the release version > image, > and introduce a FreeBSD 15.0 version to track current FreeBSD unstable > (development) branch. > > Sample output at: > > https://github.com/royger/xen/runs/1910527818

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 5.6

2023-11-28 Thread Jan Beulich
On 28.11.2023 18:09, Federico Serafini wrote: > --- a/docs/misra/deviations.rst > +++ b/docs/misra/deviations.rst > @@ -90,6 +90,22 @@ Deviations related to MISRA C:2012 Rules: > - __emulate_2op and __emulate_2op_nobyte > - read_debugreg and write_debugreg > > + * - R5.6 > +

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
On 28/11/2023 18:15, Andrew Cooper wrote: > > > On 27/11/2023 2:41 pm, Michal Orzel wrote: >> diff --git a/xen/common/ubsan/ubsan.c b/xen/common/ubsan/ubsan.c >> index a3a80fa99eec..dd5ee0013648 100644 >> --- a/xen/common/ubsan/ubsan.c >> +++ b/xen/common/ubsan/ubsan.c >> @@ -174,6 +174,10 @@

Re: [PATCH v12 16/37] x86/ptrace: Add FRED additional information to the pt_regs structure

2023-11-28 Thread H. Peter Anvin
On November 28, 2023 12:51:22 AM PST, Borislav Petkov wrote: >On Mon, Oct 02, 2023 at 11:24:37PM -0700, Xin Li wrote: >> FRED defines additional information in the upper 48 bits of cs/ss >> fields. Therefore add the information definitions into the pt_regs >> structure. >> >> Specially introduce

Re: [XEN PATCH 01/11] xen/console: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich

Re: [XEN PATCH 02/11] xen/aclinux: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich Albeit as to the subject: There's no component named "aclinux" in Xen. I think this wants to be "acpi". Jan

Re: [XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich irrespective of this being one of the examples where types alone are entirely sufficient and descriptive. Jan > --- a/xen/include/xen/c

Re: [XEN PATCH 04/11] xen/dmi: address a violation of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter name. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich

[xen-unstable-smoke test] 183899: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

[PATCH] xen/livepatch: fix livepatch tests

2023-11-28 Thread Roger Pau Monne
The current set of in-tree livepatch tests in xen/test/livepatch started failing after the constify of the payload funcs array, and the movement of the status data into a separate array. Fix the tests so they respect the constness of the funcs array and also make use of the new location of the per

Re: [PATCH] xen/livepatch: fix livepatch tests

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:41 pm, Roger Pau Monne wrote: > The current set of in-tree livepatch tests in xen/test/livepatch started > failing after the constify of the payload funcs array, and the movement of the > status data into a separate array. > > Fix the tests so they respect the constness of the funcs

  1   2   >