[linux-5.4 test] 181525: trouble: blocked/broken/fail/pass

flight 181525 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/181525/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [XEN PATCH 03/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

On 20.06.2023 22:49, Stefano Stabellini wrote: > On Tue, 20 Jun 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline >> states: >> "A "u" or "U" suffix shall be applied to all integer constants that are >> repre

Re: [XEN PATCH 06/13] xen/efi: fixed violations of MISRA C:2012 Rule 7.2

On 20.06.2023 22:56, Stefano Stabellini wrote: > On Tue, 20 Jun 2023, Jan Beulich wrote: >> On 20.06.2023 12:34, Simone Ballarin wrote: >>> From: Gianluca Luparini >>> >>> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline >>> states: >>> "A "u" or "U" suffix shall be app

Re: [PATCH v1 01/23] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

On Tue, Jun 20, 2023 at 01:24:34PM -0400, Joel Upham wrote: > > Signed-off-by: Alexey Gerasimenko This isn't a valid email address for Alexey - I presume you grabbed these patches from the xen-devel mail archives, which have mangled the addresses for anti-spam reasons. Fortunately there are alt

Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

First of all - please trim replies. On 20.06.2023 23:23, Stefano Stabellini wrote: > On Tue, 20 Jun 2023, Simone Ballarin wrote: >> --- a/xen/arch/x86/percpu.c >> +++ b/xen/arch/x86/percpu.c >> @@ -12,7 +12,7 @@ unsigned long __per_cpu_offset[NR_CPUS]; >> * possible #PF at (NULL + a little) whic

Re: [PATCH] docs/misra: add Rules 8.2, 8.3, 8.14

On 21.06.2023 03:26, Stefano Stabellini wrote: > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -213,6 +213,17 @@ maintainers if you want to suggest a change. > - Types shall be explicitly specified > - > > + * - `Rule 8.2 >

Re: [PATCH] x86: Drop opt_pku entirely

On 20.06.2023 19:47, Andrew Cooper wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -25,6 +25,9 @@ The format is based on [Keep a > Changelog](https://keepachangelog.com/en/1.0.0/) > - Add support for AVX512-FP16 on x86. > - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech

Re: [PATCH v4 06/15] cpufreq: Add Hardware P-State (HWP) driver

On 20.06.2023 20:14, Jason Andryuk wrote: > On Mon, Jun 19, 2023 at 7:38 AM Jan Beulich wrote: >> On 14.06.2023 20:02, Jason Andryuk wrote: >>> Falling back from cpufreq=hwp to cpufreq=xen is a more user-friendly >>> choice than disabling cpufreq when HWP is not available. Specifying >>> cpufreq=

[XEN PATCH v2] xen/include: avoid undefined behavior.

Redefine BUILD_BUG_ON_ZERO to fully comply with C99 avoiding undefined behavior 58 ("A structure or union is defined as containing no named members (6.7.2.1)." The chosen ill-formed construct is a negative bitwidth in a bitfield within a struct containing at least one named member, which prevents

Re: [PATCH v4 09/15] cpufreq: Export HWP parameters to userspace as CPPC

On 20.06.2023 20:41, Jason Andryuk wrote: > On Mon, Jun 19, 2023 at 10:24 AM Jan Beulich wrote: >> On 14.06.2023 20:02, Jason Andryuk wrote: >>> +else >>> { >>> +if ( !(scaling_available_governors = >>> + xzalloc_array(char, gov_num * CPUFREQ_NAME_LEN)) ) >>> +

Re: [PATCH] x86/vpmu: Simplify is_pmc_quirk

On 20.06.2023 19:45, Andrew Cooper wrote: > This should be static, and there's no need for a separate (non-init, even) > function to perform a simple equality test. Drop the is_ prefix which is > gramatically questionable, and make it __ro_after_init. > > Leave a TODO, because the behaviour is de

Re: [XEN PATCH 05/13] xen/common: fixed violations of MISRA C:2012 Rule 7.2

Il giorno mar 20 giu 2023 alle ore 14:43 Jan Beulich ha scritto: > On 20.06.2023 12:34, Simone Ballarin wrote: > > From: Gianluca Luparini > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > > "A "u" or "U" suffix shall be applied to all integer consta

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: > > On 20/06/2023 10:41, Gerd Hoffmann wrote: > >Hi, > > > > > > The guest driver should be able to restore resources after resume. > > > Thank you for your suggestion! > > > As far as I know, resources are created on host side a

Re: [XEN PATCH 07/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

Il giorno mar 20 giu 2023 alle ore 14:51 Jan Beulich ha scritto: > On 20.06.2023 12:34, Simone Ballarin wrote: > > --- a/xen/arch/x86/cpu/vpmu_intel.c > > +++ b/xen/arch/x86/cpu/vpmu_intel.c > > @@ -950,10 +950,10 @@ const struct arch_vpmu_ops *__init > core2_vpmu_init(void) > > fixed_ctr

Re: [XEN PATCH v2] xen/include: avoid undefined behavior.

On 21.06.2023 09:58, Nicola Vetrini wrote: > Redefine BUILD_BUG_ON_ZERO to fully comply with C99 avoiding > undefined behavior 58 ("A structure or union is defined as > containing no named members (6.7.2.1)." Here and in the title I'm not happy about you referencing undefined behavior. What we do

[qemu-mainline test] 181530: regressions - trouble: blocked/broken/fail/pass

flight 181530 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181530/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-ins

Re: [XEN PATCH 09/13] xen/public: fixed violations of MISRA C:2012 Rule 7.2

Hi, Il giorno mar 20 giu 2023 alle ore 15:00 Jan Beulich ha scritto: > On 20.06.2023 12:35, Simone Ballarin wrote: > > --- a/xen/include/public/io/ring.h > > +++ b/xen/include/public/io/ring.h > > @@ -36,11 +36,11 @@ > > typedef unsigned int RING_IDX; > > > > /* Round a 32-bit unsigned constan

Re: [XEN PATCH 06/13] xen/efi: fixed violations of MISRA C:2012 Rule 7.2

Il giorno mer 21 giu 2023 alle ore 09:06 Jan Beulich ha scritto: > On 20.06.2023 22:56, Stefano Stabellini wrote: > > On Tue, 20 Jun 2023, Jan Beulich wrote: > >> On 20.06.2023 12:34, Simone Ballarin wrote: > >>> From: Gianluca Luparini > >>> > >>> The xen sources contains violations of MISRA C:

Re: [PATCH] x86/vpmu: Simplify is_pmc_quirk

On 21/06/2023 9:16 am, Jan Beulich wrote: > On 20.06.2023 19:45, Andrew Cooper wrote: >> This should be static, and there's no need for a separate (non-init, even) >> function to perform a simple equality test. Drop the is_ prefix which is >> gramatically questionable, and make it __ro_after_init.

Re: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap()

On 19/06/2023 19:01, Julien Grall wrote: > > > From: Julien Grall > > On older version of the Arm Arm (ARM DDI 0487E.a, B2-125) there were > the following paragraph: > > "DMB and DSB instructions affect reads and writes to the memory system > generated by Load/Store instructions and data or

Re: [XEN PATCH 02/13] AMD/IOMMU: fixed violations of MISRA C:2012 Rule 7.2

Il giorno mar 20 giu 2023 alle ore 22:41 Stefano Stabellini < sstabell...@kernel.org> ha scritto: > On Tue, 20 Jun 2023, Luca Fancellu wrote: > > > On 20 Jun 2023, at 13:39, Jan Beulich wrote: > > > > > > On 20.06.2023 12:34, Simone Ballarin wrote: > > >> --- a/xen/drivers/passthrough/amd/iommu-d

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On 21. 06. 23, 11:09, Joel Granados wrote: In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to the register_sysctl_init call and pass an ARRAY_SIZE for all the callers. Hi, I am missing here (o

Re: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap()

Hi, On 21/06/2023 10:33, Michal Orzel wrote: On 19/06/2023 19:01, Julien Grall wrote: From: Julien Grall On older version of the Arm Arm (ARM DDI 0487E.a, B2-125) there were the following paragraph: "DMB and DSB instructions affect reads and writes to the memory system generated by Load/

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

On Tue, Jun 20, 2023 at 09:14:25PM -0400, Demi Marie Obenour wrote: > On Mon, Jun 12, 2023 at 10:09:39AM +0200, Roger Pau Monné wrote: > > On Fri, Jun 09, 2023 at 12:55:39PM -0400, Demi Marie Obenour wrote: > > > On Fri, Jun 09, 2023 at 05:13:45PM +0200, Roger Pau Monné wrote: > > > > On Thu, Jun 0

Re: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap()

On 21/06/2023 12:02, Julien Grall wrote: > > > Hi, > > On 21/06/2023 10:33, Michal Orzel wrote: >> >> >> On 19/06/2023 19:01, Julien Grall wrote: >>> >>> >>> From: Julien Grall >>> >>> On older version of the Arm Arm (ARM DDI 0487E.a, B2-125) there were >>> the following paragraph: >>> >>> "

[OSSTEST PATCH] Use updated mirror for buster armhf, and update debian-installer

This reverts commit b838a9daeb3b ("production-config: Use a snapshot for buster armhf") Installation now fails with "Invalid Release signature", while downloading the "Release" file of a repo. But, using the main mirror for armhf boxes seems to work fine now. To use the live mirror, we need to u

Re: [XEN PATCH v2] docs/misra: document the C dialect and translation toolchain assumptions.

On 20.06.2023 14:10, Roberto Bagnara wrote: > + * - static function is used in an inline function with external linkage > + - ARM64, X86_64 > + - Non-documented GCC extension. An inline function with external linkage > + can be inlined everywhere. If that calls a static functions, w

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote: > static int __init random_sysctls_init(void) > { > - register_sysctl_init("kernel/random", random_table); > + register_sysctl_init("kernel/random", random_table, > + ARRAY_SIZE(random_table)); As men

[ovmf test] 181531: all pass - PUSHED

flight 181531 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181531/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4a0642ad27bfb566835ae86aedae0e18f9735cc2 baseline version: ovmf ea55bd8f66eeca5f4e80c

Re: [PATCH v1 1/1] Q35 Support

On 20.06.23 19:24, Joel Upham wrote: Inexpressive patch subject and non-existant patch desciption. I have no clue what this is supposed to do, except that it involes q35 and xen ()I guess ?. --- hw/acpi/ich9.c| 22 +- hw/acpi/pcihp.c |6 +- hw/core/mac

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

On 21/06/2023 09:39, Gerd Hoffmann wrote: On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: On 20/06/2023 10:41, Gerd Hoffmann wrote: Hi, The guest driver should be able to restore resources after resume. Thank you for your suggestion! As far as I know, resources are crea

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On Wed 2023-06-21 11:09:57, Joel Granados wrote: > In order to remove the end element from the ctl_table struct arrays, we > explicitly define the size when registering the targes. We add a size > argument to the register_sysctl_init call and pass an ARRAY_SIZE for all > the callers. This does not

[xen-unstable-smoke test] 181532: trouble: blocked/broken/pass

flight 181532 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181532/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

Hi, > As virtio drivers are by design paravirt drivers ,I think it is reasonable > to accept some knowledge with and cooperation with the host to manage > suspend/resume. Fair point. In any case this needs a feature flag, so guest and host can negotiate whenever this is supported or not. virt

Re: [PATCH v7 11/12] xen/arm: translate virtual PCI bus topology for guests

On 13.06.2023 12:32, Volodymyr Babchuk wrote: > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -180,6 +180,44 @@ static void vpci_remove_virtual_device(const struct > pci_dev *pdev) > write_unlock(&pdev->domain->vpci_rwlock); > } > > +/* > + * Find the physical device w

Re: [PATCH v7 10/12] vpci: add initial support for virtual PCI bus topology

On 13.06.2023 12:32, Volodymyr Babchuk wrote: > @@ -121,6 +124,62 @@ int vpci_add_handlers(struct pci_dev *pdev) > } > > #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT > +static int add_virtual_device(struct pci_dev *pdev) > +{ > +struct domain *d = pdev->domain; > +pci_sbdf_t sbdf = { 0 }; > +

[xen-unstable test] 181528: trouble: blocked/broken/fail/pass

flight 181528 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181528/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [XEN PATCH v2] docs/misra: document the C dialect and translation toolchain assumptions.

On 20/06/23 16:52, Jan Beulich wrote: On 20.06.2023 14:10, Roberto Bagnara wrote: + * - Non-standard tokens + - ARM64, X86_64 + - _Static_assert: + see Section "2.1 C Language" of GCC_MANUAL. + asm, __asm__: + see Sections "6.48 Alternate Keywords" and "6.47 How

[PATCH 0/2] Fix Linux dom0 boot on a QEMU/KVM virtual machine

Fix two problems that prevent booting Linux dom0 on a QEMU/KVM virtual machine, which is sometimes useful for testing purposes. Petr Pavlu (2): xen/virtio: Fix NULL deref when a bridge of PCI root bus has no parent xen/virtio: Avoid use of the dom0 backend in dom0 drivers/xen/grant-dma-ops.c

[PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

When attempting to run Xen on a QEMU/KVM virtual machine with virtio devices (all x86_64), dom0 tries to establish a grant for itself which eventually results in a hang during the boot. The backtrace looks as follows, the while loop in __send_control_msg() makes no progress: #0 virtqueue_get_b

[PATCH 1/2] xen/virtio: Fix NULL deref when a bridge of PCI root bus has no parent

When attempting to run Xen on a QEMU/KVM virtual machine with virtio devices (all x86_64), function xen_dt_get_node() crashes on accessing bus->bridge->parent->of_node because a bridge of the PCI root bus has no parent set: [1.694192][T1] BUG: kernel NULL pointer dereference, address: 000

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > Remove the empty end element from all the arrays that are passed to the > > register sysctl calls. In some files this means reducing the explicit > > array size by one. Also make sure that

[PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

Remove the empty end element from all the arrays that are passed to the register sysctl calls. In some files this means reducing the explicit array size by one. Also make sure that we are using the size in ctl_table_header instead of evaluating the .procname element. Signed-off-by: Joel Granados

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating the

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On Wed, Jun 21, 2023 at 12:47:58PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote: > > static int __init random_sysctls_init(void) > > { > > - register_sysctl_init("kernel/random", random_table); > > + register_sysctl_init("kernel/random", ran

[PATCH 08/11] sysctl: Add size to register_sysctl_init

In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to the register_sysctl_init call and pass an ARRAY_SIZE for all the callers. Signed-off-by: Joel Granados --- arch/x86/kernel/cpu/intel.c |

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

On Wed, 21 Jun 2023, Joel Granados wrote: > On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: >> On Wed, 21 Jun 2023, Joel Granados wrote: >> > Remove the empty end element from all the arrays that are passed to the >> > register sysctl calls. In some files this means reducing the expl

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On Wed, Jun 21, 2023 at 11:56:03AM +0200, Jiri Slaby wrote: > On 21. 06. 23, 11:09, Joel Granados wrote: > > In order to remove the end element from the ctl_table struct arrays, we > > explicitly define the size when registering the targes. We add a size > > argument to the register_sysctl_init cal

Re: [XEN PATCH v2] docs/misra: document the C dialect and translation toolchain assumptions.

On 20/06/23 16:56, Jan Beulich wrote: On 20.06.2023 14:10, Roberto Bagnara wrote: + * - Arithmetic operator on void type + - ARM64, X86_64 + - See Section "6.24 Arithmetic on void- and Function-Pointers" of GCC_MANUAL." The first line is misleading - we don't (and can't) do arithmet

Re: [XEN PATCH v2] docs/misra: document the C dialect and translation toolchain assumptions.

On 21/06/23 12:27, Jan Beulich wrote: On 20.06.2023 14:10, Roberto Bagnara wrote: + * - static function is used in an inline function with external linkage + - ARM64, X86_64 + - Non-documented GCC extension. An inline function with external linkage + can be inlined everywhere. If

Re: [PATCH] mm/pdx: Add comments throughout the codebase for pdx

On Mon, Jun 19, 2023 at 05:30:20PM +0200, Jan Beulich wrote: > > + * ma_{top,bottom}_mask is simply a shifted pfn_{top,pdx_bottom}_mask > > where the > > + * bottom one shifts in 1s rather than 0s. > > + */ > > Nit: That 2nd bottom variable is ma_va_bottom_mask. Sure > > > @@ -57,9 +99,25 @@ ui

[ovmf test] 181536: all pass - PUSHED

flight 181536 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181536/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fcd71642df9a3a5932a2db116acc6fe23458d8f5 baseline version: ovmf 4a0642ad27bfb566835ae

Re: [XEN PATCH v2] docs/misra: document the C dialect and translation toolchain assumptions.

On 20/06/23 17:05, Jan Beulich wrote: On 20.06.2023 14:10, Roberto Bagnara wrote: + * - Token pasting of ',' and __VA_ARGS__ + - ARM64, X86_64 + - See Section "6.21 Macros with a Variable Number of Arguments" of GCC_MANUAL. + + * - No arguments for '...' parameter of variadic macro

[PATCH] Updates to Xen hypercall preemption

Some Xen hypercalls issued by dom0 guests may run for many 10s of seconds, potentially causing watchdog timeouts and other problems. It's rare for this to happen, but it does in extreme circumstances, for instance when shutting down VMs with very large memory allocations (> 0.5 - 1TB). These hyper

Re: [PATCH v4 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

(re-adding xen-devel@) On 21.06.2023 16:16, Jason Andryuk wrote: > On Mon, Jun 19, 2023 at 10:47 AM Jan Beulich wrote: >> On 14.06.2023 20:02, Jason Andryuk wrote: >>> +if ( !(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ACT_WINDOW) && >>> + set_cppc->activity_window ) >>> +retu

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init

On Wed, Jun 21, 2023 at 01:36:46PM +0200, Petr Mladek wrote: > On Wed 2023-06-21 11:09:57, Joel Granados wrote: > > In order to remove the end element from the ctl_table struct arrays, we > > explicitly define the size when registering the targes. We add a size > > argument to the register_sysctl_i

[XEN PATCH v3] docs/misra: document the C dialect and translation toolchain assumptions.

This document specifies the C language dialect used by Xen and the assumptions Xen makes on the translation toolchain. Signed-off-by: Roberto Bagnara Changes in V2: - Clarified several entries. - Removed entry about the use of the undefined escape sequence \m. Changes in V3: - Removed ment

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

On Wed, Jun 21, 2023 at 04:15:46PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > >> On Wed, 21 Jun 2023, Joel Granados wrote: > >> > Remove the empty end element from all the arrays that are passed to the >

[XEN PATCH 1/3] build: define ARCH and SRCARCH later

Defining ARCH and SRCARCH later in xen/Makefile allows to switch to immediate evaluation variable type. ARCH and SRCARCH depends on value defined in Config.mk and aren't used TARGET_SUBARCH or TARGET_ARCH, and not before it's needed in a sub-make or a rule. This will help reduce the number of tim

[XEN PATCH 0/3] build: reduce number of $(shell) execution on make 4.4

Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-exported-shell-command-value-v1 With GNU make 4.4, the number of execution of the command present in $(shell ) in exported variables increased greatly. This is probably because as

[XEN PATCH 3/3] Config.mk: evaluate XEN_COMPILE_ARCH and XEN_OS on first use

With GNU make 4.4, the number of execution of the command present in these $(shell ) increased greatly. This is probably because as of make 4.4, exported variable are also added to the environment of $(shell ) construct. So, to avoid having these command been run more than necessery, we will use a

[XEN PATCH 2/3] build: evaluate XEN_BUILD_* and XEN_DOMAIN on first use

With GNU make 4.4, the number of execution of the command present in these $(shell ) increased greatly. This is probably because as of make 4.4, exported variable are also added to the environment of $(shell ) construct. Also, `make -d` shows a lot of these: Makefile:15: not recursively expand

Re: [PATCH 1/2] xen/virtio: Fix NULL deref when a bridge of PCI root bus has no parent

On 21.06.23 16:12, Petr Pavlu wrote: Hello Petr > When attempting to run Xen on a QEMU/KVM virtual machine with virtio > devices (all x86_64), function xen_dt_get_node() crashes on accessing > bus->bridge->parent->of_node because a bridge of the PCI root bus has no > parent set: > > [1.6

Re: [XEN PATCH 1/3] build: define ARCH and SRCARCH later

On 21/06/2023 5:19 pm, Anthony PERARD wrote: > Defining ARCH and SRCARCH later in xen/Makefile allows to switch to > immediate evaluation variable type. > > ARCH and SRCARCH depends on value defined in Config.mk and aren't used > TARGET_SUBARCH or TARGET_ARCH, and not before it's needed in a > sub-

Re: [PATCH] Updates to Xen hypercall preemption

On Wed, Jun 21, 2023, at 8:14 AM, Per Bilse wrote: > Some Xen hypercalls issued by dom0 guests may run for many 10s of > seconds, potentially causing watchdog timeouts and other problems. > It's rare for this to happen, but it does in extreme circumstances, > for instance when shutting down VMs wit

Re: [XEN PATCH 1/3] build: define ARCH and SRCARCH later

On Wed, Jun 21, 2023 at 12:20 PM Anthony PERARD wrote: > > Defining ARCH and SRCARCH later in xen/Makefile allows to switch to > immediate evaluation variable type. > > ARCH and SRCARCH depends on value defined in Config.mk and aren't used > TARGET_SUBARCH or TARGET_ARCH, and not before it's neede

Re: [XEN PATCH 1/3] build: define ARCH and SRCARCH later

On Wed, Jun 21, 2023 at 12:27 PM Jason Andryuk wrote: > > On Wed, Jun 21, 2023 at 12:20 PM Anthony PERARD > wrote: > > > > Defining ARCH and SRCARCH later in xen/Makefile allows to switch to > > immediate evaluation variable type. > > > > ARCH and SRCARCH depends on value defined in Config.mk and

Re: [PATCH v1 1/1] Q35 Support

Sorry, this was sent in error when I did the git send-email for the folder. This was before I broke each patch down (after looking at the Qemu submission guidance). This is my first time sending a patch in this way, so thanks for the understanding. This patch can be ignored, as they are all covered

[xen-unstable-smoke test] 181537: trouble: blocked/broken/pass

flight 181537 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181537/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v1 1/1] Q35 Support

On 21.06.23 18:35, Joel Upham wrote: Sorry, this was sent in error when I did the git send-email for the folder. This was before I broke each patch down (after looking at the Qemu submission guidance). This is my first time sending a patch in this way, so thanks for the understanding. This patc

Re: [PATCH] Updates to Xen hypercall preemption

On Wed, Jun 21, 2023 at 03:14:42PM +, Per Bilse wrote: > Some Xen hypercalls issued by dom0 guests may run for many 10s of > seconds, potentially causing watchdog timeouts and other problems. > It's rare for this to happen, but it does in extreme circumstances, > for instance when shutting down

Re: [PATCH v2 1/2] x86/boot: Clear XD_DISABLE from the early boot path

Sure, to everything before this > > diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c > > index 168cd58f36..46b0cd8dbb 100644 > > --- a/xen/arch/x86/cpu/intel.c > > +++ b/xen/arch/x86/cpu/intel.c > > @@ -305,23 +305,23 @@ static void cf_check early_init_intel(struct > > cpuinfo_x86

Re: [PATCH v1 01/23] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

Thank you, I was working off the Xen-devel and didn’t find his email. I will update my qemu and xen patches for the next version. -Joel On Wed, Jun 21, 2023 at 3:17 AM Daniel P. Berrangé wrote: > On Tue, Jun 20, 2023 at 01:24:34PM -0400, Joel Upham wrote: > > > > Signed-off-by: Alexey Gerasimen

Re: [patch 05/37] x86/topology: Remove CPU0 hotplug option

On Sat, Apr 15, 2023 at 01:44:21AM +0200, Thomas Gleixner wrote: > This was introduced together with commit e1c467e69040 ("x86, hotplug: Wake > up CPU0 via NMI instead of INIT, SIPI, SIPI") to eventually support > physical hotplug of CPU0: > > "We'll change this code in the future to wake up hard

[PATCH 2/4] automation: Fix KBUILD_DEFCONFIG for *ppc64le jobs

During an iteration of the initial ppc64le support patchset the default defconfig was renamed but build.yaml wasn't updated to reflect this. Fix it up. Signed-off-by: Shawn Anastasio --- automation/gitlab-ci/build.yaml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/a

[PATCH 4/4] automation: Add smoke test for ppc64le

Add an initial smoke test that boots xen on a ppc64/pseries machine and checks for a magic string. Based on the riscv smoke test. Eventually the powernv9 (POWER9 bare metal) machine type will want to be tested as well, but for now we only boot on pseries. Signed-off-by: Shawn Anastasio --- auto

[PATCH 1/4] automation: Add QEMU to bullseye-ppc64le

Add qemu-system-ppc package to the bullseye-ppc64le container to allow running smoke tests in CI. Signed-off-by: Shawn Anastasio --- automation/build/debian/bullseye-ppc64le.dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/automation/build/debian/bullseye-ppc64le.dockerfile b/au

[PATCH 0/4] Early serial on Power

Hello all, This series adds support for early serial printing on Power, as well as a simple CI smoke test modeled after the riscv one. The third patch, which implements the serial console, also includes a set of header additions required to get the build going when including things like xen/lib.h

[PATCH 3/4] xen/ppc: Implement early serial printk on pseries

On typical Power VMs (e.g. QEMU's -M pseries), a variety of services including an early serial console are provided by Open Firmware. Implement the required interfaces to call into Open Firmware and write to the serial console. Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in 64-

[linux-linus test] 181529: regressions - trouble: blocked/broken/fail/pass

flight 181529 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181529/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-insta

Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

On 21/06/2023 5:59 pm, Shawn Anastasio wrote: > xen/arch/ppc/Kconfig.debug | 5 + > xen/arch/ppc/Makefile | 3 + > xen/arch/ppc/boot-of.c | 116 + > xen/arch/ppc/configs/ppc64_defconfig| 1 + > xen/arch/ppc/early_printk.c

[qemu-mainline test] 181534: regressions - trouble: blocked/broken/fail/pass

flight 181534 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181534/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-ins

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

On 21.06.23 16:12, Petr Pavlu wrote: Hello Petr > When attempting to run Xen on a QEMU/KVM virtual machine with virtio > devices (all x86_64), dom0 tries to establish a grant for itself which > eventually results in a hang during the boot. > > The backtrace looks as follows, the while loop i

Re: [PATCH 1/4] automation: Add QEMU to bullseye-ppc64le

On 21/06/2023 5:59 pm, Shawn Anastasio wrote: > Add qemu-system-ppc package to the bullseye-ppc64le container to allow > running smoke tests in CI. > > Signed-off-by: Shawn Anastasio Acked-by: Andrew Cooper Sorry - should have remembered to check on the previous patch. I'll commit and deploy t

Re: [PATCH 2/4] automation: Fix KBUILD_DEFCONFIG for *ppc64le jobs

On 21/06/2023 5:59 pm, Shawn Anastasio wrote: > During an iteration of the initial ppc64le support patchset the default > defconfig was renamed but build.yaml wasn't updated to reflect this. Fix > it up. > > Signed-off-by: Shawn Anastasio Acked-by: Andrew Cooper I'll commit this too.  Clearly i

Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

On 6/21/23 12:54 PM, Andrew Cooper wrote: > On 21/06/2023 5:59 pm, Shawn Anastasio wrote: >> xen/arch/ppc/Kconfig.debug | 5 + >> xen/arch/ppc/Makefile | 3 + >> xen/arch/ppc/boot-of.c | 116 + >> xen/arch/ppc/configs/ppc64_defconfig

Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

On 21/06/2023 7:21 pm, Shawn Anastasio wrote: > On 6/21/23 12:54 PM, Andrew Cooper wrote: >> On 21/06/2023 5:59 pm, Shawn Anastasio wrote: >>> xen/arch/ppc/Kconfig.debug | 5 + >>> xen/arch/ppc/Makefile | 3 + >>> xen/arch/ppc/boot-of.c | 116 +++

Re: [PATCH] Updates to Xen hypercall preemption

On 6/21/2023 5:27 PM, Andy Lutomirski wrote: > This code is a horrible mess, with and without your patches. I think that, > if this were new, there's no way it would make it in to the kernel. Hi Andy, and many thanks for your frank assessments. Generally, this is indeed somewhat old code, first

Re: [PATCH] Updates to Xen hypercall preemption

On 6/21/2023 5:40 PM, Peter Zijlstra wrote: > I don't understand it -- fundamentally, how can linux schedule when the > guest isn't even running? Hypercall transfers control to the > host/hypervisor and leaves the guest suspended. Hi Peter, as noted in earlier note to Andy, this is essentially exi

Re: [PATCH] Updates to Xen hypercall preemption

On Wed, Jun 21, 2023 at 07:19:21PM +, Per Bilse wrote: > On 6/21/2023 5:40 PM, Peter Zijlstra wrote: > > I don't understand it -- fundamentally, how can linux schedule when the > > guest isn't even running? Hypercall transfers control to the > > host/hypervisor and leaves the guest suspended. >

Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

On 6/21/23 12:54 PM, Andrew Cooper wrote: > I've noticed a couple of other things. asm/types.h repeats some > antipatterns which we're trying to delete for MISRA reasons in other > architectures. I was already planning to fix that up xen-wide, and I > guess now is the better time to do so. Could

Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

Hi Shawn, Below some remark about the coding style. I will try to spot all of them so please go through your code and check if my comments applies in other places. On 21/06/2023 17:59, Shawn Anastasio wrote: On typical Power VMs (e.g. QEMU's -M pseries), a variety of services including an ea

[PATCH 2/2] xen/types: Rework stdint vs __{u,s}$N types

Xen uses the stdint types. Rearrange the types headers to define the compatibility __{u,s}$N types in terms of the stdint types, not the other way around. All all supported compilers on architectures other than x86 support the stdint __*_TYPE__ macros. Move these into the common types.h to avoid

[PATCH 0/2] xen/types: Cleanup

Done both to avoid PPC64 bringing in yet another copy of some antipatterns, and because it fixes the MISRA issue relating to the __signed__ keyword. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/907638603 Andrew Cooper (2): xen/types: Drop #ifdefary for __{SIZE,PTRDIFF}_TYPE__

[PATCH 1/2] xen/types: Drop #ifdefary for __{SIZE,PTRDIFF}_TYPE__

All supported compilers have these types. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Bob Eshleman CC: Alistair Francis CC: Connor Davis CC:

Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

On Wed, 21 Jun 2023, Jan Beulich wrote: > First of all - please trim replies. > > On 20.06.2023 23:23, Stefano Stabellini wrote: > > On Tue, 20 Jun 2023, Simone Ballarin wrote: > >> --- a/xen/arch/x86/percpu.c > >> +++ b/xen/arch/x86/percpu.c > >> @@ -12,7 +12,7 @@ unsigned long __per_cpu_offset[N

Re: [PATCH v1 1/1] Q35 Support

Hi Joel, Nice! I've been working on making the PIIX south bridge Xen agnostic, partly to show how Xen enablement in Q35 could look like. Not that I'd have any use case for it but great to see that you've actually done that! I know you didn't intend to send this patch but I'll give you some e

Re: [PATCH] docs/misra: add Rules 8.2, 8.3, 8.14

On Wed, 21 Jun 2023, Jan Beulich wrote: > On 21.06.2023 03:26, Stefano Stabellini wrote: > > --- a/docs/misra/rules.rst > > +++ b/docs/misra/rules.rst > > @@ -213,6 +213,17 @@ maintainers if you want to suggest a change. > > - Types shall be explicitly specified > > - > > > > + * -

[xen-unstable-smoke test] 181538: trouble: blocked/broken/pass

flight 181538 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181538/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [XEN PATCH v3] docs/misra: document the C dialect and translation toolchain assumptions.

On Wed, 21 Jun 2023, Roberto Bagnara wrote: > This document specifies the C language dialect used by Xen and > the assumptions Xen makes on the translation toolchain. > > Signed-off-by: Roberto Bagnara > > Changes in V2: > - Clarified several entries. > - Removed entry about the use of the u

  1   2   >