Il giorno mar 20 giu 2023 alle ore 22:41 Stefano Stabellini < sstabell...@kernel.org> ha scritto:
> On Tue, 20 Jun 2023, Luca Fancellu wrote: > > > On 20 Jun 2023, at 13:39, Jan Beulich <jbeul...@suse.com> wrote: > > > > > > On 20.06.2023 12:34, Simone Ballarin wrote: > > >> --- a/xen/drivers/passthrough/amd/iommu-defs.h > > >> +++ b/xen/drivers/passthrough/amd/iommu-defs.h > > >> @@ -38,49 +38,49 @@ > > >> ((uint64_t)(offset) << (12 + (PTE_PER_TABLE_SHIFT * ((level) > - 1)))) > > >> > > >> /* IOMMU Capability */ > > >> -#define PCI_CAP_ID_MASK 0x000000FF > > >> +#define PCI_CAP_ID_MASK 0x000000FFU > > > > > > Seeing this and similar uses further down, I think there's a purely > > > stylistic question to be resolved first (and hence I'm widening the To: > > > list here): Do we want to allow either case of U to be used > > > interchangeably, leaving the choice up to the patch author? > > > > Because you ask to the list, my personal opinion is that we might want to > > have only capital U, so that it’s consistent across the codebase and we > don’t > > need to create too many rules for the developer, it stands out anyway as > it can’t > > be an hex digit > > I agree with Luca I also agree with Luca. -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com <http://bugseng.com>)
