On Fri, Sep 13, 2019 at 10:47:36AM +0200, Jan Beulich wrote:
>On 12.09.2019 09:22, Chao Gao wrote:
>> This series includes below changes:
>> 1. Patch 1-11: introduce a global microcode cache and some cleanup
>> 2. Patch 12: synchronize late microcode loading
>> 3. Patch 13: support parallel micr
On 17.09.2019 09:09, Chao Gao wrote:
> On Fri, Sep 13, 2019 at 10:47:36AM +0200, Jan Beulich wrote:
>> On 12.09.2019 09:22, Chao Gao wrote:
>>> This series includes below changes:
>>> 1. Patch 1-11: introduce a global microcode cache and some cleanup
>>> 2. Patch 12: synchronize late microcode lo
On 16.09.2019 18:58, Jan Beulich wrote:
> On 16.09.2019 10:10, Alexandru Stefan ISAILA wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3224,6 +3224,14 @@ static enum hvm_translation_result __hvm_copy(
>> return HVMTRANS_bad_gfn_to_mfn;
>> }
>>
On 16. Sep 2019, at 18:23, Ross Lagerwall
mailto:ross.lagerw...@citrix.com>> wrote:
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
This change is part of a independant stacked hotpatch modules
feature. This feature allows to bypass dependencies between modules
upon loading, but still verifies
On 17.09.2019 09:52, Alexandru Stefan ISAILA wrote:
> On 16.09.2019 18:58, Jan Beulich wrote:
>> On 16.09.2019 10:10, Alexandru Stefan ISAILA wrote:
>>> --- a/xen/arch/x86/hvm/hvm.c
>>> +++ b/xen/arch/x86/hvm/hvm.c
>>> @@ -3224,6 +3224,14 @@ static enum hvm_translation_result __hvm_copy(
>>>
On 16.09.2019 12:59, Pawel Wieczorkiewicz wrote:
> @@ -951,11 +952,13 @@ struct xen_sysctl_livepatch_list {
> amount of payloads and
> version.
> OUT: How many payloads left.
> */
> uint32_t pad;
On 16. Sep 2019, at 19:01, Ross Lagerwall
mailto:ross.lagerw...@citrix.com>> wrote:
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote:
snip
+/*
+ * Parse user provided action flags.
+ * This function expects to only receive an array of input parameters being
flags.
+ * Expected action is specifi
On 17. Sep 2019, at 10:27, Jan Beulich
mailto:jbeul...@suse.com>> wrote:
On 16.09.2019 12:59, Pawel Wieczorkiewicz wrote:
@@ -951,11 +952,13 @@ struct xen_sysctl_livepatch_list {
amount of payloads and version.
On 17.09.2019 10:40, Wieczorkiewicz, Pawel wrote:
>
>
> On 17. Sep 2019, at 10:27, Jan Beulich
> mailto:jbeul...@suse.com>> wrote:
>
> On 16.09.2019 12:59, Pawel Wieczorkiewicz wrote:
> @@ -951,11 +952,13 @@ struct xen_sysctl_livepatch_list {
>a
> On 17. Sep 2019, at 10:48, Jan Beulich wrote:
>
> On 17.09.2019 10:40, Wieczorkiewicz, Pawel wrote:
>>
>>
>> On 17. Sep 2019, at 10:27, Jan Beulich
>> mailto:jbeul...@suse.com>> wrote:
>>
>> On 16.09.2019 12:59, Pawel Wieczorkiewicz wrote:
>> @@ -951,11 +952,13 @@ struct xen_sysctl_live
On Fri, Sep 13, 2019 at 11:22:59AM +0200, Jan Beulich wrote:
>On 12.09.2019 09:22, Chao Gao wrote:
>> @@ -283,6 +284,27 @@ static enum microcode_match_result compare_patch(
>> : OLD_UCODE;
>> }
>>
>> +static bool is_blacklisted(void)
Julian,
The current status, as I said, is that the code has not been touched for many
years and I don’t actually know if it is functional against older versions of
Windows as it stands.
The kd protocol is a packet protocol and windbg is essentially in control;
issuing commands to dump regis
Hi Paul,
On 9/16/19 10:27 AM, Paul Durrant wrote:
...and hence the ability to disable IOMMU mappings, and control EPT
sharing.
This patch introduces a new 'libxl_passthrough' enumeration into
libxl_domain_create_info. The value will be set by xl either when it parses
a new 'passthrough' option
> On 16. Sep 2019, at 19:54, Ross Lagerwall wrote:
>
>>
snip
>> 2) post-apply hook
>> runs after the apply action has been executed and quiescing zone
>> exited. Its main purpose is to provide an ability to follow-up on
>> actions performed by the pre- hook, when module application was
>
On 9/17/19 10:12 AM, Wieczorkiewicz, Pawel wrote:
diff --git a/xen/include/xen/livepatch_payload.h
b/xen/include/xen/livepatch_payload.h
index 99613af2db..cd20944cc4 100644
--- a/xen/include/xen/livepatch_payload.h
+++ b/xen/include/xen/livepatch_payload.h
@@ -21,6 +21,16 @@ typedef struct paylo
Hi Paul,
On 9/16/19 9:34 AM, Paul Durrant wrote:
I guess this still needs ARM and toolstack acks?
For Arm bits:
Acked-by: Julien Grall
I am adding Anthony for the libxl.
Cheers,
-Original Message-
From: Paul Durrant
Sent: 13 September 2019 11:58
To: xen-devel@lists.xenproject.
Hi Jan,
On 9/13/19 12:10 PM, Jan Beulich wrote:
This patch defines a new bit reported in the hw_cap field of struct
xen_sysctl_physinfo to indicate whether the platform supports sharing of
HAP page tables (i.e. the P2M) with the IOMMU. This informs the toolstack
whether the domain needs extra me
Hi Paul,
On 9/13/19 11:58 AM, Paul Durrant wrote:
Now that there is a per-domain IOMMU-enable flag, which should be set if
any device is going to be passed through, stop deferring page table
construction until the assignment is done. Also don't tear down the tables
again when the last device is
Hi Paul,
On 9/13/19 11:58 AM, Paul Durrant wrote:
Thes macros really ought to live in the common xen/iommu.h header rather
then being distributed amongst architecture specific iommu headers and
xen/sched.h. This patch moves them there.
NOTE: Disabling 'sharept' in the command line iommu options
flight 141388 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141388/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253
Tests which
On 17.09.2019 11:01, Chao Gao wrote:
> On Fri, Sep 13, 2019 at 11:22:59AM +0200, Jan Beulich wrote:
>> On 12.09.2019 09:22, Chao Gao wrote:
>>> --- a/xen/include/asm-x86/microcode.h
>>> +++ b/xen/include/asm-x86/microcode.h
>>> @@ -30,6 +30,7 @@ struct microcode_ops {
>>> bool (*match_cpu)(con
Hi Volodymyr,
On 9/16/19 4:26 PM, Volodymyr Babchuk wrote:
Hi Julien,
Julien Grall writes:
Hi,
On 9/12/19 8:45 PM, Volodymyr Babchuk wrote:
Hi Julien,
Julien Grall writes:
Hi Volodymyr,
On 9/11/19 7:48 PM, Volodymyr Babchuk wrote:
Julien Grall writes:
Hi Volodymyr,
On 8/23/19 7:4
Hi Stewart,
On 9/14/19 2:22 AM, Stewart Hildebrand wrote:
On Friday, September 13, 2019 5:42 PM, Julien Grall
wrote:
Hi,
On 9/13/19 8:11 PM, Stewart Hildebrand wrote:
Upstream Linux kernel will use "brcm,bcm2711" as the compatible string
for Raspberry Pi 4 [1]. Add this string to our platfo
flight 141358 linux-4.9 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141358/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-xsm broken
build-i386-xsm
Hi Julien,
Julien Grall writes:
> Hi Volodymyr,
>
> On 9/16/19 4:26 PM, Volodymyr Babchuk wrote:
>>
>> Hi Julien,
>>
>> Julien Grall writes:
>>
>>> Hi,
>>>
>>> On 9/12/19 8:45 PM, Volodymyr Babchuk wrote:
Hi Julien,
Julien Grall writes:
> Hi Volodymyr,
>
> O
(+ Juergen)
Hi,
On 9/16/19 9:51 AM, Jan Beulich wrote:
On 15.09.2019 19:51, Julien Grall wrote:
Hi,
On 9/15/19 3:09 PM, osstest service owner wrote:
flight 141333 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141333/
Regressions :-(
Tests which did not suc
On 06/08/2019 14:08, Jan Beulich wrote:
> Calling amd_iommu_free_intremap_table() for every IVRS entry is correct
> only in per-device-IRT mode. Use a NULL 2nd argument to indicate that
> the shared table should be freed, and call the function exactly once in
> shared mode.
>
> Signed-off-by: Jan B
On 06/08/2019 14:08, Jan Beulich wrote:
> For us to no longer blindly allocate interrupt remapping tables for
> everything the ACPI tables name, we can't use struct ivrs_mappings'
> intremap_table field anymore to also have the meaning of "this entry
> is valid". Add a separate boolean field instea
> -Original Message-
> From: Xen-devel On Behalf Of Jan
> Beulich
> Sent: 17 September 2019 07:15
> To: xen-devel@lists.xenproject.org
> Cc: Kevin Tian ; Suravee Suthikulpanit
> ; Wei Liu
> ; Paul Durrant ; George Dunlap
> ; Andrew Cooper
> ; Jun Nakajima ; Boris
> Ostrovsky
> ; Roger
On 06/08/2019 14:09, Jan Beulich wrote:
> Additional users of the function will want to handle errors more
> gracefully. Remove the BUG_ON()s and make the current caller panic()
> instead.
>
> Signed-off-by: Jan Beulich
Acked-by: Andrew Cooper
___
Xen
On Fri, 13 Sep 2019 at 11:58, Paul Durrant wrote:
>
> This patch defines a new bit reported in the hw_cap field of struct
> xen_sysctl_physinfo to indicate whether the platform supports sharing of
> HAP page tables (i.e. the P2M) with the IOMMU. This informs the toolstack
> whether the domain need
On Tue, Sep 17, 2019 at 08:55:22AM +, Wieczorkiewicz, Pawel wrote:
>
>
> > On 17. Sep 2019, at 10:48, Jan Beulich wrote:
> >
> > On 17.09.2019 10:40, Wieczorkiewicz, Pawel wrote:
> >>
> >>
> >> On 17. Sep 2019, at 10:27, Jan Beulich
> >> mailto:jbeul...@suse.com>> wrote:
> >>
> >> On
On 17.09.2019 14:45, Paul Durrant wrote:
>> From: Xen-devel On Behalf Of Jan
>> Beulich
>> Sent: 17 September 2019 07:15
>>
>> --- a/xen/arch/x86/hvm/emulate.c
>> +++ b/xen/arch/x86/hvm/emulate.c
>> @@ -2080,6 +2080,8 @@ static int hvmemul_write_cr(
>> HVMTRACE_LONG_2D(CR_WRITE, reg, TRC_PAR
On 06/08/2019 14:09, Jan Beulich wrote:
> ACPI tables are free to list far more device coordinates than there are
> actual devices. By delaying the table allocations for most cases, and
> doing them only when an actual device is known to be present at a given
> position, overall memory used for the
On 17.09.19 14:31, Julien Grall wrote:
(+ Juergen)
Hi,
On 9/16/19 9:51 AM, Jan Beulich wrote:
On 15.09.2019 19:51, Julien Grall wrote:
Hi,
On 9/15/19 3:09 PM, osstest service owner wrote:
flight 141333 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141333/
After commit 6e3e771203 "xen/arm: setup: Relocate the Device-Tree later on
in the boot", the boot allocator will not receive any xenheap page (i.e.
mapped page) on Arm32.
However, the boot allocator implicitely rely on having the first page
already mapped and therefore result to break boot on Arm3
On 06/08/2019 14:09, Jan Beulich wrote:
> Rather than duplicating entries in amd_iommu_msi_msg_update_ire(), share
> the tables. This mainly requires some care while freeing them, to avoid
> freeing memory blocks twice.
>
> Signed-off-by: Jan Beulich
Acked-by: Andrew Cooper
On 06/08/2019 14:10, Jan Beulich wrote:
> Rather than doing this every time we set up interrupts for a device
> anew (and then in two distinct places) fill this invariant field
> right after allocating struct arch_msix.
>
> While at it also obtain the MSI-X capability structure position just
> once
Hi Juergen,
On 9/17/19 2:12 PM, Juergen Gross wrote:
On 17.09.19 14:31, Julien Grall wrote:
(+ Juergen)
Hi,
On 9/16/19 9:51 AM, Jan Beulich wrote:
On 15.09.2019 19:51, Julien Grall wrote:
Hi,
On 9/15/19 3:09 PM, osstest service owner wrote:
flight 141333 xen-unstable-smoke real [real]
htt
> -Original Message-
> From: Jan Beulich
> Sent: 17 September 2019 14:03
> To: Paul Durrant
> Cc: xen-devel@lists.xenproject.org; Suravee Suthikulpanit
> ; Andrew
> Cooper ; George Dunlap ;
> Roger Pau Monne
> ; Jun Nakajima ; Kevin Tian
> ;
> BorisOstrovsky ; Paul Durrant ; Wei
> Liu
flight 141361 linux-4.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141361/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvshim 12 guest-start fail REGR. vs. 139698
test-amd64-i386-libvi
On 17.09.2019 11:09, Jan Beulich wrote:
> On 17.09.2019 09:52, Alexandru Stefan ISAILA wrote:
>> On 16.09.2019 18:58, Jan Beulich wrote:
>>> On 16.09.2019 10:10, Alexandru Stefan ISAILA wrote:
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -3224,6 +3224,14 @@ static e
On 9/17/19 5:11 PM, Alexandru Stefan ISAILA wrote:
> +bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
> + uint16_t kind)
> +{
> +xenmem_access_t access;
> +vm_event_request_t req = {};
> +paddr_t gpa = (gfn_to_gad
flight 141391 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141391/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253
Tests which
On 17.09.2019 16:11, Alexandru Stefan ISAILA wrote:
>
>
> On 17.09.2019 11:09, Jan Beulich wrote:
>> On 17.09.2019 09:52, Alexandru Stefan ISAILA wrote:
>>> On 16.09.2019 18:58, Jan Beulich wrote:
On 16.09.2019 10:10, Alexandru Stefan ISAILA wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> ++
On Sat, 2019-09-14 at 08:42 +0200, Juergen Gross wrote:
> vcpu_force_reschedule() is only used for modifying the periodic timer
> of a vcpu. Forcing a vcpu to give up the physical cpu for that
> purpose
> is kind of brutal.
>
> So instead of doing the reschedule dance just operate on the timer
> d
Anthony PERARD writes ("Re: [PATCH] libxlu: Handle += in config files"):
> I wonder if instead of doing += on all strings, we should instead have
> `xl' whitelist the few options where += would make sense. (and at that
> point, it would be easy to add a ' ' where is make sense, like
> "cmdline"s. B
On 17.09.2019 17:32, Jan Beulich wrote:
> On 17.09.2019 16:11, Alexandru Stefan ISAILA wrote:
>>
>>
>> On 17.09.2019 11:09, Jan Beulich wrote:
>>> On 17.09.2019 09:52, Alexandru Stefan ISAILA wrote:
On 16.09.2019 18:58, Jan Beulich wrote:
> On 16.09.2019 10:10, Alexandru Stefan ISAILA wr
On 17.09.2019 17:00, Alexandru Stefan ISAILA wrote:
> There is no problem, I understand the risk of having suspicious return
> values. I am not hanged on having this return. I used this to skip
> adding a new return value. I can do this if we agree on a suitable name
> for a new return value in
On 06/08/2019 14:11, Jan Beulich wrote:
> Prepare for the number of entries to not be the maximum possible, by
> separating checks against maximum size from ones against actual size.
> For caller side simplicity have alloc_intremap_entry() return the
> maximum possible value upon allocation failure
On Tue, Sep 17, 2019 at 8:24 AM Razvan Cojocaru
wrote:
>
> On 9/17/19 5:11 PM, Alexandru Stefan ISAILA wrote:
> > +bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
> > + uint16_t kind)
> > +{
> > +xenmem_access_t access;
> >
On 06/08/2019 14:11, Jan Beulich wrote:
> There's no point setting up tables with more space than a PCI device can
> use. For both MSI and MSI-X we can determine how many interrupts could
> be set up at most. Tables allocated during ACPI table parsing, however,
> will (for now at least) continue to
On 17.09.2019 18:04, Jan Beulich wrote:
> On 17.09.2019 17:00, Alexandru Stefan ISAILA wrote:
>> There is no problem, I understand the risk of having suspicious return
>> values. I am not hanged on having this return. I used this to skip
>> adding a new return value. I can do this if we agree on
Anthony PERARD writes ("[PATCH v2 3/9] libxl_internal: Introduce libxl__ev_lock
for devices hotplug via QMP"):
> The current lock `domain_userdata_lock' can't be used when modification
> to a guest is done by sending command to QEMU, this is a slow process
> and requires to call CTX_UNLOCK, which
Anthony PERARD writes ("[PATCH v2 4/9] libxl: Add optimisation to ev_lock"):
> It will often be the case that the lock is free to grab. So we first
> try to grab it before we have to fork. Even though in this case the
> locks are grabbed in the wrong order in the lock hierarchy (ev_lock
> should be
The current implementations of xen_{map, unmap}_table() expect
{map, unmap}_domain_page() to be usable. Those helpers are used to
map/unmap page tables while update Xen page-tables.
Since commit 022387ee1a "xen/arm: mm: Don't open-code Xen PT update in
{set, clear}_fixmap()", setup_fixmap() will m
Anthony PERARD writes ("[PATCH v2 6/9] libxl_disk: Cut libxl_cdrom_insert into
steps .."):
> .. and use a new "slow" lock to avoid holding the userdata lock across
> several functions.
>
> This patch cuts libxl_cdrom_insert into different step/function but
> there are still called synchronously.
On 9/17/19 6:09 PM, Tamas K Lengyel wrote:
> On Tue, Sep 17, 2019 at 8:24 AM Razvan Cojocaru
> wrote:
>>
>> On 9/17/19 5:11 PM, Alexandru Stefan ISAILA wrote:
>>> +bool hvm_monitor_check_p2m(unsigned long gla, gfn_t gfn, uint32_t pfec,
>>> + uint16_t kind)
>>>
Anthony PERARD writes ("[PATCH v2 0/9] libxl: New slow lock + fix
libxl_cdrom_insert with QEMU depriv"):
> This patch series fix libxl_cdrom_insert to work with a depriviledge QEMU. For
> that, we need to use libxl__ev_qmp. For that, we need a new lock because
> userdata_lock can't be used anymor
Anthony PERARD writes ("[PATCH 01/15] libxl: Rename struct libxl_device_type to
libxl__device_type"):
> libxl__device_type is internal to libxl, rename it to the internal
> only prefix. And eliminate redundant 'struct' keyword, in accord with
> the coding style.
Acked-by: Ian Jackson
__
On 16/09/2019 14:56, Paul Durrant wrote:
>> -Original Message-
>> From: Wei Liu
>> Sent: 16 September 2019 14:29
>> To: Andrew Cooper
>> Cc: Paul Durrant ; Xen-devel
>> ; Jan Beulich
>> ; Wei Liu ; Roger Pau Monne
>>
>> Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL pri
Anthony PERARD writes ("[PATCH 02/15] libxl: Remove unused variable in
libxl__device_pci_add_xenstore"):
> *device isn't used.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinf
On 16/09/2019 10:48, Jan Beulich wrote:
> For some reason the Hygon enabling series left out the insn emulator.
> Make appropriate adjustments wherever we've been special casing AMD.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Andrew Cooper
___
Xen-de
Anthony PERARD writes ("[PATCH 03/15] libxl_pci: Make libxl__create_pci_backend
static"):
> libxl__create_pci_backend isn't called from outside of libxl_pci
> anymore, and it's only useful as part of the pci_add process, so
> remove the prototype from libxl_internal.h.
>
> No functional changes.
Anthony PERARD writes ("[PATCH 05/15] libxl_pci: `starting' is a bool"):
> The argument `starting' is used as a boolean, change its type to
> reflex that throughout libxl_pci.c.
>
> No functional changes.
Acked-by: Ian Jackson
___
Xen-devel mailing li
Anthony PERARD writes ("[PATCH 06/15] libxl_dom_save: Reorder functions for
switch_qemu_logdirty"):
> Pure code motion.
I'll trust you on this :-).
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproje
Anthony PERARD writes ("[PATCH 04/15] libxl_pci: Constify arg `pcidev' of
libxl__device_pci_add_xenstore"):
> libxl__device_pci_add_xenstore doesn't modify `pcidev', so it can be
> constified. Also, we don't need pcidev_saved anymore, so remove the
> saved copy. (device_add_domain_config is going
Anthony PERARD writes ("[PATCH 08/15] libxl: Comment libxl__dm_spawn_state
aboud init and dispose"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/
Anthony PERARD writes ("[PATCH 07/15] libxl_dm: Fix initialisation of
libxl__stub_dm_spawn_state"):
> sdss->pvqemu wasn't initialiased and disposed of properly.
> Also, move the initialisation of sdss->xswait with the rest of the
> initialisation of sdss.
Acked-by: Ian Jackson
_
Anthony PERARD writes ("[PATCH 09/15] libxl_domain: Cleanup
libxl__destroy_domid"):
> - dom_path isn't used anymore in that function, remove it.
> - Use `r' to store return value of external calls.
> - Use `CTX', no need for a local `ctx'.
Acked-by: Ian Jackson
_
Anthony PERARD writes ("[PATCH 10/15] libxl_usb: Use proper domid value, from
libxl__device"):
> ao->domid isn't a reliable way of getting a domid, it might not be set
> (this isn't the case here). The right domid value can be found in the
> libxl__device (which is the device we want to remove) at
Anthony PERARD writes ("[PATCH 11/15] libxl_usb: Fix wrong usage of asserts"):
> Signed-off-by: Anthony PERARD
I'm not sure why you wouldn't just delete the breaks, rather than
replacing them "return" ?
Thanks,
Ian.
___
Xen-devel mailing list
Xen-deve
Anthony PERARD writes ("[PATCH 13/15] libxl: Constify libxl_device_* param of
*_getinfo"):
> The libxl_device_TYPE parameter of all the libxl_device_TYPE_getinfo
> function seems to be only used as input to find more information to bi
> stored in the libxl_TYPEinfo parameter.
>
> Make sure this i
Anthony PERARD writes ("[PATCH 12/15] libxl_usb: Fix
libxl_device_usbctrl_getinfo"):
> `usbctrl' is modified in this function which doesn't seems to be
> intended, and usbctrlinfo.backend_id was never modified.
>
> Take this opportunity to consify the argument `usbctrl' in libxl API
> to avoid si
Anthony PERARD writes ("[PATCH 14/15] libxl_usb: usbctrl, make use of generic
device handling functions"):
> Two functions in generate `libxl_device_usbctrl' can be replaced by
> generic macro:
> - libxl_device_usbctrl_list -> LIBXL_DEFINE_DEVICE_LIST
> - libxl_devid_to_device_usbctrl -> LIBXL_DEF
Anthony PERARD writes ("[PATCH 15/15] libxl_usb: Use usbctrl instead of
usbctrlinfo"):
> The functions that calls usbctrl_getinfo() only needs information that
> can be found in a `libxl_device_usbctrl'. So avoid calling
> libxl_device_usbctrl_getinfo and call libxl_devid_to_device_usbctrl
> inste
Anthony PERARD writes ("[PATCH 01/35] libxl: Make libxl_domain_unpause async"):
> libxl_domain_unpause needs to make QMP calls, which are asynchronous,
> change the API to reflect that.
>
> Do the same with libxl_domain_pause async, even if it will keep
> completing synchronously.
Jolly good. I
Anthony PERARD writes ("[PATCH 04/35] libxl: Make
libxl_retrieve_domain_configuration async"):
> .. because it makes QMP calls which are going to be async.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.x
Anthony PERARD writes ("[PATCH 02/35] libxl: Make libxl_send_trigger async"):
> .. because it makes QMP calls which are going to be async.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mail
Anthony PERARD writes ("[PATCH 05/35] libxl: Make libxl_qemu_monitor_command
async"):
> .. because it makes QMP calls which are going to be async.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject
Anthony PERARD writes ("[PATCH 03/35] libxl: Make libxl_set_vcpuonline async"):
> .. because it makes QMP calls which are going to be async.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/ma
Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for
switch_qemu_xen_logdirty"):
> Signed-off-by: Anthony PERARD
...
> +rc = libxl__ev_time_register_rel(ao, &lds->timeout,
> + switch_logdirty_timeout, 10 * 1000);
> +if (rc) goto out;
> +
> +q
Ian Jackson writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for
switch_qemu_xen_logdirty"):
> Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > Signed-off-by: Anthony PERARD
> ...
> > +rc = libxl__ev_time_register_rel(ao, &lds->timeout,
> > +
Anthony PERARD writes ("[PATCH 07/35] libxl: Move "qmp_initializations" to
libxl_dm"):
> libxl__qmp_initializations is part of the device domain startup, it
> queries information about the newly spawned QEMU and do some
> post-startup configuration. So the function call doesn't belong to the
> gen
flight 141367 linux-4.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/141367/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail REGR. vs. 139910
test-amd64-i386-xl-q
Anthony PERARD writes ("[PATCH 08/35] libxl: Replace libxl__qmp_initializations
by ev_qmp calls"):
> Setup a timeout of 10s for all the commands. It used to be about 5s
> per commands.
This patch is quite hard to review because it is a
rewrite/rearrangement and I can't see where all the pieces co
Anthony PERARD writes ("[PATCH 09/35] libxl: Deprecate
libxl__domain_{unpause,resume}"):
> These two functions are used from many places in libxl and need to
> change to be able to accomodate libxl__ev_qmp calls and thus needs to
> be asynchronous.
>
> (There is also libxl__domain_resume_device_m
Anthony PERARD writes ("[PATCH 10/35] libxl: Re-introduce
libxl__domain_resume"):
> libxl__domain_resume is a rework libxl__domain_resume_deprecated. It
> makes uses of ev_xswatch and ev_qmp, to replace synchronous QMP calls
> and libxl__wait_for_device_model_deprecated call.
Acked-by: Ian Jackso
Anthony PERARD writes ("[PATCH 11/35] libxl_domain: Convert libxl_domain_resume
to use libxl__domain_resume"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.or
Anthony PERARD writes ("[PATCH 13/35] libxl_dm: Update libxl__spawn_stub_dm to
use libxl__domain_unpause"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/m
Anthony PERARD writes ("[PATCH 12/35] libxl: Re-introduce
libxl__domain_unpause"):
> libxl__domain_unpause is a reimplementation of
> libxl__domain_unpause_deprecated with asynchronous operation.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-de
Anthony PERARD writes ("[PATCH 14/35] libxl_domain: Convert
libxl_domain_unpause to use libxl__domain_unpause"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.
Anthony PERARD writes ("[PATCH 16/35] libxl: Inline do_usbdev_remove into
libxl__device_usbdev_remove"):
> Having the function do_usbdev_remove makes it harder to add asynchronous
> calls into it. Move its body back into libxl__device_usbdev_remove and
> adjust the latter as there are no reason to
Anthony PERARD writes ("[PATCH 15/35] libxl: Inline do_usbdev_add into
libxl__device_usbdev_add"):
> Having the function do_usbdev_add makes it harder to add asynchronous
> calls into it. Move its body back into libxl__device_usbdev_add and
> adjust the latter as there are no reason to have a sepa
Anthony PERARD writes ("[PATCH 17/35] libxl: Add libxl__ev_qmp to
libxl__ao_device"):
> `aodev->qmp' is initialised in libxl__prepare_ao_device(), but since
> there isn't a single exit path for a `libxl__ao_device', users of this
> new `qmp' field will have to disposed of it.
Acked-by: Ian Jackso
Anthony PERARD writes ("[PATCH 18/35] libxl: Add device_{config,type} to
libxl__ao_device"):
> These two fields help to give more information about the device been
> hotplug/hotunplug to callbacks.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-
Anthony PERARD writes ("[PATCH 19/35] libxl_usb: Make libxl__device_usbctrl_add
uses ev_qmp"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listin
Ian Jackson writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for
switch_qemu_xen_logdirty"):
> Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > Signed-off-by: Anthony PERARD
> ...
> > +rc = libxl__ev_time_register_rel(ao, &lds->timeout,
> > +
Anthony PERARD writes ("[PATCH 21/35] libxl_usb: Make libxl__device_usbdev_add
uses ev_qmp"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinf
Anthony PERARD writes ("[PATCH 20/35] libxl_usb: Make
libxl__initiate_device_usbctrl_remove uses ev_qmp"):
> Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/ma
1 - 100 of 150 matches
Mail list logo
