On 16/09/2019 14:56, Paul Durrant wrote: >> -----Original Message----- >> From: Wei Liu <w...@xen.org> >> Sent: 16 September 2019 14:29 >> To: Andrew Cooper <andrew.coop...@citrix.com> >> Cc: Paul Durrant <paul.durr...@citrix.com>; Xen-devel >> <xen-devel@lists.xenproject.org>; Jan Beulich >> <jbeul...@suse.com>; Wei Liu <w...@xen.org>; Roger Pau Monne >> <roger....@citrix.com> >> Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message >> >> On Mon, 16 Sep 2019 at 14:13, Andrew Cooper <andrew.coop...@citrix.com> >> wrote: >> [...] >>>>>>> Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to >>>>>>> non-xen-developers trying to interpret the message. >>>>>> This is a message that is peculiar to Windows VMs, so how about "Windows >>>>>> VM CRASH"? >>>>> I presume you mean particular, but no - it isn't windows which is the >>>>> exclusive user of this interface. Linux has a driver to use it when >>>>> running under HyperV. >>>> Hmm, that's a bit odd. I thought the crash codes are Windows specific. >>>> Perhaps they can be >> distinguished in some way. >>> Linux sets its own guest OS identifier, which is some function of >>> HV_LINUX_VENDOR_ID. >>> >>>> All the same, the log line needs to lead people to some way of decoding >>>> the magic numbers I >> think. How about: >>>> "VIRIDIAN REPORTED CRASH" >>>> >>>> ? >>> That is still just as confusing to read. >>> >>> There is no way to decode the numbers without knowing what OS is >>> running, and simply saying "Viridian" doesn't help with that. >>> >> Would it make sense to call dump_guest_os_id here as well? Seeing that >> it is only printed when it was first set. > Yes, that's not a bad idea.
This is as maybe, but still doesn't help with ambiguity because you can't expect people to recognise guest-id's by their hex value. It also doesn't help with the confusion of having the word viridian in the printed string. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
