Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty"): > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> ... > + rc = libxl__ev_time_register_rel(ao, &lds->timeout, > + switch_logdirty_timeout, 10 * 1000); > + if (rc) goto out; > + > + qmp->ao = ao; > + qmp->domid = domid; > + qmp->payload_fd = -1; > + qmp->callback = switch_qemu_xen_logdirty_done; > + libxl__qmp_param_add_bool(gc, &args, "enable", enable); > + rc = libxl__ev_qmp_send(gc, qmp, "xen-set-global-dirty-log", args);
I hate to suggest this at this stage, but: maybe the timeout could be incorporated into libxl__ev_qmp ? I think every libxl__qmp caller is going to need a timeout ? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel