Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Bill O'Donnell
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifiniband dirs

Re: [PATCH v2 3/4] xen/cppc: get xen-required cppc perf caps data

2025-01-15 Thread Jason Andryuk
Hi Penny, On 2024-12-05 00:42, Penny Zheng wrote: diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 13d6ff84a1e9..3a436591da07 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c + if (!high || !low || !nom || !min_nonlinear) + pr_war

Re: [PATCH v3 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Mykyta Poturai wrote: > From: Oleksandr Andrushchenko > > There are number of ITS implementations exist which are different from > the base one which have number of functionalities defined as is > "IMPLEMENTATION DEFINED", e.g. there may exist differences in cacheability, > s

Re: [PATCH] Manual pages: Fix a few typos

2025-01-15 Thread Andrew Cooper
On 15/01/2025 1:57 pm, Bernhard Kaindl wrote: > While skimming through the manual pages, I spotted a few typos. > > Signed-off-by: Bernhard Kaindl Reviewed-by: Andrew Cooper

Re: [PATCH] docs: Punctuation: Add missing commas after linking adverbs as intros

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Bernhard Kaindl wrote: > Fix missing commas after linking adverbs such as currently, fortunately, > hence, instead, and thus, when used as linking adverbs at the beginning > of sentences. I saw them with LTeX; other checkers have this rule too. > > Signed-off-by: Bernhard Kain

Re: [PATCH] docs: Fix spaces and capitalisation of proper nouns and abbreviations

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Bernhard Kaindl wrote: > Signed-off-by: Bernhard Kaindl > --- > SUPPORT.md | 18 +- > docs/designs/qemu-deprivilege.md | 2 +- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 2bc5bd8

Re: [PATCH] docs/misc: Fix a few typos

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Bernhard Kaindl wrote: > While skimming through the misc docs, I spotted a few typos. > > Signed-off-by: Bernhard Kaindl Reviewed-by: Stefano Stabellini

Re: [PATCH] Design docs: Fix some typos in the design docs

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Frediano Ziglio wrote: > On Wed, Jan 15, 2025 at 1:45 PM Bernhard Kaindl > wrote: > > > > Skimming through the design docs, I saw some typos that needed fixing. > > > > --- > > Comments for reviewers (not for the commit message itself): > > > > Sample typos (some are not easy

Re: [PATCH] riscv: Add initial Xen guest support for RISC-Vgh

2025-01-15 Thread Stefano Stabellini
On Wed, 15 Jan 2025, Milan Đokić wrote: > Hello Stefano, Oleksii > > On Wed, Jan 15, 2025 at 5:30 PM Oleksii Kurochko > wrote: > > > > Hi Stefano, > > > > On 1/15/25 1:01 AM, Stefano Stabellini wrote: > > > > +Oleksii > > > > On Tue, 14 Jan 2025, Milan Djokic wrote: > > > > From: Slavisa Petrovic

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Wei Liu
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: [...] > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 7a35c82976e0..9453f0c26f2a 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -141,7 +141,7 @@ static int sysctl_record_panic_msg = 1; >

Re: [PATCH v2 03/15] x86/boot: add cmdline to struct boot_domain

2025-01-15 Thread Jason Andryuk
On 2025-01-15 12:22, Daniel P. Smith wrote: On 1/10/25 14:52, Jason Andryuk wrote: On 2024-12-26 11:57, Daniel P. Smith wrote: Add a container for the "cooked" command line for a domain. This provides for the backing memory to be directly associated with the domain being constructed. This is d

Re: [PATCH v2 12/15] x86/hyperlaunch: specify dom0 mode with device tree

2025-01-15 Thread Jason Andryuk
On 2024-12-26 11:57, Daniel P. Smith wrote: Enable selecting the mode in which the domain will be built and ran. This s/built and ran/built and run/ Regards, Jason

Re: [PATCH v2 14/15] x86/hyperlaunch: add max vcpu parsing of hyperlaunch device tree

2025-01-15 Thread Jason Andryuk
On 2024-12-26 11:57, Daniel P. Smith wrote: Introduce the `cpus` property, named as such for dom0less compatibility, that represents the maximum number of vpcus to allocate for a domain. In the device tree, it will be encoded as a u32 value. s/vpcus/vcpus/ I would remove "maximum". Today, the

Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

2025-01-15 Thread Milan Đokić
Hello Stefano, Oleksii On Wed, Jan 15, 2025 at 5:30 PM Oleksii Kurochko wrote: > > Hi Stefano, > > On 1/15/25 1:01 AM, Stefano Stabellini wrote: > > +Oleksii > > On Tue, 14 Jan 2025, Milan Djokic wrote: > > From: Slavisa Petrovic > > This patch introduces initial support for running RISC-V as a

Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

2025-01-15 Thread Milan Đokić
Hello Andrew, On Tue, Jan 14, 2025 at 7:18 PM Andrew Jones wrote: > > On Tue, Jan 14, 2025 at 05:09:36PM +0100, Milan Djokic wrote: > > From: Slavisa Petrovic > > > > This patch introduces initial support for running RISC-V as a Xen guest. > > It provides the necessary infrastructure and stubs f

Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

2025-01-15 Thread Milan Đokić
Hello Teddy, On Tue, Jan 14, 2025 at 6:51 PM Teddy Astie wrote: > > Le 14/01/2025 à 17:13, Milan Djokic a écrit : > > diff --git a/test.txt b/test.txt > > new file mode 100644 > > index ..e54267998982 > > --- /dev/null > > +++ b/test.txt > > @@ -0,0 +1,21 @@ > > +WARNING: added, moved

Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

2025-01-15 Thread Milan Đokić
On Tue, Jan 14, 2025 at 5:41 PM Anup Patel wrote: > > On Tue, Jan 14, 2025 at 9:41 PM Milan Djokic > wrote: > > > > From: Slavisa Petrovic > > > > This patch introduces initial support for running RISC-V as a Xen guest. > > It provides the necessary infrastructure and stubs for Xen-specific > >

[PATCH] docs: Punctuation: Add missing commas after linking adverbs as intros

2025-01-15 Thread Bernhard Kaindl
Fix missing commas after linking adverbs such as currently, fortunately, hence, instead, and thus, when used as linking adverbs at the beginning of sentences. I saw them with LTeX; other checkers have this rule too. Signed-off-by: Bernhard Kaindl --- SUPPORT.md|

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Thomas Gleixner
On Fri, Jan 10 2025 at 15:16, Joel Granados wrote: > sed: > sed --in-place \ > -e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table > = \&uts_kern/" \ > kernel/utsname_sysctl.c > > Reviewed-by: Song Liu > Acked-by: Steven Rostedt (Google) # for kernel/trace/ >

Re: [PATCH v2 07/15] x86/hyperlaunch: initial support for hyperlaunch device tree

2025-01-15 Thread Daniel P. Smith
On 1/10/25 17:20, Jason Andryuk wrote: On 2024-12-26 11:57, Daniel P. Smith wrote: Add the ability to detect both a formal hyperlaunch device tree or a dom0less device tree. If the hyperlaunch device tree is found, then count the number of domain entries, reporting an error if more than one is

Re: [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread David Woodhouse
On Wed, 2025-01-15 at 17:49 +0100, Anthony PERARD wrote: > > With those fixed: Reviewed-by: Anthony PERARD Thanks. I've pushed those changes and am watching the pipeline at https://gitlab.com/dwmw2/qemu/-/pipelines/1626804720 I'll probably send a pull request tomorrow. The patch now looks like

Re: [PATCH] xen/ppc: Fix double xen_ulong_t typedef in public/arch-ppc.h

2025-01-15 Thread Shawn Anastasio
Hi Andrew, On 1/15/25 9:03 AM, Andrew Cooper wrote: > public/arch-ppc.h contains two adjacent #ifndef __ASSEMBLY__ blocks. > > With these merged, it becomes very obvious that there's a duplicate > definition of xen_ulong_t, which is also noticed by the docs build: > > /usr/bin/perl -w /local/x

Re: [PATCH v2 06/15] x86/hyperlaunch: introduce the domain builder

2025-01-15 Thread Daniel P. Smith
On 1/8/25 16:54, Jason Andryuk wrote: On 2024-12-26 11:57, Daniel P. Smith wrote: Introduce the domain builder which is capable of consuming a device tree as the first boot module. If it finds a device tree as the first boot module, it will set its type to BOOTMOD_FDT. This change only detects

Re: [PATCH v2 05/15] kconfig: introduce domain builder config option

2025-01-15 Thread Daniel P. Smith
On 1/10/25 14:55, Jason Andryuk wrote: On 2024-12-26 11:57, Daniel P. Smith wrote: Hyperlaunch domain builder will be the consolidated boot time domain building logic framework. Introduces the config option to enable this domain builder to and turn on the ability to load the domain configuratio

Re: [PATCH v2 03/15] x86/boot: add cmdline to struct boot_domain

2025-01-15 Thread Daniel P. Smith
On 1/10/25 14:52, Jason Andryuk wrote: On 2024-12-26 11:57, Daniel P. Smith wrote: Add a container for the "cooked" command line for a domain. This provides for the backing memory to be directly associated with the domain being constructed. This is done in anticipation that the domain construct

Re: [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread Anthony PERARD
On Wed, Jan 15, 2025 at 04:27:25PM +, David Woodhouse wrote: > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > index e61902461b..9e7f6da343 100644 > --- a/hw/char/xen_console.c > +++ b/hw/char/xen_console.c > @@ -581,19 +581,27 @@ static void > xen_console_device_create(XenBackend

Re: [PATCH v2 13/15] x86/hyperlaunch: add memory parsing to domain config

2025-01-15 Thread Jason Andryuk
On 2024-12-26 11:57, Daniel P. Smith wrote: Add three properties, memory, mem-min, and mem-max, to the domain node device tree parsing to define the memory allocation for a domain. All three fields are expressed in kb and written as a u64 in the device tree entries. Signed-off-by: Daniel P. Smit

[PATCH] docs: Fix spaces and capitalisation of proper nouns and abbreviations

2025-01-15 Thread Bernhard Kaindl
Signed-off-by: Bernhard Kaindl --- SUPPORT.md | 18 +- docs/designs/qemu-deprivilege.md | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index 2bc5bd81ee..9478b70b1b 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@

Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Andrew Cooper
On 15/01/2025 4:27 pm, David Woodhouse wrote: > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > index adfc4efad0..85b92cded4 100644 > --- a/hw/xen/xen-bus.c > +++ b/hw/xen/xen-bus.c > @@ -650,6 +650,16 @@ int xen_device_frontend_scanf(XenDevice *xendev, const > char *key, > return rc; > }

Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Anthony PERARD
On Wed, Jan 15, 2025 at 04:27:20PM +, David Woodhouse wrote: > From: Roger Pau Monne > > The 'm' parameter used to request auto-allocation of the destination variable > is not supported on FreeBSD, and as such leads to failures to parse. > > What's more, the current usage of '%ms' with xs_no

Re: [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function

2025-01-15 Thread Anthony PERARD
On Wed, Jan 15, 2025 at 04:27:19PM +, David Woodhouse wrote: > From: David Woodhouse > > This returns the full contents of the node, having created the node path > from the printf-style format string provided in its arguments. > > This will save various callers from having to do so for thems

Re: [PATCH v2 10/15] x86/hyperlaunch: locate dom0 initrd with hyperlaunch

2025-01-15 Thread Jason Andryuk
On 2024-12-26 11:57, Daniel P. Smith wrote: Look for a subnode of type `multiboot,ramdisk` within a domain node. If found, process the reg property for the MB1 module index. Signed-off-by: Daniel P. Smith --- Changes since v1: - switch to nested else/if - dropped ternary name selection --- xe

Re: [PATCH v2 09/15] x86/hyperlaunch: obtain cmdline from device tree

2025-01-15 Thread Jason Andryuk
On 2024-12-26 11:57, Daniel P. Smith wrote: If a command line is not provided through the bootloader's mechanism, e.g. muiltboot module string field, then use one from the device tree if present. The device tree command line is located in the bootargs property of the `multiboot,kernel` node. Sig

[PATCH v2] xen/riscv: identify specific ISA supported by cpu

2025-01-15 Thread Oleksii Kurochko
Supported ISA extensions are specified in the device tree within the CPU node, using two properties: `riscv,isa-extensions` and `riscv,isa`. Currently, Xen does not support the `riscv,isa-extensions` property, as all available device tree source (DTS) files in the Linux kernel (v6.12-rc3) and DTBs

[PATCH v3 3/7] hw/xen: Use xs_node_read() from xs_node_vscanf()

2025-01-15 Thread David Woodhouse
From: David Woodhouse Reduce some duplication. Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Acked-by: Roger Pau Monné --- hw/xen/trace-events | 1 - hw/xen/xen-bus-helper.c | 15 ++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/xen/trace-e

[PATCH v3 2/7] xen: do not use '%ms' scanf specifier

2025-01-15 Thread David Woodhouse
From: Roger Pau Monne The 'm' parameter used to request auto-allocation of the destination variable is not supported on FreeBSD, and as such leads to failures to parse. What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as it just leads to a double allocation of the same

[PATCH v3 1/7] xen: error handling and FreeBSD compatibility fixes

2025-01-15 Thread David Woodhouse
Add a new xs_node_read() helper function which constructs the node path using a printf format string, and use it where appropriate. In particular, use it to eliminate the use of the %ms format specifier for scanf(), which doesn't exist in FreeBSD. v3: • Further cleanups using xs_node_read().

[PATCH v3 6/7] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it

2025-01-15 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Acked-by: Roger Pau Monné --- hw/xen/xen_pvdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c index c5ad71e8dc..c9143ba259 100644 --- a/hw/xen/

[PATCH v3 4/7] hw/xen: Use xs_node_read() from xen_console_get_name()

2025-01-15 Thread David Woodhouse
From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Acked-by: Roger Pau Monné --- hw/char/xen_console.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --gi

[PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread David Woodhouse
From: David Woodhouse When attempting to read the 'output' node, interpret any error *other* than ENOENT as a fatal error. For ENOENT, fall back to serial_hd() to find a character device, or create a null device. Do not attempt to prepend to errp when serial_hd() fails; the error isn't relevant

[PATCH v3 5/7] hw/xen: Use xs_node_read() from xen_netdev_get_name()

2025-01-15 Thread David Woodhouse
From: David Woodhouse Now that xs_node_read() can construct a node path, no need to open-code it. Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Acked-by: Roger Pau Monné --- hw/net/xen_nic.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/net

[PATCH v3 1/7] hw/xen: Add xs_node_read() helper function

2025-01-15 Thread David Woodhouse
From: David Woodhouse This returns the full contents of the node, having created the node path from the printf-style format string provided in its arguments. This will save various callers from having to do so for themselves (and from using xs_node_scanf() with the non-portable %ms format string

Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

2025-01-15 Thread Oleksii Kurochko
Hi Stefano, On 1/15/25 1:01 AM, Stefano Stabellini wrote: +Oleksii On Tue, 14 Jan 2025, Milan Djokic wrote: From: Slavisa Petrovic This patch introduces initial support for running RISC-V as a Xen guest. It provides the necessary infrastructure and stubs for Xen-specific operations. Key chang

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-15 Thread David Woodhouse
On Wed, 2025-01-15 at 15:36 +0100, Anthony PERARD wrote: > On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote: > > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > > index ef0c2912efa1..989e75fef88f 100644 > > --- a/hw/char/xen_console.c > > +++ b/hw/char/xen_console.c > >

Re: [PATCH 2/4] hw/xen: Use xs_node_read() from xen_console_get_name()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:24AM +, David Woodhouse wrote: > From: David Woodhouse > > Now that xs_node_read() can construct a node path, no need to open-code it. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

[PATCH] docs/misc: Fix a few typos

2025-01-15 Thread Bernhard Kaindl
While skimming through the misc docs, I spotted a few typos. Signed-off-by: Bernhard Kaindl --- docs/misc/livepatch.pandoc| 8 docs/misc/netif-staging-grants.pandoc | 10 +- docs/misc/printk-formats.txt | 2 +- 3 files changed, 10 insertions(+), 10 deletio

Re: [PATCH] xen/ppc: Fix double xen_ulong_t typedef in public/arch-ppc.h

2025-01-15 Thread Jan Beulich
On 15.01.2025 16:03, Andrew Cooper wrote: > public/arch-ppc.h contains two adjacent #ifndef __ASSEMBLY__ blocks. > > With these merged, it becomes very obvious that there's a duplicate > definition of xen_ulong_t, which is also noticed by the docs build: > > /usr/bin/perl -w /local/xen.git/docs

Re: [PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:26AM +, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

[PATCH] xen/ppc: Fix double xen_ulong_t typedef in public/arch-ppc.h

2025-01-15 Thread Andrew Cooper
public/arch-ppc.h contains two adjacent #ifndef __ASSEMBLY__ blocks. With these merged, it becomes very obvious that there's a duplicate definition of xen_ulong_t, which is also noticed by the docs build: /usr/bin/perl -w /local/xen.git/docs/xen-headers -O html/hypercall/ppc \ -T 'arc

Re: [PATCH 3/4] hw/xen: Use xs_node_read() from xen_netdev_get_name()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:25AM +, David Woodhouse wrote: > From: David Woodhouse > > Now that xs_node_read() can construct a node path, no need to open-code it. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:23AM +, David Woodhouse wrote: > From: David Woodhouse > > Reduce some duplication. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH] Design docs: Fix some typos in the design docs

2025-01-15 Thread Frediano Ziglio
On Wed, Jan 15, 2025 at 1:45 PM Bernhard Kaindl wrote: > > Skimming through the design docs, I saw some typos that needed fixing. > > --- > Comments for reviewers (not for the commit message itself): > > Sample typos (some are not easy to spot): > - heirarchical: (ei->ie) > - implementaiton: (it->

Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

2025-01-15 Thread David Woodhouse
On Wed, 2025-01-15 at 15:34 +0100, Roger Pau Monné wrote: > On Fri, Jan 10, 2025 at 10:02:53AM +, David Woodhouse wrote: > > On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > > > Hello, > > > > > > First patch from David introduces a new helper to fetch xenstore nodes, > > > while se

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Daniel Stone
On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > No disagreement there, we need CREATE_DUMB2. > > My point is that we have the current UAPI, and we have userspace using > it, but we don't have clear rules what the ioctl does with specific > parameters, and we don't document how it has to be u

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote: > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > index ef0c2912efa1..989e75fef88f 100644 > --- a/hw/char/xen_console.c > +++ b/hw/char/xen_console.c > @@ -550,7 +550,8 @@ static void xen_console_device_create(XenBackendI

Re: [PATCH v2 0/2] xen: error handling and FreeBSD compatibility fixes

2025-01-15 Thread Roger Pau Monné
On Fri, Jan 10, 2025 at 10:02:53AM +, David Woodhouse wrote: > On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > > Hello, > > > > First patch from David introduces a new helper to fetch xenstore nodes, > > while second patch removes the usage of scanf related functions with the > > "

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Tomi Valkeinen
On 15/01/2025 15:45, Thomas Zimmermann wrote: Hi Am 15.01.25 um 14:33 schrieb Tomi Valkeinen: [...] Yeah, there are constrains in the scanline and buffer alignments and orientation. And if we say that bpp==12 means NV12, it will be a problem for all other cases where bpp==12 makes sense. I

Re: [XEN PATCH v2 2/3] docs: rationalise .gitignore

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:27 pm, Yann Dirson wrote: > diff --git a/docs/.gitignore b/docs/.gitignore > new file mode 100644 > index 00..0727c6d7cf > --- /dev/null > +++ b/docs/.gitignore > @@ -0,0 +1,14 @@ > +/figs/*.png > +/html/ > +/man/xl.cfg.5.pod > +/man/xl-disk-configuration.5.pod > +/man/xl-n

Re: [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:35:30AM +0100, Roger Pau Monne wrote: > diff --git a/include/hw/xen/xen-bus-helper.h b/include/hw/xen/xen-bus-helper.h > index d8dcc2f0107d..6478d25be5e6 100644 > --- a/include/hw/xen/xen-bus-helper.h > +++ b/include/hw/xen/xen-bus-helper.h > @@ -37,6 +37,10 @@ int xs_nod

[PATCH v2] docs: Improve spelling of few cases in the documentation

2025-01-15 Thread Bernhard Kaindl
Skimming the docs, I came across a few places for spelling improvements. Signed-off-by: Bernhard Kaindl --- Changes in v2: - Apply review of v1: Leave "brand new" and omit changes that Andy will do. - "binary-patch" -> "binary patch" ("binarily patch" is okay but uncommon) --- docs/designs/non-c

[PATCH] Manual pages: Fix a few typos

2025-01-15 Thread Bernhard Kaindl
While skimming through the manual pages, I spotted a few typos. Signed-off-by: Bernhard Kaindl --- docs/man/xen-vtpmmgr.7.pod | 2 +- docs/man/xl-numa-placement.7.pod | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/man/xen-vtpmmgr.7.pod b/docs/man/xen-vtpmmg

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 14:33 schrieb Tomi Valkeinen: [...] Yeah, there are constrains in the scanline and buffer alignments and orientation. And if we say that bpp==12 means NV12, it will be a problem for all other cases where bpp==12 makes sense. I feel I still don't quite understand. Can't we d

[PATCH] Design docs: Fix some typos in the design docs

2025-01-15 Thread Bernhard Kaindl
Skimming through the design docs, I saw some typos that needed fixing. --- Comments for reviewers (not for the commit message itself): Sample typos (some are not easy to spot): - heirarchical: (ei->ie) - implementaiton: (it->ti) - comprimised: (i->o) - contol->control (r) PS: I did the fixes usi

Re: [XEN PATCH] docs/sphinx: overview of serial consoles

2025-01-15 Thread Yann Dirson
On 1/15/25 14:27, Andrew Cooper wrote: > On 15/01/2025 12:07 pm, Yann Dirson wrote: >> --- >> >> Notes: >> This is a very preliminar first draft for comments: >> >> - would this structuration be adequate? >> >> - Is my basic understanding correct, are those first enumerations >>

Re: [XEN PATCH v2 0/3] trivial improvements to sphinx doc tooling

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:27 pm, Yann Dirson wrote: > changes: > v2: > * move import up and adjust "path setup" instructions > * new patch for .gitignore rationalisation > > Yann Dirson (3): > docs/sphinx: import sys for error reporting > docs: rationalise .gitignore > docs/sphinx: gitignore generated

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Tomi Valkeinen
Hi, On 15/01/2025 14:34, Thomas Zimmermann wrote: Hi Am 15.01.25 um 13:06 schrieb Tomi Valkeinen: Hi, On 15/01/2025 13:37, Thomas Zimmermann wrote: Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it

Re: [XEN PATCH] docs/sphinx: overview of serial consoles

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:07 pm, Yann Dirson wrote: > --- > > Notes: > This is a very preliminar first draft for comments: > > - would this structuration be adequate? > > - Is my basic understanding correct, are those first enumerations > correct? (some of it come solely from conso

Re: [PATCH v3 2/3] xen: common: add ability to enable stack protector

2025-01-15 Thread Yann Dirson
On 12/11/24 03:04, Volodymyr Babchuk wrote: > +menu "Compiler options" > + > +config STACK_PROTECTOR > + bool "Stack protector" > + depends on HAS_STACK_PROTECTOR > + help > + Enable the Stack Protector compiler hardening option. This inserts a > + canary value in the stack

Re: [PATCH v2] docs: Improve spelling of few cases in the documentation

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:47 pm, Bernhard Kaindl wrote: > Skimming the docs, I came across a few places for spelling improvements. > > Signed-off-by: Bernhard Kaindl Reviewed-by: Andrew Cooper

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 13:06 schrieb Tomi Valkeinen: Hi, On 15/01/2025 13:37, Thomas Zimmermann wrote: Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it resolves all the points you have. The current CREA

[XEN PATCH v2 0/3] trivial improvements to sphinx doc tooling

2025-01-15 Thread Yann Dirson
changes: v2: * move import up and adjust "path setup" instructions * new patch for .gitignore rationalisation Yann Dirson (3): docs/sphinx: import sys for error reporting docs: rationalise .gitignore docs/sphinx: gitignore generated files .gitignore | 17 - docs/.gitig

[XEN PATCH v2 2/3] docs: rationalise .gitignore

2025-01-15 Thread Yann Dirson
Note I did not transplant the patterns under doc/txt/ (since the whole dir is ignored already), and adjusted sort order to be fully alphabetical. Signed-off-by: Yann Dirson --- .gitignore | 17 - docs/.gitignore | 14 ++ 2 files changed, 14 insertions(+), 17 dele

[XEN PATCH v2 3/3] docs/sphinx: gitignore generated files

2025-01-15 Thread Yann Dirson
Signed-off-by: Yann Dirson --- docs/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/.gitignore b/docs/.gitignore index 0727c6d7cf..e87b12890a 100644 --- a/docs/.gitignore +++ b/docs/.gitignore @@ -10,5 +10,6 @@ /man7/ /man8/ /pdf/ +/sphinx/ /tmp.* /txt/ -- 2.39.5 Yann

[XEN PATCH v2 1/3] docs/sphinx: import sys for error reporting

2025-01-15 Thread Yann Dirson
Signed-off-by: Yann Dirson --- docs/conf.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/conf.py b/docs/conf.py index 5d2e979449..2fb8bafe65 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -6,6 +6,8 @@ # For the full list of built-in configuration values, see the do

Re: [PATCH v1 1/2] docs: fusa: Define the requirements for XEN_VERSION hypercall.

2025-01-15 Thread Ayan Kumar Halder
Hi Andrew, On 14/01/2025 20:15, Andrew Cooper wrote: On 14/01/2025 7:50 pm, Ayan Kumar Halder wrote: diff --git a/docs/fusa/reqs/product-reqs/version_hypercall.rst b/docs/fusa/reqs/product-reqs/version_hypercall.rst new file mode 100644 index 00..fdb8da04e1 --- /dev/null +++ b/docs/fus

Re: [XEN PATCH 2/2] docs/sphinx: gitignore generated files

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:01 pm, Yann Dirson wrote: > Signed-off-by: Yann Dirson > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 25484a8fd8..404590c36a 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -62,6 +62,7 @@ docs/man5/ > docs/man7/ > d

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Tomi Valkeinen
Hi, On 15/01/2025 13:37, Thomas Zimmermann wrote: Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it resolves all the points you have. The current CREATE_DUMB I had missed the discussion, and, indeed

Re: [XEN PATCH 1/2] docs/sphinx: import sys for error reporting

2025-01-15 Thread Andrew Cooper
On 15/01/2025 12:01 pm, Yann Dirson wrote: > Signed-off-by: Yann Dirson > --- > docs/conf.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/conf.py b/docs/conf.py > index 5d2e979449..84bec024e7 100644 > --- a/docs/conf.py > +++ b/docs/conf.py > @@ -21,6 +21,7 @@ > # > https://www

[XEN PATCH] docs/sphinx: overview of serial consoles

2025-01-15 Thread Yann Dirson
--- Notes: This is a very preliminar first draft for comments: - would this structuration be adequate? - Is my basic understanding correct, are those first enumerations correct? (some of it come solely from console.txt, which has already proven to be seriously outdate

Re: [PATCH] docs: Improve spelling of few cases in the documentation

2025-01-15 Thread Andrew Cooper
On 15/01/2025 11:27 am, Jan Beulich wrote: > On 15.01.2025 11:42, Bernhard Kaindl wrote: >> --- a/docs/admin-guide/microcode-loading.rst >> +++ b/docs/admin-guide/microcode-loading.rst >> @@ -20,7 +20,7 @@ distro guidance for microcode loading. >> Microcode can make almost arbitrary changes to the

[XEN PATCH 2/2] docs/sphinx: gitignore generated files

2025-01-15 Thread Yann Dirson
Signed-off-by: Yann Dirson --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 25484a8fd8..404590c36a 100644 --- a/.gitignore +++ b/.gitignore @@ -62,6 +62,7 @@ docs/man5/ docs/man7/ docs/man8/ docs/pdf/ +docs/sphinx/ docs/txt/ extras/ install/*

[XEN PATCH 1/2] docs/sphinx: import sys for error reporting

2025-01-15 Thread Yann Dirson
Signed-off-by: Yann Dirson --- docs/conf.py | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/conf.py b/docs/conf.py index 5d2e979449..84bec024e7 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -21,6 +21,7 @@ # https://www.sphinx-doc.org/en/master/usage/configuration.html#project-informa

[XEN PATCH 0/2] trivial improvements to sphinx doc tooling

2025-01-15 Thread Yann Dirson
Yann Dirson (2): docs/sphinx: import sys for error reporting docs/sphinx: gitignore generated files .gitignore | 1 + docs/conf.py | 1 + 2 files changed, 2 insertions(+) -- 2.39.5 Yann Dirson | Vates Platform Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] These are all good points. Did you read my discussion with Andy on patch 2? I think it resolves all the points you have. The current CREATE_DUMB I had missed the discussion, and, indeed, the patch you attached fixes the problem on Xilin

Re: [PATCH] docs: Improve spelling of few cases in the documentation

2025-01-15 Thread Jan Beulich
On 15.01.2025 11:42, Bernhard Kaindl wrote: > --- a/docs/admin-guide/microcode-loading.rst > +++ b/docs/admin-guide/microcode-loading.rst > @@ -20,7 +20,7 @@ distro guidance for microcode loading. > Microcode can make almost arbitrary changes to the processor, including to > software visible feat

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Tomi Valkeinen
n); +    ret = drm_mode_size_dumb(drm, args, dpsub->dma_align, 0); +    if (ret) +    return ret;     return drm_gem_dma_dumb_create_internal(file_priv, drm, args);   } I have some trouble with this one. I have sent a series to add some pixel formats: https://lore.kernel.org/all/20250115-xili

[PATCH] docs: Improve spelling of few cases in the documentation

2025-01-15 Thread Bernhard Kaindl
Skimming the docs, I came across a few places for spelling improvements. I checked using dictionaries to be sure. Signed-off-by: Bernhard Kaindl --- docs/admin-guide/microcode-loading.rst| 4 ++-- docs/designs/non-cooperative-migration.md | 4 ++-- docs/designs/qemu-deprivilege.md |

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Thomas Zimmermann
gt;dma_align, 0); +    if (ret) +    return ret;     return drm_gem_dma_dumb_create_internal(file_priv, drm, args);   } I have some trouble with this one. I have sent a series to add some pixel formats: https://lore.kernel.org/all/20250115-xilinx-formats-v2-0-160327ca6...@ideasonboard.com/

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-15 Thread Tomi Valkeinen
+ if (ret) + return ret; return drm_gem_dma_dumb_create_internal(file_priv, drm, args); } I have some trouble with this one. I have sent a series to add some pixel formats: https://lore.kernel.org/all/20250115-xilinx-formats-v2-0-160327ca6...@ideasonboard.com/ Let's look at X

Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig

2025-01-15 Thread Oleksii Kurochko
On 1/14/25 6:43 PM, Roger Pau Monne wrote: If randconfig enables coverage support the build times out due to GNU LD taking too long. For the time being prevent coverage from being enabled in clang randconfig job. Signed-off-by: Roger Pau Monné R-Acked-by: Oleksii Kurochko ~ Oleksii --- Cc

[PATCH v3 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

2025-01-15 Thread Mykyta Poturai
From: Oleksandr Andrushchenko There are number of ITS implementations exist which are different from the base one which have number of functionalities defined as is "IMPLEMENTATION DEFINED", e.g. there may exist differences in cacheability, shareability and memory requirements and others. This re

[PATCH v3 0/2] Add support for Renesas R-Car Gen4

2025-01-15 Thread Mykyta Poturai
Add support for Renesas Gen4 boards such as S4[1] and V4H[2] by adding the appropriate confing option, and support for the Gen4 ITS. Tested on Renesas R-Car V4H board. [1]: https://www.renesas.com/en/products/automotive-products/automotive-system-chips-socs/r-car-s4-automotive-system-chip-soc-car

[PATCH v3 2/2] xen/arm: platform: Add support for R-Car Gen4

2025-01-15 Thread Mykyta Poturai
From: Oleksandr Andrushchenko Add Rcar Gen4 platform choice to Kconfig to select all required drivers automatically. Changelog: v1 -> v2: - Added RB from Stefano Stabellini Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Volodymyr Babchuk Signed-off-by: Mykyta Poturai Reviewed-by: Stef

Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig

2025-01-15 Thread Roger Pau Monné
On Wed, Jan 15, 2025 at 09:19:29AM +0100, Jan Beulich wrote: > On 14.01.2025 18:43, Roger Pau Monne wrote: > > If randconfig enables coverage support the build times out due to GNU LD > > taking too long. For the time being prevent coverage from being enabled in > > clang randconfig job. > > Just

Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig

2025-01-15 Thread Andrew Cooper
On 15/01/2025 8:19 am, Jan Beulich wrote: > On 14.01.2025 18:43, Roger Pau Monne wrote: >> If randconfig enables coverage support the build times out due to GNU LD >> taking too long. For the time being prevent coverage from being enabled in >> clang randconfig job. > Just curious: How long is "to

RE: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen cmdline

2025-01-15 Thread Penny, Zheng
[AMD Official Use Only - AMD Internal Distribution Only] Hi, > -Original Message- > From: Jan Beulich > Sent: Wednesday, January 15, 2025 4:32 PM > To: Penny, Zheng > Cc: Stabellini, Stefano ; Huang, Ray > ; Ragiadakou, Xenia ; > Andryuk, Jason ; Andrew Cooper > ; Julien Grall ; Stefano

Re: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen cmdline

2025-01-15 Thread Jan Beulich
On 15.01.2025 09:18, Penny, Zheng wrote: >> -Original Message- >> From: Jan Beulich >> Sent: Thursday, January 9, 2025 5:59 PM >> >> On 03.12.2024 09:11, Penny Zheng wrote: >>> --- a/xen/arch/x86/platform_hypercall.c >>> +++ b/xen/arch/x86/platform_hypercall.c >>> @@ -574,6 +574,12 @@ ret_

Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig

2025-01-15 Thread Jan Beulich
On 14.01.2025 18:43, Roger Pau Monne wrote: > If randconfig enables coverage support the build times out due to GNU LD > taking too long. For the time being prevent coverage from being enabled in > clang randconfig job. Just curious: How long is "too long" in this case? Jan

RE: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen cmdline

2025-01-15 Thread Penny, Zheng
[AMD Official Use Only - AMD Internal Distribution Only] Hi, > -Original Message- > From: Jan Beulich > Sent: Thursday, January 9, 2025 5:59 PM > To: Penny, Zheng > Cc: Stabellini, Stefano ; Huang, Ray > ; Ragiadakou, Xenia ; > Andryuk, Jason ; Andrew Cooper > ; Julien Grall ; Stefano S

Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig

2025-01-15 Thread Roger Pau Monné
On Tue, Jan 14, 2025 at 05:48:20PM +, Andrew Cooper wrote: > On 14/01/2025 5:43 pm, Roger Pau Monne wrote: > > If randconfig enables coverage support the build times out due to GNU LD > > taking too long. For the time being prevent coverage from being enabled in > > clang randconfig job. > > >

  1   2   >