On 15/01/2025 11:27 am, Jan Beulich wrote: > On 15.01.2025 11:42, Bernhard Kaindl wrote: >> --- a/docs/admin-guide/microcode-loading.rst >> +++ b/docs/admin-guide/microcode-loading.rst >> @@ -20,7 +20,7 @@ distro guidance for microcode loading. >> Microcode can make almost arbitrary changes to the processor, including to >> software visible features. This includes removing features (e.g. the >> Haswell >> TSX errata which necessitated disabling the feature entirely), or the >> addition >> -of brand new features (e.g. the Spectre v2 controls to work around >> speculative >> +of brand-new features (e.g. the Spectre v2 controls to work around >> speculative >> execution vulnerabilities). > This having been written by a native speaker, I'm uncertain of the strict need > for a dash (also in one or two further places you touch).
Both are fine, but without a dash is more common. I'd leave it as it was. > >> @@ -40,7 +40,7 @@ Xen will report during boot if it performed a microcode >> update:: >> (XEN) microcode: CPU6 updated from revision 0x1a to 0x25, date = >> 2018-04-02 >> >> The exact details printed are system and microcode specific. After boot, >> the >> -current microcode version can obtained from with dom0:: >> +current microcode version can be obtained from with dom0:: > Pretty certainly then also s/with/within/ ? Oh, this is slightly stale now we print the BSP microcode version on boot, and also since xen-ucode can be used to find the revision. I'll do a larger update to this paragraph, including both fixes on this line. ~Andrew
