[AMD Official Use Only - AMD Internal Distribution Only]
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: Wednesday, January 15, 2025 4:32 PM
> To: Penny, Zheng <penny.zh...@amd.com>
> Cc: Stabellini, Stefano <stefano.stabell...@amd.com>; Huang, Ray
> <ray.hu...@amd.com>; Ragiadakou, Xenia <xenia.ragiada...@amd.com>;
> Andryuk, Jason <jason.andr...@amd.com>; Andrew Cooper
> <andrew.coop...@citrix.com>; Julien Grall <jul...@xen.org>; Stefano Stabellini
> <sstabell...@kernel.org>; Roger Pau Monné <roger....@citrix.com>; xen-
> de...@lists.xenproject.org
> Subject: Re: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen
> cmdline
>
> On 15.01.2025 09:18, Penny, Zheng wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeul...@suse.com>
> >> Sent: Thursday, January 9, 2025 5:59 PM
> >>
> >> On 03.12.2024 09:11, Penny Zheng wrote:
> >>> --- a/xen/arch/x86/platform_hypercall.c
> >>> +++ b/xen/arch/x86/platform_hypercall.c
> >>> @@ -574,6 +574,12 @@ ret_t do_platform_op(
> >>>
> >>> case XEN_PM_CPPC:
> >>> {
> >>> + if ( !(xen_processor_pmbits & XEN_PROCESSOR_PM_CPPC) )
> >>> + {
> >>> + ret = -ENOSYS;
> >>
> >> ENOSYS isn't appropriate for such a situation.
> >
> > I've mirrored the return value, so maybe -EINVAL is better?
>
> Generally most wrong uses of ENOSYS want replacing by EOPNOTSUPP.
Oh, understood.
>
> Jan
Many thanks,
Penny
