Re: [PATCH] docs/misra: add R18.6 to rules.rst

2024-07-23 Thread Bertrand Marquis
Hi Stefano, > On 23 Jul 2024, at 23:41, Stefano Stabellini wrote: > > In practice, we are already following R18.6 and we have zero violations > reported by ECLAIR (there are some cautions being reported.) > > Signed-off-by: Stefano Stabellini Acked-by: Bertrand Marquis Cheers Bertrand > >

Re: [PATCH 0/6] tools/libxs: Fix SIGPIPE handling issues

2024-07-23 Thread Jan Beulich
On 18.07.2024 18:48, Andrew Cooper wrote: > While the purpose of this series is patch 6, it has a side effect of reducing > the number of system calls substantally. > > Using a strace of test-xenstore as an example, we go from this: > > rt_sigaction(SIGPIPE, {sa_handler=SIG_IGN, sa_mask=[], >

Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)

2024-07-23 Thread Jan Beulich
On 24.07.2024 08:07, Juergen Gross wrote: > On 24.07.24 03:08, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git >> linux-next >> head: 368990a7fe30737c990f628a60d26d9854a9e690 >> commit: 368990a7fe30737c990f628a60d26d9854a9e690 [12/12] xen: fix mult

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Jan Beulich
On 23.07.2024 18:24, Alejandro Vallejo wrote: > On Tue Jul 23, 2024 at 5:09 PM BST, Roger Pau Monné wrote: >> On Tue, Jul 23, 2024 at 04:37:12PM +0100, Alejandro Vallejo wrote: >>> On Tue Jul 23, 2024 at 10:31 AM BST, Roger Pau Monne wrote: --- a/xen/arch/x86/include/asm/alternative.h +++

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-23 Thread Nicola Vetrini
On 2024-07-24 02:18, victorm.l...@amd.com wrote: From: Victor Lira Hi, Add a script that extracts the names of symbols in linker scripts. Signed-off-by: Victor Lira --- Note: Not included are the "." location name or symbol names enclosed in quotes since the files dont't use any. --- Cc

Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)

2024-07-23 Thread Juergen Gross
On 24.07.24 03:08, kernel test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next head: 368990a7fe30737c990f628a60d26d9854a9e690 commit: 368990a7fe30737c990f628a60d26d9854a9e690 [12/12] xen: fix multicall debug data referencing config: x86_64-randconfig

Re: [XEN PATCH v5 16/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-23 Thread Jan Beulich
On 24.07.2024 00:40, Stefano Stabellini wrote: > On Tue, 23 Jul 2024, Jan Beulich wrote: >> On 23.07.2024 10:15, Alessandro Zucchelli wrote: >>> This section explains which format should be followed by header >>> inclusion guards via a drop-down list of rules. >>> >>> No functional change. >>> >>>

Re: [RFC XEN PATCH v2] x86/cpuid: Expose max_vcpus field in HVM hypervisor leaf

2024-07-23 Thread Jan Beulich
(re-adding xen-devel@) On 23.07.2024 14:57, Matthew Barnes wrote: > On Mon, Jul 22, 2024 at 01:37:11PM +0200, Jan Beulich wrote: >> On 19.07.2024 16:21, Matthew Barnes wrote: >>> Currently, OVMF is hard-coded to set up a maximum of 64 vCPUs on >>> startup. >>> >>> There are efforts to support a ma

Re: [PATCH 1/2] x86/efi: Simplify efi_arch_cpu() a little

2024-07-23 Thread Jan Beulich
On 23.07.2024 15:47, Alejandro Vallejo wrote: > On Mon Jul 22, 2024 at 11:18 AM BST, Andrew Cooper wrote: >> +if ( (eax >> 16) != 0x8000 || eax < 0x8000U ) >> +blexit(L"In 64bit mode, but no extended CPUID leaves?!?"); > > I'm not sure about the condition even for the old code. If

[ovmf test] 186975: all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186975 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186975/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9bc7a361200215fc5065dfaa6d90d4eb50fec00c baseline version: ovmf f5901ff2a472a5418ee6f

[xen-unstable test] 186971: tolerable FAIL - PUSHED

2024-07-23 Thread osstest service owner
flight 186971 xen-unstable real [real] flight 186976 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186971/ http://logs.test-lab.xenproject.org/osstest/logs/186976/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm6

Xen for Apple Silicon (M1 and beyond)

2024-07-23 Thread Techguru
Hello, Stefano, on IRC, suggested that I start a discussion on this mailing list regarding my intention to bring up a fully function XEN on Apple Silicon (M1 and beyond). I am in the process of getting up to speed on your governance policies, applied for Coverity access to use some of the known i

[xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)

2024-07-23 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next head: 368990a7fe30737c990f628a60d26d9854a9e690 commit: 368990a7fe30737c990f628a60d26d9854a9e690 [12/12] xen: fix multicall debug data referencing config: x86_64-randconfig-012-20240724 (https://download.01.org/0day-c

[xen-4.19-testing test] 186965: tolerable FAIL - PUSHED

2024-07-23 Thread osstest service owner
flight 186965 xen-4.19-testing real [real] flight 186974 xen-4.19-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186965/ http://logs.test-lab.xenproject.org/osstest/logs/186974/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

[RFC PATCH] automation: add linker symbol name script

2024-07-23 Thread victorm.lira
From: Victor Lira Add a script that extracts the names of symbols in linker scripts. Signed-off-by: Victor Lira --- Note: Not included are the "." location name or symbol names enclosed in quotes since the files dont't use any. --- Cc: Stefano Stabellini Cc: roberto.bagn...@bugseng.com Cc: con

Re: [PATCH] CI: workaround broken selinux+docker interaction in yocto

2024-07-23 Thread Stefano Stabellini
On Sat, 20 Jul 2024, Marek Marczykowski-Górecki wrote: > `cp --preserve=xattr` doesn't work in docker when SELinux is enabled. It > tries to set the "security.selinux" xattr, but SELinux (or overlay fs?) > denies it. > Workaround it by skipping selinux.selinux xattr copying. > > Signed-off-by: Ma

Re: [XEN PATCH v5 17/17] include/asm-generic: rename inclusion guards for consistency

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > Edit inclusion guards in asm-generic header files in order to make them > consistent with the estabilished naming convention. > > No functional change. > > Signed-off-by: Alessandro Zucchelli Reviewed-by: Stefano Stabellini

Re: [XEN PATCH v5 16/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Jan Beulich wrote: > On 23.07.2024 10:15, Alessandro Zucchelli wrote: > > This section explains which format should be followed by header > > inclusion guards via a drop-down list of rules. > > > > No functional change. > > > > Signed-off-by: Alessandro Zucchelli > > As ind

Re: [XEN PATCH v5 15/17] xen/build: address violation of MISRA C Directive 4.10

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 4.10 which states as > following: Precautions shall be taken in order to prevent the contents > of a header file being included more than once. > > Changes are made for autogenerated header files: inc

Re: [XEN PATCH v5 12/17] xen: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > From: Maria Celeste Cesario > > Modify creation rule for asm-offsets.h to conform to > the new standard and to not generate conflicting guards > between architectures (which is a violation of the directive). > Modify generic-y creation rule to ge

Re: [XEN PATCH v5 12/17] xen: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > From: Maria Celeste Cesario > > Modify creation rule for asm-offsets.h to conform to > the new standard and to not generate conflicting guards > between architectures (which is a violation of the directive). > Modify generic-y creation rule to ge

Re: [XEN PATCH v5 10/17] x86/asm: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > From: Simone Ballarin > > Amend generation script, add inclusion guards to address violations > of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). >

Re: [XEN PATCH v5 01/17] misra: add deviation for headers that explicitly avoid guards

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Alessandro Zucchelli wrote: > From: Simone Ballarin > > Some headers, under specific circumstances (documented in a comment at > the beginning of the file), explicitly do not have strict inclusion > guards: the caller is responsible for including them correctly. > > These fi

[PATCH] docs/misra: add R18.6 to rules.rst

2024-07-23 Thread Stefano Stabellini
In practice, we are already following R18.6 and we have zero violations reported by ECLAIR (there are some cautions being reported.) Signed-off-by: Stefano Stabellini diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 80e5e972ad..0cb2fb8f24 100644 --- a/docs/misra/rules.rst +++ b/doc

Re: [PATCH] xen/printk: Avoid the use of L as a length modifier

2024-07-23 Thread Stefano Stabellini
On Tue, 23 Jul 2024, Andrew Cooper wrote: > Coverity complains about it being invalid. It turns out that it is a GCC-ism > to treat ll and L equivalently. C99 only permits L to mean long double. > > Convert all uses of L in to alternatives, either l, ll or PRI.64 depending on > the operand type.

[PATCH] x86/APIC: Rewrite apic_isr_read() to match apic_{tmr,irr}_read()

2024-07-23 Thread Andrew Cooper
This allows for marginally better code generation including the use of BT rather than SHR/TEST. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/include/asm/apic.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include

[PATCH] x86/APIC: Change APIC reg types to unsigned int

2024-07-23 Thread Andrew Cooper
They're all within a 12 bit range of their respective bases, and this prevents all the MSR coordinates being calculated in %rcx. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné There's one unpleasant surprise hidden: add/remove: 0/0 grow/shrink: 2/6 up/down: 18/-99 (-81

[xen-unstable-smoke test] 186970: tolerable all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186970 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186970/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] x86/IO-APIC: Improve APIC_TMR accesses

2024-07-23 Thread Andrew Cooper
XenServer's instance of coverity complains of OVERFLOW_BEFORE_WIDEN in mask_and_ack_level_ioapic_irq(), which is ultimately because of v being unsigned long, and (1U << ...) being 32 bits. Introduce a apic_tmr_read() helper like we already have for ISR and IRR, and use it to remove the opencoded a

[linux-linus test] 186963: regressions - FAIL

2024-07-23 Thread osstest service owner
flight 186963 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186963/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 186827 test-amd64-amd64-do

[ovmf test] 186972: all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186972 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186972/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f5901ff2a472a5418ee6ff790c3b86cf9c3f54f1 baseline version: ovmf da591416ee8fddb1b691d

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread Julien Grall
On 23/07/2024 18:28, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 19:25 +0200, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 16:49 +0100, Julien Grall wrote: Hi Oleksii, On 23/07/2024 16:36, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 12:02 +0200, Jan Beuli

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Jason Andryuk
On 2024-07-23 13:34, Andrew Cooper wrote: On 23/07/2024 6:31 pm, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: On 2024-07-23 11:04, Anthony PERARD wrote: On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly

[PATCH v2] xen: PE/COFF image header

2024-07-23 Thread Milan Djokic
From: Nikola Jelic Added PE/COFF generic image header which shall be used for EFI application format for x86/risc-v. x86 and risc-v source shall be adjusted to use this header in following commits. pe.h header is taken over from linux kernel with minor changes in terms of formatting and structure

[PATCH] xen/printk: Avoid the use of L as a length modifier

2024-07-23 Thread Andrew Cooper
Coverity complains about it being invalid. It turns out that it is a GCC-ism to treat ll and L equivalently. C99 only permits L to mean long double. Convert all uses of L in to alternatives, either l, ll or PRI.64 depending on the operand type. This in turn removes some unnecessary casts which

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Andrew Cooper
On 23/07/2024 6:31 pm, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: >> On 2024-07-23 11:04, Anthony PERARD wrote: >>> On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly for backendtype=phy as well as >>

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote: > On 2024-07-23 11:04, Anthony PERARD wrote: > > On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: > > > "$dev" needs to be set correctly for backendtype=phy as well as > > > backendtype=tap.  Move the setting into the conditional

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 19:25 +0200, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-07-23 at 16:49 +0100, Julien Grall wrote: > > Hi Oleksii, > > > > On 23/07/2024 16:36, oleksii.kuroc...@gmail.com wrote: > > > On Tue, 2024-07-23 at 12:02 +0200, Jan Beulich wrote: > > > > On 23.07.2024 10:55, olek

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 16:49 +0100, Julien Grall wrote: > Hi Oleksii, > > On 23/07/2024 16:36, oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-07-23 at 12:02 +0200, Jan Beulich wrote: > > > On 23.07.2024 10:55, oleksii.kuroc...@gmail.com wrote: > > > > On Tue, 2024-07-23 at 10:36 +0200, Jan Beul

[ovmf test] 186968: all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186968 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186968/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf da591416ee8fddb1b691d157e3c61bdc7a994b79 baseline version: ovmf f96298d75cebfe2a77071

Re: [XEN PATCH v3 RESEND] tools/lsevtchn: Use errno macro to handle hypercall error cases

2024-07-23 Thread Anthony PERARD
On Mon, Jul 15, 2024 at 04:36:03PM +0100, Matthew Barnes wrote: > Currently, lsevtchn aborts its event channel enumeration when it hits > its first hypercall error, namely: > * When an event channel doesn't exist at the specified port > * When the event channel is owned by Xen > > lsevtchn does no

[xen-unstable-smoke test] 186966: tolerable all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186966 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186966/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Alejandro Vallejo
On Tue Jul 23, 2024 at 5:09 PM BST, Roger Pau Monné wrote: > On Tue, Jul 23, 2024 at 04:37:12PM +0100, Alejandro Vallejo wrote: > > On Tue Jul 23, 2024 at 10:31 AM BST, Roger Pau Monne wrote: > > > Clang will generate machine code that only resets the low 8 bits of %rdi > > > between loop calls, le

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Roger Pau Monné
On Tue, Jul 23, 2024 at 04:37:12PM +0100, Alejandro Vallejo wrote: > On Tue Jul 23, 2024 at 10:31 AM BST, Roger Pau Monne wrote: > > Yet another clang code generation issue when using altcalls. > > > > The issue this time is with using loop constructs around > > alternative_{,v}call > > instances

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread Julien Grall
Hi Oleksii, On 23/07/2024 16:36, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 12:02 +0200, Jan Beulich wrote: On 23.07.2024 10:55, oleksii.kuroc...@gmail.com wrote: On Tue, 2024-07-23 at 10:36 +0200, Jan Beulich wrote: On 23.07.2024 10:02, Oleksii Kurochko wrote: On Mon, Jul 22, 2

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 12:02 +0200, Jan Beulich wrote: > On 23.07.2024 10:55, oleksii.kuroc...@gmail.com wrote: > > On Tue, 2024-07-23 at 10:36 +0200, Jan Beulich wrote: > > > On 23.07.2024 10:02, Oleksii Kurochko wrote: > > > > On Mon, Jul 22, 2024 at 7:27 PM Julien Grall > > > > wrote: > > > > >

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Alejandro Vallejo
On Tue Jul 23, 2024 at 10:31 AM BST, Roger Pau Monne wrote: > Yet another clang code generation issue when using altcalls. > > The issue this time is with using loop constructs around alternative_{,v}call > instances using parameter types smaller than the register size. > > Given the following exam

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Jason Andryuk
On 2024-07-23 11:04, Anthony PERARD wrote: On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: "$dev" needs to be set correctly for backendtype=phy as well as backendtype=tap. Move the setting into the conditional, so it can be handled properly for each. (dev could be captured durin

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-23 Thread Anthony PERARD
On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote: > "$dev" needs to be set correctly for backendtype=phy as well as > backendtype=tap. Move the setting into the conditional, so it can be > handled properly for each. > > (dev could be captured during tap-ctl allocate for blktap module

Assertion failed at arch/x86/genapic/x2apic.c:38 on S3 resume nested in KVM on AMD

2024-07-23 Thread Marek Marczykowski-Górecki
Hi, I'm observing a crash like the one below when trying to resume from S3. It happens on Xen nested in KVM (QEMU 9.0, Linux 6.9.3) but only on AMD. The very same software stack on Intel works just fine. QEMU is running with "-cpu host,+svm,+invtsc -machine q35,kernel-irqchip=split -device amd-iom

Re: [PATCH v1.1 5/6] tools/libxs: Use writev()/sendmsg() instead of write()

2024-07-23 Thread Andrew Cooper
On 23/07/2024 2:45 pm, Jason Andryuk wrote: > On 2024-07-23 08:30, Juergen Gross wrote: >> On 23.07.24 14:25, Andrew Cooper wrote: >>> On 23/07/2024 10:37 am, Jürgen Groß wrote: On 22.07.24 18:25, Andrew Cooper wrote: > With the input data now conveniently arranged, use writev()/sendmsg()

Re: [PATCH v1.1 5/6] tools/libxs: Use writev()/sendmsg() instead of write()

2024-07-23 Thread Jason Andryuk
On 2024-07-23 08:30, Juergen Gross wrote: On 23.07.24 14:25, Andrew Cooper wrote: On 23/07/2024 10:37 am, Jürgen Groß wrote: On 22.07.24 18:25, Andrew Cooper wrote: With the input data now conveniently arranged, use writev()/sendmsg() instead of decomposing it into write() calls. This causes

Re: [PATCH 6/6] tools/libxs: Stop playing with SIGPIPE

2024-07-23 Thread Jason Andryuk
On 2024-07-18 12:48, Andrew Cooper wrote: It's very rude for a library to play with signals behind the back of the application, no matter ones views on the default behaviour of SIGPIPE under POSIX. Even if the application doesn't care about the xenstored socket, it my care about others. This lo

Re: [PATCH 4/6] tools/libxs: Track whether we're using a socket or file

2024-07-23 Thread Jason Andryuk
On 2024-07-23 08:08, Jürgen Groß wrote: On 23.07.24 14:07, Andrew Cooper wrote: On 23/07/2024 10:33 am, Jürgen Groß wrote: On 18.07.24 18:48, Andrew Cooper wrote: It will determine whether to use writev() or sendmsg(). Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Juergen Gross -

Re: [PATCH 2/2] x86/efi: Unlock NX if necessary

2024-07-23 Thread Alejandro Vallejo
Well, damn. At least it was found rather quickly. On Mon Jul 22, 2024 at 11:18 AM BST, Andrew Cooper wrote: > EFI systems can run with NX disabled, as has been discovered on a Broadwell > Supermicro X10SRM-TF system. > > Prior to commit fc3090a47b21 ("x86/boot: Clear XD_DISABLE from the early boot

[ovmf test] 186964: all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186964 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186964/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f96298d75cebfe2a7707157ed644eb86bf6d46ca baseline version: ovmf 46eb0ca29bf6bd84381af

Re: [PATCH 1/2] x86/efi: Simplify efi_arch_cpu() a little

2024-07-23 Thread Alejandro Vallejo
On Mon Jul 22, 2024 at 11:18 AM BST, Andrew Cooper wrote: > Make the "no extended leaves" case fatal and remove one level of indentation. > Defer the max-leaf aquisition until it is first used. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn

Re: [PATCH 3/6] tools/libxs: Rationalise the definition of struct xs_handle

2024-07-23 Thread Jason Andryuk
On 2024-07-18 12:48, Andrew Cooper wrote: Right now there are two completely different struct xs_handle definitions, depend on #ifdef USE_PTHREAD. One is especially well hidden, and often escapes updates. Rework struct xs_handle using some interior ifdefary. It's slightly longer, but much easi

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 14:33 +0100, Julien Grall wrote: > On 23/07/2024 14:27, oleksii.kuroc...@gmail.com wrote: > > Hello Julien, > > Hi Oleksii, > > > > On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > > > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > > > > index 7d09e781bf

Re: [PATCH 2/6] tools/libxs: Rework xs_talkv() to take xsd_sockmsg within the iovec

2024-07-23 Thread Jason Andryuk
On 2024-07-18 12:48, Andrew Cooper wrote: We would like to writev() the whole outgoing message, which is hard given the current need to prepend the locally-constructed xsd_sockmsg. Instead, have the caller provide xsd_sockmsg in iovec[0]. This in turn drops the t and type parameters from xs_tal

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
On Mon, 2024-07-22 at 19:04 +0200, oleksii.kuroc...@gmail.com wrote: > On Mon, 2024-07-22 at 17:25 +0200, Jan Beulich wrote: > > On 22.07.2024 16:36, Oleksii wrote: > > > On Mon, 2024-07-22 at 14:42 +0200, Jan Beulich wrote: > > > > On 12.07.2024 18:22, Oleksii Kurochko wrote: > > > > > --- a/xen/a

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread Julien Grall
On 23/07/2024 14:27, oleksii.kuroc...@gmail.com wrote: Hello Julien, Hi Oleksii, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index 7d09e781bf..d69a174b5d 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -49,6 +49

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread Julien Grall
On 23/07/2024 13:58, oleksii.kuroc...@gmail.com wrote: Hi Julien, Hi Oleksii, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: +/* Fixmap slots */ +#define FIX_PMAP_BEGIN (0) /* Start of PMAP */ +#define FIX_PMAP_END (FIX_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */ ... here i

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
Hello Julien, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > > index 7d09e781bf..d69a174b5d 100644 > > --- a/xen/arch/riscv/mm.c > > +++ b/xen/arch/riscv/mm.c > > @@ -49,6 +49,9 @@ stage1_pgtbl_root[PAGETABLE_ENTRIES]; > >    pte

Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

2024-07-23 Thread oleksii . kurochko
Hi Julien, On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > +/* Fixmap slots */ > > +#define FIX_PMAP_BEGIN (0) /* Start of PMAP */ > > +#define FIX_PMAP_END (FIX_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of > > PMAP */ > > ... here is seems to be inclusive. Furthermore if you had 32-bit >

Re: [PATCH v1.1 5/6] tools/libxs: Use writev()/sendmsg() instead of write()

2024-07-23 Thread Juergen Gross
On 23.07.24 14:25, Andrew Cooper wrote: On 23/07/2024 10:37 am, Jürgen Groß wrote: On 22.07.24 18:25, Andrew Cooper wrote: With the input data now conveniently arranged, use writev()/sendmsg() instead of decomposing it into write() calls. This causes all requests to be submitted with a single

Re: [PATCH v1.1 5/6] tools/libxs: Use writev()/sendmsg() instead of write()

2024-07-23 Thread Andrew Cooper
On 23/07/2024 10:37 am, Jürgen Groß wrote: > On 22.07.24 18:25, Andrew Cooper wrote: >> With the input data now conveniently arranged, use writev()/sendmsg() >> instead >> of decomposing it into write() calls. >> >> This causes all requests to be submitted with a single system call, >> rather >> th

Re: [PATCH 4/6] tools/libxs: Track whether we're using a socket or file

2024-07-23 Thread Jürgen Groß
On 23.07.24 14:07, Andrew Cooper wrote: On 23/07/2024 10:33 am, Jürgen Groß wrote: On 18.07.24 18:48, Andrew Cooper wrote: It will determine whether to use writev() or sendmsg(). Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Juergen Gross ---   tools/libs/store/xs.c | 5 +  

Re: [PATCH 4/6] tools/libxs: Track whether we're using a socket or file

2024-07-23 Thread Andrew Cooper
On 23/07/2024 10:33 am, Jürgen Groß wrote: > On 18.07.24 18:48, Andrew Cooper wrote: >> It will determine whether to use writev() or sendmsg(). >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Anthony PERARD >> CC: Juergen Gross >> --- >>   tools/libs/store/xs.c | 5 + >>   1 file changed, 5

[xen-unstable test] 186960: tolerable FAIL - PUSHED

2024-07-23 Thread osstest service owner
flight 186960 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186960/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186952 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH 6/6] tools/libxs: Stop playing with SIGPIPE

2024-07-23 Thread Jürgen Groß
On 18.07.24 18:48, Andrew Cooper wrote: It's very rude for a library to play with signals behind the back of the application, no matter ones views on the default behaviour of SIGPIPE under POSIX. Even if the application doesn't care about the xenstored socket, it my care about others. This logi

[ovmf test] 186962: all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186962 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186962/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 46eb0ca29bf6bd84381af8506e0d9b1755f767d9 baseline version: ovmf c5ab17430b2579dd79e3c

Xen 4.19-rc4

2024-07-23 Thread oleksii . kurochko
Hi all, Xen 4.19-rc4 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.19.0-rc4 For your convenience there is also a tarball and the signature at: https://downloads.xenproject.org/release/xen/4.19.0-rc4/xen-4.19.0-rc4.tar.gz And the signature is at: https://downloa

[PATCH RFC] x86/IOMMU: permit use of -save-temps

2024-07-23 Thread Jan Beulich
Rather than invoking make for individual .i and/or .i targets, it may be desirable to simply add -save-temps to $(CFLAGS) for some (or all) source files. That, however, triggers a tautological compare warning with at least gcc13 / gcc14. Apparently such warnings are suppressed when the compiler kno

Re: [PATCH 2/2] x86/efi: Unlock NX if necessary

2024-07-23 Thread Marek Marczykowski-Górecki
On Tue, Jul 23, 2024 at 12:25:32PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Jul 22, 2024 at 11:18:38AM +0100, Andrew Cooper wrote: > > EFI systems can run with NX disabled, as has been discovered on a Broadwell > > Supermicro X10SRM-TF system. > > > > Prior to commit fc3090a47b21 ("x86/b

Re: [PATCH 2/2] x86/efi: Unlock NX if necessary

2024-07-23 Thread Marek Marczykowski-Górecki
On Mon, Jul 22, 2024 at 11:18:38AM +0100, Andrew Cooper wrote: > EFI systems can run with NX disabled, as has been discovered on a Broadwell > Supermicro X10SRM-TF system. > > Prior to commit fc3090a47b21 ("x86/boot: Clear XD_DISABLE from the early boot > path"), the logic to unlock NX was common

Re: [PATCH 1/2] x86/efi: Simplify efi_arch_cpu() a little

2024-07-23 Thread Marek Marczykowski-Górecki
On Mon, Jul 22, 2024 at 11:18:37AM +0100, Andrew Cooper wrote: > Make the "no extended leaves" case fatal and remove one level of indentation. > Defer the max-leaf aquisition until it is first used. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Marek Marczykowski-Górecki

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Jan Beulich
On 23.07.2024 11:31, Roger Pau Monne wrote: > Yet another clang code generation issue when using altcalls. > > The issue this time is with using loop constructs around alternative_{,v}call > instances using parameter types smaller than the register size. > > Given the following example code: > >

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread Jan Beulich
On 23.07.2024 10:55, oleksii.kuroc...@gmail.com wrote: > On Tue, 2024-07-23 at 10:36 +0200, Jan Beulich wrote: >> On 23.07.2024 10:02, Oleksii Kurochko wrote: >>> On Mon, Jul 22, 2024 at 7:27 PM Julien Grall >>> wrote: >> On 22/07/2024 15:44, Oleksii Kurochko wrote: >     /* Map a 4k page

Re: [PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 11:31 +0200, Roger Pau Monne wrote: > Yet another clang code generation issue when using altcalls. > > The issue this time is with using loop constructs around > alternative_{,v}call > instances using parameter types smaller than the register size. > > Given the following ex

Re: [PATCH v5 4/4] x86/ucode: Utilize ucode_force and remove opt_ucode_allow_same

2024-07-23 Thread Fouad Hilly
On Tue, Jul 16, 2024 at 3:59 PM Jan Beulich wrote: > > On 12.07.2024 15:07, Fouad Hilly wrote: > > --- a/xen/arch/x86/cpu/microcode/core.c > > +++ b/xen/arch/x86/cpu/microcode/core.c > > @@ -90,6 +90,16 @@ struct ucode_mod_blob { > > size_t size; > > }; > > > > +struct microcode_patch_with_f

Re: [PATCH v5 2/4] x86/ucode: refactor xen-ucode to utilize getopt

2024-07-23 Thread Fouad Hilly
On Tue, Jul 16, 2024 at 3:51 PM Jan Beulich wrote: > > On 12.07.2024 15:07, Fouad Hilly wrote: > > --- a/tools/misc/xen-ucode.c > > +++ b/tools/misc/xen-ucode.c > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > > > static xc_interface *xch; > > > > @@ -71,12 +7

Re: [PATCH v5 3/4] x86/ucode: Introduce --force option to xen-ucode

2024-07-23 Thread Fouad Hilly
On Fri, Jul 12, 2024 at 2:27 PM Jan Beulich wrote: > > On 12.07.2024 15:07, Fouad Hilly wrote: > > @@ -79,6 +81,8 @@ static void usage(FILE *stream, const char *name) > > "options:\n" > > " -h, --helpdisplay this help\n" > > " -s, --show-cpu-inf

Re: [PATCH v1.1 5/6] tools/libxs: Use writev()/sendmsg() instead of write()

2024-07-23 Thread Jürgen Groß
On 22.07.24 18:25, Andrew Cooper wrote: With the input data now conveniently arranged, use writev()/sendmsg() instead of decomposing it into write() calls. This causes all requests to be submitted with a single system call, rather than at least two. While in principle short writes can occur, th

Re: [PATCH 4/6] tools/libxs: Track whether we're using a socket or file

2024-07-23 Thread Jürgen Groß
On 18.07.24 18:48, Andrew Cooper wrote: It will determine whether to use writev() or sendmsg(). Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Juergen Gross --- tools/libs/store/xs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs/store/

[PATCH for-4.19] x86/altcall: fix clang code-gen when using altcall in loop constructs

2024-07-23 Thread Roger Pau Monne
Yet another clang code generation issue when using altcalls. The issue this time is with using loop constructs around alternative_{,v}call instances using parameter types smaller than the register size. Given the following example code: static void bar(bool b) { unsigned int i; for ( i

Re: [PATCH 3/6] tools/libxs: Rationalise the definition of struct xs_handle

2024-07-23 Thread Jürgen Groß
On 18.07.24 18:48, Andrew Cooper wrote: Right now there are two completely different struct xs_handle definitions, depend on #ifdef USE_PTHREAD. One is especially well hidden, and often escapes updates. Rework struct xs_handle using some interior ifdefary. It's slightly longer, but much easier

Re: [PATCH 2/6] tools/libxs: Rework xs_talkv() to take xsd_sockmsg within the iovec

2024-07-23 Thread Jürgen Groß
On 18.07.24 18:48, Andrew Cooper wrote: We would like to writev() the whole outgoing message, which is hard given the current need to prepend the locally-constructed xsd_sockmsg. Instead, have the caller provide xsd_sockmsg in iovec[0]. This in turn drops the t and type parameters from xs_talkv

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread oleksii . kurochko
On Tue, 2024-07-23 at 10:36 +0200, Jan Beulich wrote: > On 23.07.2024 10:02, Oleksii Kurochko wrote: > > On Mon, Jul 22, 2024 at 7:27 PM Julien Grall > > wrote: > > > > > On 22/07/2024 15:44, Oleksii Kurochko wrote: > > > >     /* Map a 4k page in a fixmap entry */ > > > >     void set_fixmap(unsi

[libvirt test] 186959: tolerable all pass - PUSHED

2024-07-23 Thread osstest service owner
flight 186959 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/186959/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186923 test-amd64-amd64-libvirt-xsm 15 migrate-s

Re: [XEN PATCH v5 16/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-23 Thread Jan Beulich
On 23.07.2024 10:15, Alessandro Zucchelli wrote: > This section explains which format should be followed by header > inclusion guards via a drop-down list of rules. > > No functional change. > > Signed-off-by: Alessandro Zucchelli As indicated in reply to v4, this wants (imo needs) to move to t

Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header

2024-07-23 Thread Jan Beulich
On 23.07.2024 10:02, Oleksii Kurochko wrote: > On Mon, Jul 22, 2024 at 7:27 PM Julien Grall wrote: On 22/07/2024 15:44, Oleksii Kurochko wrote: >>> /* Map a 4k page in a fixmap entry */ >>> void set_fixmap(unsigned map, mfn_t mfn, unsigned int flags) >>> { >>> pte_t pte; >

[XEN PATCH v5 14/17] xen/x86: rename inclusion guards for consistency

2024-07-23 Thread Alessandro Zucchelli
From: Maria Celeste Cesario Edit inclusion guards in order to make them consistent with the estabilished naming conventions. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini Signed-off-by: Alessandro Zucchelli --- C

[XEN PATCH v5 16/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-23 Thread Alessandro Zucchelli
This section explains which format should be followed by header inclusion guards via a drop-down list of rules. No functional change. Signed-off-by: Alessandro Zucchelli --- Changes in v5: - edit inclusion guards naming conventions, according to feedback received --- CODING_STYLE | 21 ++

[XEN PATCH v5 12/17] xen: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Alessandro Zucchelli
From: Maria Celeste Cesario Modify creation rule for asm-offsets.h to conform to the new standard and to not generate conflicting guards between architectures (which is a violation of the directive). Modify generic-y creation rule to generate code without violations and to conform to the new stan

[XEN PATCH v5 15/17] xen/build: address violation of MISRA C Directive 4.10

2024-07-23 Thread Alessandro Zucchelli
This addresses violations of MISRA C:2012 Rule 4.10 which states as following: Precautions shall be taken in order to prevent the contents of a header file being included more than once. Changes are made for autogenerated header files: include/xen/compile.h and include/xen/hypercall-defs.h. No fu

[XEN PATCH v5 09/17] xen: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Alessandro Zucchelli
From: Simone Ballarin Amend inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted a

[XEN PATCH v5 10/17] x86/asm: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Alessandro Zucchelli
From: Simone Ballarin Amend generation script, add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). This patch amends the Makefile adding the required inclusion gu

[XEN PATCH v5 11/17] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-07-23 Thread Alessandro Zucchelli
From: Maria Celeste Cesario Add or modify inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-off-by: Maria Celeste Cesario Signed-off-by:

[XEN PATCH v5 13/17] xen: add deviations for MISRA C 2012 Dir D4.10

2024-07-23 Thread Alessandro Zucchelli
From: Nicola Vetrini Add safe deviation for *.c files, as estabilished in past discussion. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin Signed-off-by: Nicola Vetrini Signed-off-by: Alessandro Zucchelli Reviewed-by: Stefano Stabellini --- Changes in v4: - split the

  1   2   >