On Tue, 2024-07-23 at 14:33 +0100, Julien Grall wrote: > On 23/07/2024 14:27, oleksii.kuroc...@gmail.com wrote: > > Hello Julien, > > Hi Oleksii, > > > > On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote: > > > > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > > > > index 7d09e781bf..d69a174b5d 100644 > > > > --- a/xen/arch/riscv/mm.c > > > > +++ b/xen/arch/riscv/mm.c > > > > @@ -49,6 +49,9 @@ stage1_pgtbl_root[PAGETABLE_ENTRIES]; > > > > pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) > > > > stage1_pgtbl_nonroot[PGTBL_INITIAL_COUNT * > > > > PAGETABLE_ENTRIES]; > > > > > > > > +pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) > > > > +xen_fixmap[PAGETABLE_ENTRIES]; > > > > > > Can you add a BUILD_BUG_ON() to check that the number of entries > > > in > > > the > > > fixmap will never be above PAGETABLE_ENTRIES? > > I just realized that we don't have the information about how many > > entries has been used. Am I confusing something? > > I think we do. It is FIX_LAST. Sure. We have FIX_LAST. Thanks
~ Oleksii