[LINUX KERNEL PATCH 1/1] virtgpu: init vq during resume and notify qemu guest status

2023-06-07 Thread Jiqian Chen
This patch solves two problem: First, when we suspended guest VM, it called into Qemu to call virtio_reset->__virtio_queue_reset, this cleared all virtuqueue information of virtgpu on Qemu end. As a result, after guest resumed, guest sended ctrl/cursor requests to Qemu through virtqueue, but Qemu

[LINUX KERNEL PATCH 0/1] add S3 support for virtgpu

2023-06-07 Thread Jiqian Chen
Hi all, I am working to implement virtgpu S3 function on Xen. Currently on Xen, if we start a guest who enables virtgpu, and then run "echo mem > /sys/power/state" to suspend guest. And run "sudo xl trigger s3resume" to resume guest. We can find that the guest kernel comes back, but the display

[xen-unstable-smoke test] 181292: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181292 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181292/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

[QEMU PATCH 0/1]

2023-06-07 Thread Jiqian Chen
Hi all, I am working to implement virtgpu S3 function on Xen. Currently on Xen, if we start a guest who enables virtgpu, and then run "echo mem > /sys/power/state" to suspend guest. And run "sudo xl trigger s3resume" to resume guest. We can find that the guest kernel comes back, but the display

[QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-07 Thread Jiqian Chen
After suspending and resuming guest VM, you will get a black screen, and the display can't come back. This is because when guest did suspending, it called into qemu to call virtio_gpu_gl_reset. In function virtio_gpu_gl_reset, it destroyed resources and reset renderer, which were used for display.

[xen-unstable-smoke test] 181285: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181285 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181285/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

[xen-unstable test] 181261: tolerable FAIL - PUSHED

2023-06-07 Thread osstest service owner
flight 181261 xen-unstable real [real] flight 181284 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181261/ http://logs.test-lab.xenproject.org/osstest/logs/181284/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[xen-unstable-smoke test] 181280: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181280 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181280/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

[qemu-mainline test] 181271: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181271 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181271/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

[ovmf test] 181268: tolerable FAIL - PUSHED

2023-06-07 Thread osstest service owner
flight 181268 ovmf real [real] flight 181276 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181268/ http://logs.test-lab.xenproject.org/osstest/logs/181276/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-

[xen-unstable-smoke test] 181277: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181277 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181277/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH] docs/misra: new rules addition

2023-06-07 Thread Stefano Stabellini
On Wed, 7 Jun 2023, Jan Beulich wrote: > On 07.06.2023 03:38, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > For Dir 1.1, a document describing all implementation-defined behaviour > > (i.e. gcc-specific behavior) will be added to docs/misra, also including > > implementation-spec

[xen-unstable-smoke test] 181273: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181273 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181273/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH] CI: Fix the github actions Coverity run

2023-06-07 Thread Stefano Stabellini
On Wed, 7 Jun 2023, Andrew Cooper wrote: > The Install step is failing with: > > Package python-dev is not available, but is referred to by another package. > This may mean that the package is missing, has been obsoleted, or > E: Package 'python-dev' has no installation candidate > is only

[xen-unstable-smoke test] 181266: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181266 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181266/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 181233 build-armhf

Re: [PATCH 0/3] Initial support for Power

2023-06-07 Thread Andrew Cooper
On 07/06/2023 8:01 pm, Shawn Anastasio wrote: >> If you look around in the Xen tree at bb62c25e3e5c and take the makefile >> override's in particular, you should be able to get `make -C xen build` >> work without any magic TARGET= overrides, and without most of the >> headers you've added in patch

Re: [PATCH 0/3] Initial support for Power

2023-06-07 Thread Shawn Anastasio
On Wed Jun 7, 2023 at 1:07 PM CDT, Andrew Cooper wrote: > Oh wow - this is a surprise, but certainly a good one. I'm glad to hear that! > We've recently done just a similar exercise with RISCV64, starting with > getting cross-compilation and a basic smoke test into our CI. I see. I used the init

[qemu-mainline test] 181244: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181244 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181244/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

Re: [PATCH RFC 0/4] x86/fixmap: Unify FIXADDR_TOP

2023-06-07 Thread Thomas Gleixner
On Mon, May 15 2023 at 16:19, Hou Wenlong wrote: > This patchset unifies FIXADDR_TOP as a variable for x86, allowing the > fixmap area to be movable and relocated with the kernel image in the > x86/PIE patchset [0]. This enables the kernel image to be relocated in > the top 512G of the address spa

Re: [PATCH 0/3] Initial support for Power

2023-06-07 Thread Andrew Cooper
On 07/06/2023 4:06 pm, Shawn Anastasio wrote: > Hello all, > > This patch series adds support for building a minimal image > (head.o-only) for Power ISA 2.07B+ (POWER8+) systems. The first patch > boots to an infinite loop and the second adds early serial console > support on pseries VMs, with bare

[ovmf test] 181257: all pass - PUSHED

2023-06-07 Thread osstest service owner
flight 181257 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181257/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8d238f1433397397b4d05b38cb2460929429241f baseline version: ovmf c082da89cfb2dd9640272

[linux-linus test] 181240: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181240 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181240/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are fai

[xen-unstable-smoke test] 181254: regressions - trouble: blocked/fail

2023-06-07 Thread osstest service owner
flight 181254 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181254/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 181233 build-arm64-

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 10:44:48AM +0200, Roger Pau Monné wrote: > On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote: > > On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > > > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > > > > Set "opened"

[xen-unstable-smoke bisection] complete build-amd64

2023-06-07 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree

[xen-unstable test] 181243: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181243 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181243/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 181194 test-armhf-armhf-e

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote: > On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote: > > On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > > > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: > > > > This allows s

Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 12:46:16AM -0700, Christoph Hellwig wrote: > > --- a/drivers/block/xen-blkback/xenbus.c > > +++ b/drivers/block/xen-blkback/xenbus.c > > @@ -3,6 +3,20 @@ > > Copyright (C) 2005 Rusty Russell > > Copyright (C) 2005 XenSource Ltd > > > > +In addition to the Xensto

Re: [PATCH 1/2] xen-blkback: Implement diskseq checks

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 12:44:22AM -0700, Christoph Hellwig wrote: > On Thu, Jun 01, 2023 at 05:48:22PM -0400, Demi Marie Obenour wrote: > > + if (diskseq) { > > + struct gendisk *disk = bdev->bd_disk; > > + > > + if (unlikely(disk == NULL)) { > > + pr_err("%

Re: [PATCH] x86/hvm: print valid CR4 bits in case of error

2023-06-07 Thread Andrew Cooper
On 07/06/2023 2:46 pm, Roger Pau Monne wrote: > Some of the current users of hvm_cr4_guest_valid_bits() to check > whether a CR4 value is correct don't print the valid mask, and thus > the resulting error messages are not as helpful as they could be. > > Amend callers to always print the value of h

Re: [PATCH] docs: Fix xl.cfg documentation

2023-06-07 Thread Andrew Cooper
On 07/06/2023 2:59 pm, Michal Orzel wrote: > On 07/06/2023 15:54, Luca Fancellu wrote: >> >> A recent change to the documentation for the xl.cfg introduced a build >> error, fix the issue. >> >> Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration") >> Signed-off-by: Luca Fancellu

[PATCH 2/3] xen/ppc: Implement early serial printk on PaPR/pseries

2023-06-07 Thread Shawn Anastasio
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services are provided by OpenFirmware, including an early serial console. Implement the required interfaces to call into OpenFirmware and write to the serial console. Since OpenFirmware runs in 32-bit Big Endian mode and Xen runs in 64-bi

[PATCH 1/3] xen: Add files needed for minimal Power build

2023-06-07 Thread Shawn Anastasio
Add the build system changes required to build for ppc64le (POWER8+). Following in the footsteps of the initial riscv port, only building the head.o target, which boots to an infinite loop, is supported: $ make XEN_TARGET_ARCH=ppc64 -C xen openpower_defconfig $ make XEN_TARGET_ARCH=ppc64 SUBSYSTEM

[PATCH 3/3] maintainers: Add PPC64 maintainer

2023-06-07 Thread Shawn Anastasio
Signed-off-by: Shawn Anastasio --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1bb7a6a839..bcd36f9019 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -451,6 +451,9 @@ M: Wei Liu S: Supported T: git https://xenbits.xenproject.org/git

[PATCH 0/3] Initial support for Power

2023-06-07 Thread Shawn Anastasio
Hello all, This patch series adds support for building a minimal image (head.o-only) for Power ISA 2.07B+ (POWER8+) systems. The first patch boots to an infinite loop and the second adds early serial console support on pseries VMs, with bare metal support planned next. Since Xen previously had su

Re: [PATCH] x86/hvm: print valid CR4 bits in case of error

2023-06-07 Thread Jan Beulich
On 07.06.2023 16:24, Roger Pau Monné wrote: > On Wed, Jun 07, 2023 at 04:00:14PM +0200, Jan Beulich wrote: >> On 07.06.2023 15:46, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/domain.c >>> +++ b/xen/arch/x86/hvm/domain.c >>> @@ -266,8 +266,8 @@ int arch_set_info_hvm_guest(struct vcpu *v, const

[xen-unstable-smoke test] 181248: regressions - trouble: blocked/fail

2023-06-07 Thread osstest service owner
flight 181248 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181248/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 181233 build-arm64-

Re: [PATCH] x86/hvm: print valid CR4 bits in case of error

2023-06-07 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 04:00:14PM +0200, Jan Beulich wrote: > On 07.06.2023 15:46, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/domain.c > > +++ b/xen/arch/x86/hvm/domain.c > > @@ -266,8 +266,8 @@ int arch_set_info_hvm_guest(struct vcpu *v, const > > vcpu_hvm_context_t *ctx) > > > > i

Re: [PATCH] x86/hvm: print valid CR4 bits in case of error

2023-06-07 Thread Jan Beulich
On 07.06.2023 15:46, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/domain.c > +++ b/xen/arch/x86/hvm/domain.c > @@ -266,8 +266,8 @@ int arch_set_info_hvm_guest(struct vcpu *v, const > vcpu_hvm_context_t *ctx) > > if ( v->arch.hvm.guest_cr[4] & ~hvm_cr4_guest_valid_bits(d) ) > { > -

Re: [PATCH] docs: Fix xl.cfg documentation

2023-06-07 Thread Michal Orzel
On 07/06/2023 15:54, Luca Fancellu wrote: > > > A recent change to the documentation for the xl.cfg introduced a build > error, fix the issue. > > Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration") > Signed-off-by: Luca Fancellu Tested and looks good. Reviewed-by: Mich

[PATCH] docs: Fix xl.cfg documentation

2023-06-07 Thread Luca Fancellu
A recent change to the documentation for the xl.cfg introduced a build error, fix the issue. Fixes: b46e8207d0ae ("xen/tools: add sve parameter in XL configuration") Signed-off-by: Luca Fancellu --- Apologise for the error! I think I was building an old version of the docs and after the clarifica

[PATCH] x86/hvm: print valid CR4 bits in case of error

2023-06-07 Thread Roger Pau Monne
Some of the current users of hvm_cr4_guest_valid_bits() to check whether a CR4 value is correct don't print the valid mask, and thus the resulting error messages are not as helpful as they could be. Amend callers to always print the value of hvm_cr4_guest_valid_bits(), and take the opportunity of

Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-06-07 Thread Jan Beulich
On 07.06.2023 14:45, Stewart Hildebrand wrote: > On 6/7/23 03:59, Jan Beulich wrote: >> On 07.06.2023 05:02, Stewart Hildebrand wrote: >>> --- a/xen/include/xen/iommu.h >>> +++ b/xen/include/xen/iommu.h >>> @@ -26,6 +26,9 @@ >>> #include >>> #include >>> #include >>> +#ifdef CONFIG_ACPI >>> +

Re: [PATCH v4 1/7] xen/arm: Improve readability of check for registered devices

2023-06-07 Thread Stewart Hildebrand
On 6/7/23 03:27, Julien Grall wrote: > Hi Stewart, > > On 07/06/2023 04:02, Stewart Hildebrand wrote: >> From: Oleksandr Tyshchenko >> >> Improve readability of check for devices already registered with the SMMU >> with >> legacy mmu-masters DT bindings by using is_protected. > > I am unconvinc

[PATCH, RFC] swiotlb-xen: fix dma to physical address translation for cache operations

2023-06-07 Thread Christoph Hellwig
All other places in swiotlb-xen got from PFN to BFN and then call phys_to_dma on the result or vice versa, but the reverse mapping used for cache maintenance skips the BFN to PFN mapping. [Note: only found by code inspection, please review very carefully!] Signed-off-by: Christoph Hellwig --- d

[libvirt test] 181239: tolerable all pass - PUSHED

2023-06-07 Thread osstest service owner
flight 181239 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181239/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181205 test-armhf-armhf-libvirt 16 saveresto

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-06-07 Thread Christoph Hellwig
On Mon, May 22, 2023 at 10:37:09AM +0200, Juergen Gross wrote: > In normal cases PCI passthrough in PV guests requires to start the guest > with e820_host=1. So it should be rather easy to limit allocating the > 64MB in PV guests to the cases where the memory map has non-RAM regions > especially in

Re: [PATCH 3/4] drm/nouveau: stop using is_swiotlb_active

2023-06-07 Thread Christoph Hellwig
On Thu, May 18, 2023 at 04:30:49PM -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > Thanks for getting to this! I've tentantively queued this up in the dma-mapping for-next tree. Let me know if you'd prefer it to go through the nouveau tree.

[xen-unstable-smoke test] 181246: regressions - trouble: blocked/fail

2023-06-07 Thread osstest service owner
flight 181246 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 181233 build-arm64-

Re: [PATCH RFC 0/4] x86/fixmap: Unify FIXADDR_TOP

2023-06-07 Thread Dave Hansen
On 5/15/23 01:19, Hou Wenlong wrote: > This patchset unifies FIXADDR_TOP as a variable for x86, allowing the > fixmap area to be movable and relocated with the kernel image in the > x86/PIE patchset [0]. This enables the kernel image to be relocated in > the top 512G of the address space. What pro

Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-06-07 Thread Stewart Hildebrand
On 6/7/23 03:59, Jan Beulich wrote: > On 07.06.2023 05:02, Stewart Hildebrand wrote: >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -26,6 +26,9 @@ >> #include >> #include >> #include >> +#ifdef CONFIG_ACPI >> +#include >> +#endif > > This header is supposed to be us

Re: [PATCH v6 00/14] tools/xenstore: rework internal accounting

2023-06-07 Thread Julien Grall
Hi Juergen, On 30/05/2023 09:24, Juergen Gross wrote: This series reworks the Xenstore internal accounting to use a uniform generic framework. It is adding some additional useful diagnostic information, like accounting trace and max. per-domain and global quota values seen. Changes in V2: - add

[PATCH] xen/xenbus: Avoid a lockdep warning when adding a watch

2023-06-07 Thread Petr Pavlu
The following lockdep warning appears during boot on a Xen dom0 system: [ 96.388794] == [ 96.388797] WARNING: possible circular locking dependency detected [ 96.388799] 6.4.0-rc5-default+ #8 Tainted: GEL [ 96.388803] -

[ovmf test] 181245: all pass - PUSHED

2023-06-07 Thread osstest service owner
flight 181245 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181245/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c082da89cfb2dd9640272741b7f176ede3cc41bb baseline version: ovmf 67fc78d026490ea4c375e

Re: [PATCH v6 12/14] tools/xenstore: use generic accounting for remaining quotas

2023-06-07 Thread Julien Grall
Hi Juergen, On 30/05/2023 09:24, Juergen Gross wrote: The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able t

Re: [PATCH v6 05/14] tools/xenstore: use accounting buffering for node accounting

2023-06-07 Thread Julien Grall
Hi Juergen, On 30/05/2023 09:24, Juergen Gross wrote: Add the node accounting to the accounting information buffering in order to avoid having to undo it in case of failure. This requires to call domain_nbentry_dec() before any changes to the data base, as it can return an error now. Signed-of

Re: [PATCH v8 00/12] SVE feature for arm guests

2023-06-07 Thread Julien Grall
Hi Luca, On 31/05/2023 08:24, Luca Fancellu wrote: This serie is introducing the possibility for Dom0 and DomU guests to use sve/sve2 instructions. SVE feature introduces new instruction and registers to improve performances on floating point operations. The SVE feature is advertised using the

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Andrew Cooper
On 07/06/2023 11:19 am, Jan Beulich wrote: > On 07.06.2023 11:17, Roger Pau Monné wrote: >> On Wed, Jun 07, 2023 at 11:10:27AM +0200, Jan Beulich wrote: >>> On 07.06.2023 11:01, Roger Pau Monne wrote: Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot using _apply_alte

Re: [PATCH v1 6/8] xen/riscv: add SPDX tags

2023-06-07 Thread Julien Grall
Hi Oleksii, On 06/06/2023 20:55, Oleksii Kurochko wrote: Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/config.h | 2 ++ xen/arch/riscv/include/asm/current.h | 2 ++ xen/arch/riscv/include/asm/early_printk.h | 2 ++ xen/arch/riscv/include/asm/mm.h | 2 +

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Jan Beulich
On 07.06.2023 11:17, Roger Pau Monné wrote: > On Wed, Jun 07, 2023 at 11:10:27AM +0200, Jan Beulich wrote: >> On 07.06.2023 11:01, Roger Pau Monne wrote: >>> Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot >>> using _apply_alternatives(). >>> >>> Signed-off-by: Roger Pau Monn

Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option

2023-06-07 Thread Andrew Cooper
On 07/06/2023 11:07 am, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -2628,6 +2628,9 @@ with the specified width, height and depth. >> `ask` option. (N.B menu modes are displayed in hex

Re: [PATCH v8 05/12] arm/sve: save/restore SVE context switch

2023-06-07 Thread Julien Grall
Hi Luca, On 31/05/2023 08:24, Luca Fancellu wrote: Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be maximum 256 bits, the allocated memory depends on how many bits is the vector length for the domain and

Re: [PATCH v1 0/8] xen/riscv: introduce identity mapping

2023-06-07 Thread Oleksii
On Wed, 2023-06-07 at 09:49 +0200, Jan Beulich wrote: > On 06.06.2023 21:55, Oleksii Kurochko wrote: > > The patch series introduces things necessary to implement identity > > mapping: > >   1. Make identity mapping for _start and stack. > >   2. Enable MMU. > >   3. Jump to the virtual address wor

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Jan Beulich
On 07.06.2023 11:19, Andrew Cooper wrote: > On 07/06/2023 10:17 am, Roger Pau Monné wrote: >> On Wed, Jun 07, 2023 at 11:10:27AM +0200, Jan Beulich wrote: >>> On 07.06.2023 11:01, Roger Pau Monne wrote: Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot using _apply_al

Re: [PATCH v3 1/3] multiboot2: parse vga= option when setting GOP mode

2023-06-07 Thread Jan Beulich
On 01.06.2023 15:05, Roger Pau Monne wrote: > @@ -807,7 +830,41 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, > EFI_SYSTEM_TABLE *SystemTable > > if ( gop ) > { > -gop_mode = efi_find_gop_mode(gop, 0, 0, 0); > +const char *last = cmdline; > +unsigned int

Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option

2023-06-07 Thread Jan Beulich
On 01.06.2023 15:05, Roger Pau Monne wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -2628,6 +2628,9 @@ with the specified width, height and depth. > `ask` option. (N.B menu modes are displayed in hex, so `` > should be a hexadecimal number) > >

Re: [PATCH v3 2/3] multiboot2: do not set StdOut mode unconditionally

2023-06-07 Thread Jan Beulich
On 01.06.2023 15:05, Roger Pau Monne wrote: > Only initialize StdOut if the current StdOut mode is unusable. This > avoids forcefully switching StdOut to the maximum supported > resolution, and thus very likely changing the GOP mode without having > first parsed the command line options. > > Sign

Re: [PATCH v3 1/3] multiboot2: parse vga= option when setting GOP mode

2023-06-07 Thread Jan Beulich
On 01.06.2023 15:05, Roger Pau Monne wrote: > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -226,9 +226,10 @@ __efi64_mb2_start: > jmp x86_32_switch > > .Lefi_multiboot2_proto: > -/* Zero EFI SystemTable and EFI ImageHandle addresses. */ > +/*

[PATCH] CI: Fix the github actions Coverity run

2023-06-07 Thread Andrew Cooper
The Install step is failing with: Package python-dev is not available, but is referred to by another package. This may mean that the package is missing, has been obsoleted, or E: Package 'python-dev' has no installation candidate is only available from another source However the followin

[PATCH 3/4] xen/arm: pl011: Use correct accessors

2023-06-07 Thread Michal Orzel
At the moment, we use 32-bit only accessors (i.e. readl/writel) to match the SBSA v2.x requirement. This should not be the default case for normal PL011 where accesses shall be 8/16-bit (max register size is 16-bit). There are however implementations of this UART that can only handle 32-bit MMIO. T

[PATCH 2/4] xen/arm: debug-pl011: Add support for 32-bit only MMIO

2023-06-07 Thread Michal Orzel
There are implementations of PL011 that can only handle 32-bit accesses as oppose to the normal behavior where accesses are 8/16-bit wide. This is usually advertised by setting a dt property 'reg-io-width' to 4. Introduce CONFIG_EARLY_UART_PL011_MMIO32 Kconfig option to be able to enable the use o

[PATCH 4/4] xen/arm: pl011: Add SBSA UART device-tree support

2023-06-07 Thread Michal Orzel
We already have all the bits necessary in PL011 driver to support SBSA UART thanks to commit 032ea8c736d10f02672863c6e369338f948f7ed8 that enabled it for ACPI. Plumb in the remaining part for device-tree boot: - add arm,sbsa-uart compatible to pl011_dt_match (no need for a separate struct and D

[PATCH 1/4] xen/arm: debug-pl011: Use correct accessors

2023-06-07 Thread Michal Orzel
Although most PL011 UARTs can cope with 32-bit accesses, some of the old legacy ones might not. PL011 registers are 8/16-bit wide and this shall be perceived as the normal behavior. Modify early printk pl011 code for arm32/arm64 to use the correct accessors depending on the register size (refer AR

[PATCH 0/4] xen/arm: pl011: Use correct accessors

2023-06-07 Thread Michal Orzel
At the moment we have a real mix of accessors used for PL011 registers across early printk and runtime driver resulting in a) not spec compliant behavior and b) inconsistency. This series: - switches to use the 8/16-bit accessors in normal case, - adds support to use 32-bit only accessors. The b

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Andrew Cooper
On 07/06/2023 10:17 am, Roger Pau Monné wrote: > On Wed, Jun 07, 2023 at 11:10:27AM +0200, Jan Beulich wrote: >> On 07.06.2023 11:01, Roger Pau Monne wrote: >>> Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot >>> using _apply_alternatives(). >>> >>> Signed-off-by: Roger Pau M

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 11:10:27AM +0200, Jan Beulich wrote: > On 07.06.2023 11:01, Roger Pau Monne wrote: > > Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot > > using _apply_alternatives(). > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Julien Grall > > Reviewe

Re: [PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Jan Beulich
On 07.06.2023 11:01, Roger Pau Monne wrote: > Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot > using _apply_alternatives(). > > Signed-off-by: Roger Pau Monné > Reviewed-by: Julien Grall Reviewed-by: Jan Beulich albeit the implicit ack therein is only on the assumption

Re: [PATCH] libs/light: use the cpuid feature names from cpufeatureset.h

2023-06-07 Thread Jan Beulich
On 05.06.2023 12:36, Roger Pau Monne wrote: > @@ -51,7 +53,7 @@ void libxl_cpuid_dispose(libxl_cpuid_policy_list > *p_cpuid_list) > * Used for the static structure describing all features. > */ > struct cpuid_flags { > -char* name; > +const char* name; Nit: Would you mind also moving

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-07 Thread Bertrand Marquis
Hi Andrew, > On 7 Jun 2023, at 10:27, Andrew Cooper wrote: > > On 07/06/2023 9:10 am, Jan Beulich wrote: >> On 05.06.2023 13:23, Andrew Cooper wrote: >>> v2: >>> * Fix commmit message >>> * Update comment ahead of print_tainted() >>> * Change the emitted char from 'U' to 'I' >> Just to mention i

Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()

2023-06-07 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 10:43:24AM +0200, Jan Beulich wrote: > On 05.06.2023 17:23, Andrew Cooper wrote: > > On 05/06/2023 4:19 pm, Roger Pau Monné wrote: > >> On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote: > >>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > >>> i

[PATCH v2] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Roger Pau Monne
Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot using _apply_alternatives(). Signed-off-by: Roger Pau Monné Reviewed-by: Julien Grall --- Changes since v1: - Do not guard function prototypes. --- Andrew raised a valid point of moving the prototype to a common header, but

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Roger Pau Monné
On Tue, Jun 06, 2023 at 07:10:05PM +0100, Julien Grall wrote: > Hi Roger, > > On 06/06/2023 18:23, Roger Pau Monne wrote: > > Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot > > using _apply_alternatives(). > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Julien Gr

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Roger Pau Monné
On Wed, Jun 07, 2023 at 10:14:35AM +0200, Jan Beulich wrote: > On 06.06.2023 19:23, Roger Pau Monne wrote: > > --- a/xen/arch/x86/include/asm/alternative.h > > +++ b/xen/arch/x86/include/asm/alternative.h > > @@ -24,7 +24,9 @@ struct __packed alt_instr { > > > > extern void add_nops(void *insns,

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Roger Pau Monné
On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote: > On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > > > Set "opened" to "0" before the hotplug script is called. Once the > > > device node h

Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()

2023-06-07 Thread Jan Beulich
On 05.06.2023 17:23, Andrew Cooper wrote: > On 05/06/2023 4:19 pm, Roger Pau Monné wrote: >> On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote: >>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >>> index 85242a73d374..854f3e32c00e 100644 >>> --- a/xen/include/xen/sched.

[qemu-mainline test] 181236: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181236 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-07 Thread Jan Beulich
On 07.06.2023 10:20, Bertrand Marquis wrote: > Hi Jan, > >> On 7 Jun 2023, at 10:10, Jan Beulich wrote: >> >> On 05.06.2023 13:23, Andrew Cooper wrote: >>> v2: >>> * Fix commmit message >>> * Update comment ahead of print_tainted() >>> * Change the emitted char from 'U' to 'I' >> >> Just to menti

Re: [PATCH] docs/misra: new rules addition

2023-06-07 Thread Jan Beulich
On 07.06.2023 03:38, Stefano Stabellini wrote: > From: Stefano Stabellini > > For Dir 1.1, a document describing all implementation-defined behaviour > (i.e. gcc-specific behavior) will be added to docs/misra, also including > implementation-specific (gcc-specific) appropriate types for bit-field

Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

2023-06-07 Thread Luca Fancellu
> On 6 Jun 2023, at 21:29, Vikram Garhwal wrote: > > Hi, > > On 6/5/23 12:12 PM, Julien Grall wrote: >> Hi, >> >> On 02/06/2023 01:48, Vikram Garhwal wrote: >>> Add device_tree_find_node_by_path() to find a matching node with path for a >> >> AFAICT, the only difference in name between the

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-07 Thread Andrew Cooper
On 07/06/2023 9:10 am, Jan Beulich wrote: > On 05.06.2023 13:23, Andrew Cooper wrote: >> v2: >> * Fix commmit message >> * Update comment ahead of print_tainted() >> * Change the emitted char from 'U' to 'I' > Just to mention it: With this additional change I'm no longer > considering this appli

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-07 Thread Bertrand Marquis
Hi Jan, > On 7 Jun 2023, at 10:10, Jan Beulich wrote: > > On 05.06.2023 13:23, Andrew Cooper wrote: >> v2: >> * Fix commmit message >> * Update comment ahead of print_tainted() >> * Change the emitted char from 'U' to 'I' > > Just to mention it: With this additional change I'm no longer > consi

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-07 Thread Roger Pau Monné
On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote: > On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: > > > This allows specifying a disk sequence number in XenStore. If it does > > > not match

[xen-unstable test] 181226: regressions - FAIL

2023-06-07 Thread osstest service owner
flight 181226 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 181194 Tests which are fa

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Jan Beulich
On 06.06.2023 19:23, Roger Pau Monne wrote: > --- a/xen/arch/x86/include/asm/alternative.h > +++ b/xen/arch/x86/include/asm/alternative.h > @@ -24,7 +24,9 @@ struct __packed alt_instr { > > extern void add_nops(void *insns, unsigned int len); > /* Similar to alternative_instructions except it c

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

2023-06-07 Thread Jan Beulich
On 06.06.2023 20:10, Julien Grall wrote: > On 06/06/2023 18:23, Roger Pau Monne wrote: >> --- a/xen/arch/x86/alternative.c >> +++ b/xen/arch/x86/alternative.c >> @@ -358,11 +358,12 @@ static void init_or_livepatch >> _apply_alternatives(struct alt_instr *start, >> } >> } >> >> -void ini

Re: [PATCH v2] xen: Fix incorrect taint constant

2023-06-07 Thread Jan Beulich
On 05.06.2023 13:23, Andrew Cooper wrote: > v2: > * Fix commmit message > * Update comment ahead of print_tainted() > * Change the emitted char from 'U' to 'I' Just to mention it: With this additional change I'm no longer considering this applicable to stable trees. I realize that one could arg

Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-06-07 Thread Jan Beulich
On 07.06.2023 05:02, Stewart Hildebrand wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -26,6 +26,9 @@ > #include > #include > #include > +#ifdef CONFIG_ACPI > +#include > +#endif This header is supposed to be usable without #ifdef, and then ... > @@ -228,12 +23

Re: [PATCH v1 0/8] xen/riscv: introduce identity mapping

2023-06-07 Thread Jan Beulich
On 06.06.2023 21:55, Oleksii Kurochko wrote: > The patch series introduces things necessary to implement identity mapping: > 1. Make identity mapping for _start and stack. > 2. Enable MMU. > 3. Jump to the virtual address world > 4. Remove identity mapping for _start and stack. > > Also cu

Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Christoph Hellwig
> --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -3,6 +3,20 @@ > Copyright (C) 2005 Rusty Russell > Copyright (C) 2005 XenSource Ltd > > +In addition to the Xenstore nodes required by the Xen block device > +specification, this implementation o

Re: [PATCH 1/2] xen-blkback: Implement diskseq checks

2023-06-07 Thread Christoph Hellwig
On Thu, Jun 01, 2023 at 05:48:22PM -0400, Demi Marie Obenour wrote: > + if (diskseq) { > + struct gendisk *disk = bdev->bd_disk; > + > + if (unlikely(disk == NULL)) { > + pr_err("%s: device %08x has no gendisk\n", > +__func

  1   2   >