On 07/06/2023 11:07 am, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -2628,6 +2628,9 @@ with the specified width, height and depth. >> `ask` option. (N.B menu modes are displayed in hex, so `<mode>` >> should be a hexadecimal number) >> >> +Note that all the occurrences of the vga option in the command line are >> parsed, >> +and hence later occurrences can overwrite selections done by prior ones. > I'm not a native speaker, but is it perhaps more "override" that you > mean?
I don't think this is appropriate to say in the cmdline docs. Absent bugs, all command line options get parsed left->right with latest-takes-precedence. It is a bug that vga= didn't behave like this. It might be ok to say "Note, prior to Xen 4.18, only the first instance of vga= got parsed, with subsequent instances getting ignored". Explicitly calling out the default behaviour in one option does nothing but confuse things. ~Andrew
