> -Original Message-
> From: Jan Beulich
> Sent: 25 November 2020 07:52
> To: Paul Durrant
> Cc: Durrant, Paul ; Wei Liu ; Andrew
> Cooper
> ; Roger Pau Monné ;
> xen-devel@lists.xenproject.org
> Subject: RE: [EXTERNAL] [PATCH v3 01/13] viridian: don't blindly write to
> 32-bit registe
On 24.11.2020 20:07, Paul Durrant wrote:
> From: Paul Durrant
>
> If hvm_guest_x86_mode() returns something other than 8 or 4 then
> viridian_hypercall() will return immediately but, on the way out, will write
> back status as if 'mode' was 4. This patch simply makes it leave the registers
> alon
On 24.11.2020 20:07, Paul Durrant wrote:
> From: Paul Durrant
>
> ... with macro evaluations, now that it is available.
>
> A recent patch imported the sizeof_field() macro from Linux. This patch makes
> use of it in places where the construct is currently open-coded.
>
> Signed-off-by: Paul Du
On 25.11.2020 06:23, Jürgen Groß wrote:
> On 24.11.20 17:32, Jan Beulich wrote:
>> On 24.11.2020 15:49, Jürgen Groß wrote:
>>> On 24.11.20 15:02, Jan Beulich wrote:
On 24.11.2020 08:01, Juergen Gross wrote:
> Two cpus entering evtchn_fifo_set_pending() for the same event channel
> can
flight 156987 xen-4.12-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156987/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 156635
test-amd64-amd64-xl-qcow219
On Tue, 2020-11-24 at 13:32 -0800, Kees Cook wrote:
> On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote:
> > Really, no ... something which produces no improvement has no value
> > at all ... we really shouldn't be wasting maintainer time with it
> > because it has a cost to merge. I
On 11/24/20 2:27 PM, Christoph Hellwig wrote:
Just open code the wait in the only caller of both functions.
Signed-off-by: Christoph Hellwig
---
fs/internal.h | 2 ++
fs/quota/quota.c | 31 +---
fs/super.c | 51 ++--
On 11/24/20 2:27 PM, Christoph Hellwig wrote:
Use file->f_mapping in all remaining places that have a struct file
available to properly handle the case where inode->i_mapping !=
file_inode(file)->i_mapping.
Signed-off-by: Christoph Hellwig
---
mm/filemap.c | 13 ++---
1 file changed,
On 11/24/20 2:27 PM, Christoph Hellwig wrote:
disk_get_part needs to be paired with a disk_put_part.
Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
Signed-off-by: Christoph Hellwig
Reviewed-by: Greg Kroah-Hartman
Reviewed-by: Jan Kara
Reviewed-by: Johannes Th
flight 156986 xen-4.11-testing real [real]
flight 156999 xen-4.11-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/156986/
http://logs.test-lab.xenproject.org/osstest/logs/156999/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
On 2020/11/24 21:27, Christoph Hellwig wrote:
bd_part is never NULL for a block device in use by a file system, so
remove the checks.
Signed-off-by: Christoph Hellwig
Reviewed-by: Chao Yu
Thanks,
On 2020/11/24 21:27, Christoph Hellwig wrote:
Use struct block_device to lookup partitions on a disk. This removes
all usage of struct hd_struct from the I/O path, and this allows removing
the percpu refcount in struct hd_struct.
Signed-off-by: Christoph Hellwig
---
block/bio.c
On 2020/11/24 21:27, Christoph Hellwig wrote:
Now that the hd_struct always has a block device attached to it, there is
no need for having two size field that just get out of sync.
Additional the field in hd_struct did not use proper serializiation,
possibly allowing for torn writes. By only us
On 2020/11/24 21:27, Christoph Hellwig wrote:
Store the frozen superblock in struct block_device to avoid the awkward
interface that can return a sb only used a cookie, an ERR_PTR or NULL.
Signed-off-by: Christoph Hellwig
---
drivers/md/dm-core.h | 5 -
drivers/md/dm.c | 2
On 24.11.20 18:03, Jan Beulich wrote:
Inter-domain channels can't possibly be bound to themselves, there's
always a 2nd channel involved, even when this is a loopback into the
same domain. As a result we can drop one conditional each from the two
involved functions.
With this, the number of evtc
On 24.11.20 17:32, Jan Beulich wrote:
On 24.11.2020 15:49, Jürgen Groß wrote:
On 24.11.20 15:02, Jan Beulich wrote:
On 24.11.2020 08:01, Juergen Gross wrote:
Two cpus entering evtchn_fifo_set_pending() for the same event channel
can race in case the first one gets interrupted after setting
EVT
On Tue, Nov 24, 2020 at 08:45:32PM -0800, Roman Shaposhnik wrote:
> On Tue, Nov 24, 2020 at 8:41 PM Elliott Mitchell wrote:
> >
> > On Tue, Nov 24, 2020 at 08:01:32PM -0800, Roman Shaposhnik wrote:
> > > On Tue, Nov 24, 2020 at 7:37 PM Elliott Mitchell wrote:
> > > > Presently I'm using a 5.8 ker
On Tue, Nov 24, 2020 at 8:41 PM Elliott Mitchell wrote:
>
> On Tue, Nov 24, 2020 at 08:01:32PM -0800, Roman Shaposhnik wrote:
> > On Tue, Nov 24, 2020 at 7:37 PM Elliott Mitchell wrote:
> > > Presently I'm using a 5.8 kernel with your patches and haven't seen
> > > graphical output under Xen with
On Tue, Nov 24, 2020 at 08:01:32PM -0800, Roman Shaposhnik wrote:
> On Tue, Nov 24, 2020 at 7:37 PM Elliott Mitchell wrote:
> > Presently I'm using a 5.8 kernel with your patches and haven't seen
> > graphical output under Xen with either boot stack. I've confirmed fully
> > operational graphics
Add a trivial Busybox based domU.
Signed-off-by: Stefano Stabellini
---
automation/scripts/qemu-alpine-arm64.sh | 47 ++---
1 file changed, 42 insertions(+), 5 deletions(-)
diff --git a/automation/scripts/qemu-alpine-arm64.sh
b/automation/scripts/qemu-alpine-arm64.sh
index
Use the tests-artifacts kernel, instead of the Debian kernel, for the
qemu-smoke-arm64-gcc job.
Signed-off-by: Stefano Stabellini
---
automation/gitlab-ci/test.yaml | 1 +
automation/scripts/qemu-smoke-arm64.sh | 6 --
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/aut
Create a test job that starts Xen and Dom0 on QEMU based on the alpine
linux rootfs. Use the Linux kernel and rootfs from the tests-artifacts
containers. Add the Xen tools binaries from the Alpine Linux build job.
Signed-off-by: Stefano Stabellini
---
automation/gitlab-ci/test.yaml | 24
Some tests (soon to come) will require pre-built binaries to run, such
as the Linux kernel binary. We don't want to rebuild the Linux kernel
for each gitlab-ci run: these builds should not be added to the current
list of build jobs.
Instead, create additional containers that today are built and up
Allow failure for these jobs. Currently they fail because hvmloader
doesn't build with musl. The failures don't block the pipeline.
Signed-off-by: Stefano Stabellini
---
This patch is probably required:
https://github.com/alpinelinux/aports/blob/master/main/xen/musl-hvmloader-fix-stdint.patch
--
Signed-off-by: Stefano Stabellini
---
automation/build/alpine/3.12.dockerfile | 52 +
1 file changed, 52 insertions(+)
create mode 100644 automation/build/alpine/3.12.dockerfile
diff --git a/automation/build/alpine/3.12.dockerfile
b/automation/build/alpine/3.12.dockerfi
From: Stefano Stabellini
Based on the arm64 3.12 build container
Signed-off-by: Stefano Stabellini
---
automation/gitlab-ci/build.yaml | 9 +
1 file changed, 9 insertions(+)
diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 4bd1cfc1c0..fa38c39d6a 100
From: Stefano Stabellini
The build container will be used for a new Alpine Linux 3.12 arm64 build
test.
Signed-off-by: Stefano Stabellini
---
.../build/alpine/3.12-arm64v8.dockerfile | 52 +++
1 file changed, 52 insertions(+)
create mode 100644 automation/build/alpine/3.1
QEMU upstream builds with warnings when libc is musl:
#warning redirecting incorrect #include to
Disable -Werror by passing --disable-werror to the QEMUU config script
if libc is musl.
Signed-off-by: Stefano Stabellini
---
automation/scripts/build | 5 +
1 file changed, 5 insertions(+)
In order to make available the pre-built binaries of the
automation/tests-artifacts containers to the gitlab-ci pipeline we need
to export them as gitlab artifacts.
To do that, we create two "fake" jobs that simply export the require
binaries as artifacts and do nothing else.
Signed-off-by: Stefa
Use QEMU to start Xen (just the hypervisor) up until it stops because
there is no dom0 kernel to boot.
It is based on the existing build job unstable-arm64v8.
Also use make -j$(nproc) to build Xen.
Signed-off-by: Stefano Stabellini
---
Changes in v2:
- fix x86_32 build
---
automation/gitlab-ci
Add a trivial dom0less test:
- fetch the Debian arm64 kernel and use it ad dom0/U kernel
- use busybox-static to create a trivial dom0/U ramdisk
- use ImageBuilder to generate the uboot boot script automatically
- install and use u-boot from the Debian package to start the test
- binaries are loade
Hi all,
This series does a few things:
1) it introduces a simple Xen arm64 dom0less smoke test based on QEMU
2) it introduces alpine linux builds x86 and arm64
3) it introduces two tests artifacts containers
4) it uses said artifacts to create a dom0/domU arm64 test based on QEMU
The series is v
On Tue, Nov 24, 2020 at 7:37 PM Elliott Mitchell wrote:
>
> I finally have U-Boot -> GRUB -> Xen sort-of operational as an
Yup -- same as what we're using in EVE -- we're now on the same page ;-)
> alternative to Tianocore -> GRUB -> Xen on a Raspberry PI 4B.
>
> Stefano Stabellini, how much of
I finally have U-Boot -> GRUB -> Xen sort-of operational as an
alternative to Tianocore -> GRUB -> Xen on a Raspberry PI 4B.
Stefano Stabellini, how much of the Raspberry PI 4B hardware have you
observed being operational under Linux on Xen? In particular, have you
ever observed operational graph
+ Zhiqiang Hou
On Tue, 24 Nov 2020, Leo Krueger wrote:
> > >>> On Tue, 17 Nov 2020, Leo Krueger wrote:
> > Hi,
> >
> > I enabled CONFIG_HAS_ITS (what a stupid mistake by me to not set it
> > before...) but then had to add the following node to my device tree
> >
> >
flight 156984 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156984/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 156942
test-amd64-i386-xl-qemut-win7-amd64 19
On Wed, Nov 25, 2020 at 12:53 AM Finn Thain wrote:
>
> I'm saying that supporting the official language spec makes more sense
> than attempting to support a multitude of divergent interpretations of the
> spec (i.e. gcc, clang, coverity etc.)
Making the kernel strictly conforming is a ship that s
On Mon, Nov 23, 2020 at 9:38 PM James Bottomley
wrote:
>
> So you think a one line patch should take one minute to produce ... I
> really don't think that's grounded in reality.
No, I have not said that. Please don't put words in my mouth (again).
I have said *authoring* lines of *this* kind tak
flight 156985 xen-4.10-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156985/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-arm64-arm64-xl-thunderx 3 hosts-allocate fail like 156633
test-amd64-amd64-xl-qemuu-dmrest
On Wed, 25 Nov 2020, Miguel Ojeda wrote:
>
> The C standard has nothing to do with this. We use compiler extensions
> of several kinds, for many years. Even discounting those extensions, the
> kernel is not even conforming to C due to e.g. strict aliasing. I am not
> sure what you are trying
On Tue, Nov 24, 2020 at 1:58 AM Finn Thain wrote:
>
> What I meant was that you've used pessimism as if it was fact.
"future mistakes that it might prevent" is neither pessimism nor states a fact.
> For example, "There is no way to guess what the effect would be if the
> compiler trained program
On Tue, Nov 24, 2020 at 11:24 PM Finn Thain wrote:
>
> These statements are not "missing" unless you presume that code written
> before the latest de facto language spec was written should somehow be
> held to that spec.
There is no "language spec" the kernel adheres to. Even if it did,
kernel co
Hi,
> -Ursprüngliche Nachricht-
> Von: Julien Grall
> Gesendet: Montag, 23. November 2020 19:27
> An: Leo Krueger ; Stefano Stabellini
>
> Cc: Peng Fan ; bru...@xilinx.com; Cornelia Bruelhart
> ; oleksandr_andrushche...@epam.com; xen-
> de...@lists.xenproject.org; bertrand.marq...@arm.co
On Tue, 24 Nov 2020, Kees Cook wrote:
> On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote:
> > Really, no ... something which produces no improvement has no value at
> > all ... we really shouldn't be wasting maintainer time with it because
> > it has a cost to merge. I'm not sure
On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote:
> Really, no ... something which produces no improvement has no value at
> all ... we really shouldn't be wasting maintainer time with it because
> it has a cost to merge. I'm not sure we understand where the balance
> lies in value
On Mon, Nov 23, 2020 at 05:32:51PM -0800, Nick Desaulniers wrote:
> On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote:
> >
> > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> > > If none of the 140 patches here fix a real bug, and there is no change
> > > to machine code then it so
On Tue, Nov 24, 2020 at 02:27:35PM +0100, Christoph Hellwig wrote:
> Don't play tricks with slab constructors as bdev structures tends to not
> get reused very much, and this makes the code a lot less error prone.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:34PM +0100, Christoph Hellwig wrote:
> Now that struct hd_struct has a block_device pointer use that to
> find the disk.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:33PM +0100, Christoph Hellwig wrote:
> Stop passing the whole device as a separate argument given that it
> can be trivially deducted and cleanup the !holder debug check.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
On Tue, Nov 24, 2020 at 02:27:32PM +0100, Christoph Hellwig wrote:
> Now that each hd_struct has a reference to the corresponding
> block_device, there is no need for the bd_contains pointer. Add
> a bdev_whole() helper to look up the whole device block_device
> struture instead.
>
> Signed-off-b
Hello,
Please see lkml.kernel.org/r/x708btj5njtbc...@mtj.duckdns.org for a few nits
on the previous version.
On Tue, Nov 24, 2020 at 02:27:31PM +0100, Christoph Hellwig wrote:
> To simplify block device lookup and a few other upcoming areas, make sure
> that we always have a struct block_device a
On Tue, Nov 24, 2020 at 02:27:30PM +0100, Christoph Hellwig wrote:
> Properly open the device instead of relying on deep internals by
> using get_gendisk. Note that this uses FMODE_NDELAY without either
> FMODE_READ or FMODE_WRITE, which is a special open mode to allow
> for opening without media
On Tue, Nov 24, 2020 at 02:27:29PM +0100, Christoph Hellwig wrote:
> Switch the block device lookup interfaces to directly work with a dev_t
> so that struct block_device references are only acquired by the
> blkdev_get variants (and the blk-cgroup special case). This means that
> we not don't nee
From: Paul Durrant
... with macro evaluations, now that it is available.
A recent patch imported the sizeof_field() macro from Linux. This patch makes
use of it in places where the construct is currently open-coded.
Signed-off-by: Paul Durrant
---
Cc: Jun Nakajima
Cc: Kevin Tian
Cc: Jan Beul
From: Paul Durrant
Adding the new value into the enumeration makes it immediately available
to xl, so this patch adjusts the xl.cfg(5) documentation accordingly.
Signed-off-by: Paul Durrant
---
Cc: Ian Jackson
Cc: Wei Liu
Cc: Anthony PERARD
---
docs/man/xl.cfg.5.pod.in | 8
From: Paul Durrant
To make is simpler to observe which viridian hypercalls are issued by a
particular Windows guest, this patch adds a per-domain mask to track them.
Each type of hypercall causes a different bit to be set in the mask and
when the bit transitions from clear to set, a log line is e
From: Paul Durrant
... and advertise ExProcessorMasks support if it is set.
Support is advertised by setting bit 11 in CPUID:4004:EAX.
Signed-off-by: Paul Durrant
---
Cc: Wei Liu
Cc: Jan Beulich
Cc: Andrew Cooper
Cc: "Roger Pau Monné"
Cc: George Dunlap
Cc: Ian Jackson
Cc: Julien Gral
flight 156981 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156981/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332
test-amd64-i386-xl-
From: Paul Durrant
...to set the value of the 'disable_evtchn_fifo' flag in
libxl_domain_build_info.
Signed-off-by: Paul Durrant
Signed-off-by: Eslam Elnikety
---
Cc: Ian Jackson
Cc: Wei Liu
Cc: Anthony PERARD
v4:
- New in v4
---
docs/man/xl.cfg.5.pod.in | 8
tools/xl/xl_parse.c
From: Paul Durrant
...to control setting the domain create flag XEN_DOMCTL_CDF_disable_fifo.
Signed-off-by: Paul Durrant
Signed-off-by: Eslam Elnikety
---
Cc: Ian Jackson
Cc: Wei Liu
Cc: Anthony PERARD
v4:
- New in v4
---
tools/include/libxl.h| 8
tools/libs/light/li
From: Paul Durrant
...to control the visibility of the FIFO event channel operations
(EVTCHNOP_init_control, EVTCHNOP_expand_array, and EVTCHNOP_set_priority) to
the guest.
These operations were added to the public header in commit d2d50c2f308f
("evtchn: add FIFO-based event channel ABI") and th
From: Paul Durrant
This series is the next version of what was originally a single patch sent
by Eslam Elnikety . I have re-based and slightly expanded
the modifications.
Paul Durrant (3):
domctl: introduce a new domain create flag,
XEN_DOMCTL_CDF_disable_fifo, ...
libxl: add a 'disable_
From: Paul Durrant
A previous patch introduced variants of the flush hypercalls that take a
'Virtual Processor Set' as an argument rather than a simple 64-bit mask.
This patch introduces a similar variant of the HVCALL_SEND_IPI hypercall
(HVCALL_SEND_IPI_EX).
NOTE: As with HVCALL_FLUSH_VIRTUAL_A
From: Paul Durrant
Co-locate it with the definition of offsetof() (since this is also in stddef.h
in the Linux kernel source). This macro will be needed in a subsequent patch.
Signed-off-by: Paul Durrant
Acked-by: Jan Beulich
---
Cc: Andrew Cooper
Cc: George Dunlap
Cc: Ian Jackson
Cc: Julie
From: Paul Durrant
The Microsoft Hypervisor TLFS specifies variants of the already implemented
HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE/LIST hypercalls that take a 'Virtual
Processor Set' as an argument rather than a simple 64-bit mask.
This patch adds a new hvcall_flush_ex() function to implement the
From: Paul Durrant
If hvm_guest_x86_mode() returns something other than 8 or 4 then
viridian_hypercall() will return immediately but, on the way out, will write
back status as if 'mode' was 4. This patch simply makes it leave the registers
alone.
NOTE: The formatting of the 'out' label and the s
From: Paul Durrant
vlapic_ipi() uses a softirq batching mechanism to improve the efficiency of
sending a IPIs to large number of processors. This patch modifies send_ipi()
(the worker function called by hvcall_ipi()) to also make use of the
mechanism when there multiple bits set the hypercall_vpm
From: Paul Durrant
A subsequent patch will need to IPI a mask of virtual processors potentially
wider than 64 bits. A previous patch introduced per-cpu hypercall_vpmask
to allow hvcall_flush() to deal with such wide masks. This patch modifies
the implementation of hvcall_ipi() to make use of the
From: Paul Durrant
... and make use of them in hvcall_flush()/need_flush().
Subsequent patches will need to deal with virtual processor masks potentially
wider than 64 bits. Thus, to avoid using too much stack, this patch
introduces global per-cpu virtual processor masks and converts the
impleme
From: Paul Durrant
This patch moves the implementation of HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE/LIST
that is currently inline in viridian_hypercall() into a new hvcall_flush()
function.
The new function returns Xen erro values which are then dealt with
appropriately. A return value of -ERESTART tra
From: Paul Durrant
This patch moves the implementation of HVCALL_SEND_IPI that is currently
inline in viridian_hypercall() into a new hvcall_ipi() function.
The new function returns Xen errno values similarly to hvcall_flush(). Hence
the errno translation code in viridial_hypercall() is generali
From: Paul Durrant
... plus one miscellaneous cleanup patch after introducing sizeof_field().
Paul Durrant (13):
viridian: don't blindly write to 32-bit registers is 'mode' is invalid
viridian: move flush hypercall implementation into separate function
viridian: move IPI hypercall implemen
> -Original Message-
> From: Jan Beulich
> Sent: 24 November 2020 16:56
> To: Paul Durrant
> Cc: Paul Durrant ; Wei Liu ; Andrew Cooper
> ; Roger Pau Monné ;
> xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v2 08/12] viridian: add ExProcessorMasks variants of the
> flush hypercall
Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall wrote:
>
> From: Julien Grall
>
> At the moment, xen_pt_update_entry() only supports mapping at level 3
> (i.e 4KB mapping). While this is fine for most of the runtime helper,
> the boot code will require to use superpage mapping.
>
> We don
On Tue, Nov 24, 2020 at 02:27:28PM +0100, Christoph Hellwig wrote:
> Just call devcgroup_check_permission to avoid various superflous checks
> and a double conversion of the access flags.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:27PM +0100, Christoph Hellwig wrote:
> Move more code that is only run on the outer open but not the open of
> the underlying whole device when opening a partition into blkdev_get,
> which leads to a much easier to follow structure.
>
> This allows to simplify the dis
On Tue, 24 Nov 2020, Rahul Singh wrote:
> > On 24 Nov 2020, at 11:12 am, Bertrand Marquis
> > wrote:
> >
> > On the Cortex A55, TLB entries can be allocated by a speculative AT
> > instruction. If this is happening during a guest context switch with an
> > inconsistent page table state in the gu
flight 156978 qemu-mainline real [real]
flight 156993 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/156978/
http://logs.test-lab.xenproject.org/osstest/logs/156993/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be
On Tue, Nov 24, 2020 at 02:27:26PM +0100, Christoph Hellwig wrote:
> Reorder the code to have one big section for the last close, and to use
> bdev_is_partition.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:25PM +0100, Christoph Hellwig wrote:
> Avoid a totally pointless goto label, and use the same style of
> comparism for both helpers.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
> Reviewed-by: Johannes Thumshirn
A
On Tue, Nov 24, 2020 at 02:27:24PM +0100, Christoph Hellwig wrote:
> The code in devt_from_partuuid is very convoluted. Refactor a bit by
> sanitizing the goto and variable name usage.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
Acked-by: Tej
On Tue, Nov 24, 2020 at 02:27:23PM +0100, Christoph Hellwig wrote:
> Split each case into a self-contained helper, and move the block
> dependent code entirely under the pre-existing #ifdef CONFIG_BLOCK.
> This allows to remove the blk_lookup_devt stub in genhd.h.
>
> Signed-off-by: Christoph Hell
On Tue, Nov 24, 2020 at 02:27:22PM +0100, Christoph Hellwig wrote:
> Adding the minor to the major creates tons of pointless conflicts. Just
> use the dev_t itself, which is 32-bits and thus is guaranteed to fit
> into ino_t.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
On Tue, Nov 24, 2020 at 02:27:21PM +0100, Christoph Hellwig wrote:
> Use put_device to put the device instead of poking into the internals
> and using kobject_put.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
> Reviewed-by: Johannes Thumshirn
On Tue, Nov 24, 2020 at 02:27:20PM +0100, Christoph Hellwig wrote:
> Call disk_part_iter_exit in disk_part_iter_next instead of duplicating
> the functionality.
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:19PM +0100, Christoph Hellwig wrote:
> Add a little helper to find the kobject for a struct block_device.
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:18PM +0100, Christoph Hellwig wrote:
> sector_t is now always a u64, so this check is not needed.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Tejun Heo
--
tejun
On Tue, Nov 24, 2020 at 02:27:17PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Jan Kara
> Reviewed-by: Johannes Thumshirn
Acked-by: Tejun Heo
--
tejun
Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall wrote:
>
> From: Stefano Stabellini
>
> There is no need to have a special case for CPU0 when converting the
> page-table virtual address into a physical address. The helper
> virt_to_maddr() is able to translate any address as long as the r
Inter-domain channels can't possibly be bound to themselves, there's
always a 2nd channel involved, even when this is a loopback into the
same domain. As a result we can drop one conditional each from the two
involved functions.
With this, the number of evtchn_write_lock() invocations can also be
Hello,
This is great. So much simpler & better. Some nits below.
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index a02e224115943d..0ba0bf44b88af3 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -340,12 +340,11 @@ void delete_partition(struct hd_s
On 20.11.2020 10:48, Paul Durrant wrote:
> From: Paul Durrant
>
> A previous patch introduced variants of the flush hypercalls that take a
> 'Virtual Processor Set' as an argument rather than a simple 64-bit mask.
> This patch introduces a similar variant of the HVCALL_SEND_IPI hypercall
> (HVCAL
Hi Andrew,
Thank you for the detailed explanation :).
On 24/11/2020 00:40, Andrew Cooper wrote:
On 23/11/2020 22:49, Julien Grall wrote:
Hi Jan,
On 19/11/2020 10:27, Jan Beulich wrote:
On 18.11.2020 19:09, Julien Grall wrote:
On 23/10/2020 11:19, Jan Beulich wrote:
--- a/xen/include/xen/co
On 20.11.2020 10:48, Paul Durrant wrote:
> From: Paul Durrant
>
> The Microsoft Hypervisor TLFS specifies variants of the already implemented
> HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE/LIST hypercalls that take a 'Virtual
> Processor Set' as an argument rather than a simple 64-bit mask.
>
> This patch
flight 156991 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156991/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 24.11.2020 15:49, Jürgen Groß wrote:
> On 24.11.20 15:02, Jan Beulich wrote:
>> On 24.11.2020 08:01, Juergen Gross wrote:
>>> Two cpus entering evtchn_fifo_set_pending() for the same event channel
>>> can race in case the first one gets interrupted after setting
>>> EVTCHN_FIFO_PENDING and when
On Tue, Nov 24, 2020 at 04:49:17PM +0100, Roger Pau Monné wrote:
> Could you also give a try with ioapic_ack=new on the Xen command line?
With this I still have the interrupt issue, but Xen doesn't panic on 'i'.
http://www-soc.lip6.fr/~bouyer/xen-log8.txt
--
Manuel Bouyer
NetBSD: 26 ans d'
On Tue, Nov 24, 2020 at 04:08:42PM +0100, Manuel Bouyer wrote:
> On Tue, Nov 24, 2020 at 03:52:25PM +0100, Jan Beulich wrote:
> > On 24.11.2020 15:27, Manuel Bouyer wrote:
> > > new log at
> > > http://www-soc.lip6.fr/~bouyer/xen-log7.txt
> > >
> > > this one ends up in a panic, I hope you'll find
On 24.11.20 15:59, Roger Pau Monné wrote:
On Tue, Nov 24, 2020 at 03:42:28PM +0100, Jan Beulich wrote:
On 24.11.2020 11:05, Jan Beulich wrote:
On 23.11.2020 18:39, Manuel Bouyer wrote:
On Mon, Nov 23, 2020 at 06:06:10PM +0100, Roger Pau Monné wrote:
OK, I'm afraid this is likely too verbose a
On Tue, Nov 24, 2020 at 03:59:27PM +0100, Roger Pau Monné wrote:
> [...]
>
> Sorry Manuel, you seem to have hit some kind of weird bug regarding
> interrupt management. If you want to progress further with NetBSD PVH
> dom0 it's likely to work on a different box,
the problem is, I don't have a di
1 - 100 of 216 matches
Mail list logo
