On 24.11.2020 20:07, Paul Durrant wrote: > From: Paul Durrant <pdurr...@amazon.com> > > If hvm_guest_x86_mode() returns something other than 8 or 4 then > viridian_hypercall() will return immediately but, on the way out, will write > back status as if 'mode' was 4. This patch simply makes it leave the registers > alone. > > NOTE: The formatting of the 'out' label and the switch statement are also > adjusted as per CODING_STYLE.
Partly only as far as the latter goes: > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -692,13 +692,14 @@ int viridian_hypercall(struct cpu_user_regs *regs) > break; > } > > -out: > + out: > output.result = status; > switch (mode) { This would want to be switch ( mode ) { I guess this could easily be taken care of while committing. Jan