[Xen-devel] [GIT PULL] xen: fixes and features for 5.3-rc1

2019-07-18 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.3a-rc1-tag xen: fixes and features for 5.3-rc1 It contains: - A series to introduce a common command line parameter for disabling paravirtual extensions when running as a guest i

Re: [Xen-devel] [PATCH 00/60] xen: add core scheduling support

2019-07-18 Thread Juergen Gross
On 18.07.19 17:14, Sergey Dyasli wrote: On 18/07/2019 15:48, Juergen Gross wrote: On 15.07.19 16:08, Sergey Dyasli wrote: On 05/07/2019 14:56, Dario Faggioli wrote: On Fri, 2019-07-05 at 14:17 +0100, Sergey Dyasli wrote: 1) This crash is quite likely to happen: [2019-07-04 18:22:46 UTC] (XEN

Re: [Xen-devel] [PATCH 07/60] xen/sched: build a linked list of struct sched_unit

2019-07-18 Thread Juergen Gross
On 19.07.19 02:01, Dario Faggioli wrote: On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: In order to make it easy to iterate over sched_unit elements of a domain build a single linked list and add an iterator for it. How about a ',' between domain and build? Okay. For completenes

Re: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit

2019-07-18 Thread Juergen Gross
On 19.07.19 00:52, Dario Faggioli wrote: On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: This prepares making the different schedulers vcpu agnostic. Ok, but the scheduler private data is, actually, for all the schedulers, per-vcpu scheduler data such as, for instance, struct csched2_v

Re: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu

2019-07-18 Thread Juergen Gross
On 18.07.19 19:57, Dario Faggioli wrote: On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: Allocate a struct sched_unit for each vcpu. This removes the need to have it locally on the stack in schedule.c. Signed-off-by: Juergen Gross And this patch looks ok as well. However, I don't se

Re: [Xen-devel] [PATCH 04/60] xen/sched: use new sched_unit instead of vcpu in scheduler interfaces

2019-07-18 Thread Juergen Gross
On 18.07.19 19:44, Dario Faggioli wrote: On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: In order to prepare core- and socket-scheduling use a new struct sched_unit instead of struct vcpu for interfaces of the different schedulers. Rename the per-scheduler functions insert_vcpu and remo

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: replace global limit of mapped pages by limit per call

2019-07-18 Thread Juergen Gross
On 18.07.19 19:36, Andrew Cooper wrote: On 18/07/2019 07:52, Juergen Gross wrote: Today there is a global limit of pages mapped via /dev/xen/gntdev set to 1 million pages per default. The Xen default limit even for dom0 is 1024 pages * 16 entries per page, which is far lower than this limit.

[Xen-devel] [qemu-mainline test] 139110: trouble: broken/fail/pass

2019-07-18 Thread osstest service owner
flight 139110 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/139110/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken Tests which are fai

Re: [Xen-devel] [PATCH v2] libxl_qmp: wait for completion of device removal

2019-07-18 Thread Chao Gao
On Wed, Jul 03, 2019 at 05:03:17PM +0100, Anthony PERARD wrote: >On Wed, Jul 03, 2019 at 01:56:13PM +0800, Chao Gao wrote: >> To remove a device from a domain, a qmp command is sent to qemu. But it is >> handled by qemu asychronously. Even the qmp command is claimed to be done, >> the actual handli

[Xen-devel] [xen-unstable-smoke test] 139130: tolerable all pass - PUSHED

2019-07-18 Thread osstest service owner
flight 139130 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/139130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [PATCH v3 0/9] x86: Concurrent TLB flushes

2019-07-18 Thread Nadav Amit
[ Cover-letter is identical to v2, including benchmark results, excluding the change log. ] Currently, local and remote TLB flushes are not performed concurrently, which introduces unnecessary overhead - each INVLPG can take 100s of cycles. This patch-set allows TLB flushes to be run concurrent

[Xen-devel] [PATCH v3 4/9] x86/mm/tlb: Flush remote and local TLBs concurrently

2019-07-18 Thread Nadav Amit
To improve TLB shootdown performance, flush the remote and local TLBs concurrently. Introduce flush_tlb_multi() that does so. Introduce paravirtual versions of flush_tlb_multi() for KVM, Xen and hyper-v (Xen and hyper-v are only compile-tested). While the updated smp infrastructure is capable of r

Re: [Xen-devel] [PATCH 07/60] xen/sched: build a linked list of struct sched_unit

2019-07-18 Thread Dario Faggioli
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: > In order to make it easy to iterate over sched_unit elements of a > domain build a single linked list and add an iterator for it. > How about a ',' between domain and build? > For completeness add another iterator for_each_sched_unit_vcpu()

[Xen-devel] [ovmf test] 139118: all pass - PUSHED

2019-07-18 Thread osstest service owner
flight 139118 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/139118/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3dafa0382286f00d5969b9471d4a0ab362beab11 baseline version: ovmf cce01f538fb4d6ae8c13c

[Xen-devel] [linux-linus test] 139100: regressions - trouble: blocked/broken/fail/pass

2019-07-18 Thread osstest service owner
flight 139100 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/139100/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd64-i386-qemuu-rhel6hvm-int

Re: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit

2019-07-18 Thread Dario Faggioli
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: > This prepares making the different schedulers vcpu agnostic. > Ok, but the scheduler private data is, actually, for all the schedulers, per-vcpu scheduler data such as, for instance, struct csched2_vcpu. After this patch we have (sticking

[Xen-devel] [xen-unstable test] 139104: regressions - FAIL

2019-07-18 Thread osstest service owner
flight 139104 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/139104/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 139032 Tests whic

[Xen-devel] [PATCH] golang/xenlight: Add libxl_utils support

2019-07-18 Thread George Dunlap
The Go bindings for libxl miss functions from libxl_utils, let's start with the simple libxl_domid_to_name and its counterpart libxl_name_to_domid. NB that C.GoString() will return "" if it's passed a NULL; see https://github.com/golang/go/issues/32734#issuecomment-506835432 Signed-off-by: Nicola

Re: [Xen-devel] [PATCH v2] golang/xenlight: Add libxl_utils support

2019-07-18 Thread George Dunlap
> On Jun 28, 2019, at 9:01 PM, George Dunlap wrote: > > > >> On Jun 28, 2019, at 5:32 PM, George Dunlap wrote: >> >> On 6/28/19 9:25 AM, Nicolas Belouin wrote: >>> The Go bindings for libxl miss functions from libxl_utils, let's start >>> with the simple libxl_domid_to_name and its counterp

[Xen-devel] [PATCH] golang/xenlight: Use the most generic pointer for xennoollog

2019-07-18 Thread George Dunlap
From: Nicolas Belouin It makes more sense for Ctx to contain the generic C.xentoollog_logger type, rather than the specific type we end up assigning to it. This also allows one fewer cast. Signed-off-by: Nicolas Belouin Signed-off-by: George Dunlap --- Nicolas' submitted a patch fixing casts

Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

2019-07-18 Thread George Dunlap
> On Jul 18, 2019, at 9:51 PM, George Dunlap wrote: > > > >> On Jul 18, 2019, at 7:26 PM, Rich Persaud wrote: >> >>> On Apr 25, 2019, at 07:41, George Dunlap wrote: >>> >>> On 4/25/19 12:40 PM, Jan Beulich wrote: >>> On 18.04.19 at 15:11, wrote: >> On 4/18/19 2:52 AM, Daniel P. S

Re: [Xen-devel] [PATCH 2/3] xen/trace: Implement TRACE_?D() in a more efficient fashon

2019-07-18 Thread George Dunlap
> On Jul 18, 2019, at 6:07 PM, Andrew Cooper wrote: > > These can easily be expressed with a variadic macro. No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: George Dunlap > CC: Jan Beulich > CC: Wei Liu > CC: Roger Pau Monné > > Interestingly, this results in fractiona

Re: [Xen-devel] [PATCH 3/3] xen/trace: Adjust types in function declarations

2019-07-18 Thread George Dunlap
> On Jul 18, 2019, at 6:07 PM, Andrew Cooper wrote: > > Use uint32_t consistently for 'event', bool consistently for 'cycles', > and unsigned int consistently for 'extra' > > Signed-off-by: Andrew Cooper Acked-by: George Dunlap ___ Xen-devel mai

Re: [Xen-devel] [PATCH 1/3] xen/trace: Add trace.h to MAINTAINER

2019-07-18 Thread George Dunlap
> On Jul 18, 2019, at 6:07 PM, Andrew Cooper wrote: > > ... to match the existing trace.c entry > > Reported-by: Jan Beulich > Signed-off-by: Andrew Cooper Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https:

Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

2019-07-18 Thread George Dunlap
> On Jul 18, 2019, at 7:26 PM, Rich Persaud wrote: > >> On Apr 25, 2019, at 07:41, George Dunlap wrote: >> >> On 4/25/19 12:40 PM, Jan Beulich wrote: >> On 18.04.19 at 15:11, wrote: > On 4/18/19 2:52 AM, Daniel P. Smith wrote: > This deals with two casting issues for compiling un

[Xen-devel] [libvirt test] 139109: regressions - FAIL

2019-07-18 Thread osstest service owner
flight 139109 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/139109/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 139037 build-amd64-libvirt

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 11:59 AM Andrew Cooper wrote: > > On 18/07/2019 15:43, Tamas K Lengyel wrote: > > diff --git a/CODING_STYLE b/CODING_STYLE > > index 6cc5b774cf..0b37f7ae4d 100644 > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -60,8 +60,8 @@ Bracing > > --- > > > > Braces ('{' a

Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

2019-07-18 Thread Rich Persaud
> On Apr 25, 2019, at 07:41, George Dunlap wrote: > > On 4/25/19 12:40 PM, Jan Beulich wrote: > On 18.04.19 at 15:11, wrote: On 4/18/19 2:52 AM, Daniel P. Smith wrote: This deals with two casting issues for compiling under go 1.11: - explicitly cast to *C.xentoollog_logger for

[Xen-devel] [xen-unstable-smoke test] 139123: tolerable all pass - PUSHED

2019-07-18 Thread osstest service owner
flight 139123 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/139123/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] schedule: mask out XEN_RUNSTATE_UPDATE from state entry time

2019-07-18 Thread Andrii Anisov
Hello Jan, On 18.07.19 18:04, Jan Beulich wrote: On 18.07.2019 16:12, Andrii Anisov wrote: The scenario is quite trivial: some vcpu uptdating its runstate values (e.g. context switching) while those values are being read by a guest using other vcpu. Well, that's (afaia) not an intended usage

Re: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu

2019-07-18 Thread Dario Faggioli
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: > Allocate a struct sched_unit for each vcpu. This removes the need to > have it locally on the stack in schedule.c. > > Signed-off-by: Juergen Gross > And this patch looks ok as well. However, I don't see much value in not doing what's don

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Andrew Cooper
On 18/07/2019 15:43, Tamas K Lengyel wrote: > diff --git a/CODING_STYLE b/CODING_STYLE > index 6cc5b774cf..0b37f7ae4d 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -60,8 +60,8 @@ Bracing > --- > > Braces ('{' and '}') are usually placed on a line of their own, except > -for the do/w

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 1025: The tools needs to be able to deal for_each_vcpu(...) & co. These can be made OK by adding braces. Other than that the only way I found to make it not change the indentation is to add the comment "/* *INDENT-OFF* */" before the block and "/* *INDENT-ON* */" afterwards. Tamas __

Re: [Xen-devel] [PATCH 04/60] xen/sched: use new sched_unit instead of vcpu in scheduler interfaces

2019-07-18 Thread Dario Faggioli
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: > In order to prepare core- and socket-scheduling use a new struct > sched_unit instead of struct vcpu for interfaces of the different > schedulers. > > Rename the per-scheduler functions insert_vcpu and remove_vcpu to > insert_unit and remov

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 8735: It looks like to me the tools policy is quite > inconsistent. In previous place it keeps it properly aligned see line 5777. This was also due to not allowing indentation to be more then 40 characters to the right. Overriding max-continuation-indent leaves these be. Tamas __

Re: [Xen-devel] [PATCH 1/2] xen/gntdev: replace global limit of mapped pages by limit per call

2019-07-18 Thread Andrew Cooper
On 18/07/2019 07:52, Juergen Gross wrote: > Today there is a global limit of pages mapped via /dev/xen/gntdev set > to 1 million pages per default. The Xen default limit even for dom0 is 1024 pages * 16 entries per page, which is far lower than this limit. > There is no reason why that limit is >

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 58: This is fairly common to indent the parameters as it is > today. But then on line 158/272 it indents as we do today. So I am not > sure what the expected coding style from the tools. This was due to the tool not allowing indentation to be further to the right then 40 characters. Ca

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrii Anisov
Hello Andrew, On 18.07.19 20:16, Andrew Cooper wrote: If you can come up with a suitable piece of text, I can fix up on commit. Following text might have a better reference to the current problem: Currently vunmap() is called from from xen/arch/arm/cpuerrata.c with an address potentially not

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 276: The switch case indentation was correct from Xen PoV before Removing "indent-switches" from the .astylerc actually leaves these switches untouched, so that's an easy fix. Tamas ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 139: The { are commonly on the same line as struct or definition. According to CODING_STYLE that's not how it should be. Tamas ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
>- Line 289: Files imported from Linux should not be touch here. This is just a raw dump of what happens if I run astyle on all source and header files. Obviously I won't attempt to upstream all these changes you see in the gist. Respective maintainers are welcome to use the tool if they find

Re: [Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrew Cooper
On 18/07/2019 18:11, Andrii Anisov wrote: > From: Andrii Anisov > > Let vunmap align passed virtual address by PAGE_SIZE. You probably want to describe where this goes wrong currently on ARM here. If you can come up with a suitable piece of text, I can fix up on commit. > This also makes it con

[Xen-devel] [PATCH] vunmap: let vunmap align virtual address by itself

2019-07-18 Thread Andrii Anisov
From: Andrii Anisov Let vunmap align passed virtual address by PAGE_SIZE. This also makes it consistent with how {,un}map_domain_page() currently works. With the main change, also: - strip all existing vunmap() calls from prior masking - replace opencoded PAGE_MASK macro in vm_index() Signed-

[Xen-devel] [PATCH 3/3] xen/trace: Adjust types in function declarations

2019-07-18 Thread Andrew Cooper
Use uint32_t consistently for 'event', bool consistently for 'cycles', and unsigned int consistently for 'extra' Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/include/xen/trace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

[Xen-devel] [PATCH 1/3] xen/trace: Add trace.h to MAINTAINER

2019-07-18 Thread Andrew Cooper
... to match the existing trace.c entry Reported-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8e4daae41..d18c46de91 1006

[Xen-devel] [PATCH 2/3] xen/trace: Implement TRACE_?D() in a more efficient fashon

2019-07-18 Thread Andrew Cooper
These can easily be expressed with a variadic macro. No functional change. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné Interestingly, this results in fractionally different (but equally correct) code generation in vlapic_update_timer().

[Xen-devel] [PATCH 0/3] xen/trace: Misc improvements

2019-07-18 Thread Andrew Cooper
Misc fixes/improvements to trace.h noticed during the build fix for !CONFIG_TRACEBUFFER Andrew Cooper (3): xen/trace: Add trace.h to MAINTAINER xen/trace: Implement TRACE_?D() in a more efficient fashon xen/trace: Adjust types in function declarations MAINTAINERS | 1 + xen/i

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 05:12:54PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Jul 18, 2019 at 11:29:39AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote: > > > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > > >

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 03:17:27PM +, Jan Beulich wrote: > On 18.07.2019 15:46, Roger Pau Monné wrote: > > In fact I don't think INTx should be enabled when MSI(-X) is disabled, > > QEMU already traps writes to the command register, and it will manage > > INTx enabling/disabling by itself. I t

Re: [Xen-devel] [PATCH 00/60] xen: add core scheduling support

2019-07-18 Thread Dario Faggioli
On Thu, 2019-07-18 at 16:14 +0100, Sergey Dyasli wrote: > On 18/07/2019 15:48, Juergen Gross wrote: > > > > I can easily reproduce the issue with any PV guest with more than 1 > > vcpu > > by doing "xl save" and then "xl restore" again. > > > > With the reproducer being available I'm now diving i

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Andrii Anisov
On 18.07.19 17:20, Julien Grall wrote: As Andrew pointed out, this also makes the interface more consistent with how {,un}map_domain_page() currently works. OK, got it. BTW, in the x86 code they do apply PAGE_MASK to va before passing it to `vunmap()`. I would cleanup all those places as w

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Julien Grall
Hi Tamas, On 7/18/19 4:14 PM, Tamas K Lengyel wrote: On Thu, Jul 18, 2019 at 9:02 AM Julien Grall wrote: Hi Tamas, Adding Lars, Artem and Iurii. Iurii has been working on a version for clang-format recently. On 7/18/19 3:43 PM, Tamas K Lengyel wrote: Using astyle (http://astyle.sourceforge

Re: [Xen-devel] printf formatter for pci_sbdf_t

2019-07-18 Thread Jan Beulich
On 18.07.2019 17:14, Roger Pau Monné wrote: > On Thu, Jul 18, 2019 at 11:51:57AM +, Jan Beulich wrote: >> On 17.07.2019 19:06, Andrew Cooper wrote: >>> On 17/07/2019 15:08, Roger Pau Monné wrote: As part of some PCI related cleanup I'm doing, which includes expanding the usage of pci

Re: [Xen-devel] [PATCH] x86emul: Ignore ssse3-{aes, pclmul}.[hc] as well

2019-07-18 Thread Jan Beulich
On 18.07.2019 17:11, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich I'm sorry for not having paid attention when adding these. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailm

Re: [Xen-devel] [PATCH] xen/trace: Adjust types in trace_var() declarations

2019-07-18 Thread Jan Beulich
On 18.07.2019 16:00, Andrew Cooper wrote: > Use bool rather than int/bool_t for 'cycles' to match the !CONFIG_TRACEBUFFER > version, and use unsigned int rather than int for 'extra' to match the > function it is forwarded to. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich albeit I'd hav

Re: [Xen-devel] [PATCH] xen/trace: Fix build with !CONFIG_TRACEBUFFER

2019-07-18 Thread Jan Beulich
On 18.07.2019 16:00, Andrew Cooper wrote: > GCC reports: > > In file included from hvm.c:24:0: > /local/xen.git/xen/include/xen/trace.h: In function ‘tb_control’: > /local/xen.git/xen/include/xen/trace.h:60:13: error: ‘ENOSYS’ > undeclared (first use in this function) > return -ENOSYS; >

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:46, Roger Pau Monné wrote: > In fact I don't think INTx should be enabled when MSI(-X) is disabled, > QEMU already traps writes to the command register, and it will manage > INTx enabling/disabling by itself. I think the only check required is > that MSI(-X) cannot be enabled if I

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 9:14 AM Jan Beulich wrote: > > On 18.07.2019 16:43, Tamas K Lengyel wrote: > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -60,8 +60,8 @@ Bracing > > --- > > > > Braces ('{' and '}') are usually placed on a line of their own, except > > -for the do/while loop.

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 9:02 AM Julien Grall wrote: > > Hi Tamas, > > Adding Lars, Artem and Iurii. Iurii has been working on a version for > clang-format recently. > > On 7/18/19 3:43 PM, Tamas K Lengyel wrote: > > Using astyle (http://astyle.sourceforge.net) can greatly reduce the > > overhead

Re: [Xen-devel] printf formatter for pci_sbdf_t

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 11:51:57AM +, Jan Beulich wrote: > On 17.07.2019 19:06, Andrew Cooper wrote: > > On 17/07/2019 15:08, Roger Pau Monné wrote: > >> As part of some PCI related cleanup I'm doing, which includes > >> expanding the usage of pci_sbdf_t, I'm also planning to add a custom > >>

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Jan Beulich
On 18.07.2019 16:43, Tamas K Lengyel wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -60,8 +60,8 @@ Bracing > --- > > Braces ('{' and '}') are usually placed on a line of their own, except > -for the do/while loop. This is unlike the Linux coding style and > -unlike K&R. do/while

Re: [Xen-devel] [PATCH 00/60] xen: add core scheduling support

2019-07-18 Thread Sergey Dyasli
On 18/07/2019 15:48, Juergen Gross wrote: > On 15.07.19 16:08, Sergey Dyasli wrote: >> On 05/07/2019 14:56, Dario Faggioli wrote: >>> On Fri, 2019-07-05 at 14:17 +0100, Sergey Dyasli wrote: 1) This crash is quite likely to happen: [2019-07-04 18:22:46 UTC] (XEN) [ 3425.220660] Watchd

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-18 Thread Marek Marczykowski-Górecki
On Thu, Jul 18, 2019 at 11:29:39AM +0200, Roger Pau Monné wrote: > On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote: > > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki > > > wrote

[Xen-devel] [PATCH] x86emul: Ignore ssse3-{aes, pclmul}.[hc] as well

2019-07-18 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 8a19c8af04..3c947ac948 100644 --- a/.gitignore +++ b/.gitignore @@ -233,7 +233,7 @@ tools/tests/x86_

Re: [Xen-devel] [PATCH] schedule: mask out XEN_RUNSTATE_UPDATE from state entry time

2019-07-18 Thread Jan Beulich
On 18.07.2019 16:12, Andrii Anisov wrote: > On 18.07.19 14:10, Jan Beulich wrote: >> A concrete scenario where update_runstate_area() and vcpu_runstate_change() >> can actually race would be very worthwhile to point out here. In particular >> on Arm I'm not (yet?) seeing how this could happen. > >

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Julien Grall
Hi Tamas, Adding Lars, Artem and Iurii. Iurii has been working on a version for clang-format recently. On 7/18/19 3:43 PM, Tamas K Lengyel wrote: Using astyle (http://astyle.sourceforge.net) can greatly reduce the overhead of manually checking and applying style-fixes to source-code. The incl

[Xen-devel] [linux-4.19 test] 139094: regressions - FAIL

2019-07-18 Thread osstest service owner
flight 139094 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/139094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 6 kernel-build fail REGR. vs. 129313 Tests which did not

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 8:47 AM Jan Beulich wrote: > > On 18.07.2019 16:35, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 8:28 AM Jan Beulich wrote: > >> On 18.07.2019 15:47, Tamas K Lengyel wrote: > >>> I feel like we are going in circles and having the same conversations > >>> over and ove

Re: [Xen-devel] [PATCH v2 07/10] vm_event: Add vm_event_ng interface

2019-07-18 Thread Petre Ovidiu PIRCALABU
On Thu, 2019-07-18 at 14:44 +, Jan Beulich wrote: > On 18.07.2019 15:59, Petre Ovidiu PIRCALABU wrote: > > Before using xenforeignmemory_map_resource I investigated several > > different approaches: > > - Allocate the memory in hypervisor and xc_map_foreign_pages > > (doesn't > > work because y

Re: [Xen-devel] [PATCH 00/60] xen: add core scheduling support

2019-07-18 Thread Juergen Gross
On 15.07.19 16:08, Sergey Dyasli wrote: On 05/07/2019 14:56, Dario Faggioli wrote: On Fri, 2019-07-05 at 14:17 +0100, Sergey Dyasli wrote: 1) This crash is quite likely to happen: [2019-07-04 18:22:46 UTC] (XEN) [ 3425.220660] Watchdog timer detects that CPU2 is stuck! [2019-07-04 18:22:46 UTC

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Jan Beulich
On 18.07.2019 16:35, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 8:28 AM Jan Beulich wrote: >> On 18.07.2019 15:47, Tamas K Lengyel wrote: >>> I feel like we are going in circles and having the same conversations >>> over and over without really making any headway. You introduced >>> grabbing

Re: [Xen-devel] [PATCH v2 07/10] vm_event: Add vm_event_ng interface

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:59, Petre Ovidiu PIRCALABU wrote: > Before using xenforeignmemory_map_resource I investigated several > different approaches: > - Allocate the memory in hypervisor and xc_map_foreign_pages (doesn't > work because you cannot "foreignmap" pages of your own domain. > - Allocate the me

[Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

2019-07-18 Thread Tamas K Lengyel
Using astyle (http://astyle.sourceforge.net) can greatly reduce the overhead of manually checking and applying style-fixes to source-code. The included .astylerc is the closest approximation of the established Xen style (including styles not formally spelled out by CODING_STYLE but commonly request

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 8:28 AM Jan Beulich wrote: > > On 18.07.2019 15:47, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:33 AM Jan Beulich wrote: > >> > >> On 18.07.2019 15:13, Tamas K Lengyel wrote: > >>> On Thu, Jul 18, 2019 at 7:12 AM Jan Beulich wrote: > > On 18.07.2019 14:

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:47, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 7:33 AM Jan Beulich wrote: >> >> On 18.07.2019 15:13, Tamas K Lengyel wrote: >>> On Thu, Jul 18, 2019 at 7:12 AM Jan Beulich wrote: On 18.07.2019 14:55, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 4:47 AM Jan

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Julien Grall
On 7/18/19 3:08 PM, Andrii Anisov wrote: Hello Julien, Hi, On 18.07.19 16:44, Julien Grall wrote: My suggestion about vunmap() still stands though. +1 for the vunmap solution. It was my initial idea. But, the issue is introduced by change 9cc0618. In particular, by the check in `xen_pt

Re: [Xen-devel] [PATCH] schedule: mask out XEN_RUNSTATE_UPDATE from state entry time

2019-07-18 Thread Andrii Anisov
Hello Jan, On 18.07.19 14:10, Jan Beulich wrote: Considering the value of XEN_RUNSTATE_UPDATE it must be a rather rare race anyway, I would guess. I'm not sure about the exact rate of the race, but with following prints: diff --git a/xen/common/schedule.c b/xen/common/schedule.c index 25f6ab3

Re: [Xen-devel] [PATCH] schedule: mask out XEN_RUNSTATE_UPDATE from state entry time

2019-07-18 Thread Andrii Anisov
Hello Jan, On 18.07.19 14:10, Jan Beulich wrote: A concrete scenario where update_runstate_area() and vcpu_runstate_change() can actually race would be very worthwhile to point out here. In particular on Arm I'm not (yet?) seeing how this could happen. The scenario is quite trivial: some vcpu

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:52 AM Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:37 AM Jan Beulich wrote: > > > > On 18.07.2019 15:16, Tamas K Lengyel wrote: > > > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > > >> > > >> On 18.07.2019 14:59, Tamas K Lengyel wrote: > > >>> On Thu, Jul

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Andrii Anisov
Hello Julien, On 18.07.19 16:44, Julien Grall wrote: My suggestion about vunmap() still stands though. +1 for the vunmap solution. It was my initial idea. But, the issue is introduced by change 9cc0618. In particular, by the check in `xen_pt_update()` if ( !IS_ALIGNED(virt, PAGE_SIZE)

[Xen-devel] [PATCH] xen/trace: Adjust types in trace_var() declarations

2019-07-18 Thread Andrew Cooper
Use bool rather than int/bool_t for 'cycles' to match the !CONFIG_TRACEBUFFER version, and use unsigned int rather than int for 'extra' to match the function it is forwarded to. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Stefano Stabellini CC: Tim D

[Xen-devel] [PATCH] xen/trace: Fix build with !CONFIG_TRACEBUFFER

2019-07-18 Thread Andrew Cooper
GCC reports: In file included from hvm.c:24:0: /local/xen.git/xen/include/xen/trace.h: In function ‘tb_control’: /local/xen.git/xen/include/xen/trace.h:60:13: error: ‘ENOSYS’ undeclared (first use in this function) return -ENOSYS; ^~ Include xen/errno.h to resolve the issue.

Re: [Xen-devel] [PATCH v2 07/10] vm_event: Add vm_event_ng interface

2019-07-18 Thread Petre Ovidiu PIRCALABU
On Wed, 2019-07-17 at 16:32 +, Jan Beulich wrote: > On 17.07.2019 16:41, Petre Ovidiu PIRCALABU wrote: > > On Wed, 2019-07-17 at 10:06 +, Jan Beulich wrote: > > > On 16.07.2019 19:06, Petre Pircalabu wrote: > > > > +static void vm_event_channels_free_buffer(struct > > > > vm_event_channels_

Re: [Xen-devel] [PATCH v5 6/6] tools/libxc: add wrapper for PHYSDEVOP_msi_control

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 02:12:20AM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 17, 2019 at 12:21:58PM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 03:00:44AM +0200, Marek Marczykowski-Górecki wrote: > > > Add libxc wrapper for PHYSDEVOP_msi_control introduced in previous > >

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:37 AM Jan Beulich wrote: > > On 18.07.2019 15:16, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > >> > >> On 18.07.2019 14:59, Tamas K Lengyel wrote: > >>> On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: > > On 17.07.2019 21:

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemut-rhel6hvm-intel

2019-07-18 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemut-rhel6hvm-intel testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.gi

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:33 AM Jan Beulich wrote: > > On 18.07.2019 15:13, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 7:12 AM Jan Beulich wrote: > >> > >> On 18.07.2019 14:55, Tamas K Lengyel wrote: > >>> On Thu, Jul 18, 2019 at 4:47 AM Jan Beulich wrote: > On 17.07.2019 21:33, Tam

Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 01:54:26AM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 17, 2019 at 12:18:43PM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 03:00:43AM +0200, Marek Marczykowski-Górecki wrote: > > > Allow device model running in stubdomain to enable/disable MSI(-X), >

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Julien Grall
Hi, On 7/18/19 2:43 PM, Andrew Cooper wrote: On 18/07/2019 14:38, Andrew Cooper wrote: On 18/07/2019 14:22, Andrii Anisov wrote: From: Andrii Anisov After changes introduced by 9cc0618 we are able to vmap/vunmap page aligned addresses only. So if we add a page address remainder to the mapped

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Andrew Cooper
On 18/07/2019 14:38, Andrew Cooper wrote: > On 18/07/2019 14:22, Andrii Anisov wrote: >> From: Andrii Anisov >> >> After changes introduced by 9cc0618 we are able to vmap/vunmap >> page aligned addresses only. >> So if we add a page address remainder to the mapped virtual address, >> we have to ma

Re: [Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Andrew Cooper
On 18/07/2019 14:22, Andrii Anisov wrote: > From: Andrii Anisov > > After changes introduced by 9cc0618 we are able to vmap/vunmap > page aligned addresses only. > So if we add a page address remainder to the mapped virtual address, > we have to mask it out before unmapping. > > Signed-off-by: And

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:16, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: >> >> On 18.07.2019 14:59, Tamas K Lengyel wrote: >>> On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: On 17.07.2019 21:33, Tamas K Lengyel wrote: > @@ -136,8 +137,8 @@ static inline b

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Jan Beulich
On 18.07.2019 15:13, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 7:12 AM Jan Beulich wrote: >> >> On 18.07.2019 14:55, Tamas K Lengyel wrote: >>> On Thu, Jul 18, 2019 at 4:47 AM Jan Beulich wrote: On 17.07.2019 21:33, Tamas K Lengyel wrote: > @@ -900,6 +895,7 @@ static int share_pag

[Xen-devel] [PATCH] arm:cpuerrata: Align a virtual address before unmap

2019-07-18 Thread Andrii Anisov
From: Andrii Anisov After changes introduced by 9cc0618 we are able to vmap/vunmap page aligned addresses only. So if we add a page address remainder to the mapped virtual address, we have to mask it out before unmapping. Signed-off-by: Andrii Anisov --- xen/arch/arm/cpuerrata.c | 2 +- 1 file

Re: [Xen-devel] [PATCH] xen/arm: remove unused dt_device_node parameter

2019-07-18 Thread Viktor Mitin
Hi Julien, I've checked latest Xen staging, the patch has not been integrated yet. Please integrate the patch if no objections. Thanks On Mon, Jul 8, 2019 at 3:12 PM Julien Grall wrote: > > Hi Viktor, > > On 6/18/19 9:58 AM, Viktor Mitin wrote: > > Some of the function generating nodes (e.g mak

Re: [Xen-devel] [PATCH 1/2] x86/cpu/intel: Clear cache self-snoop capability in CPUs with known errata

2019-07-18 Thread Andrew Cooper
On 18/07/2019 14:07, Jan Beulich wrote: > On 18.07.2019 14:23, Andrew Cooper wrote: >> On 18/07/2019 13:09, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpu/intel.c >>> +++ b/xen/arch/x86/cpu/intel.c >>> @@ -15,6 +15,32 @@ >>>#include "cpu.h" >>> >>>/* >>> + * Processors which have self-sn

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:14 AM Jan Beulich wrote: > > On 18.07.2019 14:59, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: > >> > >> On 17.07.2019 21:33, Tamas K Lengyel wrote: > >>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) > >>>

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Tamas K Lengyel
On Thu, Jul 18, 2019 at 7:12 AM Jan Beulich wrote: > > On 18.07.2019 14:55, Tamas K Lengyel wrote: > > On Thu, Jul 18, 2019 at 4:47 AM Jan Beulich wrote: > >> On 17.07.2019 21:33, Tamas K Lengyel wrote: > >>> @@ -900,6 +895,7 @@ static int share_pages(struct domain *sd, gfn_t sgfn, > >>> shr_han

Re: [Xen-devel] [PATCH v6 5/5] x86/mem_sharing: style cleanup

2019-07-18 Thread Jan Beulich
On 18.07.2019 14:59, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich wrote: >> >> On 17.07.2019 21:33, Tamas K Lengyel wrote: >>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) >>>cpu_relax(); >>>nx = x + (1 | PGT_locked);

Re: [Xen-devel] [PATCH v6 1/5] x86/mem_sharing: reorder when pages are unlocked and released

2019-07-18 Thread Jan Beulich
On 18.07.2019 14:55, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 4:47 AM Jan Beulich wrote: >> On 17.07.2019 21:33, Tamas K Lengyel wrote: >>> @@ -900,6 +895,7 @@ static int share_pages(struct domain *sd, gfn_t sgfn, >>> shr_handle_t sh, >>>p2m_type_t smfn_type, cmfn_type; >>>

  1   2   >