On 18.07.2019 14:59, Tamas K Lengyel wrote: > On Thu, Jul 18, 2019 at 4:56 AM Jan Beulich <jbeul...@suse.com> wrote: >> >> On 17.07.2019 21:33, Tamas K Lengyel wrote: >>> @@ -136,8 +137,8 @@ static inline bool _page_lock(struct page_info *page) >>> cpu_relax(); >>> nx = x + (1 | PGT_locked); >>> if ( !(x & PGT_validated) || >>> - !(x & PGT_count_mask) || >>> - !(nx & PGT_count_mask) ) >>> + !(x & PGT_count_mask) || >>> + !(nx & PGT_count_mask) ) >>> return false; >>> } while ( cmpxchg(&page->u.inuse.type_info, x, nx) != x ); >> >> Aren't you screwing up indentation here? It looks wrong both in my >> mail client's view and on the list archives, whereas. Furthermore >> this is code you've introduced earlier in the series, so it should >> be got right there, not here. > > The style was auto-applied with astyle using the bsd format. In the > previous patch there were no style-changes applied because it was a > copy-paste job from the other code location. I rather keep > code-copying and style fixes separate.
But you're actively breaking Xen style here (and below). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
