On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote: > This prepares making the different schedulers vcpu agnostic. > Ok, but the scheduler private data is, actually, for all the schedulers, per-vcpu scheduler data such as, for instance, struct csched2_vcpu.
After this patch we have (sticking to Credit2 as an example) csched2_vcpu allocated by a function called csched2_alloc_vdata() but stored on a per-sched_unit basis. Similarly, we have an accessor method called csched2_vcpu() which returns the struct csched2_vcpu which was stored in the per-unit private space. But shouldn't then the struct be called csched2_unit, and cited functions be called csched2_alloc_udata() and csched2_unit()? Now, I know that these transformation happen later in the series. And, this time, I'm not asking to consolidate the patches. However: - can the changelog of this patch be a little more explicit, not only informing that this is a preparatory patch, but also explaining briefly the temporary inconcistency - could the patches that deal with this be grouped together, so that they are close to each other in the series (e.g., this patch, the renaming hunks of patch 10 and patches that are currently 20 to 24)? Or are there dependencies that I am not considering? Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
