[Xen-devel] [distros-debian-sid test] 66555: tolerable trouble: blocked/broken

2016-07-11 Thread Platform Team regression test user
flight 66555 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66555/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 66516 build-armhf

Re: [Xen-devel] [PATCH] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Roger Pau Monné
On Sun, Jul 10, 2016 at 07:35:47PM +0200, Marek Marczykowski-Górecki wrote: > When this daemon is started after creating backend device, that device > will not be configured. > > Racy situation: > 1. driver domain is started > 2. frontend domain is started (just after kicking driver domain off) >

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

2016-07-11 Thread Evgenii Shatokhin
On 06.06.2016 11:42, Dario Faggioli wrote: Just Cc-ing some Linux, block, and Xen on CentOS people... Ping. Any suggestions how to debug this or what might cause the problem? Obviously, we cannot control Xen on the Amazon's servers. But perhaps there is something we can do at the kernel's s

Re: [Xen-devel] [PATCH] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Marek Marczykowski-Górecki
On Mon, Jul 11, 2016 at 10:31:17AM +0200, Roger Pau Monné wrote: > On Sun, Jul 10, 2016 at 07:35:47PM +0200, Marek Marczykowski-Górecki wrote: > > When this daemon is started after creating backend device, that device > > will not be configured. > > > > Racy situation: > > 1. driver domain is star

[Xen-devel] [libvirt test] 97003: tolerable FAIL - PUSHED

2016-07-11 Thread osstest service owner
flight 97003 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/97003/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 12 migrate-sup

Re: [Xen-devel] [PATCH v2] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

2016-07-11 Thread Andre Przywara
Hi Dirk, On 08/07/16 12:38, Dirk Behme wrote: > Hi Andre, > > On 05.07.2016 16:29, Andre Przywara wrote: >> Hi, >> >> On 05/07/16 15:22, Dirk Behme wrote: >>> On 05.07.2016 15:45, Andre Przywara wrote: Hi, On 05/07/16 14:34, Julien Grall wrote: > (CC Andre) > > On 05/07

Re: [Xen-devel] Question about xen event channel

2016-07-11 Thread David Vrabel
On 11/07/16 04:58, 소병철 wrote: > Hello everyone :) > > > > I have a question about xen event channel. Is it possible to allocate > two event channels in one xen frontend driver? Yes. For example, netif can have a separate Tx and Rx event channel. David ___

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 04:51, Bin Wu wrote: > During scsi command queueing, if mapping data fails, we need to > reclaim the failed request. Otherwise, the garbage request will > be pushed into the ring for the backend to work. Well spotted. There is another instance of this problem in scsifront_action_handle

Re: [Xen-devel] [PATCH] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Roger Pau Monné
On Mon, Jul 11, 2016 at 10:56:04AM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Jul 11, 2016 at 10:31:17AM +0200, Roger Pau Monné wrote: > > On Sun, Jul 10, 2016 at 07:35:47PM +0200, Marek Marczykowski-Górecki wrote: > > > When this daemon is started after creating backend device, that device

Re: [Xen-devel] [PATCHv3 1/2] libfs: allow simple_fill_super() to add symlinks

2016-07-11 Thread David Vrabel
On 28/06/16 19:06, David Vrabel wrote: > simple_fill_super() will add symlinks if an entry has mode & S_IFLNK. > The target is provided in the new "link" field. Can I get an ack for this, please? So it can go into 4.8 via the Xen tree. David > > Signed-off-by: David Vrabel > --- > v2: > - simp

Re: [Xen-devel] [PATCH] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Marek Marczykowski-Górecki
On Mon, Jul 11, 2016 at 11:43:18AM +0200, Roger Pau Monné wrote: > On Mon, Jul 11, 2016 at 10:56:04AM +0200, Marek Marczykowski-Górecki wrote: > > On Mon, Jul 11, 2016 at 10:31:17AM +0200, Roger Pau Monné wrote: > > > On Sun, Jul 10, 2016 at 07:35:47PM +0200, Marek Marczykowski-Górecki > > > wrote

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread David Vrabel
On 11/07/16 10:33, Juergen Gross wrote: > On 11/07/16 04:51, Bin Wu wrote: >> During scsi command queueing, if mapping data fails, we need to >> reclaim the failed request. Otherwise, the garbage request will >> be pushed into the ring for the backend to work. > > Well spotted. There is another in

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 11:50, David Vrabel wrote: > On 11/07/16 10:33, Juergen Gross wrote: >> On 11/07/16 04:51, Bin Wu wrote: >>> During scsi command queueing, if mapping data fails, we need to >>> reclaim the failed request. Otherwise, the garbage request will >>> be pushed into the ring for the backend to

Re: [Xen-devel] [PATCH] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Roger Pau Monné
On Mon, Jul 11, 2016 at 11:49:19AM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Jul 11, 2016 at 11:43:18AM +0200, Roger Pau Monné wrote: > > On Mon, Jul 11, 2016 at 10:56:04AM +0200, Marek Marczykowski-Górecki wrote: > > > On Mon, Jul 11, 2016 at 10:31:17AM +0200, Roger Pau Monné wrote: > > >

Re: [Xen-devel] [PATCH v2] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

2016-07-11 Thread Dirk Behme
Hi, On 11.07.2016 11:25, Andre Przywara wrote: Hi Dirk, On 08/07/16 12:38, Dirk Behme wrote: Hi Andre, On 05.07.2016 16:29, Andre Przywara wrote: Hi, On 05/07/16 15:22, Dirk Behme wrote: On 05.07.2016 15:45, Andre Przywara wrote: Hi, On 05/07/16 14:34, Julien Grall wrote: (CC Andre) On

Re: [Xen-devel] [PATCH 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:25:13PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 2/7] tools/helper: honour XEN_RUN_DIR in > init-xenstore-domain.c"): > > Place the PID file under XEN_RUN_DIR. Note that this change the default > > location from /var/run to /var/run/xen. > > > > Generate a _p

Re: [Xen-devel] [PATCH 6/7] libxenstat: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:27:28PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 6/7] libxenstat: honour XEN_RUN_DIR"): > > This is because libxl uses XEN_RUN_DIR to generate the socket path for > > libxenstat while libxenstat itself uses hard-coded path, which is not > > necessary in sync wi

Re: [Xen-devel] [PATCH 7/7] oxenstored: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:28:40PM +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH 7/7] oxenstored: honour XEN_RUN_DIR"): > > Wei Liu writes ("[PATCH 7/7] oxenstored: honour XEN_RUN_DIR"): > > > Move default the pid file under XEN_RUN_DIR. Note that it changes the > > > location from /v

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

2016-07-11 Thread George Dunlap
On Mon, Jul 11, 2016 at 9:50 AM, Evgenii Shatokhin wrote: > On 06.06.2016 11:42, Dario Faggioli wrote: >> >> Just Cc-ing some Linux, block, and Xen on CentOS people... >> > > Ping. > > Any suggestions how to debug this or what might cause the problem? > > Obviously, we cannot control Xen on the Am

[Xen-devel] [PATCH v2] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Marek Marczykowski-Górecki
When this daemon is started after creating backend device, that device will not be configured. Racy situation: 1. driver domain is started 2. frontend domain is started (just after kicking driver domain off) 3. device in frontend domain is connected to the backend (as specified in frontend doma

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > On 07/08/2016 12:07 PM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 06:55 AM, Wei Liu wrote: > + > +/* Map page that will hold RSDP */ > +extent = RSD

Re: [Xen-devel] [PATCH v2 0/4] libxl: add framework for device types

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:54:54PM +0100, Ian Jackson wrote: > Juergen Gross writes ("[PATCH v2 0/4] libxl: add framework for device types"): > > Instead of duplicate coding for each device type (vtpms, usbctrls, ...) > > especially on domain creation introduce a framework for that purpose. > > >

Re: [Xen-devel] [PATCH v2] libxl: trigger attach events for devices attached before xl devd startup

2016-07-11 Thread Roger Pau Monné
On Mon, Jul 11, 2016 at 12:44:42PM +0200, Marek Marczykowski-Górecki wrote: > When this daemon is started after creating backend device, that device > will not be configured. > > Racy situation: > 1. driver domain is started > 2. frontend domain is started (just after kicking driver domain off) >

Re: [Xen-devel] [DRAFT 1] XenSock protocol design document

2016-07-11 Thread Stefano Stabellini
On Fri, 8 Jul 2016, David Vrabel wrote: > On 08/07/16 12:23, Stefano Stabellini wrote: > > > > XenSocks provides the following benefits: > > * guest networking works out of the box with VPNs, wireless networks and > > any other complex configurations on the host > > Only in the trivial case whe

Re: [Xen-devel] [PATCH v3 1/5] libxl: libxl_domain_need_memory shouldn't modify b_info

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:35:59PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v3 1/5] libxl: libxl_domain_need_memory shouldn't > modify b_info"): > > This function is used to return the memory needed for a guest. It's not > > in a position to modify the b_info passed in (note the _setdef

[Xen-devel] [xen-unstable test] 96993: tolerable FAIL

2016-07-11 Thread osstest service owner
flight 96993 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/96993/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-xsm 7 host-ping-check-xen fail in 96893 pass in 96993 test-amd64-amd64-i386-pvgrub 18 gu

Re: [Xen-devel] [PATCH v3 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:44:28PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v3 4/5] libxl: update vcpus bitmap in retrieved guest > config"): > > ... because the available vcpu bitmap can change during domain life time > > due to cpu hotplug and unplug. > > > > For QEMU upstream, we in

Re: [Xen-devel] [PATCH v3 5/5] libxl: only issue cpu-add call to QEMU for not present CPU

2016-07-11 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:48:27PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v3 5/5] libxl: only issue cpu-add call to QEMU for > not present CPU"): > > Calculate the final bitmap for CPUs to add to avoid having annoying > > error messages complaining those CPUs are already present. > >

Re: [Xen-devel] [PATCH 3/8] x86/time: introduce and use rdtsc_ordered()

2016-07-11 Thread Dario Faggioli
On Mon, 2016-06-20 at 13:59 +0100, Andrew Cooper wrote: > On 15/06/16 11:27, Jan Beulich wrote: > > Matching Linux commit 03b9730b76 ("x86/asm/tsc: Add rdtsc_ordered() > > and > > use it in trivial call sites") and earlier ones it builds upon, > > let's > > make sure timing loops don't have their r

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

2016-07-11 Thread Bob Liu
On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote: > On 06.06.2016 11:42, Dario Faggioli wrote: >> Just Cc-ing some Linux, block, and Xen on CentOS people... >> > > Ping. > > Any suggestions how to debug this or what might cause the problem? > > Obviously, we cannot control Xen on the Amazon's s

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Wei Liu
CC Lars More licence stuff. Do you have contact(s)? Wei. On Fri, Jul 08, 2016 at 11:57:59AM -0400, Boris Ostrovsky wrote: > On 07/08/2016 11:50 AM, Ian Jackson wrote: > > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH v1 02/20] > > acpi/hvmloader: Move acpi_info initialization out of ACP

Re: [Xen-devel] monitor access to pages with a specific p2m_type_t

2016-07-11 Thread sepanta s
On Sun, Jul 10, 2016 at 4:50 PM, sepanta s wrote: > > > On Sun, Jun 26, 2016 at 5:15 PM, sepanta s wrote: > >> >> >> >> On Fri, Jun 24, 2016 at 8:10 PM, Tamas K Lengyel >> wrote: >> >>> >>> On Jun 24, 2016 05:19, "Razvan Cojocaru" >>> wrote: >>> > >>> > On 06/24/2016 02:05 PM, George Dunlap wr

[Xen-devel] [patch 52/66] arm: xen: Convert to hotplug state machine

2016-07-11 Thread Anna-Maria Gleixner
From: Richard Cochran Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. The get_cpu() in xen_starting_cpu() boils down to preempt_disable() since we already know the CPU we run on. Disabling preemption shouldn't be required here from wha

[Xen-devel] [ovmf test] 96996: regressions - FAIL

2016-07-11 Thread osstest service owner
flight 96996 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/96996/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-i386-

Re: [Xen-devel] [DRAFT 1] XenSock protocol design document

2016-07-11 Thread Paul Durrant
> -Original Message- [snip] > > # XenSocks Protocol v1 > > ## Rationale > > XenSocks is a paravirtualized protocol for the POSIX socket API. > > The purpose of XenSocks is to allow the implementation of a specific set > of POSIX calls to be done in a domain other than your own. It allow

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 06:47 AM, Wei Liu wrote: > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: >> On 07/08/2016 12:07 PM, Wei Liu wrote: >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: On 07/08/2016 06:55 AM, Wei Liu wrote: >> + >> +/* Map page that

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Julien Grall
On 11/07/16 14:33, Boris Ostrovsky wrote: On 07/11/2016 06:47 AM, Wei Liu wrote: On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: On 07/08/2016 12:07 PM, Wei Liu wrote: On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: On 07/08/2016 06:55 AM, Wei Liu wrote: +

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 06:47 AM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 12:07 PM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 02:39:05PM +0100, Julien Grall wrote: > >Yes, we do. However, in PVH(v2) case it will be seen next by the guest > >who will expect the tables to already be in memory. I.e. there is no > >intermediate Xen component, such as hvmloader, who can load the blobs. > > > >Having sai

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Julien Grall
On 11/07/16 14:42, Wei Liu wrote: On Mon, Jul 11, 2016 at 02:39:05PM +0100, Julien Grall wrote: Yes, we do. However, in PVH(v2) case it will be seen next by the guest who will expect the tables to already be in memory. I.e. there is no intermediate Xen component, such as hvmloader, who can loa

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Anthony PERARD
On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 06:47 AM, Wei Liu wrote: > > On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > >> On 07/08/2016 12:07 PM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 10:48:52AM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

2016-07-11 Thread Evgenii Shatokhin
On 11.07.2016 15:04, Bob Liu wrote: On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote: On 06.06.2016 11:42, Dario Faggioli wrote: Just Cc-ing some Linux, block, and Xen on CentOS people... Ping. Any suggestions how to debug this or what might cause the problem? Obviously, we cannot control

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

2016-07-11 Thread Evgenii Shatokhin
On 11.07.2016 13:37, George Dunlap wrote: On Mon, Jul 11, 2016 at 9:50 AM, Evgenii Shatokhin wrote: On 06.06.2016 11:42, Dario Faggioli wrote: Just Cc-ing some Linux, block, and Xen on CentOS people... Ping. Any suggestions how to debug this or what might cause the problem? Obviously, we

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 09:41 AM, Wei Liu wrote: > On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: >> On 07/11/2016 06:47 AM, Wei Liu wrote: >>> On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: On 07/08/2016 12:07 PM, Wei Liu wrote: > On Fri, Jul 08, 2016 at 10:48:52

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Lars Kurth
> On 11 Jul 2016, at 13:10, Wei Liu wrote: > > CC Lars > > More licence stuff. Do you have contact(s)? James (on vacation) or I can confirm on behalf of Citrix. I am assuming that Konrad can get the approval for Sun/Oracle As for Intel, we can ask Susie Li. It would have to be a Intel decision

Re: [Xen-devel] [DRAFT 1] XenSock protocol design document

2016-07-11 Thread Joao Martins
On 07/08/2016 12:23 PM, Stefano Stabellini wrote: > Hi all, > Hey! [...] > > ## Design > > ### Xenstore > > The frontend and the backend connect to each other exchanging information via > xenstore. The toolstack creates front and back nodes with state > XenbusStateInitialising. There can only

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 11, 2016 at 03:47:20PM +0100, Lars Kurth wrote: > > > On 11 Jul 2016, at 13:10, Wei Liu wrote: > > > > CC Lars > > > > More licence stuff. Do you have contact(s)? > > James (on vacation) or I can confirm on behalf of Citrix. > I am assuming that Konrad can get the approval for Sun/

[Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread David Vrabel
IOCTL_EVTCHN_RESTRICT limits the file descriptor to being able to bind to interdomain event channels from a specific domain. Event channels that are already bound continue to work for sending and receiving notifications. This is useful as part of deprivileging a user space PV backend or device mo

Re: [Xen-devel] [PATCH v3 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 12:31:43PM +0100, Wei Liu wrote: [...] > > > > > > +/* If the user did not explicitly specify a device model > > > + * version, we need to use the same logic used during domain > > > + * creation to derive the device model version. > > > + *

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 10:54 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 11, 2016 at 03:47:20PM +0100, Lars Kurth wrote: >>> On 11 Jul 2016, at 13:10, Wei Liu wrote: >>> >>> CC Lars >>> >>> More licence stuff. Do you have contact(s)? >> James (on vacation) or I can confirm on behalf of Citrix. >> I am a

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-11 Thread Andrew Cooper
On 09/07/16 05:12, Corneliu ZUZU wrote: > This wouldn't let me make a param of a function that used atomic_read() const. > > Signed-off-by: Corneliu ZUZU This is a good improvement, but you must make an identical adjustment to the arm code, otherwise you will end up with subtle build failures. I

Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 10:57 AM, David Vrabel wrote: > diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h > index 14e833ee4..f057b53 100644 > --- a/include/uapi/xen/evtchn.h > +++ b/include/uapi/xen/evtchn.h > @@ -85,4 +85,19 @@ struct ioctl_evtchn_notify { > #define IOCTL_EVTCHN_RESET

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > But do we need to look at who touched the file or who is explicitly > listed as copyright holder (in files' headers)? You need to look at the history. Sadly, we don't hav

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: > Move acpi_info initialization out of ACPI code"): > > But do we need to look at who touched the fil

[Xen-devel] [PATCH v4 3/5] libxl: introduce libxl__qmp_query_cpus

2016-07-11 Thread Wei Liu
It interrogates QEMU for CPUs and update the bitmap accordingly. Signed-off-by: Wei Liu Reviewed-by: Dario Faggioli Reviewed-by: Anthony PERARD Acked-by: Ian Jackson --- Cc: Ian Jackson Cc: Anthony PERARD v3: 1. Initialise rc in error path. 2. Fix comment in header and a typo in log message

[Xen-devel] [PATCH v4 2/5] libxl: libxl_domain_need_memory shouldn't modify b_info

2016-07-11 Thread Wei Liu
This function is used to return the memory needed for a guest. It's not in a position to modify the b_info passed in (note the _setdefault function). Constify the passed in b_info, use a copy to do the calculation. Mark the change in API in libxl.h. Signed-off-by: Wei Liu --- Cc: Ian Jackson v

[Xen-devel] [PATCH v4 0/5] libxl: update available vcpus map in retrieved configuration

2016-07-11 Thread Wei Liu
See individual patch for detailed changelog. Wei Liu (5): libxl: constify copy and length calculation functions libxl: libxl_domain_need_memory shouldn't modify b_info libxl: introduce libxl__qmp_query_cpus libxl: update vcpus bitmap in retrieved guest config libxl: only issue cpu-add ca

[Xen-devel] [PATCH v4 5/5] libxl: only issue cpu-add call to QEMU for not present CPU

2016-07-11 Thread Wei Liu
Calculate the final bitmap for CPUs to add to avoid having annoying error messages complaining those CPUs are already present. Example message is like (wrapped): libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an error message from QMP server: Unable to add CPU: 0, it already exi

[Xen-devel] [PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Wei Liu
... because the available vcpu bitmap can change during domain life time due to cpu hotplug and unplug. For QEMU upstream, we interrogate QEMU for the number of vcpus. For others, we look directly into xenstore for information. Reported-by: Jan Beulich Signed-off-by: Wei Liu --- Cc: Ian Jackson

[Xen-devel] [PATCH v4 1/5] libxl: constify copy and length calculation functions

2016-07-11 Thread Wei Liu
These functions are not supposed to modify the passed in parameters. Reflect that in function declarations. Mark the change in APIs in libxl.h Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxl/gentypes.py | 4 ++-- tools/libxl/libxl.c | 10 +- tools/libxl/libxl.

Re: [Xen-devel] [PATCH v4 1/5] libxl: constify copy and length calculation functions

2016-07-11 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 1/5] libxl: constify copy and length calculation functions"): > These functions are not supposed to modify the passed in parameters. > Reflect that in function declarations. Acked-by: Ian Jackson ___ Xen-devel mailing list X

Re: [Xen-devel] [PATCH v4 2/5] libxl: libxl_domain_need_memory shouldn't modify b_info

2016-07-11 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 2/5] libxl: libxl_domain_need_memory shouldn't modify b_info"): > This function is used to return the memory needed for a guest. It's not > in a position to modify the b_info passed in (note the _setdefault > function). > > Constify the passed in b_info, use a copy to d

Re: [Xen-devel] [PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config"): > ... because the available vcpu bitmap can change during domain life time > due to cpu hotplug and unplug. > > For QEMU upstream, we interrogate QEMU for the number of vcpus. For > others, we look directly in

Re: [Xen-devel] [PATCH v4 5/5] libxl: only issue cpu-add call to QEMU for not present CPU

2016-07-11 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 5/5] libxl: only issue cpu-add call to QEMU for not present CPU"): > Calculate the final bitmap for CPUs to add to avoid having annoying > error messages complaining those CPUs are already present. Example > message is like (wrapped): > > libxl: error: libxl_qmp.c:287:q

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 11:38 AM, Ian Jackson wrote: > Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: > Move acpi_info initialization out of ACPI code"): >> But do we need to look at who touched the file or who is explicitly >> listed as copyright holder (in files' headers)? > You

Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread David Vrabel
On 11/07/16 16:31, Boris Ostrovsky wrote: > On 07/11/2016 10:57 AM, David Vrabel wrote: >> diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h >> index 14e833ee4..f057b53 100644 >> --- a/include/uapi/xen/evtchn.h >> +++ b/include/uapi/xen/evtchn.h >> @@ -85,4 +85,19 @@ struct ioctl_e

Re: [Xen-devel] [PATCH v6 12/14] xen/arm: p2m: Introduce helpers to insert and remove mapping

2016-07-11 Thread Julien Grall
Hi, On 06/07/16 14:01, Julien Grall wrote: int map_mmio_regions(struct domain *d, @@ -1189,12 +1207,8 @@ int map_mmio_regions(struct domain *d, unsigned long nr, mfn_t mfn) { -return apply_p2m_changes(d, INSERT, -

Re: [Xen-devel] [PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Wei Liu
On Mon, Jul 11, 2016 at 04:56:02PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest > config"): > > ... because the available vcpu bitmap can change during domain life time > > due to cpu hotplug and unplug. > > > > For QEMU upstream, we in

Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread Andrew Cooper
On 11/07/16 17:15, David Vrabel wrote: > On 11/07/16 16:31, Boris Ostrovsky wrote: >> On 07/11/2016 10:57 AM, David Vrabel wrote: >>> diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h >>> index 14e833ee4..f057b53 100644 >>> --- a/include/uapi/xen/evtchn.h >>> +++ b/include/uapi/xen

Re: [Xen-devel] [PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config

2016-07-11 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v4 4/5] libxl: update vcpus bitmap in retrieved guest config"): > The hunk is (on top of this patch) to use libxl__xs_read_checked Errr. Sorry for not spotting that in my review. > Is it ok to keep your ack? Yes, thanks. Ian. __

Re: [Xen-devel] [PATCH 11/16] x86/monitor: fix: treat -monitor- properly, as a subsys of the vm-event subsys

2016-07-11 Thread Tamas K Lengyel
>>> diff --git a/xen/include/asm-arm/monitor.h >>> b/xen/include/asm-arm/monitor.h >>> index 9a9734a..7ef30f1 100644 >> >> [snip] > > > I keep seeing '[snip]' lately but I don't know what it means. Placeholder for "I've cut some of your patch content here to shorten the message I'm sending". > >>

Re: [Xen-devel] [PATCH 03/16] x86/monitor: mechanical renames

2016-07-11 Thread Tamas K Lengyel
On Sat, Jul 9, 2016 at 12:46 PM, Corneliu ZUZU wrote: > On 7/9/2016 9:10 PM, Tamas K Lengyel wrote: >> >> On Fri, Jul 8, 2016 at 10:13 PM, Corneliu ZUZU >> wrote: >>> >>> Arch-specific vm-event functions in x86/vm_event.h -e.g. >>> vm_event_init_domain()- >>> don't have an 'arch_' prefix. Apply t

Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread David Vrabel
On 11/07/16 17:33, Andrew Cooper wrote: > On 11/07/16 17:15, David Vrabel wrote: >> On 11/07/16 16:31, Boris Ostrovsky wrote: >>> On 07/11/2016 10:57 AM, David Vrabel wrote: diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h index 14e833ee4..f057b53 100644 --- a/inclu

Re: [Xen-devel] [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 12:44 PM, David Vrabel wrote: > On 11/07/16 17:33, Andrew Cooper wrote: >> On 11/07/16 17:15, David Vrabel wrote: >>> On 11/07/16 16:31, Boris Ostrovsky wrote: On 07/11/2016 10:57 AM, David Vrabel wrote: > diff --git a/include/uapi/xen/evtchn.h b/include/uapi/xen/evtchn.h >>>

[Xen-devel] [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
This is because libxl uses XEN_RUN_DIR to generate the socket path for libxenstat while libxenstat itself uses hard-coded path, which is not necessarily the same path as XEN_RUN_DIR. The default configuration happened to work because XEN_RUN_DIR defaulted to /var/run/xen, which matched the hard-co

[Xen-devel] [PATCH v2 4/7] hotplug/NetBSD: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
Store xldevd.pid under XEN_RUN_DIR. Note that this will change the default location from /var/run to /var/run/xen. Signed-off-by: Wei Liu Acked-by: Roger Pau Monné Acked-by: Ian Jackson --- Cc: Ian Jackson Cc: Roger Pau Monné --- tools/hotplug/NetBSD/rc.d/xendriverdomain.in | 2 +- 1 file ch

[Xen-devel] [PATCH v2 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c

2016-07-11 Thread Wei Liu
Place the PID file under XEN_RUN_DIR. Note that this change the default location from /var/run to /var/run/xen. Generate a _paths.h as that is required to make this change work. Signed-off-by: Wei Liu --- Cc: Ian Jackson v4: fix dependency in Makefile v3: new --- .gitignore

[Xen-devel] [PATCH v2 5/7] hotplug/Linux: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
Store various PID files under XEN_RUN_DIR. Note that this change the default location from /var/run to /var/run/xen. Signed-off-by: Wei Liu Acked-by: Roger Pau Monné Acked-by: Ian Jackson --- Cc: Ian Jackson Cc: Roger Pau Monné --- tools/hotplug/Linux/init.d/xencommons.in | 6 +++--- to

[Xen-devel] [PATCH v2 1/7] xenconsoled: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
Place the PID file under XEN_RUN_DIR by default. Note this change the default location from /var/run to /var/run/xen. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/console/daemon/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/console/daemon/main.c b/tool

[Xen-devel] [PATCH v2 0/7] Remove hard-coded /var/run in tools

2016-07-11 Thread Wei Liu
Wei Liu (7): xenconsoled: honour XEN_RUN_DIR tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c hotplug/FreeBSD: honour XEN_RUN_DIR hotplug/NetBSD: honour XEN_RUN_DIR hotplug/Linux: honour XEN_RUN_DIR libxenstat: honour XEN_RUN_DIR oxenstored: honour XEN_RUN_DIR .gitignore

[Xen-devel] [PATCH v2 3/7] hotplug/FreeBSD: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
Store xldevd.pid under XEN_RUN_DIR. Note that the default location would change from /var/run to /var/run/xen. Signed-off-by: Wei Liu Acked-by: Roger Pau Monné Acked-by: Ian Jackson --- Cc: Ian Jackson Cc: Roger Pau Monné --- tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 2 +- 1 file chang

[Xen-devel] [PATCH v2 7/7] oxenstored: honour XEN_RUN_DIR

2016-07-11 Thread Wei Liu
Move default the pid file under XEN_RUN_DIR. Note that it changes the location from /var/run to /var/run/xen. Signed-off-by: Wei Liu Acked-by: David Scott --- Cc: Ian Jackson Not a backport candidate. --- tools/ocaml/xenstored/xenstored.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Xen-devel] [PATCH] xen/arm: map_dev_mmio_region: The iomem permission check should be done on MFN

2016-07-11 Thread Stefano Stabellini
On Wed, 15 Jun 2016, Shannon Zhao wrote: > Hi Julien, > > On 2016/6/14 19:50, Julien Grall wrote: > > The helper iomem_access_permitted expects MFNs in parameters and not > > GNFs. Thankfully only the hardware domain can call this function and > > it will always be with GFNS == MFNs for now. > >

Re: [Xen-devel] [PATCH] xen/arm: io: Protect the handlers with a read-write lock

2016-07-11 Thread Stefano Stabellini
On Tue, 28 Jun 2016, Julien Grall wrote: > Currently, accessing the I/O handlers does not require to take a lock > because new handlers are always added at the end of the array. In a > follow-up patch, this array will be sort to optimize the look up. > > Given that most of the time the I/O handler

Re: [Xen-devel] [PATCH v2] xen/arm: gic-v3: No need to sort the Redistributor regions

2016-07-11 Thread Stefano Stabellini
On Tue, 28 Jun 2016, Julien Grall wrote: > The sorting was required by the vGIC emulation until commit > 9b9d51e98edb8c5c731e2d06dfad3633053d88a4 "xen/arm: vgic-v3: > Correctly retrieve the vCPU associated to a re-distributor". > > Furthermore, the code is buggy because both local variables 'l' an

Re: [Xen-devel] [PATCH] xen/arm: io: Protect the handlers with a read-write lock

2016-07-11 Thread Julien Grall
Hi Stefano, On 11/07/16 18:49, Stefano Stabellini wrote: On Tue, 28 Jun 2016, Julien Grall wrote: Currently, accessing the I/O handlers does not require to take a lock because new handlers are always added at the end of the array. In a follow-up patch, this array will be sort to optimize the lo

[Xen-devel] [PATCH v6] x86/mem-sharing: mem-sharing a range of memory

2016-07-11 Thread Tamas K Lengyel
Currently mem-sharing can be performed on a page-by-page basis from the control domain. However, this process is quite wasteful when a range of pages have to be deduplicated. This patch introduces a new mem_sharing memop for range sharing where the user doesn't have to separately nominate each pag

Re: [Xen-devel] [PATCH 11/16] x86/monitor: fix: treat -monitor- properly, as a subsys of the vm-event subsys

2016-07-11 Thread Corneliu ZUZU
On 7/11/2016 7:38 PM, Tamas K Lengyel wrote: diff --git a/xen/include/asm-arm/monitor.h b/xen/include/asm-arm/monitor.h index 9a9734a..7ef30f1 100644 [snip] I keep seeing '[snip]' lately but I don't know what it means. Placeholder for "I've cut some of your patch content here to shorten the m

Re: [Xen-devel] [PATCH 11/16] x86/monitor: fix: treat -monitor- properly, as a subsys of the vm-event subsys

2016-07-11 Thread Tamas K Lengyel
On Mon, Jul 11, 2016 at 2:20 PM, Corneliu ZUZU wrote: > On 7/11/2016 7:38 PM, Tamas K Lengyel wrote: > > diff --git a/xen/include/asm-arm/monitor.h > b/xen/include/asm-arm/monitor.h > index 9a9734a..7ef30f1 100644 [snip] >>> >>> >>> I keep seeing '[snip]' lately but I don

Re: [Xen-devel] [PATCH 11/16] x86/monitor: fix: treat -monitor- properly, as a subsys of the vm-event subsys

2016-07-11 Thread Corneliu ZUZU
On 7/12/2016 12:27 AM, Tamas K Lengyel wrote: On Mon, Jul 11, 2016 at 2:20 PM, Corneliu ZUZU wrote: On 7/11/2016 7:38 PM, Tamas K Lengyel wrote: diff --git a/xen/include/asm-arm/monitor.h b/xen/include/asm-arm/monitor.h index 9a9734a..7ef30f1 100644 [snip] I keep seeing '[snip]' lately but

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Bin Wu
On 2016/7/11 17:53, Juergen Gross wrote: On 11/07/16 11:50, David Vrabel wrote: On 11/07/16 10:33, Juergen Gross wrote: On 11/07/16 04:51, Bin Wu wrote: During scsi command queueing, if mapping data fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed int

[Xen-devel] [PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed

2016-07-11 Thread Bin Wu
During scsi command queueing or exception handling, if prepairing fails, we need to reclaim the failed request. Otherwise, the garbage request will be pushed into the ring for the backend to work. Signed-off-by: Bin Wu --- drivers/scsi/xen-scsifront.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Xen-devel] [oxenstored]Guest users could get the VM count and domids on the host

2016-07-11 Thread Sunguodong
Hi all, I found a problem in oxenstored, which may be a security issue: Guest users could get the VM count and domids on the host by a sniffing method. You can reproduce it like this: (1) Create a VM, e.g. CentOS 7.0 64bit (2) Install xen tools in VM, excute cmds: yum install centos-release-x

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-11 Thread Shannon Zhao
On 2016/7/7 23:30, Wei Liu wrote: > On Mon, Jun 27, 2016 at 11:40:32AM +0100, Julien Grall wrote: >> > Hi Shannon, >> > >> > On 23/06/16 15:34, Shannon Zhao wrote: >>> > >On 2016年06月23日 21:39, Stefano Stabellini wrote: > >>On Thu, 23 Jun 2016, Shannon Zhao wrote: >> > From: Shannon

Re: [Xen-devel] [PATCH v3 05/17] libxl/arm: Generate static ACPI DSDT table

2016-07-11 Thread Shannon Zhao
On 2016/7/7 23:52, Wei Liu wrote: > On Tue, Jul 05, 2016 at 11:12:35AM +0800, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > It uses static DSDT table like the way x86 uses. Currently the DSDT >> > table only contains processor device objects and it generates the >> > maximal objects whi

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-11 Thread Shannon Zhao
On 2016/7/6 18:12, Stefano Stabellini wrote: > On Wed, 6 Jul 2016, Julien Grall wrote: >> > Hi Stefano, >> > >> > On 05/07/16 18:13, Stefano Stabellini wrote: >>> > > On Thu, 23 Jun 2016, Julien Grall wrote: > > > On 23/06/2016 04:17, Shannon Zhao wrote: > > > > > From: Shannon Zhao >>

[Xen-devel] Atheros WiFi - memory paging failure on driver load

2016-07-11 Thread Andrey Grodzovsky
Hello Some background - We are trying to run Qualcomm Atheros AR928X Wireless Network Adapter and have a crash right on driver load, following are our observations and questions. Jurgen's observation - " The Atheros card "Qualcomm Atheros AR928X Wireless Network Adapter (PCI-Express) (rev 01)"

[Xen-devel] linux-next: manual merge of the xen-tip tree with the pm tree

2016-07-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the xen-tip tree got a conflict in: drivers/acpi/scan.c between commit: 68bdb6773289 ("ACPI: add support for ACPI reconfiguration notifiers") from the pm tree and commit: c8ac8b6fb495 ("Xen: ACPI: Hide UART used by Xen") from the xen-tip tree. I fix

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-11 Thread Corneliu ZUZU
Hi Andrew, On 7/11/2016 6:18 PM, Andrew Cooper wrote: On 09/07/16 05:12, Corneliu ZUZU wrote: This wouldn't let me make a param of a function that used atomic_read() const. Signed-off-by: Corneliu ZUZU This is a good improvement, but you must make an identical adjustment to the arm code, oth

[Xen-devel] Data Abort while in booting when using latest version on arm32 fastmodels

2016-07-11 Thread Wonseok Ko
Hi, All I founded the previous post to solve the problem as the same as mine, the patch was applied in latest version, but I've got the data abort. previous post: https://lists.xen.org/archives/html/xen-devel/2013-09/msg00606.html and I referred to the wiki page: http://wiki.xen.org/wiki/Xen_ARM_w

  1   2   >