On Mon, Jul 11, 2016 at 12:31:43PM +0100, Wei Liu wrote: [...] > > > > > > + /* If the user did not explicitly specify a device model > > > + * version, we need to use the same logic used during domain > > > + * creation to derive the device model version. > > > + */ > > > + version = d_config->b_info.device_model_version; > > > + if (version == LIBXL_DEVICE_MODEL_VERSION_UNKNOWN) > > > + version = libxl__get_device_model_version(gc, > > > &d_config->b_info); > > > > I think this is rather unfortunate. Won't changing the default device > > model while the domain is running will cause this function to give > > wrong answers ? > > I think saving the device model into the template should work. No need > to derive it during runtime. >
Actually this information is already available via libxl__device_model_version_running. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
