[Xen-devel] [linux-3.14 bisection] complete test-amd64-amd64-qemuu-nested-intel

2016-06-14 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-intel testid xen-boot/l1 Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-tr

Re: [Xen-devel] [PATCH v8 09/11] vt-d: fix the IOMMU flush issue

2016-06-14 Thread Xu, Quan
On June 13, 2016 11:52 PM, Jan Beulich wrote: > >>> "Xu, Quan" 06/13/16 5:22 PM >>> > >From: Quan Xu > >@@ -546,17 +550,37 @@ static int __must_check iommu_flush_all(void) > >struct acpi_drhd_unit *drhd; struct iommu *iommu; int flush_dev_iotlb; > >+int rc = 0; > > > >flush_all_cache(); > >

Re: [Xen-devel] [PATCH v8 09/11] vt-d: fix the IOMMU flush issue

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 10:10, wrote: > On June 13, 2016 11:52 PM, Jan Beulich wrote: >> >>> "Xu, Quan" 06/13/16 5:22 PM >>> >> >From: Quan Xu >> >@@ -546,17 +550,37 @@ static int __must_check iommu_flush_all(void) >> >struct acpi_drhd_unit *drhd; struct iommu *iommu; int flush_dev_iotlb; >> >+i

Re: [Xen-devel] vTPM detaching issue

2016-06-14 Thread Xu, Quan
On June 13, 2016 11:11 PM, Andrea Genuise wrote: > I'm not sure if this is a bug or my fault, but when I create a domain > with a vTPM attached, detaching it sometimes causes the following error > to be thrown (I post the command sequence): > I am afraid this is not a bug. As 'xl vtpm-detach' is

Re: [Xen-devel] MEM_SHARING_DEBUG

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 10:51:33AM +0430, sepanta s wrote: > On Mon, Jun 13, 2016 at 12:59 PM, Wei Liu wrote: > > > On Sun, Jun 12, 2016 at 02:37:29PM +0430, sepanta s wrote: > > > Hi, > > > > > > how to does MEM_SHARING_DEBUG works in xen ? > > > This function is located at and its internal stru

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Dario Faggioli
On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: > When trying to use xl cpupool-numa-split and dom0 is limited to less > vcpus than one numa node the operation will fail. > > Correct this by allowing this configuration. > > Reported-by: Glenn Enright > Signed-off-by: Juergen Gross > Rev

[Xen-devel] [PATCH] AMD IOMMU: correctly propagate errors from amd_iommu_init()

2016-06-14 Thread Jan Beulich
... instead of using -ENODEV for any kind of error. It in particular addresses Coverity ID 1362694 (introduced by commit eb48587210 ["AMD IOMMU: introduce support for IVHD block type 11h"]). Coverity ID: 1362694 Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen

Re: [Xen-devel] [PATCH v8 09/11] vt-d: fix the IOMMU flush issue

2016-06-14 Thread Xu, Quan
On June 14, 2016 4:27 PM, Jan Beulich wrote: > >>> On 14.06.16 at 10:10, wrote: > > On June 13, 2016 11:52 PM, Jan Beulich wrote: > >> >>> "Xu, Quan" 06/13/16 5:22 PM >>> > >> >From: Quan Xu > >> >@@ -546,17 +550,37 @@ static int __must_check iommu_flush_all(void) > >> >struct acpi_drhd_unit

Re: [Xen-devel] [PATCH] AMD IOMMU: correctly propagate errors from amd_iommu_init()

2016-06-14 Thread Andrew Cooper
On 14/06/16 10:03, Jan Beulich wrote: > ... instead of using -ENODEV for any kind of error. It in particular > addresses Coverity ID 1362694 (introduced by commit eb48587210 ["AMD > IOMMU: introduce support for IVHD block type 11h"]). > > Coverity ID: 1362694 > > Signed-off-by: Jan Beulich Review

Re: [Xen-devel] vTPM detaching issue

2016-06-14 Thread Wei Liu
On Mon, Jun 13, 2016 at 05:10:35PM +0200, Andrea Genuise wrote: > I'm not sure if this is a bug or my fault, but when I create a domain > with a vTPM attached, detaching it sometimes causes the following error > to be thrown (I post the command sequence): > > [root@localhost ~]# xl create /etc/xen

Re: [Xen-devel] MEM_SHARING_DEBUG

2016-06-14 Thread sepanta s
On Tue, Jun 14, 2016 at 1:04 PM, Wei Liu wrote: > On Tue, Jun 14, 2016 at 10:51:33AM +0430, sepanta s wrote: > > On Mon, Jun 13, 2016 at 12:59 PM, Wei Liu wrote: > > > > > On Sun, Jun 12, 2016 at 02:37:29PM +0430, sepanta s wrote: > > > > Hi, > > > > > > > > how to does MEM_SHARING_DEBUG works i

Re: [Xen-devel] xen/x86: efi: warning value truncated

2016-06-14 Thread Jan Beulich
>>> On 13.06.16 at 19:13, wrote: > I noticed the warnings below when building Xen x86 > with Livepatch enabled. I did notice some of these too (not as many though, iirc), but I didn't get around yet to check what exactly is causing them. Since they're in the symbol table files only, I didn't cons

Re: [Xen-devel] [PATCH raisin 1/4] components/xen: Actually disable rombios

2016-06-14 Thread Stefano Stabellini
On Mon, 13 Jun 2016, George Dunlap wrote: > Commit 5fe3855 meant to disable rombios, but didn't. This causes the > following > build failure: > > gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing > -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement > -Wno-unuse

Re: [Xen-devel] MEM_SHARING_DEBUG

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 01:46:45PM +0430, sepanta s wrote: > On Tue, Jun 14, 2016 at 1:04 PM, Wei Liu wrote: > > > On Tue, Jun 14, 2016 at 10:51:33AM +0430, sepanta s wrote: > > > On Mon, Jun 13, 2016 at 12:59 PM, Wei Liu wrote: > > > > > > > On Sun, Jun 12, 2016 at 02:37:29PM +0430, sepanta s w

Re: [Xen-devel] [PATCH raisin 2/4] config: Separate config urls into a separate file

2016-06-14 Thread Stefano Stabellini
On Mon, 13 Jun 2016, George Dunlap wrote: > So that we're not duplicating information. > > Signed-off-by: George Dunlap Acked-by: Stefano Stabellini > configs/config-4.5 | 39 --- > configs/config-4.6 | 39 ---

Re: [Xen-devel] [PATCH 14/17] ocaml/libxs: generate a paths.ml

2016-06-14 Thread Wei Liu
On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote: > > > On 13 Jun 2016, at 16:22, Wei Liu wrote: > > > > On Mon, Jun 13, 2016 at 04:19:59PM +0100, Ian Jackson wrote: > >> Wei Liu writes ("[PATCH 14/17] ocaml/libxs: generate a paths.ml"): > >>> Signed-off-by: Wei Liu > >> > >> FAOD I

Re: [Xen-devel] [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches

2016-06-14 Thread Stefano Stabellini
On Mon, 13 Jun 2016, George Dunlap wrote: > Point xen, qemu, and qemu-trad to stable-4.5 and -4.6 branches. > > And point the default libvirt to point to the libvirt 1.3.3 > maintenance branch, rather than xen-tested-master. > > Also update OVMF revision for 4.6 to a version that builds with mode

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread Stefano Stabellini
On Mon, 13 Jun 2016, George Dunlap wrote: > Add a 4.7 config file, make it the default. > > Also update the qemu and qemu_traditional recipies after Ian Cambell's > work to split off separate libraries. > > Signed-off-by: George Dunlap > --- > CC: Stefano Stabellini > --- > components/qemu

Re: [Xen-devel] [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

2016-06-14 Thread Jan Beulich
>>> On 12.06.16 at 01:24, wrote: > @@ -1468,6 +1516,79 @@ int > mem_sharing_memop(XEN_GUEST_HANDLE_PARAM(xen_mem_sharing_op_t) arg) > } > break; > > +case XENMEM_sharing_op_bulk_share: > +{ > +unsigned long max_sgfn, max_cgfn; > +struct

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-14 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > Does that mean you're satisfied with this patch? Can I translate this > thread into an ack? Err, sorry, yes, I should have said Acked-by: Ian Jackson ___ Xen-de

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote: > On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: > > When trying to use xl cpupool-numa-split and dom0 is limited to less > > vcpus than one numa node the operation will fail. > > > > Correct this by allowing this configurati

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 10:56:52AM +0100, Wei Liu wrote: > On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote: > > On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: > > > When trying to use xl cpupool-numa-split and dom0 is limited to less > > > vcpus than one numa node the operat

Re: [Xen-devel] [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches

2016-06-14 Thread George Dunlap
On 14/06/16 10:40, Stefano Stabellini wrote: > On Mon, 13 Jun 2016, George Dunlap wrote: >> Point xen, qemu, and qemu-trad to stable-4.5 and -4.6 branches. >> >> And point the default libvirt to point to the libvirt 1.3.3 >> maintenance branch, rather than xen-tested-master. >> >> Also update OVMF

Re: [Xen-devel] [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches

2016-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2016, George Dunlap wrote: > On 14/06/16 10:40, Stefano Stabellini wrote: > > On Mon, 13 Jun 2016, George Dunlap wrote: > >> Point xen, qemu, and qemu-trad to stable-4.5 and -4.6 branches. > >> > >> And point the default libvirt to point to the libvirt 1.3.3 > >> maintenance branch,

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread George Dunlap
On 14/06/16 10:46, Stefano Stabellini wrote: > On Mon, 13 Jun 2016, George Dunlap wrote: >> Add a 4.7 config file, make it the default. >> >> Also update the qemu and qemu_traditional recipies after Ian Cambell's >> work to split off separate libraries. >> >> Signed-off-by: George Dunlap >> --- >>

Re: [Xen-devel] [PATCH v4 1/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-06-14 Thread Jan Beulich
>>> On 19.05.16 at 11:05, wrote: > @@ -5507,6 +5507,8 @@ long do_hvm_op(unsigned long op, > XEN_GUEST_HANDLE_PARAM(void) arg) > get_gfn_query_unlocked(d, a.pfn, &t); > if ( p2m_is_mmio(t) ) > a.mem_type = HVMMEM_mmio_dm; > +else if ( t == p2

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Juergen Gross
On 14/06/16 11:58, Wei Liu wrote: > On Tue, Jun 14, 2016 at 10:56:52AM +0100, Wei Liu wrote: >> On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote: >>> On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: When trying to use xl cpupool-numa-split and dom0 is limited to less

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0"): > On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote: > > On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: > > > When trying to use xl cpupool-numa-split and dom0 is limited t

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2016, George Dunlap wrote: > On 14/06/16 10:46, Stefano Stabellini wrote: > > On Mon, 13 Jun 2016, George Dunlap wrote: > >> Add a 4.7 config file, make it the default. > >> > >> Also update the qemu and qemu_traditional recipies after Ian Cambell's > >> work to split off separate li

Re: [Xen-devel] [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches

2016-06-14 Thread George Dunlap
On 14/06/16 11:01, Stefano Stabellini wrote: > On Tue, 14 Jun 2016, George Dunlap wrote: >> On 14/06/16 10:40, Stefano Stabellini wrote: >>> On Mon, 13 Jun 2016, George Dunlap wrote: Point xen, qemu, and qemu-trad to stable-4.5 and -4.6 branches. And point the default libvirt to poin

Re: [Xen-devel] xen/x86: efi: warning value truncated

2016-06-14 Thread Ross Lagerwall
On 06/14/2016 10:24 AM, Jan Beulich wrote: On 13.06.16 at 19:13, wrote: I noticed the warnings below when building Xen x86 with Livepatch enabled. I did notice some of these too (not as many though, iirc), but I didn't get around yet to check what exactly is causing them. Since they're in the

Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary"): > The original code is bogus because the common case is no HA enabled. > Setting ha variable at the beginning is not very useful. This seems like a plausible cleanup but I don't understand why you say the o

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread George Dunlap
On 14/06/16 11:08, Stefano Stabellini wrote: > On Tue, 14 Jun 2016, George Dunlap wrote: >> On 14/06/16 10:46, Stefano Stabellini wrote: >>> On Mon, 13 Jun 2016, George Dunlap wrote: Add a 4.7 config file, make it the default. Also update the qemu and qemu_traditional recipies after

Re: [Xen-devel] [PATCH 2/6] libxl: add emacs block to libxl_linux.c

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/6] libxl: add emacs block to libxl_linux.c"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/6] libxl: linux hotplug: clean up get_hotplug_env

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 3/6] libxl: linux hotplug: clean up get_hotplug_env"): > That get_hotplug_env function is called for both block and nic. Move > some nic specific code out of common code to appropriate place. Acked-by: Ian Jackson ___ Xen-devel

Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable when > necessary"): > > The original code is bogus because the common case is no HA enabled. > > Setting ha variable at the beginning is not very useful. > > Thi

Re: [Xen-devel] [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 4/6] libxl: debug output for args and env when invoking hotplug script"): > Signed-off-by: Wei Liu ... > +const char *arg; > +unsigned int x = 2; > + > +arg = args[x]; > +while (arg) { > +LOG(DEBUG, "\t%s", arg); > +x

Re: [Xen-devel] [PATCH 5/6] libxl: rename a field in libxl__domain_create_state

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 5/6] libxl: rename a field in libxl__domain_create_state"): > The libxl__stub_dm_spawn_state field in libxl__domain_create_state was > named dmss. That was inconsistent with how things were named (usually > acronym) and there was already libxl__dm_spawn_state named dmss in

Re: [Xen-devel] [PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson It would be nice to fix the error handling pattern to `goto out' style, but this patch is an improvement. Ian.

Re: [Xen-devel] [PATCH 1/2] x86/HVM: latch linear->phys translation results

2016-06-14 Thread Andrew Cooper
On 09/06/16 13:13, Jan Beulich wrote: On 09.06.16 at 13:54, wrote: >> On 08/06/16 14:09, Jan Beulich wrote: >>> ... to avoid re-doing the same translation later again (in a retry, for >>> example). This doesn't help very often according to my testing, but >>> it's pretty cheap to have, and wi

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Juergen Gross
On 14/06/16 12:07, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split > with vcpu limited dom0"): >> On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote: >>> On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote: When trying to use x

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2016, George Dunlap wrote: > On 14/06/16 11:08, Stefano Stabellini wrote: > > On Tue, 14 Jun 2016, George Dunlap wrote: > >> On 14/06/16 10:46, Stefano Stabellini wrote: > >>> On Mon, 13 Jun 2016, George Dunlap wrote: > Add a 4.7 config file, make it the default. > > A

Re: [Xen-devel] vTPM detaching issue

2016-06-14 Thread Andrea Genuise
On 14/06/2016 10:29, Xu, Quan wrote: > On June 13, 2016 11:11 PM, Andrea Genuise wrote: >> I'm not sure if this is a bug or my fault, but when I create a domain >> with a vTPM attached, detaching it sometimes causes the following error >> to be thrown (I post the command sequence): >> > I am afrai

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread George Dunlap
On 14/06/16 11:31, Stefano Stabellini wrote: > On Tue, 14 Jun 2016, George Dunlap wrote: >> On 14/06/16 11:08, Stefano Stabellini wrote: >>> On Tue, 14 Jun 2016, George Dunlap wrote: On 14/06/16 10:46, Stefano Stabellini wrote: > On Mon, 13 Jun 2016, George Dunlap wrote: >> Add a 4.7 c

[Xen-devel] [xen-4.6-testing test] 95645: regressions - trouble: broken/fail/pass

2016-06-14 Thread osstest service owner
flight 95645 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/95645/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 15 guest-start/debian.repeat fail REGR. vs. 95447 Tests which are f

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-14 Thread Jan Beulich
>>> On 19.05.16 at 11:05, wrote: > A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to > let one ioreq server claim/disclaim its responsibility for the > handling of guest pages with p2m type p2m_ioreq_server. Users > of this HVMOP can specify which kind of operation is supposed > to be

[Xen-devel] Make hvm_fep available to non-debug build as well?

2016-06-14 Thread Wei Liu
Andrew and I had a short conversation on IRC about why hvm_fep is only available to debug build. Here is what he said: liuw: because hvm_fep puts a very large attack surface back into the hypervisor I intoduced it originally to make it easy to test the instruction emulator wi

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Mon, Jun 13, 2016 at 07:21:53PM +0100, Wei Liu wrote: > On Mon, Jun 13, 2016 at 06:39:36PM +0100, Anthony PERARD wrote: > > On Wed, Jun 08, 2016 at 03:28:45PM +0100, Wei Liu wrote: > > > ... because the available vcpu bitmap can change during domain life time > > > due to cpu hotplug and unplug.

Re: [Xen-devel] xen/x86: efi: warning value truncated

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 12:15, wrote: > On 06/14/2016 10:24 AM, Jan Beulich wrote: > On 13.06.16 at 19:13, wrote: >>> I noticed the warnings below when building Xen x86 >>> with Livepatch enabled. >> >> I did notice some of these too (not as many though, iirc), but I >> didn't get around yet to ch

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: [...] > > > > + > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid, > > > > libxl_domain_config *d_config) > > > > { > > > > @@ -7270,6 +7317,46 @@ int > > > > lib

Re: [Xen-devel] Make hvm_fep available to non-debug build as well?

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 12:47, wrote: > Andrew and I had a short conversation on IRC about why hvm_fep is only > available to debug build. Here is what he said: > > liuw: because hvm_fep puts a very large attack surface back > into the hypervisor > I intoduced it originally to make it easy

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 11:50:12AM +0100, Wei Liu wrote: > On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: > [...] > > > > > + > > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t > > > > > domid, > > > > > libxl_domai

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:58:58AM +0100, Anthony PERARD wrote: [...] > > > > This means your device model version is LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN > > so it should be covered by the correct case. > > > > I'm confused. > > If it works for you, I'll properly install Xen with your patch in,

Re: [Xen-devel] xen/x86: efi: warning value truncated

2016-06-14 Thread Ross Lagerwall
On 06/14/2016 11:50 AM, Jan Beulich wrote: On 14.06.16 at 12:15, wrote: On 06/14/2016 10:24 AM, Jan Beulich wrote: On 13.06.16 at 19:13, wrote: I noticed the warnings below when building Xen x86 with Livepatch enabled. I did notice some of these too (not as many though, iirc), but I didn't

Re: [Xen-devel] Make hvm_fep available to non-debug build as well?

2016-06-14 Thread Andrew Cooper
On 14/06/16 11:54, Jan Beulich wrote: On 14.06.16 at 12:47, wrote: >> Andrew and I had a short conversation on IRC about why hvm_fep is only >> available to debug build. Here is what he said: >> >> liuw: because hvm_fep puts a very large attack surface back >> into the hypervisor >

[Xen-devel] [PATCH] xen/arm: map_dev_mmio_region: The iomem permission check should be done on MFN

2016-06-14 Thread Julien Grall
The helper iomem_access_permitted expects MFNs in parameters and not GNFs. Thankfully only the hardware domain can call this function and it will always be with GFNS == MFNs for now. Also, fix the printf to use the MFN range and not the GFN one. Signed-off-by: Julien Grall Cc: Shannon Zhao ---

[Xen-devel] [PATCH 3/8] xen: Use typesafe gfn in xenmem_add_to_physmap_one

2016-06-14 Thread Julien Grall
The x86 version of the function xenmem_add_to_physmap_one contains variable name gpfn and gfn which make the code very confusing. I have left unchanged for now. Also, rename gpfn to gfn in the ARM version as the latter is the correct acronym for a guest physical frame. Finally, remove the trailin

[Xen-devel] [PATCH 1/8] xen/arm: Rename gmfn_to_mfn to gfn_to_mfn and use gfn/mfn typesafe

2016-06-14 Thread Julien Grall
The correct acronym for a guest physical frame is gfn. Also use the recently introduced typesafe gfn/mfn to avoid mixing the two different kind of frame. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c| 6 +++--- xen/common/grant_table.c | 4 ++-- xen/common/memory.c | 4 ++--

[Xen-devel] [PATCH 6/8] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn

2016-06-14 Thread Julien Grall
The prototype and the declaration of p2m_lookup disagree on how the function should be used. One expect a frame number whilst the other an address. Thankfully, everyone is using with an address today. However, most of the callers have to convert a guest frame to an address. Modify the interface to

[Xen-devel] [PATCH 5/8] xen: Use the typesafe mfn and gfn in map_mmio_regions...

2016-06-14 Thread Julien Grall
to avoid mixing machine frame with guest frame. Signed-off-by: Julien Grall --- Cc: Stefano Stabellini Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Konrad Rzeszutek Wilk Cc: Tim Deegan Cc: Wei Liu --- xen/arch/arm/domain_build.c | 4 ++-- xen/arch/arm/gi

[Xen-devel] [PATCH 2/8] xen: Use typesafe gfn/mfn in guest_physmap_* helpers

2016-06-14 Thread Julien Grall
Also rename some variables to gfn or mfn when it does not require much rework. Signed-off-by: Julien Grall --- Cc: Stefano Stabellini Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant Cc: George Dunlap Cc: Ian Jackson Cc: Konrad Rzeszutek Wilk Cc: Tim Deegan Cc: Wei Liu --- xen/arch/a

[Xen-devel] [PATCH 4/8] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn

2016-06-14 Thread Julien Grall
The correct acronym for a guest physical frame is gfn. Also use the typesafe gfn to ensure that a guest frame is effectively used. Signed-off-by: Julien Grall --- xen/arch/arm/domain.c | 4 ++-- xen/arch/arm/mm.c | 2 +- xen/include/asm-arm/domain.h | 2 +- xen/i

[Xen-devel] [PATCH 0/8] xen/arm: Use the typesafes gfn and mfn

2016-06-14 Thread Julien Grall
Hello all, Some of the ARM functions are mixing gfn vs mfn and even physical vs frame. To avoid more confusion, this patch series makes use of the terminology described in xen/include/xen/mm.h and the associated typesafe. This series is based on staging + the branch next-4.8 from Stefano merge.

[Xen-devel] [PATCH 8/8] xen/arm: p2m_cache_flush: Use the correct terminology and typesafe gfn

2016-06-14 Thread Julien Grall
p2m_cache_flush is expecting GFNs in parameter and not MFNs. Rename the variable to *gfn* and use typesafe to avoid possible misusage. Signed-off-by: Julien Grall --- xen/arch/arm/domctl.c | 2 +- xen/arch/arm/p2m.c| 10 +- xen/include/asm-arm/p2m.h | 2 +- 3 files changed,

[Xen-devel] [PATCH 7/8] xen/mm: Introduce max_gfn and min_gfn

2016-06-14 Thread Julien Grall
Those helpers will be useful to find the maximum/minimum between two GFNs without having to unbox/box manually. Signed-off-by: Julien Grall --- Cc: Stefano Stabellini Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Konrad Rzeszutek Wilk Cc: Tim Deegan Cc: Wei Liu

Re: [Xen-devel] [PATCH v3 16/16] xen/arm: arm64: Document Cortex-A57 erratum 834220

2016-06-14 Thread Julien Grall
Hello, On 07/06/16 17:06, Julien Grall wrote: The ARM erratum applies to certain revisions of Cortex-A57. The processor may report a Stage 2 translation fault as the result of Stage 1 fault for load crossing a page boundary when there is a permission fault or device memory fault at stage 1 and a

Re: [Xen-devel] xen/x86: efi: warning value truncated

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 13:19, wrote: > On 06/14/2016 11:50 AM, Jan Beulich wrote: > On 14.06.16 at 12:15, wrote: >>> On 06/14/2016 10:24 AM, Jan Beulich wrote: >>> On 13.06.16 at 19:13, wrote: > I noticed the warnings below when building Xen x86 > with Livepatch enabled. I

Re: [Xen-devel] [PATCH 1/8] xen/arm: Rename gmfn_to_mfn to gfn_to_mfn and use gfn/mfn typesafe

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 14:07, wrote: > The correct acronym for a guest physical frame is gfn. Also use > the recently introduced typesafe gfn/mfn to avoid mixing the two > different kind of frame. > > Signed-off-by: Julien Grall > --- > xen/arch/arm/p2m.c| 6 +++--- > xen/common/grant_table

Re: [Xen-devel] [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:26:56AM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 4/6] libxl: debug output for args and env when > invoking hotplug script"): > > Signed-off-by: Wei Liu > ... > > +const char *arg; > > +unsigned int x = 2; > > + > > +arg = args[x]; > >

Re: [Xen-devel] [PATCH 1/8] xen/arm: Rename gmfn_to_mfn to gfn_to_mfn and use gfn/mfn typesafe

2016-06-14 Thread Julien Grall
On 14/06/16 13:44, Jan Beulich wrote: On 14.06.16 at 14:07, wrote: The correct acronym for a guest physical frame is gfn. Also use the recently introduced typesafe gfn/mfn to avoid mixing the two different kind of frame. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c| 6 +++---

Re: [Xen-devel] [PATCH 2/8] xen: Use typesafe gfn/mfn in guest_physmap_* helpers

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 14:07, wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -665,21 +665,21 @@ p2m_remove_page(struct p2m_domain *p2m, unsigned long > gfn, unsigned long mfn, > } > > int > -guest_physmap_remove_page(struct domain *d, unsigned long gfn, > -

Re: [Xen-devel] [PATCH 3/8] xen: Use typesafe gfn in xenmem_add_to_physmap_one

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 14:07, wrote: > The x86 version of the function xenmem_add_to_physmap_one contains > variable name gpfn and gfn which make the code very confusing. > I have left unchanged for now. > > Also, rename gpfn to gfn in the ARM version as the latter is the correct > acronym for a gues

Re: [Xen-devel] [PATCH 4/8] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn

2016-06-14 Thread Andrew Cooper
On 14/06/16 13:07, Julien Grall wrote: > diff --git a/xen/include/asm-arm/grant_table.h > b/xen/include/asm-arm/grant_table.h > index 5e076cc..46cfe24 100644 > --- a/xen/include/asm-arm/grant_table.h > +++ b/xen/include/asm-arm/grant_table.h > @@ -30,7 +30,7 @@ static inline int replace_grant_supp

Re: [Xen-devel] [PATCH 5/8] xen: Use the typesafe mfn and gfn in map_mmio_regions...

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 14:07, wrote: > to avoid mixing machine frame with guest frame. > > Signed-off-by: Julien Grall Non-ARM bits: Acked-by: Jan Beulich > @@ -2217,10 +2217,11 @@ int map_mmio_regions(struct domain *d, >i += 1UL << order, ++iter ) > { > /* OR'ing gfn an

Re: [Xen-devel] [PATCH 7/8] xen/mm: Introduce max_gfn and min_gfn

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 14:07, wrote: > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -70,6 +70,9 @@ TYPE_SAFE(unsigned long, gfn); > #undef gfn_t > #endif > > +#define max_gfn(x, y) _gfn(max(gfn_x(x), gfn_x(y))) > +#define min_gfn(x, y) _gfn(min(gfn_x(x), gfn_x(y))) With my reply t

Re: [Xen-devel] [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches

2016-06-14 Thread Wei Liu
On Mon, Jun 06, 2016 at 11:52:06AM +0100, Wei Liu wrote: > A handful of patches I accumulated during freeze when I was debugging various > issues in xl / libxl. > > Wei. > > Wei Liu (6): > xl: remus/colo: only initialise ha variable when necessary > libxl: add emacs block to libxl_linux.c >

Re: [Xen-devel] Xen 4.7 crash

2016-06-14 Thread Aaron Cornelius
On 6/9/2016 7:14 AM, Ian Jackson wrote: Aaron Cornelius writes ("Re: [Xen-devel] Xen 4.7 crash"): I am not that familiar with the xenstored code, but as far as I can tell the grant mapping will be held by the xenstore until the xs_release() function is called (which is not called by libxl, and I

Re: [Xen-devel] [PATCH 7/8] xen/mm: Introduce max_gfn and min_gfn

2016-06-14 Thread Andrew Cooper
On 14/06/16 14:05, Jan Beulich wrote: On 14.06.16 at 14:07, wrote: >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -70,6 +70,9 @@ TYPE_SAFE(unsigned long, gfn); >> #undef gfn_t >> #endif >> >> +#define max_gfn(x, y) _gfn(max(gfn_x(x), gfn_x(y))) >> +#define min_gfn(x, y)

Re: [Xen-devel] [PATCH 8/8] xen/arm: p2m_cache_flush: Use the correct terminology and typesafe gfn

2016-06-14 Thread Andrew Cooper
On 14/06/16 13:07, Julien Grall wrote: > p2m_cache_flush is expecting GFNs in parameter and not MFNs. Rename > the variable to *gfn* and use typesafe to avoid possible misusage. > > Signed-off-by: Julien Grall > --- > xen/arch/arm/domctl.c | 2 +- > xen/arch/arm/p2m.c| 10 +-

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-14 Thread George Dunlap
On 14/06/16 11:45, Jan Beulich wrote: >> + struct hvm_ioreq_server *s) >> +{ >> +struct p2m_domain *p2m = p2m_get_hostp2m(d); >> +int rc; >> + >> +spin_lock(&p2m->ioreq.lock); >> + >> +if ( flags == 0 ) >> +{ >> +rc = -EINVAL; >> +if ( p2m

Re: [Xen-devel] Xen 4.7 crash

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 09:11:47AM -0400, Aaron Cornelius wrote: > On 6/9/2016 7:14 AM, Ian Jackson wrote: > >Aaron Cornelius writes ("Re: [Xen-devel] Xen 4.7 crash"): > >>I am not that familiar with the xenstored code, but as far as I can tell > >>the grant mapping will be held by the xenstore unt

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-14 Thread George Dunlap
On 19/05/16 10:05, Yu Zhang wrote: > A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to > let one ioreq server claim/disclaim its responsibility for the > handling of guest pages with p2m type p2m_ioreq_server. Users > of this HVMOP can specify which kind of operation is supposed > to be

Re: [Xen-devel] [PATCH v4 1/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-06-14 Thread George Dunlap
On 14/06/16 11:04, Jan Beulich wrote: On 19.05.16 at 11:05, wrote: >> @@ -5507,6 +5507,8 @@ long do_hvm_op(unsigned long op, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> get_gfn_query_unlocked(d, a.pfn, &t); >> if ( p2m_is_mmio(t) ) >> a.mem_type = HVMM

Re: [Xen-devel] [PATCH 00/17] Honour more configure variables in various places (iteration 2)

2016-06-14 Thread Wei Liu
On Mon, Jun 13, 2016 at 08:48:58AM +0100, Wei Liu wrote: > The first three patches are carried over from previous series. > > The rest introduce some new variables and replace various hard-coded paths in > code. > > There is one more path /var/run, with which I'm not sure what to do for the > mom

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 11:58:58AM +0100, Anthony PERARD wrote: > On Tue, Jun 14, 2016 at 11:50:12AM +0100, Wei Liu wrote: > > On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: > > [...] > > > > > > + > > > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t > > >

Re: [Xen-devel] Xen 4.7 crash

2016-06-14 Thread Aaron Cornelius
On 6/14/2016 9:15 AM, Wei Liu wrote: On Tue, Jun 14, 2016 at 09:11:47AM -0400, Aaron Cornelius wrote: On 6/9/2016 7:14 AM, Ian Jackson wrote: Aaron Cornelius writes ("Re: [Xen-devel] Xen 4.7 crash"): I am not that familiar with the xenstored code, but as far as I can tell the grant mapping wil

Re: [Xen-devel] [PATCH v4 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-06-14 Thread Jan Beulich
>>> On 14.06.16 at 15:13, wrote: > On 14/06/16 11:45, Jan Beulich wrote: >>> + struct hvm_ioreq_server *s) >>> +{ >>> +struct p2m_domain *p2m = p2m_get_hostp2m(d); >>> +int rc; >>> + >>> +spin_lock(&p2m->ioreq.lock); >>> + >>> +if ( flags == 0 ) >>> +{ >

Re: [Xen-devel] Xen 4.7 crash

2016-06-14 Thread Aaron Cornelius
On 6/14/2016 9:26 AM, Aaron Cornelius wrote: On 6/14/2016 9:15 AM, Wei Liu wrote: On Tue, Jun 14, 2016 at 09:11:47AM -0400, Aaron Cornelius wrote: On 6/9/2016 7:14 AM, Ian Jackson wrote: Aaron Cornelius writes ("Re: [Xen-devel] Xen 4.7 crash"): I am not that familiar with the xenstored code,

Re: [Xen-devel] Xen 4.7 crash

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 09:38:22AM -0400, Aaron Cornelius wrote: > On 6/14/2016 9:26 AM, Aaron Cornelius wrote: > >On 6/14/2016 9:15 AM, Wei Liu wrote: > >>On Tue, Jun 14, 2016 at 09:11:47AM -0400, Aaron Cornelius wrote: > >>>On 6/9/2016 7:14 AM, Ian Jackson wrote: > Aaron Cornelius writes ("Re

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 11:34:43AM +0100, George Dunlap wrote: > On 14/06/16 11:31, Stefano Stabellini wrote: > > On Tue, 14 Jun 2016, George Dunlap wrote: > >> On 14/06/16 11:08, Stefano Stabellini wrote: > >>> On Tue, 14 Jun 2016, George Dunlap wrote: > On 14/06/16 10:46, Stefano Stabellini

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread George Dunlap
On 14/06/16 14:53, Anthony PERARD wrote: > On Tue, Jun 14, 2016 at 11:34:43AM +0100, George Dunlap wrote: >> On 14/06/16 11:31, Stefano Stabellini wrote: >>> On Tue, 14 Jun 2016, George Dunlap wrote: On 14/06/16 11:08, Stefano Stabellini wrote: > On Tue, 14 Jun 2016, George Dunlap wrote: >

Re: [Xen-devel] [PATCH] xen: Clean up includes

2016-06-14 Thread Peter Maydell
On 30 May 2016 at 16:54, Stefano Stabellini wrote: > On Tue, 24 May 2016, Peter Maydell wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Peter May

[Xen-devel] [qemu-mainline test] 95649: regressions - FAIL

2016-06-14 Thread osstest service owner
flight 95649 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/95649/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 94856 test-

Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

2016-06-14 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary"): > On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote: > > Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable > > when necessary"): > > > The original code is bogus because

Re: [Xen-devel] [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 03:15:19PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 1/6] xl: remus/colo: only initialise ha variable > when necessary"): > > On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote: > > > Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha var

Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0

2016-06-14 Thread Ian Jackson
Juergen Gross writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0"): > On 14/06/16 12:07, Ian Jackson wrote: > > I looked at the code for a minute or two, and perhaps I'm being dense > > this morning, but I wasn't able to see (from the code and the commit >

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 03:00:12PM +0100, George Dunlap wrote: > On 14/06/16 14:53, Anthony PERARD wrote: > > On Tue, Jun 14, 2016 at 11:34:43AM +0100, George Dunlap wrote: > >> That code might be in qemu-upstream, but it's not in the qemu-xen trees; > >> if you revert this bit of the patch and try

Re: [Xen-devel] [PATCH] xen: Clean up includes

2016-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2016, Peter Maydell wrote: > On 30 May 2016 at 16:54, Stefano Stabellini wrote: > > On Tue, 24 May 2016, Peter Maydell wrote: > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > >> > >> This commit was created with

Re: [Xen-devel] [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes

2016-06-14 Thread George Dunlap
On 14/06/16 15:23, Anthony PERARD wrote: > On Tue, Jun 14, 2016 at 03:00:12PM +0100, George Dunlap wrote: >> On 14/06/16 14:53, Anthony PERARD wrote: >>> On Tue, Jun 14, 2016 at 11:34:43AM +0100, George Dunlap wrote: That code might be in qemu-upstream, but it's not in the qemu-xen trees;

[Xen-devel] [PATCH] x86: show remote CPU state upon fatal NMI

2016-06-14 Thread Jan Beulich
Quite frequently the watchdog would hit an innocent CPU, e.g. one trying to acquire a spin lock a remote CPU holds for extended periods of time, or a random CPU in TSC calbration rendezvous. In such cases the register and stack dump for that CPU doesn't really help in the analysis of the problem.

  1   2   >