On Tue, Jun 14, 2016 at 03:15:19PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 1/6] xl: remus/colo: only initialise ha variable
> when necessary"):
> > On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote:
> > > Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable
> > > when necessary"):
> > > > The original code is bogus because the common case is no HA enabled.
> > > > Setting ha variable at the beginning is not very useful.
> > >
> > > This seems like a plausible cleanup but I don't understand why you say
> > > the original code is `bogus'. Is it wrong ? If so you don't say how.
> >
> > What I meant is "the default state should be no HA enabled", hence if we
> > don't move the ha variable into a narrower scope it should have been
> > initialised to NULL first. It is not a bug though.
>
> IC. Perhaps you'd like to clarify the commit message ?
Sure, I will incorporate my reply above to the commit message.
> Whether or not you do,
>
> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
Thanks.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
