Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Christoffer Dall
On Thu, Aug 13, 2015 at 8:41 AM, Jan Beulich wrote: On 12.08.15 at 18:18, wrote: >> On 12/08/15 16:58, Jan Beulich wrote: >> On 12.08.15 at 17:51, wrote: On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: On 07.08.15 at 04:11, wrote: >> All these tables will be copi

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 10:01, wrote: > On Thu, Aug 13, 2015 at 8:41 AM, Jan Beulich wrote: > On 12.08.15 at 18:18, wrote: >>> Nonetheless, we still have to copy some table in Xen in order to modify >>> them and/or new one. I have in mind the FADT table to set the hypervisor >>> field and hiding

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 10:01, wrote: > On Thu, Aug 13, 2015 at 8:41 AM, Jan Beulich wrote: > On 12.08.15 at 18:18, wrote: >>> Nonetheless, we still have to copy some table in Xen in order to modify >>> them and/or new one. I have in mind the FADT table to set the hypervisor >>> field and hiding

Re: [Xen-devel] [PATCH for-4.6 v2] libxl: fix libxl__build_hvm error code return path

2015-08-13 Thread Wei Liu
This one missed libxl__domain_firmware call. I will respin. Not sure why gcc doesn't complain. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Failure to boot HVM guest with more than 32 VCPUS

2015-08-13 Thread Vitaly Kuznetsov
"Hao, Xudong" writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Wednesday, August 12, 2015 5:40 PM >> To: Hao, Xudong >> Cc: xen-devel@lists.xen.org >> Subject: Re: [Xen-devel] Failure to boot HVM guest with more than 32 >> VCPUS >> >> "Hao, Xu

Re: [Xen-devel] [PATCH OSSTEST] ts-xen-install: Install netcat-openbsd

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 17:09 +0100, Ian Campbell wrote: > This is required by libvirt for live migration (netcat-traditional > doesn't cut it). > > netcat-openbsd has higher update-alternatives priority, so it will be > used if installed. > > Signed-off-by: Ian Campbell > Cc: Jim Fehlig I ran a

[Xen-devel] [PATCH for-4.6 v3] libxl: fix libxl__build_hvm error code return path

2015-08-13 Thread Wei Liu
In 25652f23 ("tools/libxl: detect and avoid conflicts with RDM"), new code was added to use rc to store libxl function call return value, which complied to libxl coding style. That patch, however, didn't change other locations where return value was stored in ret. In the end libxl__build_hvm could

Re: [Xen-devel] [PATCH v5 01/17] VT-d Posted-intterrupt (PI) design

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 03:37, wrote: >> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] >> Sent: Wednesday, August 12, 2015 11:35 PM >> And with those tiny little changes: >> >> Reviewed-by: Konrad Rzeszutek Wilk > > Thanks a lot for your review on this whole series, Konrad! Especially

Re: [Xen-devel] [PATCH v5 11/17] vt-d: Add API to update IRTE when VT-d PI is used

2015-08-13 Thread Jan Beulich
>>> On 12.08.15 at 18:23, wrote: > On Wed, Aug 12, 2015 at 10:35:32AM +0800, Feng Wu wrote: >> +GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, remap_index, iremap_entries, p); >> + >> +old_ire = new_ire = *p; >> + >> +/* Setup/Update interrupt remapping table entry. */ >> +setup_posted_ir

Re: [Xen-devel] [PATCH for-4.6 3/3] libxc: fix vNUMA memory allocation

2015-08-13 Thread Dario Faggioli
On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > We should use new_memflags in xc_domain_populate_physmap. That variable > contains node information. > > Reported-by: Boris Ostrovsky > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli Regards, Dario -- <> (Raistlin Majere) -

Re: [Xen-devel] [PATCH for-4.6 1/3] xl: fix vNUMA vdistance parsing

2015-08-13 Thread Dario Faggioli
On Wed, 2015-08-12 at 20:35 +0100, Wei Liu wrote: > We should parse the output from splitting function, not the original > string. > > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli Regards, Dario -- <> (Raistlin Majere) - D

Re: [Xen-devel] [PATCH v5 12/17] Update IRTE according to guest interrupt config changes

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 03:37, wrote: >> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] >> Sent: Thursday, August 13, 2015 12:43 AM >> On Wed, Aug 12, 2015 at 10:35:33AM +0800, Feng Wu wrote: >> > +} >> > + >> > +if ( dest_vcpu_num != 0 ) >> > +{ >> > +idx = 0; >> > + >

Re: [Xen-devel] Failure to boot HVM guest with more than 32 VCPUS

2015-08-13 Thread Hao, Xudong
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, August 13, 2015 4:20 PM > To: Hao, Xudong > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] Failure to boot HVM guest with more than 32 VCPUS > > "Hao, Xudong" writes: > > >> -Origi

Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 18:12 +0100, Wei Liu wrote: > On Wed, Aug 12, 2015 at 11:04:25AM +0100, Ian Campbell wrote: > [...] > > > > > > > > As Andy says I think we want restore_fd in the check, I can't see > > > > any > > > > reason we wouldn't want to close the socket too. > > > > > > > > > > Do

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Ian Campbell
On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: > The function shouldn't return NULL after having obtained a reference, > or else the caller won't know to drop it. > Also its result shouldn't be ignored - if calling code is certain that > a page already has a non-zero refcount, it better ASS

Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 09:39:36AM +0100, Ian Campbell wrote: > On Wed, 2015-08-12 at 18:12 +0100, Wei Liu wrote: > > On Wed, Aug 12, 2015 at 11:04:25AM +0100, Ian Campbell wrote: > > [...] > > > > > > > > > > As Andy says I think we want restore_fd in the check, I can't see > > > > > any > > > >

Re: [Xen-devel] [BUG][4.5.1]xl cpupool-create segfault (with config file parameter)

2015-08-13 Thread Dario Faggioli
On Wed, 2015-08-12 at 12:28 +0100, Ian Campbell wrote: > On Wed, 2015-08-12 at 13:03 +0200, Benjamin Beier wrote: > > You never get any output apart from "segmentation fault". > > If you create exactly the same cpupool without using a config file it > > works absolutely fine. > > Tested on multip

Re: [Xen-devel] [PATCH v5 15/17] vmx: Add some scheduler hooks for VT-d posted interrupts

2015-08-13 Thread Dario Faggioli
On Wed, 2015-08-12 at 13:13 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 12, 2015 at 10:35:36AM +0800, Feng Wu wrote: > > This patch adds the following arch hooks in scheduler: > > - vmx_pre_ctx_switch_pi(): > > It is called before context switch, we update the posted > > interrupt descriptor

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 00:41 -0600, Jan Beulich wrote: > > > > Nonetheless, we still have to copy some table in Xen in order to modify > > them and/or new one. I have in mind the FADT table to set the hypervisor > > field and hiding the hypervisor specific data (GIC hyp, timer hyp...) to > > avoid

Re: [Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-13 Thread Wei Liu
On Tue, Aug 11, 2015 at 08:24:01PM -0600, Chun Yan Liu wrote: > > > >>> On 8/11/2015 at 07:27 PM, in message > <2015082702.gf7...@zion.uk.xensource.com>, Wei Liu > wrote: > > On Mon, Aug 10, 2015 at 06:35:24PM +0800, Chunyan Liu wrote: > > > Add pvusb APIs, including: > > > - attach/deta

Re: [Xen-devel] [PATCH V6 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-08-13 Thread Wei Liu
On Tue, Aug 11, 2015 at 08:37:09PM -0600, Chun Yan Liu wrote: [...] > > > + > > > +if (rs < datalen) { > > > +if (ferror(f)) { > > > LOGE(ERROR, "failed to read %s", filename); > > > -else if (feof(f)) > > > -LOG(ERROR, "%s chang

Re: [Xen-devel] [PATCH v5 15/17] vmx: Add some scheduler hooks for VT-d posted interrupts

2015-08-13 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Thursday, August 13, 2015 5:06 PM > To: Wu, Feng > Cc: Konrad Rzeszutek Wilk; xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; > George Dunlap; Andrew Cooper; Jan Beulich > Subject: Re: [Xen-devel] [P

Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 09:50 +0100, Wei Liu wrote: > On Thu, Aug 13, 2015 at 09:39:36AM +0100, Ian Campbell wrote: > > On Wed, 2015-08-12 at 18:12 +0100, Wei Liu wrote: > > > On Wed, Aug 12, 2015 at 11:04:25AM +0100, Ian Campbell wrote: > > > [...] > > > > > > > > > > > > As Andy says I think we wa

Re: [Xen-devel] Failure to boot HVM guest with more than 32 VCPUS

2015-08-13 Thread Vitaly Kuznetsov
"Hao, Xudong" writes: > > Attach the Fedora22 log, a different issue. > Here is the crash: [ 6399.814801] xen_netfront: Initialising Xen virtual ethernet driver [ 6399.814838] [drm] Initialized drm 1.1.0 20060810 [ 6399.838500] xen_netfront: can't alloc rx grant refs [ 6399.838504] net eth0: on

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:05, wrote: > The other reason for modification is to hide the Xen console device (i.e. > one UART) from the dom0 kernel, since it is unusable. How does that work on > x86? Do you just not bother and you expect the admin to arrange the > configuration to work or is there some

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

2015-08-13 Thread Wei Liu
On Wed, Aug 12, 2015 at 08:16:33AM -0600, Jan Beulich wrote: > ... and its callers. > > While all non-nested users are made fully honor the semantics of that > type, doing so in the nested case seemed insane (if doable at all, > considering VMCS shadowing), and hence there the respective operation

Re: [Xen-devel] [PATCH for-4.6 v3] libxl: fix libxl__build_hvm error code return path

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 09:24 +0100, Wei Liu wrote: > @@ -1002,22 +1005,22 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t > domid, > goto out; > } > > -ret = hvm_build_set_params(ctx->xch, domid, info, state->store_port, At least this one doesn't return ERROR_*, it returns 0 or

Re: [Xen-devel] [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic

2015-08-13 Thread Wei Liu
On Wed, Aug 12, 2015 at 08:48:05PM +0300, Razvan Cojocaru wrote: > On 08/12/2015 08:45 PM, Andrew Cooper wrote: > > On 12/08/15 18:00, Razvan Cojocaru wrote: > >> hvm_event_crX() already returns a bool_t to tell us whether an > >> event will be sent out or not, so the extra check that value != old

Re: [Xen-devel] [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode

2015-08-13 Thread Wei Liu
On Wed, Aug 12, 2015 at 09:05:43AM -0600, Jan Beulich wrote: > Tearing down a 1:1 mapping that was never established isn't really nice > (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a > wrapper macro to a proper function which then can take care of the > situation. > > Also ta

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread David Vrabel
On 12/08/15 20:36, Wei Liu wrote: > Originally, if user didn't specify maxvcpus= in xl config file, the > maximum size of vcpu bitmap was always equal to maximum number of pcpus. > This might not be what user wants. > > Calculate the maximum number of vcpus before allocating vcpu bitmap. > This re

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-13 Thread Stefano Stabellini
On Thu, 13 Aug 2015, Jan Beulich wrote: > >>> On 12.08.15 at 18:15, wrote: > > On Wed, 12 Aug 2015, Jan Beulich wrote: > >> >>> On 12.08.15 at 16:47, wrote: > >> > @@ -31,8 +33,15 @@ typedef int decompress_fn(unsigned char *inbuf, > >> > unsigned int len, > >> > * dependent). > >> > */ > >>

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 10:50, wrote: > On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: >> The function shouldn't return NULL after having obtained a reference, >> or else the caller won't know to drop it. > >> Also its result shouldn't be ignored - if calling code is certain that >> a page alre

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Tim Deegan
At 09:50 +0100 on 13 Aug (1439459451), Ian Campbell wrote: > On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: > > The function shouldn't return NULL after having obtained a reference, > > or else the caller won't know to drop it. > > > Also its result shouldn't be ignored - if calling code is

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Dario Faggioli
On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > Originally, if user didn't specify maxvcpus= in xl config file, the > maximum size of vcpu bitmap was always equal to maximum number of pcpus. > This might not be what user wants. > So, to understand, the issue here is that the bitmaps may be too

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:22, wrote: > On Wed, Aug 12, 2015 at 08:16:33AM -0600, Jan Beulich wrote: >> ... and its callers. >> >> While all non-nested users are made fully honor the semantics of that >> type, doing so in the nested case seemed insane (if doable at all, >> considering VMCS shadowing),

Re: [Xen-devel] [PATCH for-4.6] xen/mm: populate_physmap: validate correctly the gfn for direct mapped domain

2015-08-13 Thread Ian Campbell
On Tue, 2015-08-11 at 18:41 +0100, Julien Grall wrote: > Direct mapped domain has already the memory allocated 1:1, so we are > directly using the gfn as mfn to map the RAM in the guest. > > While we are validating that the page associated to the first mfn belongs > to > the domain, the subsequen

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 03:33:42AM -0600, Jan Beulich wrote: > >>> On 13.08.15 at 11:22, wrote: > > On Wed, Aug 12, 2015 at 08:16:33AM -0600, Jan Beulich wrote: > >> ... and its callers. > >> > >> While all non-nested users are made fully honor the semantics of that > >> type, doing so in the nes

Re: [Xen-devel] [PATCH for-4.6 v3] libxl: fix libxl__build_hvm error code return path

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 10:22:25AM +0100, Ian Campbell wrote: > On Thu, 2015-08-13 at 09:24 +0100, Wei Liu wrote: > > @@ -1002,22 +1005,22 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t > > domid, > > goto out; > > } > > > > -ret = hvm_build_set_params(ctx->xch, domid, info, st

Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

2015-08-13 Thread Andrew Cooper
On 13/08/15 10:17, Ian Campbell wrote: > On Thu, 2015-08-13 at 09:50 +0100, Wei Liu wrote: >> On Thu, Aug 13, 2015 at 09:39:36AM +0100, Ian Campbell wrote: >>> On Wed, 2015-08-12 at 18:12 +0100, Wei Liu wrote: On Wed, Aug 12, 2015 at 11:04:25AM +0100, Ian Campbell wrote: [...] >>> As

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > Originally, if user didn't specify maxvcpus= in xl config file, the > maximum size of vcpu bitmap was always equal to maximum number of pcpus. > This might not be what user wants. What are you suggesting they wanted instead? We are only talking a

[Xen-devel] PCI Pass-through in Xen ARM: Draft 4

2015-08-13 Thread Manish Jaggi
- | PCI Pass-through in Xen ARM | - manish.ja...@caviumnetworks.com --- Draft-4 -

Re: [Xen-devel] [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM

2015-08-13 Thread Wei Liu
On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote: > The firmware directory is not built at all on ARM. Attempting to update > it using the target subtree-force-update will fail when try to update > seabios. > > Signed-off-by: Julien Grall Release-acked-by: Wei Liu > > --- > Cc: Ia

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Stefano Stabellini
On Thu, 13 Aug 2015, Jan Beulich wrote: > >>> On 12.08.15 at 18:18, wrote: > > On 12/08/15 16:58, Jan Beulich wrote: > > On 12.08.15 at 17:51, wrote: > >>> On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: > >>> On 07.08.15 at 04:11, wrote: > > All these tables will be copied to D

Re: [Xen-devel] [PATCH for-4.6] tools/xenstore: Correct use of va_end() after va_copy()

2015-08-13 Thread Wei Liu
On Fri, Aug 07, 2015 at 02:51:59PM +0100, Andrew Cooper wrote: > C requires that every use of va_copy() is matched with a va_end() call. > > This is especially important for x86_64 as va_{start,copy}() may need to > allocate memory to generate a va_list containing parameters which were > previousl

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:31, wrote: > At 09:50 +0100 on 13 Aug (1439459451), Ian Campbell wrote: >> On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: >> > The function shouldn't return NULL after having obtained a reference, >> > or else the caller won't know to drop it. >> >> > Also its result

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 11:32:35AM +0200, Dario Faggioli wrote: > On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > > Originally, if user didn't specify maxvcpus= in xl config file, the > > maximum size of vcpu bitmap was always equal to maximum number of pcpus. > > This might not be what user wa

Re: [Xen-devel] [xs-devel] Trying to bring up stub domain in xen-4.4-xs88306

2015-08-13 Thread Andrew Cooper
On 13/08/15 08:04, Xuehan Xu wrote: > Hi, everyone. > > I'm trying to run a Windows HVM vm with stub domain in xenserver-6.5, > whose internal xen version is xen-4.4-xs88306. After I started the vm, > both the vm and its corresponding stub domain crashed. Here is the > related content in hypervisor

[Xen-devel] [distros-debian-jessie test] 37829: tolerable FAIL

2015-08-13 Thread Platform Team regression test user
flight 37829 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/37829/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-armhf-jessie-netboot-pygrub 9 debian-di-install fail never pass baseline version: fli

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 10:42:26AM +0100, Ian Campbell wrote: > On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > > Originally, if user didn't specify maxvcpus= in xl config file, the > > maximum size of vcpu bitmap was always equal to maximum number of pcpus. > > This might not be what user want

Re: [Xen-devel] [PATCH for-4.6] xen/mm: populate_physmap: validate correctly the gfn for direct mapped domain

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:33, wrote: > On Tue, 2015-08-11 at 18:41 +0100, Julien Grall wrote: >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -126,22 +126,28 @@ static void populate_physmap(struct memop_args *a) >> if ( is_domain_direct_mapped(d) ) >> { >>

Re: [Xen-devel] [xs-devel] Trying to bring up stub domain in xen-4.4-xs88306

2015-08-13 Thread Andrew Cooper
On 13/08/15 10:52, Andrew Cooper wrote: > On 13/08/15 08:04, Xuehan Xu wrote: >> Hi, everyone. >> >> I'm trying to run a Windows HVM vm with stub domain in xenserver-6.5, >> whose internal xen version is xen-4.4-xs88306. After I started the >> vm, both the vm and its corresponding stub domain crash

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:28, wrote: > On Thu, 13 Aug 2015, Jan Beulich wrote: >> >>> On 12.08.15 at 18:15, wrote: >> > On Wed, 12 Aug 2015, Jan Beulich wrote: >> >> >>> On 12.08.15 at 16:47, wrote: >> >> > @@ -31,8 +33,15 @@ typedef int decompress_fn(unsigned char *inbuf, >> >> > unsigned int len,

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 03:31 -0600, Jan Beulich wrote: > > > > > > On 13.08.15 at 10:50, wrote: > > On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: > > > The function shouldn't return NULL after having obtained a reference, > > > or else the caller won't know to drop it. > > > > > Also its

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:43, wrote: > On Thu, 13 Aug 2015, Jan Beulich wrote: >> >>> On 12.08.15 at 18:18, wrote: >> > On 12/08/15 16:58, Jan Beulich wrote: >> > On 12.08.15 at 17:51, wrote: >> >>> On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: >> >>> On 07.08.15 at 04:11, wrote: >>

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 10:54 +0100, Wei Liu wrote: > On Thu, Aug 13, 2015 at 10:42:26AM +0100, Ian Campbell wrote: > > On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > > > Originally, if user didn't specify maxvcpus= in xl config file, the > > > maximum size of vcpu bitmap was always equal to max

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 11:35, wrote: > On Thu, Aug 13, 2015 at 03:33:42AM -0600, Jan Beulich wrote: >> >>> On 13.08.15 at 11:22, wrote: >> > On Wed, Aug 12, 2015 at 08:16:33AM -0600, Jan Beulich wrote: >> >> ... and its callers. >> >> >> >> While all non-nested users are made fully honor the semanti

[Xen-devel] [PATCH] xl: close restore file fd when we're done with it

2015-08-13 Thread Wei Liu
And log if close fails. Reported-by: Andrew Armenia Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Andrew Armenia For 4.6, fix leaking fd to avoid holding on to restoring file. This should also be backported to many versions that uses xl. --- tools/libxl/xl_cmdimpl.c | 9

Re: [Xen-devel] [PATCH] xl: close restore file fd when we're done with it

2015-08-13 Thread Wei Liu
This patch is for 4.6. Forgot to extend the tag in subject line. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v4 0/2] Refactor ioreq server for better performance.

2015-08-13 Thread Yu Zhang
XenGT leverages ioreq server to track and forward the accesses to GPU I/O resources, e.g. the PPGTT(per-process graphic translation tables). Currently, ioreq server uses rangeset to track the BDF/ PIO/MMIO ranges to be emulated. To select an ioreq server, the rangeset is searched to see if the I/O

[Xen-devel] [PATCH v4 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-13 Thread Yu Zhang
Currently in ioreq server, guest write-protected ram pages are tracked in the same rangeset with device mmio resources. Yet unlike device mmio, which can be in big chunks, the guest write- protected pages may be discrete ranges with 4K bytes each. This patch uses a seperate rangeset for the guest

[Xen-devel] [PATCH v4 2/2] Refactor rangeset structure for better performance.

2015-08-13 Thread Yu Zhang
This patch refactors struct rangeset to base it on the red-black tree structure, instead of on the current doubly linked list. By now, ioreq leverages rangeset to keep track of the IO/memory resources to be emulated. Yet when number of ranges inside one ioreq server is very high, traversing a doubl

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Tim Deegan
At 03:46 -0600 on 13 Aug (1439437600), Jan Beulich wrote: > >>> On 13.08.15 at 11:31, wrote: > > At 09:50 +0100 on 13 Aug (1439459451), Ian Campbell wrote: > >> On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: > >> > The function shouldn't return NULL after having obtained a reference, > >> >

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Stefano Stabellini
On Thu, 13 Aug 2015, Jan Beulich wrote: > >>> On 13.08.15 at 11:43, wrote: > > On Thu, 13 Aug 2015, Jan Beulich wrote: > >> >>> On 12.08.15 at 18:18, wrote: > >> > On 12/08/15 16:58, Jan Beulich wrote: > >> > On 12.08.15 at 17:51, wrote: > >> >>> On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich

Re: [Xen-devel] [PATCH for-4.6] xen/mm: populate_physmap: validate correctly the gfn for direct mapped domain

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 03:54 -0600, Jan Beulich wrote: > > > > > > On 13.08.15 at 11:33, wrote: > > On Tue, 2015-08-11 at 18:41 +0100, Julien Grall wrote: > > > --- a/xen/common/memory.c > > > +++ b/xen/common/memory.c > > > @@ -126,22 +126,28 @@ static void populate_physmap(struct memop_args > >

Re: [Xen-devel] [PATCH] xl: close restore file fd when we're done with it

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 11:09 +0100, Wei Liu wrote: > And log if close fails. > > Reported-by: Andrew Armenia > Signed-off-by: Wei Liu > --- Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-13 Thread Paul Durrant
> -Original Message- > From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > Sent: 13 August 2015 11:06 > To: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; > Ian > Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse.com; Andrew Cooper > Cc: Kevin Tian; zhiyuan...@inte

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 03:57 -0600, Jan Beulich wrote: > > > > > > On 13.08.15 at 11:28, wrote: > > On Thu, 13 Aug 2015, Jan Beulich wrote: > > > > > > On 12.08.15 at 18:15, wrote: > > > > On Wed, 12 Aug 2015, Jan Beulich wrote: > > > > > > > > On 12.08.15 at 16:47, > > > > > > > > wrote: > > >

Re: [Xen-devel] [PATCHv3 01/10] mm: memory hotplug with an existing resource

2015-08-13 Thread David Vrabel
On 30/07/15 18:03, David Vrabel wrote: > Add add_memory_resource() to add memory using an existing "System RAM" > resource. This is useful if the memory region is being located by > finding a free resource slot with allocate_resource(). > > Xen guests will make use of this in their balloon driver

Re: [Xen-devel] [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 12:12, wrote: > At 03:46 -0600 on 13 Aug (1439437600), Jan Beulich wrote: >> >>> On 13.08.15 at 11:31, wrote: >> > At 09:50 +0100 on 13 Aug (1439459451), Ian Campbell wrote: >> >> On Fri, 2015-07-24 at 06:37 -0600, Jan Beulich wrote: >> >> > The function shouldn't return NULL a

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 11:13 +0100, Stefano Stabellini wrote: > > > > For example it is only natural for the kernel to try to use the GIC > > > hyp > > > functionalities if they are described, while actually they are not > > > emulated by Xen at all. > > > > See Ian's earlier reply: It can also b

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 11:07:47AM +0100, Ian Campbell wrote: > On Thu, 2015-08-13 at 10:54 +0100, Wei Liu wrote: > > On Thu, Aug 13, 2015 at 10:42:26AM +0100, Ian Campbell wrote: > > > On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > > > > Originally, if user didn't specify maxvcpus= in xl conf

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 12:17, wrote: > On Thu, 2015-08-13 at 03:57 -0600, Jan Beulich wrote: >> > >> > > > On 13.08.15 at 11:28, wrote: >> > On Thu, 13 Aug 2015, Jan Beulich wrote: >> > > > > > On 12.08.15 at 18:15, wrote: >> > > > On Wed, 12 Aug 2015, Jan Beulich wrote: >> > > > > > > > On 12.08.1

Re: [Xen-devel] [PATCH OSSTEST] ts-xen-install: Install netcat-openbsd

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 09:21 +0100, Ian Campbell wrote: > > Which is pretty WTF... Logs for this one are at > http://xenbits.xen.org/people/ianc/tmp/37828/ > http://xenbits.xen.org/people/ianc/tmp/37828/test-amd64-amd64-libvirt > -pair/info.html > > I'm doing an experiment now with $dho->{Ip} but

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Christoffer Dall
On Thu, Aug 13, 2015 at 11:22:19AM +0100, Ian Campbell wrote: > On Thu, 2015-08-13 at 11:13 +0100, Stefano Stabellini wrote: > > > > > > For example it is only natural for the kernel to try to use the GIC > > > > hyp > > > > functionalities if they are described, while actually they are not > > >

Re: [Xen-devel] [PATCH for-4.6] xen/mm: populate_physmap: validate correctly the gfn for direct mapped domain

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 12:14, wrote: > There isn't a race here is there? What if the reference were dropped after > this check but before the guest_physmap_add_page (which takes new > references)? We are implicitly relying on a guarantee made elsewhere that a > direct mapped guest never drops the fina

Re: [Xen-devel] [PATCH for-4.6] tools/libxc: linux: Don't use getpagesize() when unmapping the grants

2015-08-13 Thread Ian Campbell
On Tue, 2015-08-11 at 13:48 +0100, Ian Campbell wrote: > On Fri, 2015-08-07 at 22:45 +0100, Wei Liu wrote: > > On Fri, Aug 07, 2015 at 07:53:55PM +0100, Julien Grall wrote: > > > The grants are based on the Xen granularity (i.e 4KB). While the > > > function > > > to map grants for Linux (linux_gn

Re: [Xen-devel] [PATCH for-4.6 v2 0/4] Patches for c/oxenstored

2015-08-13 Thread Ian Campbell
On Mon, 2015-08-10 at 09:00 +0100, Wei Liu wrote: > Wei Liu (4): > cxenstored: fix systemd socket activation > cxenstored: document a bunch of short options in help string > oxenstored: fix systemd socket activation > oxenstored: move sd_notify_ready out of main loop Applied. > > tools/

Re: [Xen-devel] [PATCH for-4.6] tools/xenstore: Correct use of va_end() after va_copy()

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 10:45 +0100, Wei Liu wrote: > On Fri, Aug 07, 2015 at 02:51:59PM +0100, Andrew Cooper wrote: > > C requires that every use of va_copy() is matched with a va_end() call. > > > > This is especially important for x86_64 as va_{start,copy}() may need > > to > > allocate memory t

Re: [Xen-devel] [PATCH 1/2] tools: libxl: Remove unnecessary trailing \n from log messages.

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 17:42 +0100, Wei Liu wrote: > On Wed, Aug 12, 2015 at 02:56:01PM +0100, Ian Campbell wrote: > > Both xl's LOG and the various libxl logging mechanisms automatically > > include a trailing \n. > > > > Remove all unnecessary \n's from the logs messages with the following > > se

Re: [Xen-devel] [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 10:44 +0100, Wei Liu wrote: > On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote: > > The firmware directory is not built at all on ARM. Attempting to update > > it using the target subtree-force-update will fail when try to update > > seabios. > > > > Signed-off-by

Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-13 Thread Ian Campbell
On Wed, 2015-08-12 at 16:21 +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] gitignore: Don't > ignore *.rej"): > > On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote: > > > These indicate a patch application went wrong, I want to see them in > > > "git

Re: [Xen-devel] [PATCH v4 2/2] Refactor rangeset structure for better performance.

2015-08-13 Thread Paul Durrant
> -Original Message- > From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > Sent: 13 August 2015 11:06 > To: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; > Ian > Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse.com; Andrew Cooper > Cc: Kevin Tian; zhiyuan...@inte

Re: [Xen-devel] [xs-devel] Trying to bring up stub domain in xen-4.4-xs88306

2015-08-13 Thread Wei Liu
On Thu, Aug 13, 2015 at 10:52:14AM +0100, Andrew Cooper wrote: > On 13/08/15 08:04, Xuehan Xu wrote: > > Hi, everyone. > > > > I'm trying to run a Windows HVM vm with stub domain in xenserver-6.5, > > whose internal xen version is xen-4.4-xs88306. After I started the vm, > > both the vm and its cor

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Stefano Stabellini
On Thu, 13 Aug 2015, Christoffer Dall wrote: > On Thu, Aug 13, 2015 at 11:22:19AM +0100, Ian Campbell wrote: > > On Thu, 2015-08-13 at 11:13 +0100, Stefano Stabellini wrote: > > > > > > > > For example it is only natural for the kernel to try to use the GIC > > > > > hyp > > > > > functionalities

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 12:29 +0200, Christoffer Dall wrote: > On Thu, Aug 13, 2015 at 11:22:19AM +0100, Ian Campbell wrote: > > On Thu, 2015-08-13 at 11:13 +0100, Stefano Stabellini wrote: > > > > > > > > For example it is only natural for the kernel to try to use the > > > > > GIC > > > > > hyp

Re: [Xen-devel] [PATCH OSSTEST] ts-xen-install: Install netcat-openbsd

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 11:27 +0100, Ian Campbell wrote: > On Thu, 2015-08-13 at 09:21 +0100, Ian Campbell wrote: > > > > Which is pretty WTF... Logs for this one are at > > http://xenbits.xen.org/people/ianc/tmp/37828/ > > http://xenbits.xen.org/people/ianc/tmp/37828/test-amd64-amd64-libvirt > > -

Re: [Xen-devel] PCI Pass-through in Xen ARM: Draft 4

2015-08-13 Thread Julien Grall
Hi Manish, I left Linaro 4 months ago. Can you please use my email citrix (julien.gr...@citrix.com). On 13/08/15 10:42, Manish Jaggi wrote: > - > > > 1.Background of PCI passthrough >

Re: [Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 11:28 +0100, Wei Liu wrote: > On Thu, Aug 13, 2015 at 11:07:47AM +0100, Ian Campbell wrote: > > On Thu, 2015-08-13 at 10:54 +0100, Wei Liu wrote: > > > On Thu, Aug 13, 2015 at 10:42:26AM +0100, Ian Campbell wrote: > > > > On Wed, 2015-08-12 at 20:36 +0100, Wei Liu wrote: > > >

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Julien Grall
On 13/08/15 10:20, Jan Beulich wrote: >> BTW, IIRC x86 does modify at least one ACPI table which is the DMAR (I >> think), to hide the IOMMU from the guest? That's another table we would >> want to frob on ARM I think (or it's equivalent, which I think is IORT). > > Eliminating that hack is suppos

Re: [Xen-devel] [PATCH for-4.6] xen/mm: populate_physmap: validate correctly the gfn for direct mapped domain

2015-08-13 Thread Ian Campbell
On Thu, 2015-08-13 at 04:29 -0600, Jan Beulich wrote: > > > > > > On 13.08.15 at 12:14, wrote: > > There isn't a race here is there? What if the reference were dropped > > after > > this check but before the guest_physmap_add_page (which takes new > > references)? We are implicitly relying on a

Re: [Xen-devel] [PATCH OSSTEST] ts-xen-install: Install netcat-openbsd

2015-08-13 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST] ts-xen-install: Install netcat-openbsd"): > This is required by libvirt for live migration (netcat-traditional > doesn't cut it). > > netcat-openbsd has higher update-alternatives priority, so it will be > used if installed. Acked-by: Ian Jackson __

Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

2015-08-13 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline"): > I also considered refactoring this bit: > > if [ "x$treeurl" != xnone: ]; then > treearg=--tree-$tree=$treeurl > fi > tested_revis

Re: [Xen-devel] [PATCH v4 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-13 Thread Yu, Zhang
On 8/13/2015 6:16 PM, Paul Durrant wrote: -Original Message- From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: 13 August 2015 11:06 To: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; Ian Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse.com; Andrew Cooper

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Shannon Zhao
On 2015/8/13 18:29, Christoffer Dall wrote: > On Thu, Aug 13, 2015 at 11:22:19AM +0100, Ian Campbell wrote: >> On Thu, 2015-08-13 at 11:13 +0100, Stefano Stabellini wrote: >>> > For example it is only natural for the kernel to try to use the GIC > hyp > functionalities if they are de

[Xen-devel] [PATCH v2] add page_get_owner_and_reference() related ASSERT()s

2015-08-13 Thread Jan Beulich
The function shouldn't return NULL after having obtained a reference, or else the caller won't know to drop it. Also its result shouldn't be ignored - if calling code is certain that a page already has a non-zero refcount, it better ASSERT()s so. Finally this as well as get_page() and put_page()

Re: [Xen-devel] [PATCH v4 2/2] Refactor rangeset structure for better performance.

2015-08-13 Thread Yu, Zhang
On 8/13/2015 6:33 PM, Paul Durrant wrote: -Original Message- From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: 13 August 2015 11:06 To: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; Ian Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse.com; Andrew Cooper

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Jan Beulich
>>> On 13.08.15 at 12:48, wrote: > On 2015/8/13 18:29, Christoffer Dall wrote: >> However, what about for other resources? Having code somewhere that >> says "hide this random piece of hardware if you're Xen dom0" sounds >> awful to me. I know it's only the serial port right now, but still. >>

[Xen-devel] [PATCH] x86/dmi_scan: only honor end-of-table for 64-bit tables

2015-08-13 Thread Jan Beulich
From: Jean Delvare A 32-bit entry point to a DMI table says how many structures the table contains. The SMBIOS specification explicitly says that end-of-table markers should be ignored if they are not actually at the end of the DMI table. So only honor the end-of-table marker for tables accessed

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Julien Grall
On 13/08/15 11:54, Jan Beulich wrote: On 13.08.15 at 12:48, wrote: >> On 2015/8/13 18:29, Christoffer Dall wrote: >>> However, what about for other resources? Having code somewhere that >>> says "hide this random piece of hardware if you're Xen dom0" sounds >>> awful to me. I know it's only

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-13 Thread Stefano Stabellini
On Thu, 13 Aug 2015, Julien Grall wrote: > On 13/08/15 11:54, Jan Beulich wrote: > On 13.08.15 at 12:48, wrote: > >> On 2015/8/13 18:29, Christoffer Dall wrote: > >>> However, what about for other resources? Having code somewhere that > >>> says "hide this random piece of hardware if you're

  1   2   >