Re: [Xen-devel] [PATCH 2/2] x86emul: simplify asm() constraints

2015-03-11 Thread Jan Beulich
>>> On 10.03.15 at 20:48, wrote: > Did you observe any code changes simply from changing = constraints to > +, or did we get very lucky in with the generated code? I think it's not really unexpected that there was no change, since the operands were all memory-only ones (and generally gcc avoids t

Re: [Xen-devel] [PATCH 1/4] x86/MSI-X: be more careful during teardown

2015-03-11 Thread Jan Beulich
>>> On 10.03.15 at 22:05, wrote: > On 10/03/15 16:27, Jan Beulich wrote: >> When a device gets detached from a guest, pciback will clear its >> command register, thus disabling both memory and I/O decoding. The >> disabled memory decoding, however, has an effect on the MSI-X table >> accesses the

Re: [Xen-devel] [libvirt test] 36071: tolerable all pass - PUSHED

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 17:59 +, xen.org wrote: > flight 36071 libvirt real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/36071/ > > Failures :-/ but no regressions. > > Tests which did not succeed, but are not blocking: > test-armhf-armhf-libvirt 10 migrate-support-check

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Jan Beulich
>>> On 10.03.15 at 23:45, wrote: > In order to do static labeling for device passthrough, the nodes in a > device tree need a 32-bit numeric identifier. IO memory uses the MFN, > PCI devices use SBDF, and IRQs and x86 legacy IOs just use the number. A 32-bit number can't uniquely identify an MMI

Re: [Xen-devel] [xen-unstable test] 36062: trouble: broken/fail/pass

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 19:54 +, xen.org wrote: > flight 36062 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/36062/ > > Failures and problems with tests :-( Seems there are two main classes of failure here. > Tests which did not succeed and are blocking, > includi

Re: [Xen-devel] Failed to launch xen on J6 evm

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 20:52 +, Korupol, Naveen (EXT) wrote: > (XEN) > (XEN) Panic on CPU 0: > (XEN) GICv2: Cannot find the maintenance IRQ This suggests that your DTB does not describe the maintenance interrupt on the interrupt controller node. Ian.

Re: [Xen-devel] [PATCH v3 0/2] Add support for Xilinx ZynqMP SoC

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 09:59 +1000, Edgar E. Iglesias wrote: > On Tue, Mar 10, 2015 at 11:30:10AM +, Julien Grall wrote: > > Hello Edgar, > > > > Thank you for adding support of the ZynqMP. > > > > On 10/03/15 02:49, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > > > Adds s

Re: [Xen-devel] [PATCH v3 0/2] Add support for Xilinx ZynqMP SoC

2015-03-11 Thread Edgar E. Iglesias
Sorry for top post. That makes sense, thanks! Cheers, Edgar --- Sent from my phone On 11/03/2015 7:46 pm, "Ian Campbell" wrote: > On Wed, 2015-03-11 at 09:59 +1000, Edgar E. Iglesias wrote: > > On Tue, Mar 10, 2015 at 11:30:10AM +, Julien Grall wrote: > > > Hello Edgar, > > > > > > Thank y

[Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

2015-03-11 Thread Ian Campbell
The recent libvirt failures seemed to happen after a couple of stop/start pairs, so arrange to start/stop each guest 10 times. By cribbing from the existing use of repeat-ts I hope I've arranged for a new test with testid ts-guest-start/debian.repeat. We already arrange by more adhoc means to rep

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 10:12 +, Gareth Stockwell wrote: > Hi Ian, > > Thanks for your reply. > > On Tue, Mar 10, 2015 at 16:22:40, Ian Campbell wrote: > > > > > What is the recommended way for the donor to transmit a batch of > > > grant references? I assume that this requires the donor to pa

Re: [Xen-devel] [PATCH 1/2] iommu VT-d: separate rmrr addition function

2015-03-11 Thread Jan Beulich
>>> On 09.03.15 at 15:42, wrote: > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthrough/vtd/dmar.c > @@ -567,6 +567,66 @@ out: > return ret; > } > > +int register_one_rmrr(struct acpi_rmrr_unit *rmrru) static - I don't see why the command line processing in patch 2 can

Re: [Xen-devel] [PATCH] xen: postpone updating domains' node affinity when removing a CPU from a cpupool

2015-03-11 Thread Dario Faggioli
On Mon, 2015-03-09 at 17:49 +0100, Dario Faggioli wrote: > 93be8285 ("update domU's node-affinity on the cpupool_unassign_cpu() > path") does the right thing, but does it too early. In fact, it > is necessary to call domain_update_node_affinity() when a pCPU is > removed from a cpupool, but that m

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Gareth Stockwell
On Wed, Mar 11, 2015 at 10:24:48, Ian Campbell wrote: > > I think this gives us two options for grant reference batch transmission: > > > > 1. Send the grant references via the ring buffer. > > This doesn't require any additional allocations, but means that if > > the number of grant references in

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Wei Liu
On Wed, Mar 11, 2015 at 10:24:48AM +, Ian Campbell wrote: > On Wed, 2015-03-11 at 10:12 +, Gareth Stockwell wrote: > > Hi Ian, > > > > Thanks for your reply. > > > > On Tue, Mar 10, 2015 at 16:22:40, Ian Campbell wrote: > > > > > > > What is the recommended way for the donor to transmit a

Re: [Xen-devel] [PATCH v4 1/3] xen/arm: Add Xilinx ZynqMP platform support

2015-03-11 Thread Julien Grall
Hi Edgar, On 11/03/2015 01:19, Edgar E. Iglesias wrote: diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile index d9f98f9..315f3e8 100644 --- a/xen/arch/arm/platforms/Makefile +++ b/xen/arch/arm/platforms/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_ARM_32) += rcar2.o obj-$

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-11 Thread Ian Campbell
On Fri, 2015-02-27 at 15:07 +, Xu, Quan wrote: > > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: Wednesday, February 25, 2015 9:54 PM > > To: Xu, Quan > > Cc: Andrew Cooper; Olaf Hering; Daniel De Graaf; xen-devel@lists.xen.org > > Subject: Re:

Re: [Xen-devel] VM Migration on ARM

2015-03-11 Thread Andrew Cooper
On 11/03/15 05:32, Vijay Kilari wrote: > Hi Andrew, > > From Ian & Stefano, I came to know that you have introduced > Migration framework v2 > under below patch series > > http://marc.info/?l=xen-devel&m=141036915311145 > > I have few queries: > > 1) Is there any plans/timeline to support for A

Re: [Xen-devel] [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests

2015-03-11 Thread Julien Grall
Hi Jan, On 10/03/2015 13:35, Jan Beulich wrote: Ah, right, I mixed this up with iommu_hap_pt_share. Roger - looks like this could indeed be replaced by if ( iommu_enabled && iommu_use_hap_pt(d) ) ops->share_p2m(d); and the corresponding check in VT-d and AMD Vi code could then

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 10:40 +, Gareth Stockwell wrote: > On Wed, Mar 11, 2015 at 10:24:48, Ian Campbell wrote: > > > I think this gives us two options for grant reference batch transmission: > > > > > > 1. Send the grant references via the ring buffer. > > > This doesn't require any additional

Re: [Xen-devel] [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

2015-03-11 Thread Ian Campbell
On Tue, 2015-02-03 at 10:45 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 03, 2015 at 03:11:11PM +, Ian Jackson wrote: > > Konrad Rzeszutek Wilk writes ("[PATCH 2/4] libxl: vcpuset: Check max_vcpus > > argument against the maximum number of vCPUs the guest has set."): > > > The maximum num

Re: [Xen-devel] PML (Page Modification Logging) design for Xen

2015-03-11 Thread George Dunlap
On Tue, Feb 17, 2015 at 10:19 AM, Jan Beulich wrote: On 12.02.15 at 03:39, wrote: >> On 02/11/2015 07:52 PM, Andrew Cooper wrote: >>> On 11/02/15 08:28, Kai Huang wrote: Design == - PML feature is used globally A new Xen boot parameter, say 'opt_enable_pml',

Re: [Xen-devel] VM Migration on ARM

2015-03-11 Thread Julien Grall
Hi, On 11/03/2015 10:51, Andrew Cooper wrote: On 11/03/15 05:32, Vijay Kilari wrote: Hi Andrew, From Ian & Stefano, I came to know that you have introduced Migration framework v2 under below patch series http://marc.info/?l=xen-devel&m=141036915311145 I have few queries: 1) Is there an

Re: [Xen-devel] [PATCH v4 4/9] sysctl: Make XEN_SYSCTL_numainfo a little more efficient

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > Make sysctl NUMA topology query use fewer copies by combining some > fields into a single structure and copying distances for each node > in a single copy. > > Instead of using max_node_index for passing number of nodes keep this > value

Re: [Xen-devel] [PATCH v4 7/9] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 13:40 +, Dario Faggioli wrote: > On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > > xc_cputopoinfo() is not expected to be used on a hot path and therefore > > hypercall buffer management can be pushed into libxc. This will simplify > > life for callers. > > >

Re: [Xen-devel] [PATCH v4 8/9] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 13:44 +, Dario Faggioli wrote: > On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > > xc_numainfo() is not expected to be used on a hot path and therefore > > hypercall buffer management can be pushed into libxc. This will simplify > > life for callers. > > > > A

Re: [Xen-devel] [PATCH v4 9/9] libxl: Add interface for querying hypervisor about PCI topology

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 13:51 +, Dario Faggioli wrote: > On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > > .. and use this new interface to display it along with CPU topology > > and NUMA information when 'xl info -n' command is issued > > > > The output will look like > > ... > > cp

Re: [Xen-devel] PML (Page Modification Logging) design for Xen

2015-03-11 Thread Andrew Cooper
On 11/03/15 10:59, George Dunlap wrote: > On Tue, Feb 17, 2015 at 10:19 AM, Jan Beulich wrote: > On 12.02.15 at 03:39, wrote: >>> On 02/11/2015 07:52 PM, Andrew Cooper wrote: On 11/02/15 08:28, Kai Huang wrote: > Design > == > > - PML feature is used globally > >>

[Xen-devel] [PATCH] xen/passthrough: share_p2m: fix build failure on ARM

2015-03-11 Thread Julien Grall
The commit 7978429 "iommu: fix usage of shared EPT/IOMMU page tables on PVH guests" breaks the hypervisor compilation on ARM. This is because the macro hap_enabled is not defined on ARM. On x86, the P2M can only be shared when hap is enabled and the user didn't deny it (via the command line). Tho

Re: [Xen-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 14:45 +0800, Chen, Tiejun wrote: > On 2015/3/6 20:55, Wei Liu wrote: > > On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > >> Although we already have 'gfx_passthru' in b_info, this doesn' suffice

Re: [Xen-devel] [v2][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 17:42 +0800, Tiejun Chen wrote: > While working with qemu, IGD is a specific device in the case of pass through > so we need to identify that to handle more later. Here we define a table to > record all IGD types currently we can support. Also we need to introduce two > helper

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 17:42 +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we can benef

[Xen-devel] [PATCH 1/2] x86: Don't apply reboot quirks if reboot set by user

2015-03-11 Thread Ross Lagerwall
If reboot= is specified on the command-line, don't apply reboot quirks to allow the command-line option to take precedence. This is a port of Linux commit 5955633e91bf ("x86/reboot: Skip DMI checks if reboot set by user"). Signed-off-by: Ross Lagerwall --- xen/arch/x86/shutdown.c | 10 +

Re: [Xen-devel] VM Migration on ARM

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 11:04 +, Julien Grall wrote: > Hi, > > On 11/03/2015 10:51, Andrew Cooper wrote: > > On 11/03/15 05:32, Vijay Kilari wrote: > >> Hi Andrew, > >> > >> From Ian & Stefano, I came to know that you have introduced > >> Migration framework v2 > >> under below patch series

Re: [Xen-devel] [PATCH] xen/passthrough: share_p2m: fix build failure on ARM

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 11:23 +, Julien Grall wrote: > The commit 7978429 "iommu: fix usage of shared EPT/IOMMU page tables on > PVH guests" breaks the hypervisor compilation on ARM. > > This is because the macro hap_enabled is not defined on ARM. > > On x86, the P2M can only be shared when hap

Re: [Xen-devel] [PATCH v3] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 10:43 +0530, Vijay Kilari wrote: > On Tue, Mar 10, 2015 at 5:22 PM, Ian Campbell wrote: > > On Tue, 2015-03-10 at 11:45 +, Julien Grall wrote: > >> On 09/03/15 16:08, Vijay Kilari wrote: > >> > On Mon, Mar 9, 2015 at 5:46 PM, Julien Grall > >> > wrote: > >> >> Hi Vijay,

Re: [Xen-devel] [PATCH v4 1/3] xen/arm: Add Xilinx ZynqMP platform support

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 10:49 +, Julien Grall wrote: > Hi Edgar, > > On 11/03/2015 01:19, Edgar E. Iglesias wrote: > > diff --git a/xen/arch/arm/platforms/Makefile > > b/xen/arch/arm/platforms/Makefile > > index d9f98f9..315f3e8 100644 > > --- a/xen/arch/arm/platforms/Makefile > > +++ b/xen/arc

Re: [Xen-devel] [PATCH v4 1/3] xen/arm: Add Xilinx ZynqMP platform support

2015-03-11 Thread Julien Grall
On 11/03/2015 12:00, Ian Campbell wrote: On Wed, 2015-03-11 at 10:49 +, Julien Grall wrote: Hi Edgar, On 11/03/2015 01:19, Edgar E. Iglesias wrote: diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile index d9f98f9..315f3e8 100644 --- a/xen/arch/arm/platforms/Ma

Re: [Xen-devel] [PATCH v4 3/9] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-11 Thread Boris Ostrovsky
On 03/11/2015 07:04 AM, Ian Campbell wrote: On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: Instead of copying data for each field in xen_sysctl_topologyinfo separately put cpu/socket/node into a single structure and do a single copy for each processor. Do not use max_cpu_index, which

Re: [Xen-devel] [PATCH v2 2/6] tools/libxl: Update datacopier to support sending data only

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > From: Wen Congyang > > Currently, starting a datacopier requires a valid read and write fd, but this > is a problem when purely sending data from a local buffer to a writable fd. > > The prefixdata mechanism already exists and works for i

Re: [Xen-devel] [PATCH v2 1/6] tools/libxl: Introduce min and max macros

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > This is the same set used by libxc. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > > --- > v2: Don't use reserved identifiers in min_t/max_t > --- > tools/libxl/libxl_internal.h | 16 ++

Re: [Xen-devel] [PATCH v2 3/6] tools/libxl: Avoid overrunning static buffer with prefixdata

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > From: Ross Lagerwall > > An individual datacopier_buf contains a static buffer of 1000 bytes. > Attempting to add prefixdata of more than 1000 bytes would overrun the buffer > and cause heap corruption. > > Instead, split the prefixdata a

Re: [Xen-devel] [PATCH 1/2] x86: Don't apply reboot quirks if reboot set by user

2015-03-11 Thread Andrew Cooper
On 11/03/15 11:44, Ross Lagerwall wrote: > If reboot= is specified on the command-line, don't apply reboot quirks > to allow the command-line option to take precedence. > > This is a port of Linux commit 5955633e91bf ("x86/reboot: Skip DMI > checks if reboot set by user"). > > Signed-off-by: Ross L

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Julien Grall
Hi Jan, On 11/03/2015 08:53, Jan Beulich wrote: On 10.03.15 at 23:45, wrote: In order to do static labeling for device passthrough, the nodes in a device tree need a 32-bit numeric identifier. IO memory uses the MFN, PCI devices use SBDF, and IRQs and x86 legacy IOs just use the number. A 3

Re: [Xen-devel] [PATCH v2 4/6] tools/libxl: Allow limiting amount copied by datacopier

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > From: Ross Lagerwall > > Currently, a datacopier will unconditionally read until EOF on its read fd. > > For migration v2, libxl needs to read records of a specific length out of the > migration stream, without reading any further data. >

Re: [Xen-devel] [PATCH v2 5/6] tools/libxl: Extend datacopier to support reading into a buffer

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > From: Ross Lagerwall > > Currently a datacopier may source its data from an fd or local buffer, but its > destination must be an fd. For migration v2, libxl needs to read from the > migration stream into a local buffer. > > Implement a "

Re: [Xen-devel] [PATCH v2 6/6] tools/libxl: Adjust datacopiers POLLHUP handling when the fd is also readable

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > POLLHUP|POLLIN is a valid revent to receive when there is readable data in a > pipe, but the writable fd has been closed. This occurs in migration v2 when > the legacy conversion process (which transforms the data inline) completes and > ex

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 12:15 +, Julien Grall wrote: > Hi Jan, > > On 11/03/2015 08:53, Jan Beulich wrote: > On 10.03.15 at 23:45, wrote: > >> In order to do static labeling for device passthrough, the nodes in a > >> device tree need a 32-bit numeric identifier. IO memory uses the MFN, >

Re: [Xen-devel] [PATCH v2 4/6] tools/libxl: Allow limiting amount copied by datacopier

2015-03-11 Thread Andrew Cooper
On 11/03/15 12:15, Ian Campbell wrote: > On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: >> From: Ross Lagerwall >> >> Currently, a datacopier will unconditionally read until EOF on its read fd. >> >> For migration v2, libxl needs to read records of a specific length out of the >> migratio

Re: [Xen-devel] [PATCH v4 3/9] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 08:02 -0400, Boris Ostrovsky wrote: > it's probably better to wait until v5. Done! ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Andrew Cooper
On 11/03/15 11:44, Ross Lagerwall wrote: > On some systems, the ResetSystem EFI runtime service is broken. Follow the > Linux (and Windows) way by preferring ACPI reboot over EFI reboot. This is > done by making BOOT_EFI a reboot mode similar to BOOT_ACPI and BOOT_KBD. > > This was seen on an Int

Re: [Xen-devel] [PATCH] stubdom: export XEN_ROOT in makefile

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 14:16 +0100, Samuel Thibault wrote: > Wei Liu, le Tue 10 Mar 2015 13:14:39 +, a écrit : > > ... because XEN_ROOT is used in mini-os's Config.mk. > > > > Signed-off-by: Wei Liu > > Acked-by: Samuel Thibault acked + applied, thanks, __

Re: [Xen-devel] [PATCH 3/3] mini-os: sort objects in binary archives

2015-03-11 Thread Ian Campbell
On Thu, 2015-02-05 at 01:22 +0100, Samuel Thibault wrote: > Olaf Hering, le Tue 03 Feb 2015 12:45:37 +0100, a écrit : > > When building stubdom the mini-os objects are also linked into the > > binary. Unfortunately the linker will place them in the order found in > > the archive. Since this order i

Re: [Xen-devel] [PATCH] mini-os: replace XEN_TARGET_ARCH with MINIOS_TARGET_ARCH

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 14:15 +0100, Samuel Thibault wrote: > Wei Liu, le Tue 10 Mar 2015 13:14:38 +, a écrit : > > One place was missed when I did the replacement in 55f7cd7427 ("Mini-OS: > > standalone build"). > > > > Signed-off-by: Wei Liu > > Acked-by: Samuel Thibault Applied, along wit

Re: [Xen-devel] [PATCH] libxc: use xc_dom_panic when decompressor is not supported

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 12:43 +, Andrew Cooper wrote: > On 06/03/2015 11:33, Wei Liu wrote: > > State explicitly that specific decompressor is not supported by libxc. > > Without this change, libxc error message only says the provided kernel > > is invalid, which is misleading. > > > > Signed-off

Re: [Xen-devel] [PATCH v2 0/4] fix freemem loop

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 17:16 +, Stefano Stabellini wrote: > Hi all, > > this patch series fixes the freemem loop on machines with very large > amount of memory, where the current wait time is not enough. > > In order to be able to handle arbitrarly large amount of ram, we > implement in libxl_

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Julien Grall
Hi Daniel, On 10/03/2015 23:39, Daniel De Graaf wrote: On 03/10/2015 07:07 PM, Julien Grall wrote: Hi Daniel, On 10/03/2015 22:45, Daniel De Graaf wrote: BTW, do you have any pointer on how to write a policy for device/IRQ passthrough? There is a bit of documentation in xsm-flask.txt about

Re: [Xen-devel] [PATCH] VHD: Fix locale aware character encoding handling

2015-03-11 Thread Ian Campbell
On Sun, 2015-03-08 at 11:54 +0100, Philipp Hahn wrote: > ASCII is 7 bit only, which does not work in UTF-8 environments: > > failed to read parent name > > Setup locale in vhd-util to parse LC_CTYPE and use the right codeset > when doing file name encoding and decoding. > > Increase allocation fo

Re: [Xen-devel] [PATCH] tools/libxl: cleanup one libxl__calloc() usage

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 09:21 +, Wei Liu wrote: > On Tue, Mar 10, 2015 at 02:28:16PM +0800, Tiejun Chen wrote: > > Its pointless because internally, libxl__calloc() would always > > terminate program execution if failed, > > > > libxl__calloc() > > | > > + void *ptr = calloc(nmemb, size)

Re: [Xen-devel] [PATCH v2 4/6] tools/libxl: Allow limiting amount copied by datacopier

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 12:23 +, Andrew Cooper wrote: > On 11/03/15 12:15, Ian Campbell wrote: > > On Fri, 2015-03-06 at 19:05 +, Andrew Cooper wrote: > >> From: Ross Lagerwall > >> > >> Currently, a datacopier will unconditionally read until EOF on its read fd. > >> > >> For migration v2, l

Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 13:58 +, Julien Grall wrote: > On 23/02/15 16:27, Ian Campbell wrote: > > On Mon, 2015-02-23 at 16:01 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 23/02/15 15:30, Ian Campbell wrote: > >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >>> > +/* This

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Julien Grall
On 11/03/2015 12:23, Ian Campbell wrote: On Wed, 2015-03-11 at 12:15 +, Julien Grall wrote: Hi Jan, On 11/03/2015 08:53, Jan Beulich wrote: On 10.03.15 at 23:45, wrote: In order to do static labeling for device passthrough, the nodes in a device tree need a 32-bit numeric identifier. IO

Re: [Xen-devel] [PATCH v3 18/24] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 15:29 +, Julien Grall wrote: > Hi, > > On 23/02/15 15:34, Ian Campbell wrote: > > On Mon, 2015-02-23 at 10:10 +, Julien Grall wrote: > >> > >> On 20/02/2015 17:04, Ian Campbell wrote: > >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > Currently, when

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Ian Campbell
On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: > Hi Ian, > > On 20/02/15 17:17, Ian Campbell wrote: > >> +/* TODO: Do we need to check is_dying? Mostly to protect against > >> + * hypercall trying to passthrough a device while we are > >> + * dying. > > > > FWIW the PCI case a

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 13:15, wrote: > Hi Jan, > > On 11/03/2015 08:53, Jan Beulich wrote: > On 10.03.15 at 23:45, wrote: >>> In order to do static labeling for device passthrough, the nodes in a >>> device tree need a 32-bit numeric identifier. IO memory uses the MFN, >>> PCI devices use SBDF,

[Xen-devel] [PATCH] x86/domctl: Improve XEN_DOMCTL_hypercall_init error handling

2015-03-11 Thread Andrew Cooper
EACCES cannot be distinguished against an incorrect DOMCTL_INTERFACE_VERSION, and will cause an incorrect "need to rebuild the user-space tool set?" message from libxc. EINVAL is a perfectly reasonable alternative. On the libxc side, put the useful piece of information in the error message, rathe

Re: [Xen-devel] [PATCH v4 0/3] Add support for Xilinx ZynqMP SoC

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 11:19 +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" All applied, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 1/1] xen/arm: Remove warning for platforms without platform specific code

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:34 +0200, Julien Grall wrote: > Hi Edgar, > > On 09/03/2015 07:23, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Replace the warning with an info message stating that the platform > > is generic. > > > > Suggested-by: Ian Campbell > > Signed-off-by: Edga

Re: [Xen-devel] [PATCH] tools: xl: handle unspecified extra= when dealing with root=

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 13:00 +, Wei Liu wrote: > On Mon, Mar 09, 2015 at 12:48:56PM +, Ian Campbell wrote: > > If the cfg file includes root= but not extra= (nor cmdline=, which > > supercedes both) then the command line will end up with an extra > > "(null)" on it (at least with glibc's imp

Re: [Xen-devel] [Xen-users] Grant reference batch transmission

2015-03-11 Thread Gareth Stockwell
On Wed, Mar 11, 2015 at 10:54:25, Ian Campbell wrote: > > > What sorts of batch sizes are you expecting to see in your use case? > > > > We need to share hundreds of MB, so (assuming a 4kB guest page size) > > the batch size can be thousands of grant references. > > FWIW, the granularity of a gref

Re: [Xen-devel] [PATCH] x86/domctl: Improve XEN_DOMCTL_hypercall_init error handling

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 13:56, wrote: > EACCES cannot be distinguished against an incorrect DOMCTL_INTERFACE_VERSION, > and will cause an incorrect "need to rebuild the user-space tool set?" > message > from libxc. EINVAL is a perfectly reasonable alternative. I'm okay with this for the !page case,

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Julien Grall
Hi Ian, On 11/03/2015 12:37, Ian Campbell wrote: On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: Hi Ian, On 20/02/15 17:17, Ian Campbell wrote: +/* TODO: Do we need to check is_dying? Mostly to protect against + * hypercall trying to passthrough a device while we are + * dy

[Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread Jan Beulich
Otherwise the guest can abuse that control to cause e.g. PCIe Unsupported Request responses (by disabling memory and/or I/O decoding and subsequently causing [CPU side] accesses to the respective address ranges), which (depending on system configuration) may be fatal to the host. Note that to alte

[Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Jan Beulich
It's not clear to me why only the enabling operation got handled so far. Signed-off-by: Jan Beulich --- drivers/xen/xen-pciback/conf_space_header.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) --- 4.0-rc3-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_header.c +

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 13:50 +, Julien Grall wrote: > Hi Ian, > > On 11/03/2015 12:37, Ian Campbell wrote: > > On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 20/02/15 17:17, Ian Campbell wrote: > +/* TODO: Do we need to check is_dying? Mostly to protec

[Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
This allows for early-printk to be specified (for existing UARTS at least) without the need to edit Rules.mk. The existing shortcuts are retained, but in a much more compact fashion. An unused EARLY_PRINTK_BAUD was removed from the zynqmq settings. Signed-off-by: Ian Campbell --- docs/misc/arm

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:11 +, Ian Campbell wrote: Sorry, I was too lazy to write a cover letter for these changes and forgot that would mean that git send-email wouldn't thread them. > This allows for early-printk to be specified (for existing UARTS at > least) without the need to edit Rules

Re: [Xen-devel] [libvirt test] 36071: tolerable all pass - PUSHED

2015-03-11 Thread Jim Fehlig
Ian Campbell wrote: > On Tue, 2015-03-10 at 17:59 +, xen.org wrote: > >> flight 36071 libvirt real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/36071/ >> >> Failures :-/ but no regressions. >> >> Tests which did not succeed, but are not blocking: >> test-armhf-armhf-libvirt

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Andrew Cooper
On 11/03/15 14:11, Ian Campbell wrote: > + > +COMMA := , COMMA is available from the root Config.mk as 'comma' ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] xen-pciback: limit guest control of command register

2015-03-11 Thread David Vrabel
On 11/03/15 13:51, Jan Beulich wrote: > Otherwise the guest can abuse that control to cause e.g. PCIe > Unsupported Request responses (by disabling memory and/or I/O decoding > and subsequently causing [CPU side] accesses to the respective address > ranges), which (depending on system configuration

[Xen-devel] vTPM implementation

2015-03-11 Thread Marcos Simó Picó
Hello all, I am looking for information about the vTPM implementation on Xen. I have checked the wiki and its references and all the official documentation and even asked in the Q & A forum. However, I could not find what I am looking for. In the forum they recommended me to ask it here. I’d l

Re: [Xen-devel] [xen-unstable test] 36062: trouble: broken/fail/pass

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 09:30 +, Ian Campbell wrote: > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > test-amd64-i386-qemut-rhel6hvm-intel 3 host-install(3) broken REGR. vs. > > 35887 > > field-cricket never collected its preseed file. serial l

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:19 +, Andrew Cooper wrote: > On 11/03/15 14:11, Ian Campbell wrote: > > + > > +COMMA := , > > COMMA is available from the root Config.mk as 'comma' I had missed the -i off my grep, thanks! Ian. ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 1/2] xen: arm: sort earlyprintk related lists

2015-03-11 Thread Julien Grall
Hi Ian, On 11/03/2015 14:11, Ian Campbell wrote: Also add a bunch of missing entries to the doc Signed-off-by: Ian Campbell I was wondering if we should also order between ARM64 and ARM32. But I guess it doesn't bring much benefit. So: Reviewed-by: Julien Grall Regards, -- Julien Grall

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-11 Thread David Vrabel
On 10/03/15 13:35, Boris Ostrovsky wrote: > On 03/10/2015 07:40 AM, David Vrabel wrote: >> On 09/03/15 14:10, David Vrabel wrote: >>> Memory hotplug doesn't work with PV guests because: >>> >>>a) The p2m cannot be expanded to cover the new sections. >> Broken by 054954eb051f35e74b75a566a96fe756

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: > It's not clear to me why only the enabling operation got handled so > far. Reviewed-by: Konrad Rzeszutek Wilk > > Signed-off-by: Jan Beulich > --- > drivers/xen/xen-pciback/conf_space_header.c | 16 +++- > 1 file chan

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 02:44:18PM +, David Vrabel wrote: > On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: > > On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: > >> It's not clear to me why only the enabling operation got handled so > >> far. > > > > Reviewed-by: Konrad Rzeszutek

Re: [Xen-devel] [PATCH 2/2] xen-pciback: also support disabling of bus-mastering and memory-write-invalidate

2015-03-11 Thread David Vrabel
On 11/03/15 14:42, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 11, 2015 at 01:52:00PM +, Jan Beulich wrote: >> It's not clear to me why only the enabling operation got handled so >> far. > > Reviewed-by: Konrad Rzeszutek Wilk With no reports that this actually fixes anything, do we want this

[Xen-devel] [PATCHv7 2/2] xen/privcmd: improve performance of MMAPBATCH_V2

2015-03-11 Thread David Vrabel
Make the IOCTL_PRIVCMD_MMAPBATCH_V2 (and older V1 version) map multiple frames at a time rather than one at a time, despite the pages being non-consecutive GFNs. xen_remap_foreign_mfn_array() is added which maps an array of GFNs (instead of a consecutive range of GFNs). Since per-frame errors are

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 11:01 +, Wei Liu wrote: > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > with the rest of the file, where we return 1 on 0, rather > > than using libxl error codes. > > > > While being consistent is good I'm not very sure if we should go for 0/1 > ra

[Xen-devel] [PATCHv7 0/2] xen: improve migration performance

2015-03-11 Thread David Vrabel
This series signficantly improves the performance of migration by speeding up privcmd's MMAPBATCH_V2 ioctl (for PV toolstack domains). Changes in v7: - Drop (broken) arm __get_user() patch and use get_user() instead as a workaround. - Fix MMAPBATCH_V1 error reporting. Changes in v6: - unify PVH

[Xen-devel] [PATCHv7 1/2] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-11 Thread David Vrabel
Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and unmap foreign GFNs using the same method (updating the physmap). Unify the two arm and x86 implementations into one commont one. Note that on arm and arm64, the correct error code will be returned (instead of always -EFAULT) and

Re: [Xen-devel] [PATCH 2/2] xen: arm: more flexible scheme for specifying early printk device

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 14:47 +, Julien Grall wrote: > Hi Ian, > > On 11/03/2015 14:11, Ian Campbell wrote: > > This allows for early-printk to be specified (for existing UARTS at > > least) without the need to edit Rules.mk. > > > > The existing shortcuts are retained, but in a much more compac

Re: [Xen-devel] [PATCH] xen: postpone updating domains' node affinity when removing a CPU from a cpupool

2015-03-11 Thread George Dunlap
On 03/09/2015 04:49 PM, Dario Faggioli wrote: > 93be8285 ("update domU's node-affinity on the cpupool_unassign_cpu() > path") does the right thing, but does it too early. In fact, it > is necessary to call domain_update_node_affinity() when a pCPU is > removed from a cpupool, but that must happen

[Xen-devel] [PATCH] flask/policy: fix static device labeling examples

2015-03-11 Thread Daniel De Graaf
The definitions of static device labels must be placed at the end of the policy.conf before passing it to checkpolicy; the existing examples (which are commented out) are in the wrong location. Create a new file for device contexts which will place them in the proper location. This also removes s

Re: [Xen-devel] [PATCH v7 02/21] libxc: duplicate snippet to allocate p2m_host array

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > Currently all in tree code doesn't set the superpage flag, I would just > remove superpage support if I can, but Konrad wants it retained for the > moment. > > As I'm going to change the p2m_host array allocation, duplicate the code > snippet to

Re: [Xen-devel] [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 18:22 +0100, Dario Faggioli wrote: > instead manually free the elements of the list, which is ^of freeing > exactly the purpose of the said function. > > Trade also a couple of 'return'-s with 'goto out'-s, which > is more in line with libxl usage paradigm. >

Re: [Xen-devel] [PATCH 0/9] Some (not only) cpupool related fixes and improvements

2015-03-11 Thread Ian Campbell
On Fri, 2015-03-06 at 18:20 +0100, Dario Faggioli wrote: > Hi everyone, > > The main goal of this series is making it possible to specify ranges of pCPUs > when manipulating (creating, adding/removing pCPUs) cpupools. Something like > this: > > xl cpupool-cpu-remove Pool-node0 6-10 > > while, r

Re: [Xen-devel] [PATCH 0/9] Some (not only) cpupool related fixes and improvements

2015-03-11 Thread Dario Faggioli
On Wed, 2015-03-11 at 14:56 +, Ian Campbell wrote: > On Fri, 2015-03-06 at 18:20 +0100, Dario Faggioli wrote: > > --- > > Dario Faggioli (9): > > 1/9 docs: RTDS is a valid alternative as a scheduler for a cpupool > > 2/9 docs: fix `xl list' manpage entry > > Acked + applied these two. >

Re: [Xen-devel] [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent

2015-03-11 Thread Ian Campbell
On Wed, 2015-03-11 at 15:04 +, Wei Liu wrote: > On Wed, Mar 11, 2015 at 02:52:31PM +, Ian Campbell wrote: > > On Mon, 2015-03-09 at 11:01 +, Wei Liu wrote: > > > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > > > with the rest of the file, where we return 1 on 0, ra

Re: [Xen-devel] [PATCH v7 21/21] xl: vNUMA support

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 12:51 +, Wei Liu wrote: > +Each B is a quoted key=value pair. Supported > +Bs are: Which of these are optional and which are mandatory? All mandatory? > +if (!xlu_cfg_get_long (config, "maxmem", &l, 0)) > +max_memkb1 = l * 1024; I think you should arrange t

  1   2   >