[Xen-devel] [PATCH v2 0/6] grub-xen: support booting huge pv-domains

2016-02-10 Thread Juergen Gross
The Xen hypervisor supports starting a dom0 with large memory (up to the TB range) by not including the initrd and p2m list in the initial kernel mapping. Especially the p2m list can grow larger than the available virtual space in the initial mapping. The started kernel is indicating the support o

[Xen-devel] [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

2016-02-10 Thread Juergen Gross
Do the allocation of page tables in a separate function. This will allow to do the allocation at different times of the boot preparations depending on the features the kernel is supporting. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen.c | 82

[Xen-devel] [PATCH v2 6/6] xen: add capability to load p2m list outside of kernel mapping

2016-02-10 Thread Juergen Gross
Modern pvops linux kernels support a p2m list not covered by the kernel mapping. This capability is flagged by an elf-note specifying the virtual address the kernel is expecting the p2m list to be mapped to. In case the elf-note is set by the kernel don't place the p2m list into the kernel mapping

[Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-10 Thread Juergen Gross
Modern pvops linux kernels support an initrd not covered by the initial mapping. This capability is flagged by an elf-note. In case the elf-note is set by the kernel don't place the initrd into the initial mapping. This will allow to load larger initrds and/or support domains with larger memory, a

[Xen-devel] [PATCH v2 5/6] xen: modify page table construction

2016-02-10 Thread Juergen Gross
Modify the page table construction to allow multiple virtual regions to be mapped. This is done as preparation for removing the p2m list from the initial kernel mapping in order to support huge pv domains. This allows a cleaner approach for mapping the relocator page by using this capability. The

[Xen-devel] [PATCH v2 2/6] xen: factor out allocation of special pages into separate function

2016-02-10 Thread Juergen Gross
Do the allocation of special pages (start info, console and xenbus ring buffers) in a separate function. This will allow to do the allocation at different times of the boot preparations depending on the features the kernel is supporting. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen

[Xen-devel] [PATCH v2 1/6] xen: factor out p2m list allocation into separate function

2016-02-10 Thread Juergen Gross
Do the p2m list allocation of the to be loaded kernel in a separate function. This will allow doing the p2m list allocation at different times of the boot preparations depending on the features the kernel is supporting. While at this remove superfluous setting of first_p2m_pfn and nr_p2m_frames as

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 7:56 PM, Tamas K Lengyel wrote: On Wed, Feb 10, 2016 at 10:34 AM, Corneliu ZUZU > wrote: On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 3a90f47..e46be1b 100644

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: I think it would be better if this function just had a single rc instead of two (not passing one rc as a pointer on input). Good point. Would it be ok if: * I remove the rc param * make return type int * rc = 0 if arch-side didn't handle the event, b

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 7:11 PM, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -17,6 +17,12 @@ #ifndef __ASM_X86_HVM_EVENT_H__ #define __ASM_X86_H

[Xen-devel] [qemu-upstream-4.4-testing test] 81625: regressions - trouble: broken/fail/pass

2016-02-10 Thread osstest service owner
flight 81625 qemu-upstream-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/81625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 3 host-install(3)broken REGR. vs. 77834 test-am

[Xen-devel] [linux-3.16 baseline-only test] 38735: regressions - FAIL

2016-02-10 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38735 linux-3.16 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38735/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-midway 15 guest-start/debia

Re: [Xen-devel] [PATCH v2 1/1] XEN/ARM: Add Odroid-XU3/XU4 support

2016-02-10 Thread Suriyan Ramasami
On Wed, Feb 10, 2016 at 2:03 AM, Ian Campbell wrote: > On Tue, 2016-02-09 at 10:20 -0800, Suriyan Ramasami wrote: > > I agree on the first two paragraphs. > > > > For the third paragraph, the rebuttal is that the exynos5800 and > > > > exynos5422 based SoCs can have both clusters on at the same

[Xen-devel] [xen-unstable test] 81620: tolerable FAIL - PUSHED

2016-02-10 Thread osstest service owner
flight 81620 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/81620/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 15 guest-start/debian.repeatfail like 80683 test-amd64-i386-xl-qemut-win7

Re: [Xen-devel] [PATCH] xen: Fix XSM build following c/s 92942fd

2016-02-10 Thread Daniel De Graaf
On 10/02/16 05:47, Jan Beulich wrote: On 10.02.16 at 11:39, wrote: On 09/02/16 17:05, Jan Beulich wrote: On 09.02.16 at 17:21, wrote: Signed-off-by: Andrew Cooper I'm sorry for the breakage / not noticing. --- CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell CC: Daniel De Graaf Is th

Re: [Xen-devel] [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented

2016-02-10 Thread Alex Braunegg
Hi Ian, > There is a function internal to libxl (libxl__domain_pvcontrol) which > answers this question (by looking at the callback IRQ). I looked at this function yesterday and it appears that it calls: ret = libxl__domain_pvcontrol_available(gc, domid); which in turn calls: r

Re: [Xen-devel] [PATCH v4 01/17] Xen: ACPI: Hide UART used by Xen

2016-02-10 Thread Rafael J. Wysocki
On Tuesday, February 09, 2016 11:19:02 AM Stefano Stabellini wrote: > On Mon, 8 Feb 2016, Rafael J. Wysocki wrote: > > On Monday, February 08, 2016 10:57:01 AM Stefano Stabellini wrote: > > > On Sat, 6 Feb 2016, Rafael J. Wysocki wrote: > > > > On Fri, Feb 5, 2016 at 4:05 AM, Shannon Zhao > > > >

[Xen-devel] [ovmf test] 81618: regressions - FAIL

2016-02-10 Thread osstest service owner
flight 81618 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/81618/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 65543 version targeted

[Xen-devel] [linux-3.16 test] 81614: tolerable trouble: blocked/broken/fail/pass - PUSHED

2016-02-10 Thread osstest service owner
flight 81614 linux-3.16 real [real] http://logs.test-lab.xenproject.org/osstest/logs/81614/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 3 host-install(3) broken pass in 81206 test-armhf-armhf-xl-credi

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Andrew Cooper
On 10/02/2016 17:11, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: >> On 2/10/2016 6:18 PM, Jan Beulich wrote: >> On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -17,6 +17,12 @@ #ifndef __ASM_X86_HVM_EVEN

Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 7:16 PM, Jan Beulich wrote: On 10.02.16 at 17:44, wrote: On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU wrote: Rename: - arch/x86/monitor_x86.c -> arch/x86/monitor.c - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h (previous commit explains why these renames

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 7:11 PM, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -17,6 +17,12 @@ #ifndef __ASM_X86_HVM_EVENT_H__ #define __ASM_X86_H

Re: [Xen-devel] [PATCH v2] build: specify minimum versions of make and binutils

2016-02-10 Thread Andrew Cooper
On 28/01/2016 13:47, Jan Beulich wrote: On 28.01.16 at 14:02, wrote: >> On Thu, 2016-01-28 at 05:49 -0700, Jan Beulich wrote: >> On 28.01.16 at 00:12, wrote: To help people avoid having to figure out what versions of make and binutils need to be supported document them explicit

Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:44 PM, Tamas K Lengyel wrote: On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU > wrote: Rename: - arch/x86/monitor_x86.c -> arch/x86/monitor.c - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h (previous commit explain

[Xen-devel] [xen-unstable-smoke test] 81826: tolerable all pass - PUSHED

2016-02-10 Thread osstest service owner
flight 81826 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/81826/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH 8/8] x86/efi: Generate uefi_call_wrapper() when compiling with clang

2016-02-10 Thread Andrew Cooper
On 10/02/16 13:41, Andrew Cooper wrote: > On 10/02/16 13:31, Jan Beulich wrote: > On 09.02.16 at 21:01, wrote: >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> >>> What is the GCC version check supposed to be achieving here? GCC has >>> supported this syntax since 3.0 >> Thi

[Xen-devel] [qemu-upstream-unstable test] 81615: regressions - FAIL

2016-02-10 Thread osstest service owner
flight 81615 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/81615/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 9 redhat-installfail REGR. vs. 80694 test-amd64

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Tamas K Lengyel
On Wed, Feb 10, 2016 at 10:34 AM, Corneliu ZUZU wrote: > > On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: > > > > On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU > wrote: > >> 1. Kconfig: >> * Added Kconfigs for common monitor vm-events: >> # see files: common/Kconfig, x86/Kconfig >> HAS_VM

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Tamas K Lengyel
On Wed, Feb 10, 2016 at 10:28 AM, Razvan Cojocaru wrote: > On 02/10/2016 07:04 PM, Corneliu ZUZU wrote: > >>> @@ -27,9 +33,8 @@ bool_t hvm_event_cr(unsigned int index, unsigned > >>> long value, > >>> #define hvm_event_crX(what, new, old) \ > >>> hvm_event_cr(VM_EVENT_X86_##what, new, old

Re: [Xen-devel] [PATCH 1/3] x86: avoid flush IPI when possible

2016-02-10 Thread Andrew Cooper
On 10/02/16 15:37, Jan Beulich wrote: On 10.02.16 at 16:00, wrote: >> On 10/02/16 12:56, Jan Beulich wrote: >>> Since CLFLUSH, other than WBINVD, is a coherency domain wide flush, >> I can't parse this sentence. > Should have been "..., is a cache coherency domain wide flush, ..." - > does it

Re: [Xen-devel] [PATCH] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 17:33 +, Andrew Cooper wrote: > On 10/02/16 17:27, Ian Campbell wrote: > > That is, if gc is not NOGC and ptr is not NULL then ptr must be > > associated gc. > > > > Currently in this case the new_ptr would not be registered with any > > gc, which Coverity rightly points o

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Razvan Cojocaru
On 02/10/2016 07:04 PM, Corneliu ZUZU wrote: >>> @@ -27,9 +33,8 @@ bool_t hvm_event_cr(unsigned int index, unsigned >>> long value, >>> #define hvm_event_crX(what, new, old) \ >>> hvm_event_cr(VM_EVENT_X86_##what, new, old) >>> void hvm_event_msr(unsigned int msr, uint64_t value); >>> -/*

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU > wrote: 1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig HAS_VM_EVENT_WRITE_CTRLREG HAS

Re: [Xen-devel] [PATCH] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-10 Thread Andrew Cooper
On 10/02/16 17:27, Ian Campbell wrote: > That is, if gc is not NOGC and ptr is not NULL then ptr must be > associated gc. > > Currently in this case the new_ptr would not be registered with any > gc, which Coverity rightly points out would be a memory leak. > > It would also be possible to fix this

[Xen-devel] [PATCH] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-10 Thread Ian Campbell
That is, if gc is not NOGC and ptr is not NULL then ptr must be associated gc. Currently in this case the new_ptr would not be registered with any gc, which Coverity rightly points out would be a memory leak. It would also be possible to fix this by adding a libxl__ptr_add() at the same point, ho

Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 17:44, wrote: > On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU > wrote: > >> Rename: >> - arch/x86/monitor_x86.c -> arch/x86/monitor.c >> - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h >> >> (previous commit explains why these renames were necessary) >> > >

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:30 PM, Jan Beulich wrote: On 10.02.16 at 17:26, wrote: On 10.02.16 at 16:52, wrote: xen/arch/x86/Kconfig | 4 + xen/arch/x86/Makefile | 2 +- xen/arch/x86/hvm/event.c | 2 +- xen/arch/x

Re: [Xen-devel] [PATCH v2 7/7] xen/vm-events: move arch_domain.monitor bits to common

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:29 PM, Jan Beulich wrote: On 10.02.16 at 17:00, wrote: +#if CONFIG_HAS_VM_EVENT_GUEST_REQUEST +uint8_t guest_request_enabled : 1; +uint8_t guest_request_sync : 1; +#endif // HAS_VM_EVENT_GUEST_REQUEST +} monitor; }; Please use C-style comment

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:26 PM, Jan Beulich wrote: On 10.02.16 at 16:52, wrote: xen/arch/x86/Kconfig | 4 + xen/arch/x86/Makefile | 2 +- xen/arch/x86/hvm/event.c | 2 +- xen/arch/x86/hvm/hvm.c

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 18:04, wrote: > On 2/10/2016 6:18 PM, Jan Beulich wrote: > On 10.02.16 at 16:50, wrote: >>> --- a/xen/include/asm-x86/hvm/event.h >>> +++ b/xen/include/asm-x86/hvm/event.h >>> @@ -17,6 +17,12 @@ >>> #ifndef __ASM_X86_HVM_EVENT_H__ >>> #define __ASM_X86_HVM_EVENT_H__ >>>

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 17:37, wrote: > On 10/02/16 16:18, Jan Beulich wrote: >> >>> --- a/xen/include/asm-x86/hvm/event.h >>> +++ b/xen/include/asm-x86/hvm/event.h >>> @@ -17,6 +17,12 @@ >>> #ifndef __ASM_X86_HVM_EVENT_H__ >>> #define __ASM_X86_HVM_EVENT_H__ >>> >>> +enum hvm_event_breakpoint_type

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Corneliu ZUZU
On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: @@ -151,61 +154,52 @@ void hvm_event_guest_request(void) } } -int hvm_event_int3(unsigned long rip) +static inline +uint64_t gfn_of_rip(unsigned long rip) This should be a single line and the return value should

Re: [Xen-devel] [PATCH v5 1/7] VT-d: Check VT-d Device-TLB flush error(IOMMU part).

2016-02-10 Thread Jan Beulich
>>> On 05.02.16 at 11:18, wrote: > This patch checks all kinds of error and all the way up > the call trees of VT-d Device-TLB flush(IOMMU part). > > Signed-off-by: Quan Xu > --- > xen/drivers/passthrough/amd/iommu_init.c | 4 +- > xen/drivers/passthrough/amd/pci_amd_iommu.c | 4 +- >

[Xen-devel] [PATCH] public/io/netif.h: fix typos

2016-02-10 Thread Paul Durrant
Unfortunately my patch 162a81ab "document control ring and toeplitz hashing" contained a couple of typos. This patch fixes them. Signed-off-by: Paul Durrant Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/netif.h | 4 ++-- 1 file cha

[Xen-devel] [PATCH] init-xenstore-domain: cleanup all resources on a single exit path

2016-02-10 Thread Ian Campbell
Previously xs_fd would be left open, which is CID 1055993 (previously partially fixed by 3bca826aae5eb). Instead arrange for both success and error cases to cleanup everything on a single exit path instead of doing partial cleanup on the success path a few operations higher up. Signed-off-by: Ian

[Xen-devel] [xen-unstable-smoke test] 81805: regressions - FAIL

2016-02-10 Thread osstest service owner
flight 81805 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/81805/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 9 debian-installfail REGR. vs. 81619 Tests which di

Re: [Xen-devel] Urgent: Cleaning up project list in preparation for GSoc and the next Outreachy round

2016-02-10 Thread Lars Kurth
Hi all, Just to let you know, I created a combined landing page for the next Outreachy and GSoC rounds at http://wiki.xenproject.org/wiki/Outreachy/Round12%2B2016GSoC I will be chasing owners of projects to see whether these are still

Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-10 Thread Tamas K Lengyel
On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU wrote: > Rename: > - arch/x86/monitor_x86.c -> arch/x86/monitor.c > - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h > > (previous commit explains why these renames were necessary) > Referencing a "previous commit" like this is not

Re: [Xen-devel] [qemu-mainline test] 80469: regressions - FAIL

2016-02-10 Thread Paul Durrant
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: 10 February 2016 15:25 > To: Paul Durrant; Anthony Perard; osstest service owner; Ian Jackson; > Stefano Stabellini > Cc: xen-de...@lists.xensource.com > Subject: Re: [Xen-devel] [qemu-mainline test] 80469: r

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Tamas K Lengyel
On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU wrote: > 1. Kconfig: > * Added Kconfigs for common monitor vm-events: > # see files: common/Kconfig, x86/Kconfig > HAS_VM_EVENT_WRITE_CTRLREG > HAS_VM_EVENT_SINGLESTEP > HAS_VM_EVENT_SOFTWARE_BREAKPOINT > HAS_VM_EVENT_GUEST_REQUES

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Andrew Cooper
On 10/02/16 16:18, Jan Beulich wrote: > >> --- a/xen/include/asm-x86/hvm/event.h >> +++ b/xen/include/asm-x86/hvm/event.h >> @@ -17,6 +17,12 @@ >> #ifndef __ASM_X86_HVM_EVENT_H__ >> #define __ASM_X86_HVM_EVENT_H__ >> >> +enum hvm_event_breakpoint_type >> +{ >> +HVM_EVENT_SOFTWARE_BREAKPOINT

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 17:26, wrote: On 10.02.16 at 16:52, wrote: >> xen/arch/x86/Kconfig | 4 + >> xen/arch/x86/Makefile | 2 +- >> xen/arch/x86/hvm/event.c | 2 +- >> xen/arch/x86/hvm/hvm.c

Re: [Xen-devel] [PATCH v2 7/7] xen/vm-events: move arch_domain.monitor bits to common

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 17:00, wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -464,6 +464,22 @@ struct domain > /* vNUMA topology accesses are protected by rwlock. */ > rwlock_t vnuma_rwlock; > struct vnuma_info *vnuma; > + > +/* Common monitor vm-events

[Xen-devel] [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data

2016-02-10 Thread Ian Campbell
Otherwise the fd is leaked. NB the mmap'd memory in the global cpu_qos_data[n] is not affected by closing the underlying fd. Compile tested only. CID: 1055930 Signed-off-by: Ian Campbell --- tools/xenmon/xenbaked.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenmon/xenbaked.c b/t

[Xen-devel] [PATCH] loadpolicy: only close polFd if it is valid

2016-02-10 Thread Ian Campbell
It can be -1 at this point. CID 1055562 Signed-off-by: Ian Campbell --- tools/flask/utils/loadpolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/flask/utils/loadpolicy.c b/tools/flask/utils/loadpolicy.c index 47b5139..76710a2 100644 --- a/tools/flask/utils/loadpol

Re: [Xen-devel] [PATCH 2/3] x86: use CLFLUSHOPT when available

2016-02-10 Thread Andrew Cooper
On 10/02/16 15:39, Jan Beulich wrote: On 10.02.16 at 16:03, wrote: >> On 10/02/16 12:57, Jan Beulich wrote: >>> Also drop an unnecessary va adjustment in the code being touched. >>> >>> Signed-off-by: Jan Beulich >>> >>> --- a/xen/arch/x86/flushtlb.c >>> +++ b/xen/arch/x86/flushtlb.c >>> @@

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 16:52, wrote: > xen/arch/x86/Kconfig | 4 + > xen/arch/x86/Makefile | 2 +- > xen/arch/x86/hvm/event.c | 2 +- > xen/arch/x86/hvm/hvm.c| 2 +- > xen/arch/x86/hv

[Xen-devel] [PATCH 2/2] xenmon: initialise dummy array

2016-02-10 Thread Ian Campbell
This is just used to expand the shared backing file to the expected size (whether this is actually necessary I'm not sure). Rather than leaking some small amount of the processes' heap set the array to zeroes. While at it add a check that the malloc succeeded before using the result. Compile test

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 16:50, wrote: > @@ -151,61 +154,52 @@ void hvm_event_guest_request(void) > } > } > > -int hvm_event_int3(unsigned long rip) > +static inline > +uint64_t gfn_of_rip(unsigned long rip) This should be a single line and the return value should be unsigned long. > { > -

Re: [Xen-devel] [PATCH v2 1/7] xen/arm: fix file comments

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Corneliu ZUZU wrote: > Add file header comment and local variable block @ EOF > of xen/arch/arm/hvm.c. > > Signed-off-by: Corneliu ZUZU Acked-by: Stefano Stabellini > xen/arch/arm/hvm.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-)

[Xen-devel] [PATCH v2 7/7] xen/vm-events: move arch_domain.monitor bits to common

2016-02-10 Thread Corneliu ZUZU
This patch moves bitfield members for single-step, software-breakpoint and guest-request monitor vm-events from the arch-side (arch_domain.monitor) to the common-side (domain.monitor). Ctrl-reg bits (i.e. write_ctrlreg_* members) are left on the arch-side, because control-registers number can vary

[Xen-devel] [PATCH v2 6/7] Rename event_x86.c to event.c and event_arch.h to event.h + minor fixes

2016-02-10 Thread Corneliu ZUZU
Rename: - arch/x86/hvm/event_x86.c -> arch/x86/hvm/event.c - asm-{x86,arm}/hvm/event_arch.h -> asm-{x86/arm}/hvm/event.h (previous commit explains why these renames were necessary) Minor fixes: * xen/common/hvm/event.c: fix malformed file header comment * xen/hvm/event.h: fix comm

[Xen-devel] [PATCH v2 5/7] xen/vm-events: Move hvm_event_* functions to common-side.

2016-02-10 Thread Corneliu ZUZU
1. Moved hvm_event_traps, hvm_event_cr, hvm_event_guest_request, hvm_event_breakpoint from arch-side to common-side 1.1. Moved arch/x86/hvm/event.c to common/hvm/event.c # see files: arch/x86/hvm/Makefile, xen/common/Makefile, xen/common/hvm/Makefile, xen/common/

Re: [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set()

2016-02-10 Thread Luis R. Rodriguez
On Wed, Feb 10, 2016 at 7:44 AM, Olaf Hering wrote: > On Wed, Feb 10, Luis R. Rodriguez wrote: > >> cherry picks for fixes or huge interest to keep it compatible with latest >> compilers qemu-xen-traditional seems to be more of a liability than a > > Hey, this is about gnutls, not gcc! Actually n

[Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-10 Thread Corneliu ZUZU
Rename: - arch/x86/monitor_x86.c -> arch/x86/monitor.c - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h (previous commit explains why these renames were necessary) Signed-off-by: Corneliu ZUZU --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/{monitor_x

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 15:42 +, Stefano Stabellini wrote: > On Wed, 10 Feb 2016, Ian Campbell wrote: > > On Wed, 2016-02-10 at 14:51 +, Stefano Stabellini wrote: > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > > > > > On Wed, 20

[Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-10 Thread Corneliu ZUZU
1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig HAS_VM_EVENT_WRITE_CTRLREG HAS_VM_EVENT_SINGLESTEP HAS_VM_EVENT_SOFTWARE_BREAKPOINT HAS_VM_EVENT_GUEST_REQUEST 2. Moved monitor_domctl from arch-side to common-side 2.1. Moved

[Xen-devel] [xen-unstable-coverity test] 81806: all pass - PUSHED

2016-02-10 Thread osstest service owner
flight 81806 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/81806/ Perfect :-) All tests in this flight passed version targeted for testing: xen 1ac81bb7166b79b6555290547d4e305c74d0 baseline version: xen 9937763265d9597e5f

[Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-10 Thread Corneliu ZUZU
This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single function called hvm_event_breakpoint. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/hvm/event.c| 76 +++-- xen/arch/x86/hvm/vmx/vmx.c | 15

[Xen-devel] [PATCH v2 0/7] Vm-events: move monitor vm-events code to common-side.

2016-02-10 Thread Corneliu ZUZU
This patch series is an attempt to move (most) of the monitor vm-events code to the common-side. Patches summary: 1. Minor file-comment fix 2. Merge almost identical functions hvm_event_int3 + hvm_event_single_step -> hvm_event_breakpoint. 3. Add Kconfigs: HAS_VM_EVENT_WRITE_CTRLREG, HAS_VM

[Xen-devel] [PATCH v2 1/7] xen/arm: fix file comments

2016-02-10 Thread Corneliu ZUZU
Add file header comment and local variable block @ EOF of xen/arch/arm/hvm.c. Signed-off-by: Corneliu ZUZU --- xen/arch/arm/hvm.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index 5fd0753..056db1a 10064

Re: [Xen-devel] [PATCH 1/3] x86: avoid flush IPI when possible

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 16:00, wrote: > On 10/02/16 12:56, Jan Beulich wrote: >> Since CLFLUSH, other than WBINVD, is a coherency domain wide flush, > > I can't parse this sentence. Should have been "..., is a cache coherency domain wide flush, ..." - does it read any better then? > CLFUSH states "I

Re: [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set()

2016-02-10 Thread Olaf Hering
On Wed, Feb 10, Luis R. Rodriguez wrote: > cherry picks for fixes or huge interest to keep it compatible with latest > compilers qemu-xen-traditional seems to be more of a liability than a Hey, this is about gnutls, not gcc! Olaf ___ Xen-devel mailing

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:51 +, Stefano Stabellini wrote: > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > > > > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > > > > On Wed, Feb 10

Re: [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set()

2016-02-10 Thread Luis R. Rodriguez
On Wed, Feb 10, 2016 at 09:46:30AM +, Ian Campbell wrote: > On Tue, 2016-02-09 at 19:04 -0800, Luis R. Rodriguez wrote: > > On Tue, Feb 9, 2016 at 10:23 AM, Olaf Hering wrote: > > > On Tue, Feb 09, Luis R. Rodriguez wrote: > > > > > > > Thanks so it seems the other option is to bump the relea

Re: [Xen-devel] [PATCH 2/3] x86: use CLFLUSHOPT when available

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 16:03, wrote: > On 10/02/16 12:57, Jan Beulich wrote: >> Also drop an unnecessary va adjustment in the code being touched. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/flushtlb.c >> +++ b/xen/arch/x86/flushtlb.c >> @@ -139,10 +139,12 @@ unsigned int flush_area_loca

Re: [Xen-devel] [qemu-mainline test] 80469: regressions - FAIL

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 12:09 +, Paul Durrant wrote: > > I would prefer if libxl also kicked off qemu with a default events file > that enabled logging from the platform device). FWIW from upstream commit 10578a257d94 it appears to be possible to do this from the QEMU command line with "-trace e

Re: [Xen-devel] HVMlite ABI specification DRAFT B + implementation outline

2016-02-10 Thread Boris Ostrovsky
On 02/10/2016 09:51 AM, Roger Pau Monné wrote: The detection of local APIC and IO APICs is quite isolated from each other, and the failure to find any IO APICs should not prevent local APICs from being enabled. Although I don't think there's any hardware with this setup, such configuration would

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 14:51 +, Stefano Stabellini wrote: > On Wed, 10 Feb 2016, Ian Campbell wrote: > > On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > > > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrot

Re: [Xen-devel] [PATCH 2/3] x86: use CLFLUSHOPT when available

2016-02-10 Thread Andrew Cooper
On 10/02/16 12:57, Jan Beulich wrote: > Also drop an unnecessary va adjustment in the code being touched. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/flushtlb.c > +++ b/xen/arch/x86/flushtlb.c > @@ -139,10 +139,12 @@ unsigned int flush_area_local(const void > c->x86_clflush

Re: [Xen-devel] [PATCH 3/3] x86: rename X86_FEATURE_{CLFLSH -> CLFLUSH}

2016-02-10 Thread Andrew Cooper
On 10/02/16 12:57, Jan Beulich wrote: > This is both more natural and in line with a Linux change (between 3.14 > and 3.15). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.

Re: [Xen-devel] [PATCH v3] travis: add initial Travis CI script to do builds

2016-02-10 Thread Wei Liu
On Sun, Feb 07, 2016 at 08:45:03PM -0600, Doug Goldstein wrote: > This is just suppose to do a simple compile test on Travis CI. Currently > due to linux86 (bcc/bin86/dev86) not being whitelisted the tools cannot > be built. > > Signed-off-by: Doug Goldstein FWIW: Reviewed-by: Wei Liu ___

Re: [Xen-devel] [PATCH 1/3] x86: avoid flush IPI when possible

2016-02-10 Thread Andrew Cooper
On 10/02/16 12:56, Jan Beulich wrote: > Since CLFLUSH, other than WBINVD, is a coherency domain wide flush, I can't parse this sentence. CLFUSH states "Invalidates from every level of the cache hierarchy in the cache coherence domain" WBINVD however states "The instruction then issues a special-

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 14:44 +, Stefano Stabellini wrote: > > > > But, if you use '--check-backend --backend' (no 's') instead, the > > > > check > > > > would works with qemu-xen >= 4.3 > > > > BTW, I think those correspond to > > > > qemu-mainline == QEMU 2.5.50 > > qemu-xen-unstable == QEMU

Re: [Xen-devel] HVMlite ABI specification DRAFT B + implementation outline

2016-02-10 Thread Roger Pau Monné
El 10/2/16 a les 13:53, Jan Beulich ha escrit: On 10.02.16 at 13:01, wrote: >> El 9/2/16 a les 14:24, Jan Beulich ha escrit: >> On 08.02.16 at 20:03, wrote: * 2. HVMlite with (or capable to) PCI-passthrough --- The current

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > > diff --

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > > diff --

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > diff --git a/tools/Makefile b/tools/Makefile > > > > index

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > diff --git a/tools/Makefile b/tools/Makefile > > > > index 5688a7c..76a

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 14:27 +, Ian Campbell wrote: > On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > > diff --git a/tools/Makefile b/tools/Makefile > > > > index

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 14:18 +, Anthony PERARD wrote: > On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > > On Wed, 10 Feb 2016, Ian Campbell wrote: > > > diff --git a/tools/Makefile b/tools/Makefile > > > index 5688a7c..76a2235 100644 > > > --- a/tools/Makefile > > > +++ b/t

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Anthony PERARD
On Wed, Feb 10, 2016 at 02:14:13PM +, Stefano Stabellini wrote: > On Wed, 10 Feb 2016, Ian Campbell wrote: > > diff --git a/tools/Makefile b/tools/Makefile > > index 5688a7c..76a2235 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -228,7 +228,7 @@ qemu-xen-dir-force-update: qemu

Re: [Xen-devel] [PATCH v8] x86/p2m: use large pages for MMIO mappings

2016-02-10 Thread George Dunlap
On 10/02/16 12:31, Jan Beulich wrote: > When mapping large BARs (e.g. the frame buffer of a graphics card) the > overhead of establishing such mappings using only 4k pages has, > particularly after the XSA-125 fix, become unacceptable. Alter the > XEN_DOMCTL_memory_mapping semantics once again, so

Re: [Xen-devel] [PATCH] tools: probe for existence of qemu-xen trace backends.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > QEMU upstream commit ed7f5f1d8db0 ("trace: convert stderr backend to > log") renamed the stderr trace backend to log, which breaks the xen > build when pointed at a QEMU tree after that point: > > ./configure of QEMU fail with: > "ERROR: invalid trace bac

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread George Dunlap
On 10/02/16 14:03, Jan Beulich wrote: On 10.02.16 at 14:50, wrote: >> On 10/02/16 13:22, Jan Beulich wrote: >> On 09.02.16 at 21:01, wrote: Clang objects to having multiple initialisers when creating an array. As this warning is useful for spotting obscure bugs, disabling

Re: [Xen-devel] [PATCH] libxc: Fix CID 1351228 resource leak

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 11:14 +, Ian Jackson wrote: > Dario Faggioli writes ("Re: [PATCH] libxc: Fix CID 1351228 resource > leak"): > > On Wed, 2016-02-10 at 14:39 +0530, Harmandeep Kaur wrote: > > > > > What I just said about the other patch ("libxc: Fix CID 1351225 > > resource leak") applies

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread Jan Beulich
>>> On 10.02.16 at 14:50, wrote: > On 10/02/16 13:22, Jan Beulich wrote: > On 09.02.16 at 21:01, wrote: >>> Clang objects to having multiple initialisers when creating an array. >>> >>> As this warning is useful for spotting obscure bugs, disabling it is >>> unhelpful. Instead, fix our two d

Re: [Xen-devel] [PATCH 6/8] xen/x86: Avoid overriding initialisers in arrays

2016-02-10 Thread Andrew Cooper
On 10/02/16 13:22, Jan Beulich wrote: On 09.02.16 at 21:01, wrote: >> Clang objects to having multiple initialisers when creating an array. >> >> As this warning is useful for spotting obscure bugs, disabling it is >> unhelpful. Instead, fix our two deliberate usecases. > Ugly again, but - w

Re: [Xen-devel] [PATCH 8/8] x86/efi: Generate uefi_call_wrapper() when compiling with clang

2016-02-10 Thread Andrew Cooper
On 10/02/16 13:31, Jan Beulich wrote: On 09.02.16 at 21:01, wrote: >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> >> What is the GCC version check supposed to be achieving here? GCC has >> supported this syntax since 3.0 > This is best answered by looking at where we've got t

Re: [Xen-devel] [PATCH 8/8] x86/efi: Generate uefi_call_wrapper() when compiling with clang

2016-02-10 Thread Jan Beulich
>>> On 09.02.16 at 21:01, wrote: > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > > What is the GCC version check supposed to be achieving here? GCC has > supported this syntax since 3.0 This is best answered by looking at where we've got these headers from - the gnu-efi package. It h

  1   2   >