Re: [Xen-devel] [PATCH 05/11] x86/altp2m: basic data structures and support routines.

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 19:49, wrote: > On 01/15/2015 08:53 AM, Jan Beulich wrote: > On 15.01.15 at 17:48, wrote: >>> At 13:26 -0800 on 09 Jan (1420806395), Ed White wrote: +/* Init alternate p2m data */ +if ( (d->arch.altp2m_eptp = alloc_xenheap_page()) == NULL ) +{ >>>

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 18:28, wrote: > On 01/15/2015 12:16 AM, Jan Beulich wrote: > On 14.01.15 at 18:35, wrote: >>> Right. The key observation is that at any single point in time, a given >>> hardware thread can be fetching an instruction or reading data, but not >>> both. >> >> Fine, as long a

[Xen-devel] [xen-unstable test] 33418: regressions - FAIL

2015-01-15 Thread xen . org
flight 33418 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/33418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 8 guest-startfail REGR. vs. 33112 test-amd64-i386-xl-q

[Xen-devel] [PATCH 03/28] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-01-15 Thread Yijing Wang
From: Arnd Bergmann Use pci_scan_root_bus() instead of deprecated function pci_scan_bus_parented(). Signed-off-by: Arnd Bergmann Signed-off-by: Yijing Wang CC: Konrad Rzeszutek Wilk CC: xen-de...@lists.xenproject.org --- drivers/pci/xen-pcifront.c | 10 +++--- 1 files changed, 7 insert

Re: [Xen-devel] [PATCH] libxl: adjust hvm direct boot code

2015-01-15 Thread Chun Yan Liu
>>> On 1/15/2015 at 10:51 PM, in message <20150115145156.ga3...@zion.uk.xensource.com>, Wei Liu wrote: > On Thu, Jan 15, 2015 at 01:50:27PM +, Ian Campbell wrote: > > On Thu, 2015-01-15 at 12:29 +, Wei Liu wrote: > > > The -initrd and -append parameters should only be supplied to QEMU

Re: [Xen-devel] [PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-15 at 09:58 +0100, Christian Borntraeger wrote: > ACCESS_ONCE does not work reliably on non-scalar types. For > example gcc 4.6 and 4.7 might remove the volatile tag for such > accesses during the SRA (scalar replacement of aggregates) step > (https://gcc.gnu.org/bugzilla/show_bug.c

Re: [Xen-devel] [PATCH for-4.5 v7 3/7] vmware: Add VMware provided include files.

2015-01-15 Thread Don Slutz
On 01/15/15 11:46, Jan Beulich wrote: On 02.10.14 at 23:30, wrote: >> These 2 files: backdoor_def.h and guest_msg_def.h come from: >> >> http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html >> open-vm-tools-kmod-7.4.8-396269.423167.src.rpm >> open-vm-tools-kmod-7.4.8.tar.

[Xen-devel] [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU

2015-01-15 Thread Julien Grall
Signed-off-by: Julien Grall --- This patch requires to regenerate tools/configure Changes in v2: - Patch added --- tools/configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/tools/configure.ac b/tools/configure.ac index 72e2465..2aff18d 100644 --- a/tools/configu

[Xen-devel] [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU

2015-01-15 Thread Julien Grall
QEMU upstream requires the use of pixman. When pixman is not present the system, the configure of QEMU will fail with: ERROR: pixman not present. Your options: (1) Preferred: Install the pixman devel package (any recent distro should have packages as Xorg needs pixman too).

[Xen-devel] [PATCH v2 0/2] tools/configure: Add QEMU dependencies

2015-01-15 Thread Julien Grall
Hello, This small patch series replaces the patch [1] sent earlier. Sincerely yours, [1] https://patches.linaro.org/43077/ Julien Grall (2): tools/configure: Check if Glib is present only when building QEMU tools/configure: Check if pixman is present on the system when building QEMU t

Re: [Xen-devel] [PATCH 08/11] x86/altp2m: add remaining support routines.

2015-01-15 Thread Ed White
On 01/15/2015 09:33 AM, Tim Deegan wrote: > Hi, > > Sorry for the fractured replies - my notes are confused about which > functions were defined where. > > At 13:26 -0800 on 09 Jan (1420806398), Ed White wrote: >> +bool_t p2m_change_altp2m_pfn(struct domain *d, uint16_t idx, >> +

Re: [Xen-devel] [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE

2015-01-15 Thread Christian Borntraeger
Am 15.01.2015 um 21:01 schrieb Oleg Nesterov: > On 01/15, Christian Borntraeger wrote: >> >> Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: >>> On 01/15, Christian Borntraeger wrote: --- a/arch/x86/include/asm/spinlock.h +++ b/arch/x86/include/asm/spinlock.h @@ -186,7 +186,7 @@ s

Re: [Xen-devel] [PATCH for-4.5 v7 1/7] xen: Add support for VMware cpuid leaves

2015-01-15 Thread Don Slutz
On 01/15/15 11:42, Jan Beulich wrote: On 02.10.14 at 23:30, wrote: >> @@ -5536,6 +5540,11 @@ long do_hvm_op(unsigned long op, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> if ( curr_d == d ) >> break; >> >> +if ( d->arch.hvm_domain.params[HVM

Re: [Xen-devel] [PATCH 08/11] x86/altp2m: add remaining support routines.

2015-01-15 Thread Ed White
On 01/15/2015 09:25 AM, Tim Deegan wrote: > Hi, > > At 13:26 -0800 on 09 Jan (1420806398), Ed White wrote: >> +int >> +altp2mhvm_hap_nested_page_fault(struct vcpu *v, paddr_t gpa, >> +unsigned long gla, struct npfec npfec) >> +{ >> +struct domain *d = v->domain;

Re: [Xen-devel] [PATCH 10/11] x86/altp2m: fix log-dirty handling.

2015-01-15 Thread Ed White
On 01/15/2015 09:20 AM, Tim Deegan wrote: > Hi, > > The locking chages look OK at first glance, but... > > At 13:26 -0800 on 09 Jan (1420806400), Ed White wrote: >> @@ -793,6 +793,10 @@ int p2m_change_type_one(struct domain *d, unsigned long >> gfn, >> >> gfn_unlock(p2m, gfn, 0); >> >>

Re: [Xen-devel] [PATCH 09/11] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-01-15 Thread Ed White
On 01/15/2015 09:09 AM, Tim Deegan wrote: > Hi, > > These _definitely_ need XSM checks, otherwise any domain can call them > on any other! I think you can probably copy the other p2m-munging > operations to see how to make a sensible default policy. Understood. I'll look at this subject again, b

Re: [Xen-devel] [PATCH 07/11] x86/altp2m: introduce p2m_ram_rw_ve type.

2015-01-15 Thread Ed White
On 01/15/2015 09:03 AM, Tim Deegan wrote: > At 13:26 -0800 on 09 Jan (1420806397), Ed White wrote: >> This is treated exactly like p2m_ram_rw, except that suppress_ve is not >> set in the EPTE. > > I don't think this is going to work -- you probably want to support > p2m_ram_ro at least, and maybe

[Xen-devel] [PATCH v2 1/3] xen/arm: vgic: Rename nr_lines into nr_spis

2015-01-15 Thread Julien Grall
The field nr_lines in the arch_domain vgic structure contains the number of SPIs for the emulated GIC. Using the nr_lines make confusion with the GIC code, where it means the number of IRQs. This can lead to coding error. Also introduce vgic_num_irqs to get the number of IRQ handled by the emulate

[Xen-devel] [PATCH v2 2/3] xen/arm: vgic: Keep track of vIRQ used by a domain

2015-01-15 Thread Julien Grall
While it's easy to know which hardware IRQ is assigned to a domain, there is no way to know which vIRQ is allocated by Xen for a specific domain. Introduce a bitmap to keep track of every vIRQ used by a domain. This will be used later to find free vIRQ for interrupt device assignment and emulated

[Xen-devel] [PATCH v2 0/3] Find automatically a PPI for the DOM0 event channel IRQ

2015-01-15 Thread Julien Grall
Hello, This patch series replaces the per-platform hardcoded event channel interrupt to a generic solution. It will make the port to a new platform easier and may avoid to introduce per-platform code with the new upcoming ACPI support. This could be done by keeping track of vIRQ (emulated and ass

[Xen-devel] [PATCH v2 3/3] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt

2015-01-15 Thread Julien Grall
Use the new vgic interface to know which virtual PPI is free and use it for the event channel code. At the DOM0 creation time, Xen still don't know which vIRQ will be free. All the vIRQ will be reserved when we parse the device tree. So allocate when the hypervisor node is created. It's safe to d

Re: [Xen-devel] [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE

2015-01-15 Thread Oleg Nesterov
On 01/15, Christian Borntraeger wrote: > > Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: > > On 01/15, Christian Borntraeger wrote: > >> > >> --- a/arch/x86/include/asm/spinlock.h > >> +++ b/arch/x86/include/asm/spinlock.h > >> @@ -186,7 +186,7 @@ static inline void > >> arch_spin_unlock_wait(arch

Re: [Xen-devel] [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE

2015-01-15 Thread Christian Borntraeger
Am 15.01.2015 um 20:38 schrieb Oleg Nesterov: > On 01/15, Christian Borntraeger wrote: >> >> --- a/arch/x86/include/asm/spinlock.h >> +++ b/arch/x86/include/asm/spinlock.h >> @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t >> *lock) >> __ticket_t head = ACCESS_ONC

[Xen-devel] QEMU 2.2.0 in Xen 4.6

2015-01-15 Thread Don Slutz
Now that Xen 4.5 has been released, I would like to see at least QEMU 2.2.0 in qemu-upstream-stable on the master branch. -Don Slutz ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE

2015-01-15 Thread Oleg Nesterov
On 01/15, Christian Borntraeger wrote: > > --- a/arch/x86/include/asm/spinlock.h > +++ b/arch/x86/include/asm/spinlock.h > @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t > *lock) > __ticket_t head = ACCESS_ONCE(lock->tickets.head); > > for (;;) { > -

Re: [Xen-devel] [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL

2015-01-15 Thread Samuel Thibault
Andrew Cooper, le Thu 15 Jan 2015 19:07:47 +, a écrit : > MiniOS has never advertised support for supervisor_mode_kernel, and the > feature was only ever implemented for 32bit Xen. > > Signed-off-by: Andrew Cooper > CC: Keir Fraser > CC: Jan Beulich > CC: Tim Deegan > CC: Stefano Stabellin

[Xen-devel] [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL

2015-01-15 Thread Andrew Cooper
MiniOS has never advertised support for supervisor_mode_kernel, and the feature was only ever implemented for 32bit Xen. Signed-off-by: Andrew Cooper CC: Keir Fraser CC: Jan Beulich CC: Tim Deegan CC: Stefano Stabellini CC: Samuel Thibault --- extras/mini-os/arch/x86/x86_64.S |5 +

Re: [Xen-devel] [PATCH 06/11] VMX/altp2m: add code to support EPTP switching and #VE.

2015-01-15 Thread Ed White
On 01/15/2015 08:56 AM, Tim Deegan wrote: > Hi, > > At 13:26 -0800 on 09 Jan (1420806396), Ed White wrote: >> @@ -2551,6 +2640,17 @@ static void vmx_vmexit_ud_intercept(struct >> cpu_user_regs *regs) >> hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE); >> brea

Re: [Xen-devel] [PATCH 05/11] x86/altp2m: basic data structures and support routines.

2015-01-15 Thread Ed White
On 01/15/2015 08:53 AM, Jan Beulich wrote: On 15.01.15 at 17:48, wrote: >> At 13:26 -0800 on 09 Jan (1420806395), Ed White wrote: >>> +/* Init alternate p2m data */ >>> +if ( (d->arch.altp2m_eptp = alloc_xenheap_page()) == NULL ) >>> +{ >>> +rv = -ENOMEM; >>> +goto

Re: [Xen-devel] [PATCH 02/11] VMX: implement suppress #VE.

2015-01-15 Thread Ed White
On 01/15/2015 08:25 AM, Tim Deegan wrote: > Hi, > > At 13:26 -0800 on 09 Jan (1420806392), Ed White wrote: >> static inline bool_t is_epte_valid(ept_entry_t *e) >> { >> -return (e->epte != 0 && e->sa_p2mt != p2m_invalid); >> +return (e->valid != 0 && e->sa_p2mt != p2m_invalid); > > This

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Ed White
On 01/15/2015 09:45 AM, Tim Deegan wrote: > At 09:28 -0800 on 15 Jan (1421310487), Ed White wrote: >> On 01/15/2015 12:16 AM, Jan Beulich wrote: >> On 14.01.15 at 18:35, wrote: On 01/14/2015 03:28 AM, Tamas K Lengyel wrote: > At the mem_access trap point you can swap in an altp2m wher

Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL

2015-01-15 Thread Ian Jackson
Martin Lucina writes ("Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL"): > ian.jack...@eu.citrix.com said: > > Looking at the output of `objdump -d .../rump-kernel' it's in > > __sflush, called by fflush. The alleged caller of fflush, `0x42ff70', > > isn't in the text segment. > >

Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL

2015-01-15 Thread Martin Lucina
mar...@lucina.net said: > > The build was this > > > > http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/build-amd64-rumpuserxen/info.html > > and the output files are here: > > > > http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/build-amd64-rumpuserxen/build/ > > of which the rel

Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL

2015-01-15 Thread Martin Lucina
ian.jack...@eu.citrix.com said: > Martin Lucina writes ("Re: [Xen-devel] [rumpuserxen test] 33416: regressions > - FAIL"): > > http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/test-amd64-amd64-rumpuserxen-amd64/guest-rump-console > > Yes. > > > --- > > GPF rip: 0x6018b, error_code=0 > ...

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Ed White
On 01/15/2015 08:15 AM, Tim Deegan wrote: > Hello, > > Thanks for sending this series - in particular, thank you for sending > it early in the release cycle! I'll review some of the patches > individually but since I expect there will be some changes to come in > future versions I'm not going to

Re: [Xen-devel] --enable-xsm ?

2015-01-15 Thread Konrad Rzeszutek Wilk
On Thu, Jan 15, 2015 at 11:53:20AM -0500, Don Slutz wrote: > On 01/15/15 04:40, Ian Campbell wrote: > >On Wed, 2015-01-14 at 13:39 -0500, Konrad Rzeszutek Wilk wrote: > >>On Wed, Jan 14, 2015 at 09:06:37AM +, Jan Beulich wrote: > >>On 13.01.15 at 21:43, wrote: > On 01/13/2015 02:27 PM,

Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL

2015-01-15 Thread Ian Jackson
Martin Lucina writes ("Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL"): > http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/test-amd64-amd64-rumpuserxen-amd64/guest-rump-console Yes. > --- > GPF rip: 0x6018b, error_code=0 ... > --- > > Ian, do you have the build output (rump

[Xen-devel] [libvirt test] 33422: tolerable FAIL - PUSHED

2015-01-15 Thread xen . org
flight 33422 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/33422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 9 guest-start fail never pass test-armhf-armhf-libvirt 9 guest-start

[Xen-devel] [PATCH] libxl: Avoid returning empty path from libxl_console_get_tty

2015-01-15 Thread Anthony PERARD
This could happen if xenconsoled have not populate the xenstore key yet. Signed-off-by: Anthony PERARD --- CC: Ian Jackson CC: Ian Campbell CC: Wei Liu --- tools/libxl/libxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index

Re: [Xen-devel] [rumpuserxen test] 33416: regressions - FAIL

2015-01-15 Thread Martin Lucina
ian.jack...@eu.citrix.com said: > flight 33416 rumpuserxen real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/ > > Regressions :-( I presume this is the console log: http://www.chiark.greenend.org.uk/~xensrcts/logs/33416/test-amd64-amd64-rumpuserxen-amd64/guest-rump-console --

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Tim Deegan
At 09:28 -0800 on 15 Jan (1421310487), Ed White wrote: > On 01/15/2015 12:16 AM, Jan Beulich wrote: > On 14.01.15 at 18:35, wrote: > >> On 01/14/2015 03:28 AM, Tamas K Lengyel wrote: > >>> At the mem_access trap point you can swap in an altp2m where the > >>> gfn->mfn mapping is the one where

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Ed White
On 01/15/2015 02:39 AM, Tamas K Lengyel wrote: >> There are ways of avoiding the >> single-step too, although I don't think that falls within the scope >> of this conversation. >> >> Ed > > I would be very interested in knowing how we can avoid the singlestep > phase. Are you envisioning using thi

Re: [Xen-devel] [PATCH 08/11] x86/altp2m: add remaining support routines.

2015-01-15 Thread Tim Deegan
Hi, Sorry for the fractured replies - my notes are confused about which functions were defined where. At 13:26 -0800 on 09 Jan (1420806398), Ed White wrote: > +bool_t p2m_change_altp2m_pfn(struct domain *d, uint16_t idx, > + unsigned long old_pfn, unsigned long new_pfn

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Ed White
On 01/15/2015 12:16 AM, Jan Beulich wrote: On 14.01.15 at 18:35, wrote: >> On 01/14/2015 03:28 AM, Tamas K Lengyel wrote: >>> At the mem_access trap point you can swap in an altp2m where the >>> gfn->mfn mapping is the one where the breakpoints are hidden, >>> singlestep, then swap the origin

Re: [Xen-devel] [PATCH 08/11] x86/altp2m: add remaining support routines.

2015-01-15 Thread Tim Deegan
Hi, At 13:26 -0800 on 09 Jan (1420806398), Ed White wrote: > +int > +altp2mhvm_hap_nested_page_fault(struct vcpu *v, paddr_t gpa, > +unsigned long gla, struct npfec npfec) > +{ > +struct domain *d = v->domain; > +struct p2m_domain *hp2m = p2m_get_hostp2m(d);

Re: [Xen-devel] [PATCH 10/11] x86/altp2m: fix log-dirty handling.

2015-01-15 Thread Tim Deegan
Hi, The locking chages look OK at first glance, but... At 13:26 -0800 on 09 Jan (1420806400), Ed White wrote: > @@ -793,6 +793,10 @@ int p2m_change_type_one(struct domain *d, unsigned long > gfn, > > gfn_unlock(p2m, gfn, 0); > > +if ( pt == ot && altp2mhvm_active(d) ) > +/*

Re: [Xen-devel] [PATCH 09/11] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-01-15 Thread Tim Deegan
Hi, These _definitely_ need XSM checks, otherwise any domain can call them on any other! I think you can probably copy the other p2m-munging operations to see how to make a sensible default policy. Cheers, Tim. ___ Xen-devel mailing list Xen-devel@l

Re: [Xen-devel] [PATCH 07/11] x86/altp2m: introduce p2m_ram_rw_ve type.

2015-01-15 Thread Tim Deegan
At 13:26 -0800 on 09 Jan (1420806397), Ed White wrote: > This is treated exactly like p2m_ram_rw, except that suppress_ve is not > set in the EPTE. I don't think this is going to work -- you probably want to support p2m_ram_ro at least, and maybe other types, but duplicating each of them as a 'typ

[Xen-devel] [linux-3.10 test] 33417: regressions - FAIL

2015-01-15 Thread xen . org
flight 33417 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/33417/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 7 windows-install fail REGR. vs. 26303 Tests which are failin

Re: [Xen-devel] [PATCH v2] make error codes a formal part of the ABI

2015-01-15 Thread Andrew Cooper
On 15/01/15 16:49, Jan Beulich wrote: On 15.01.15 at 17:27, wrote: >> On 15/01/15 15:25, Jan Beulich wrote: >>> Now that we have two cases where patches against hvmloader got >>> submitted needing to include the hypervisor's errno.h (for the host's >>> system header not necessarily reflecting

Re: [Xen-devel] [PATCH 06/11] VMX/altp2m: add code to support EPTP switching and #VE.

2015-01-15 Thread Tim Deegan
Hi, At 13:26 -0800 on 09 Jan (1420806396), Ed White wrote: > @@ -2551,6 +2640,17 @@ static void vmx_vmexit_ud_intercept(struct > cpu_user_regs *regs) > hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE); > break; > case X86EMUL_EXCEPTION: > +/* chec

Re: [Xen-devel] [PATCH 05/11] x86/altp2m: basic data structures and support routines.

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 17:48, wrote: > At 13:26 -0800 on 09 Jan (1420806395), Ed White wrote: >> +/* Init alternate p2m data */ >> +if ( (d->arch.altp2m_eptp = alloc_xenheap_page()) == NULL ) >> +{ >> +rv = -ENOMEM; >> +goto out; >> +} >> +for (i = 0; i < 512; i++)

Re: [Xen-devel] --enable-xsm ?

2015-01-15 Thread Don Slutz
On 01/15/15 04:40, Ian Campbell wrote: On Wed, 2015-01-14 at 13:39 -0500, Konrad Rzeszutek Wilk wrote: On Wed, Jan 14, 2015 at 09:06:37AM +, Jan Beulich wrote: On 13.01.15 at 21:43, wrote: On 01/13/2015 02:27 PM, Konrad Rzeszutek Wilk wrote: I was wondering if there would be any plans fo

Re: [Xen-devel] [PATCH v2] make error codes a formal part of the ABI

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 17:27, wrote: > On 15/01/15 15:25, Jan Beulich wrote: >> Now that we have two cases where patches against hvmloader got >> submitted needing to include the hypervisor's errno.h (for the host's >> system header not necessarily reflecting the correct numbers), take >> this as a st

Re: [Xen-devel] [PATCH 05/11] x86/altp2m: basic data structures and support routines.

2015-01-15 Thread Tim Deegan
Hi, At 13:26 -0800 on 09 Jan (1420806395), Ed White wrote: > --- a/xen/arch/x86/hvm/Makefile > +++ b/xen/arch/x86/hvm/Makefile > @@ -22,4 +22,5 @@ obj-y += vlapic.o > obj-y += vmsi.o > obj-y += vpic.o > obj-y += vpt.o > -obj-y += vpmu.o > \ No newline at end of file > +obj-y += vpmu.o > +obj-y

[Xen-devel] [PATCH for-4.5 v7 3/7] vmware: Add VMware provided include files.

2015-01-15 Thread Jan Beulich
>>> On 02.10.14 at 23:30, wrote: > These 2 files: backdoor_def.h and guest_msg_def.h come from: > > http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html > open-vm-tools-kmod-7.4.8-396269.423167.src.rpm > open-vm-tools-kmod-7.4.8.tar.gz >vmhgfs/backdoor_def.h >vmhgfs/g

Re: [Xen-devel] [PATCH for-4.5 v7 1/7] xen: Add support for VMware cpuid leaves

2015-01-15 Thread Jan Beulich
>>> On 02.10.14 at 23:30, wrote: > @@ -5536,6 +5540,11 @@ long do_hvm_op(unsigned long op, > XEN_GUEST_HANDLE_PARAM(void) arg) > if ( curr_d == d ) > break; > > +if ( d->arch.hvm_domain.params[HVM_PARAM_VMWARE_HW] ) > +{ > +

[Xen-devel] [PATCH V3] libxl: Set path to console on domain startup.

2015-01-15 Thread Anthony PERARD
The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call to virDomainGetXMLDesc done before OpenConsole will not have the path to the pty, but a call after OpenConsole will. e.g. of the current issue. Starting a domain with '' Then: virDomainGe

Re: [Xen-devel] [PATCH v2] make error codes a formal part of the ABI

2015-01-15 Thread Ian Campbell
On Thu, 2015-01-15 at 16:27 +, Andrew Cooper wrote: > On 15/01/15 15:25, Jan Beulich wrote: > > > Now that we have two cases where patches against hvmloader got > > submitted needing to include the hypervisor's errno.h (for the host's > > system header not necessarily reflecting the correct nu

Re: [Xen-devel] [PATCH 04/11] x86/MM: Improve p2m type checks.

2015-01-15 Thread Tim Deegan
Hi, At 13:26 -0800 on 09 Jan (1420806394), Ed White wrote: > The alternate p2m code will introduce a new p2m type. In preparation for using > that new type, introduce the type indicator here and fix all the checks > that assume !nestedp2m == hostp2m to explicitly check for hostp2m. > > Signed-off

Re: [Xen-devel] [PATCH 03/11] x86/HVM: Hardware alternate p2m support detection.

2015-01-15 Thread Tim Deegan
At 13:26 -0800 on 09 Jan (1420806393), Ed White wrote: > As implemented here, only supported on platforms with VMX HAP. This patch, I think, is where we could have an off-by-default feature option to disable all this new code until it's stable. There must also be some way for the toolstack to fin

Re: [Xen-devel] [PATCH v2] make error codes a formal part of the ABI

2015-01-15 Thread Andrew Cooper
On 15/01/15 15:25, Jan Beulich wrote: > Now that we have two cases where patches against hvmloader got > submitted needing to include the hypervisor's errno.h (for the host's > system header not necessarily reflecting the correct numbers), take > this as a strong sign that we need to make the error

Re: [Xen-devel] [PATCH 02/11] VMX: implement suppress #VE.

2015-01-15 Thread Tim Deegan
Hi, At 13:26 -0800 on 09 Jan (1420806392), Ed White wrote: > static inline bool_t is_epte_valid(ept_entry_t *e) > { > -return (e->epte != 0 && e->sa_p2mt != p2m_invalid); > +return (e->valid != 0 && e->sa_p2mt != p2m_invalid); This test for 0 is just catching uninitialised entries in fr

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-01-15 Thread Tim Deegan
Hello, Thanks for sending this series - in particular, thank you for sending it early in the release cycle! I'll review some of the patches individually but since I expect there will be some changes to come in future versions I'm not going to go into too much detail. I see there's been some disc

Re: [Xen-devel] [PATCHv1] grant-table: defer releasing pages acquired in a grant copy

2015-01-15 Thread Jan Beulich
>>> On 13.01.15 at 11:46, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -2077,152 +2077,293 @@ __acquire_grant_for_copy( > return rc; > } > > -static void > -__gnttab_copy( > -struct gnttab_copy *op) > +struct gnttab_copy_buf { > +/* guest provided.

Re: [Xen-devel] how to generate a smaller core with xm dump-core

2015-01-15 Thread Don Slutz
On 01/15/15 05:20, Ian Campbell wrote: On Thu, 2015-01-15 at 11:31 +0800, Zhenzhong Duan wrote: Hi Maintainers, We are facing issue collecting coredump using the xm dump mechanism in Dom0. We face couple of such issues daily, where the VMs panic s and the SA team is supposed to collect the c

Re: [Xen-devel] [PATCH] kexec: fix some types

2015-01-15 Thread David Vrabel
On 15/01/15 15:32, Jan Beulich wrote: > crashinfo_maxaddr can/will be a 64-bit type, hence passing it to fls() > is wrong. > > crashinfo_maxaddr_bits, otoh, doesn't need to be a paddr_t, and can > additionally be __initdata. > > struct xen_kexec_reserve's start field - representing a physical > a

Re: [Xen-devel] [PATCH] libxl: check HVM direct boot parameters

2015-01-15 Thread Wei Liu
On Thu, Jan 15, 2015 at 03:11:42PM +, Wei Liu wrote: > We should honour -initrd and -append iff -kernel is specified, because > that's how QEMU works. > > Check direct boot parameters in libxl__domain_build_info_setdefault. > Return failure if kernel is missing while ramdisk (-initrd) and / or

Re: [Xen-devel] [PATCH v3] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-15 Thread Andrew Cooper
On 15/01/15 15:24, Jan Beulich wrote: > Following the earlier similar change validating CR4 modifications. > > Note that this requires a non-obvious adjustment to hvm_cpuid(): On > 32-bit hosts/tool stacks, the SYSCALL feature flag will be seen clear > on Intel CPUs, yet 64-bit guests legitimately

Re: [Xen-devel] [Qemu-devel] [v3 4/5] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backen.

2015-01-15 Thread Stefan Berger
On 12/30/2014 06:03 PM, Quan Xu wrote: This Patch provides the glue for the TPM_TIS(Qemu frontend) to Xen stubdom vTPM domain that provides the actual TPM functionality. It sends data and TPM commends with xen_vtpm_frontend. It is similar as another two vTPM backens: *vTPM passthrough backen S

Re: [Xen-devel] [PATCH] hvm/hpet: Correctly gate the virtual HPET on HVM_PARAM_HPET_ENABLE

2015-01-15 Thread Andrew Cooper
On 15/01/15 15:34, Jan Beulich wrote: On 15.01.15 at 15:40, wrote: >> c/s 3f8e22de7 "x86 hvm: Allow HPET to be configured as a per-domain config >> option" introduced the parameter to conditionally enable the HPET. >> >> However, having the check in hpet_range() does not have the intended eff

Re: [Xen-devel] [PATCH] hvm/hpet: Correctly gate the virtual HPET on HVM_PARAM_HPET_ENABLE

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 15:40, wrote: > c/s 3f8e22de7 "x86 hvm: Allow HPET to be configured as a per-domain config > option" introduced the parameter to conditionally enable the HPET. > > However, having the check in hpet_range() does not have the intended effect. > As currently implemented, when the

[Xen-devel] [PATCH] kexec: fix some types

2015-01-15 Thread Jan Beulich
crashinfo_maxaddr can/will be a 64-bit type, hence passing it to fls() is wrong. crashinfo_maxaddr_bits, otoh, doesn't need to be a paddr_t, and can additionally be __initdata. struct xen_kexec_reserve's start field - representing a physical address - ought to have respective type. Signed-off-by

[Xen-devel] [PATCH] physdev: hide compatibility definitions for new enough interface version

2015-01-15 Thread Jan Beulich
There's no point in continuing to expose those. Signed-off-by: Jan Beulich --- a/xen/include/public/physdev.h +++ b/xen/include/public/physdev.h @@ -344,6 +344,7 @@ DEFINE_XEN_GUEST_HANDLE(physdev_dbgp_op_ */ #define PHYSDEVOP_IRQ_UNMASK_NOTIFY 4 +#if __XEN_INTERFACE_VERSION__ < 0x0003

[Xen-devel] [PATCH v2] make error codes a formal part of the ABI

2015-01-15 Thread Jan Beulich
Now that we have two cases where patches against hvmloader got submitted needing to include the hypervisor's errno.h (for the host's system header not necessarily reflecting the correct numbers), take this as a strong sign that we need to make the error return values part of the hypervisor ABI (whi

[Xen-devel] [PATCH v3] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-15 Thread Jan Beulich
Following the earlier similar change validating CR4 modifications. Note that this requires a non-obvious adjustment to hvm_cpuid(): On 32-bit hosts/tool stacks, the SYSCALL feature flag will be seen clear on Intel CPUs, yet 64-bit guests legitimately expect the feature for be available. Mimic hard

Re: [Xen-devel] [PATCH v1 1/2] tools: unhook blktap1 from the build and remove all references to it

2015-01-15 Thread Ian Campbell
On Wed, 2015-01-14 at 16:54 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH v1 1/2] tools: unhook blktap1 from the build and > remove all references to it"): > > This was disabled by default in Xen 4.4. Since xend has now been > > removed from the tree I don't believe anything is using it

Re: [Xen-devel] [PATCH v4] xen: arm: enable perf counters

2015-01-15 Thread Ian Campbell
On Wed, 2015-01-14 at 17:55 +, Julien Grall wrote: > Hi Ian, > > On 14/01/15 16:16, Ian Campbell wrote: > > As well as the existing common perf counters add a bunch of ARM > > specifics, including the various trap types, vuart/vgic/vtimer > > accesses and different types of interrupt. > > > >

Re: [Xen-devel] [PATCH v2] xen: arm: wait 1000ms for a CPU to come up, instead of forever

2015-01-15 Thread Ian Campbell
On Wed, 2015-01-14 at 15:47 +, Ian Campbell wrote: > Otherwise continue without it, which is preferable to the current > infinite hang. > > Slightly tweak the grammar of a comment in the same function. > > Signed-off-by: Ian Campbell > Reviewed-by: Julien Grall Now applied, thanks. ___

Re: [Xen-devel] [PATCH v2] xen/arm: Blacklist the memory mapped timer (armv7-timer-mem)

2015-01-15 Thread Ian Campbell
On Wed, 2015-01-14 at 18:00 +, Julien Grall wrote: > Some platform (such as the VFP Base AEMv8 model) has a memory mapped > timer. We don't want DOM0 use this timer rather than the generic ARM > timer. So blacklist it for all platforms. > > Signed-off-by: Julien Grall Acked + applied. > >

[Xen-devel] [PATCH] libxl: check HVM direct boot parameters

2015-01-15 Thread Wei Liu
We should honour -initrd and -append iff -kernel is specified, because that's how QEMU works. Check direct boot parameters in libxl__domain_build_info_setdefault. Return failure if kernel is missing while ramdisk (-initrd) and / or cmdline (-append) is present. Signed-off-by: Wei Liu Cc: Ian Cam

Re: [Xen-devel] [PATCH 2/2] xen/arm: grant-table: Increased the initial number of grant frame to 4

2015-01-15 Thread Ian Campbell
On Tue, 2015-01-13 at 18:17 +, Julien Grall wrote: > When a domain is created on ARM, the grant table code initialized one > grant frame. With a basic load (i.e disk usage), Xen is quickly trying > to expand the number of frames: > > (XEN) grant_table.c:1305:d2v0 Expanding dom (2) grant table

Re: [Xen-devel] [PATCH 1/2] xen/arm: Remove the define INVALID_GFN from arch-arm/grant_table.h

2015-01-15 Thread Ian Campbell
On Tue, 2015-01-13 at 18:17 +, Julien Grall wrote: > The define INVALID_GFN is misplaced in arch-arm/grant_table.h and is > never used in neither in ARM nor in the common code. Yeah, it appears to be an x86-ism which we copied over at some point. > Therefore we can safely remove it. > > Sign

Re: [Xen-devel] [xen-unstable test] 33399: regressions - FAIL

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 16:06, wrote: > On 15/01/15 14:53, Jan Beulich wrote: > On 15.01.15 at 15:14, wrote: >>> But I think I made a wrong assumption above regarding the >>> guest size: test-amd64-i386-xl-win7-amd64 produces a 64-bit >>> guest with a 32-bit tool stack, so the crucial part of all

Re: [Xen-devel] [xen-unstable test] 33399: regressions - FAIL

2015-01-15 Thread Andrew Cooper
On 15/01/15 14:53, Jan Beulich wrote: On 15.01.15 at 15:14, wrote: >> But I think I made a wrong assumption above regarding the >> guest size: test-amd64-i386-xl-win7-amd64 produces a 64-bit >> guest with a 32-bit tool stack, so the crucial part of all the >> tests failing is not the guest's

Re: [Xen-devel] FW: [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0

2015-01-15 Thread Xu, Quan
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: Thursday, January 15, 2015 10:54 PM > To: Xu, Quan > Cc: wei.l...@citrix.com; xen-devel@lists.xen.org > Subject: Re: FW: [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0 > > On Thu, Jan 15, 2015 at 02:31:01PM +000

Re: [Xen-devel] FW: [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0

2015-01-15 Thread Wei Liu
On Thu, Jan 15, 2015 at 02:31:01PM +, Xu, Quan wrote: > Wei > > Are this series of patch in one thread? Thanks. > Yes. > -Quan > > > -Original Message- > > From: Xu, Quan > > Sent: Thursday, January 15, 2015 5:22 PM > > To: xen-devel@lists.xen.org; dgde...@tycho.nsa.gov > > Cc: i

Re: [Xen-devel] [xen-unstable test] 33399: regressions - FAIL

2015-01-15 Thread Jan Beulich
>>> On 15.01.15 at 15:14, wrote: > But I think I made a wrong assumption above regarding the > guest size: test-amd64-i386-xl-win7-amd64 produces a 64-bit > guest with a 32-bit tool stack, so the crucial part of all the > tests failing is not the guest's bitness, but tool stack's. So I'll > next l

Re: [Xen-devel] [PATCH] libxl: adjust hvm direct boot code

2015-01-15 Thread Wei Liu
On Thu, Jan 15, 2015 at 01:50:27PM +, Ian Campbell wrote: > On Thu, 2015-01-15 at 12:29 +, Wei Liu wrote: > > The -initrd and -append parameters should only be supplied to QEMU iff > > -kernel parameter is present, because that's how QEMU works. > > What do you think of catching this e.g.

[Xen-devel] [PATCH] hvm/hpet: Correctly gate the virtual HPET on HVM_PARAM_HPET_ENABLE

2015-01-15 Thread Andrew Cooper
c/s 3f8e22de7 "x86 hvm: Allow HPET to be configured as a per-domain config option" introduced the parameter to conditionally enable the HPET. However, having the check in hpet_range() does not have the intended effect. As currently implemented, when the HPET is disabled, the range is not claimed a

[Xen-devel] FW: [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0

2015-01-15 Thread Xu, Quan
Wei Are this series of patch in one thread? Thanks. -Quan > -Original Message- > From: Xu, Quan > Sent: Thursday, January 15, 2015 5:22 PM > To: xen-devel@lists.xen.org; dgde...@tycho.nsa.gov > Cc: ian.campb...@citrix.com; ian.jack...@eu.citrix.com; jbeul...@suse.com; > k...@xen.org; t

Re: [Xen-devel] Question about partitioning shared cache in Xen

2015-01-15 Thread Meng Xu
2015-01-15 3:23 GMT-05:00 Jan Beulich : On 14.01.15 at 22:19, wrote: >> So when Xen allocate memory to a PV guest with 256MB memory and 4KB >> page size (i.e., 2^16 memory pages), Xen will allocate 2^16 continuous >> memory pages to this guest since the maximum continuous memory pages >> Xen

[Xen-devel] [PATCH v4 04/14] vTPM/TPM2: Add TPM 2.0 Exposed APIs

2015-01-15 Thread Quan Xu
These TPM 2.0 Exposed APIs for the Mini-os to access TPM 2.0 hardware. Signed-off-by: Quan Xu --- stubdom/vtpmmgr/Makefile | 2 +- stubdom/vtpmmgr/tpm2.c | 455 +++ stubdom/vtpmmgr/tpm2.h | 104 +++ 3 files changed, 560 insertions(+), 1 d

[Xen-devel] [PATCH v4 12/14] vTPM/TPM2: Bind group keys and sectors data on disk

2015-01-15 Thread Quan Xu
Signed-off-by: Quan Xu --- stubdom/vtpmmgr/disk_write.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/stubdom/vtpmmgr/disk_write.c b/stubdom/vtpmmgr/disk_write.c index 4c825c5..ab15a9a 100644 --- a/stubdom/vtpmmgr/disk_write.c +++ b/stubdom/vtpmmgr/disk_write.

[Xen-devel] [PATCH v4 08/14] vTPM/TPM2: Add main entrance vtpmmgr2_init()

2015-01-15 Thread Quan Xu
Accept commands from the vtpm-stubdom domains via the mini-os TPM backend driver. The vTPM manager communicates directly with hardware TPM 2.0 using the mini-os tpm2_tis driver. Signed-off-by: Quan Xu --- stubdom/vtpmmgr/init.c| 109 ++ stubdom/vtp

[Xen-devel] [PATCH v4 02/14] vTPM/TPM2: TPM 2.0 data structures marshal

2015-01-15 Thread Quan Xu
Add TPM 2.0 data structure marshal for packing and unpacking TPM 2.0 data structures. Signed-off-by: Quan Xu --- stubdom/vtpmmgr/tpm2_marshal.h | 673 + 1 file changed, 673 insertions(+) create mode 100644 stubdom/vtpmmgr/tpm2_marshal.h diff --git a/stub

[Xen-devel] [PATCH v4 13/14] vTPM/TPM2: Unind group keys and sectors data on disk

2015-01-15 Thread Quan Xu
Signed-off-by: Quan Xu --- stubdom/vtpmmgr/disk_read.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c index 33aacdd..e9dc20f 100644 --- a/stubdom/vtpmmgr/disk_read.c +++ b/stubdom/vtpmmgr/disk_read.c

[Xen-devel] [PATCH v4 10/14] vTPM/TPM2: TPM 2.0 PCRs read

2015-01-15 Thread Quan Xu
Signed-off-by: Quan Xu --- stubdom/vtpmmgr/init.c | 34 ++ stubdom/vtpmmgr/tpm2_types.h | 2 ++ stubdom/vtpmmgr/vtpmmgr.h| 1 + 3 files changed, 37 insertions(+) diff --git a/stubdom/vtpmmgr/init.c b/stubdom/vtpmmgr/init.c index 980f622..1506735 100644

[Xen-devel] [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0

2015-01-15 Thread Quan Xu
This series of patch enable the virtual Trusted Platform Module (vTPM) subsystem for Xen on TPM 2.0. Noted, functionality for a virtual guest operating system (a DomU) is still TPM 1.2. The main modifcation is on vtpmmgr-stubdom. The challenge is that TPM 2.0 is not backward compatible with TPM 1.

[Xen-devel] [PATCH v4 03/14] vTPM/TPM2: Add global data in vtpm_globals{}

2015-01-15 Thread Quan Xu
These data is for the Mini-os to access TPM 2.0 hardware. Signed-off-by: Quan Xu --- stubdom/vtpmmgr/vtpmmgr.h | 9 + 1 file changed, 9 insertions(+) diff --git a/stubdom/vtpmmgr/vtpmmgr.h b/stubdom/vtpmmgr/vtpmmgr.h index 2d9d153..0d0c604 100644 --- a/stubdom/vtpmmgr/vtpmmgr.h +++ b/st

  1   2   >