On Thu, Jan 15, 2015 at 03:11:42PM +0000, Wei Liu wrote:
> We should honour -initrd and -append iff -kernel is specified, because
> that's how QEMU works.
>
> Check direct boot parameters in libxl__domain_build_info_setdefault.
> Return failure if kernel is missing while ramdisk (-initrd) and / or
> cmdline (-append) is present.
>
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
> Cc: Ian Campbell <ian.campb...@citrix.com>
> Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com>
> Cc: Chunyan Liu <cy...@suse.com>
> ---
> tools/libxl/libxl_create.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 1198225..31f681e 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -170,6 +170,15 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
> break;
> default:abort();
> }
> +
> + /* Check HVM direct boot parameters, we should honour ->ramdisk and
> + * ->cmdline iff ->kernel is set.
> + */
> + if (!b_info->kernel && (b_info->ramdisk || b_info->cmdline)) {
> + LIBXL__LOG(CTX, XLT_ERROR,
> + "direct boot parameters specified but kernel is
> missing");
Hmm... There's a formatting error. I can resend if it's necessary.
> + return ERROR_INVAL;
> + }
> }
>
> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM &&
> --
> 1.7.10.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
