Re: [Xen-devel] [v7][RFC][PATCH 04/13] hvmloader/util: get reserved device memory maps

2014-11-20 Thread Jan Beulich
>>> On 21.11.14 at 08:43, wrote: >> From: Chen, Tiejun >> Sent: Friday, November 21, 2014 2:26 PM >> >> On 2014/11/3 18:02, Jan Beulich wrote: >> On 03.11.14 at 10:55, wrote: >> >> On 2014/11/3 17:45, Jan Beulich wrote: >> >> On 03.11.14 at 10:32, wrote: >> On 2014/11/3 16:53, Ja

Re: [Xen-devel] [for-xen-4.5 PATCH v2 2/2] dpci: Add ZOMBIE state to allow the softirq to finish with the dpci_pirq.

2014-11-20 Thread Jan Beulich
>>> On 20.11.14 at 20:51, wrote: > @@ -669,7 +670,7 @@ static void hvm_dirq_assist(struct domain *d, struct > hvm_pirq_dpci *pirq_dpci) > ASSERT(d->arch.hvm_domain.irq.dpci); > > spin_lock(&d->event_lock); > -if ( pirq_dpci->state ) > +if ( test_and_clear_bool(pirq_dpci->maske

Re: [Xen-devel] [v7][RFC][PATCH 04/13] hvmloader/util: get reserved device memory maps

2014-11-20 Thread Tian, Kevin
> From: Chen, Tiejun > Sent: Friday, November 21, 2014 2:26 PM > > On 2014/11/3 18:02, Jan Beulich wrote: > On 03.11.14 at 10:55, wrote: > >> On 2014/11/3 17:45, Jan Beulich wrote: > >> On 03.11.14 at 10:32, wrote: > On 2014/11/3 16:53, Jan Beulich wrote: > On 03.11.14 at

Re: [Xen-devel] [v7][RFC][PATCH 04/13] hvmloader/util: get reserved device memory maps

2014-11-20 Thread Chen, Tiejun
On 2014/11/3 18:02, Jan Beulich wrote: On 03.11.14 at 10:55, wrote: On 2014/11/3 17:45, Jan Beulich wrote: On 03.11.14 at 10:32, wrote: On 2014/11/3 16:53, Jan Beulich wrote: On 03.11.14 at 03:22, wrote: On 2014/10/31 16:14, Jan Beulich wrote: On 31.10.14 at 03:20, wrote: On 2014/10/30

Re: [Xen-devel] Buggy interaction of live migration and p2m updates

2014-11-20 Thread Juergen Gross
On 11/20/2014 07:28 PM, Andrew Cooper wrote: Hello, Tim, David and I were discussing this over lunch. This email is a (hopefully accurate) account of our findings, and potential solutions. (If I have messed up, please shout.) Currently, correct live migration of PV domains relies on the toolst

[Xen-devel] [PATCH V4] Decouple SandyBridge quirk from VTd timeout

2014-11-20 Thread Donald D. Dugger
Currently the quirk code for SandyBridge uses the VTd timeout value when writing to an IGD register. This is the wrong timeout to use and, at 1000 msec., is also much too large. This patch changes the quirk code to use a timeout that is specific to the IGD device and allows the user control of th

Re: [Xen-devel] [PATCH V3] Decouple SnadyBridge quirk form VTd timeout

2014-11-20 Thread Donald D. Dugger
On Thu, Nov 20, 2014 at 12:31:48PM +0100, Jan Beulich wrote: > >>> On 19.11.14 at 20:46, wrote: > > @@ -237,6 +248,42 @@ > > } > > } > > > > +static void __init parse_snb_timeout(const char *s) > > +{ > > + int not; > > + > > + switch (*s) { > > + > > + case '\0': > > + snb

Re: [Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Gedalya
On 11/20/2014 10:13 PM, Gedalya wrote: On 11/20/2014 03:21 PM, Konrad Rzeszutek Wilk wrote: On Thu, Nov 20, 2014 at 03:48:47PM +, Ian Campbell wrote: The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which is freed by xc_dom_release. However the various xc_try_*_decode

Re: [Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Gedalya
On 11/20/2014 03:21 PM, Konrad Rzeszutek Wilk wrote: On Thu, Nov 20, 2014 at 03:48:47PM +, Ian Campbell wrote: The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which is freed by xc_dom_release. However the various xc_try_*_decode routines (other than the gzip one) just

Re: [Xen-devel] Xen-4.5 Testing - Cache Monitoring Technology

2014-11-20 Thread Chao Peng
On Thu, Nov 20, 2014 at 02:21:48PM +, Andrew Cooper wrote: > On 20/11/14 10:23, Andrew Cooper wrote: > > On 20/11/14 10:15, Chao Peng wrote: > >> On Thu, Nov 20, 2014 at 09:58:37AM +, Andrew Cooper wrote: > >>> Hi, > >>> > >>> I have found myself a PSR-capable server and have been having a

Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

2014-11-20 Thread Tian, Kevin
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Friday, November 21, 2014 4:11 AM > > > Jan are you OK with this? In previous approach we reserved all the > > RMRR regions so hotplug scenario is covered automatically. Now since > > we want to do BDF specific filtering, this n

[Xen-devel] [PATCH for-xen-4.5] libxl: Allow copying smaller bitmap into a larger one

2014-11-20 Thread Boris Ostrovsky
When parsing bitmap objects JSON parser will create libxl_bitmap map of the smallest size needed. This can cause problems when saved image file specifies CPU affinity. For example, if 'vcpu_hard_affinity' in the saved image has only the first CPU specified, just a single byte will be allocated and

Re: [Xen-devel] [for-xen-4.5 PATCH v2 2/2] dpci: Add ZOMBIE state to allow the softirq to finish with the dpci_pirq.

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 09:18:30PM +0100, Sander Eikelenboom wrote: > > Thursday, November 20, 2014, 8:51:33 PM, you wrote: > > > Ah crud. > > > So a simple fix could be to seperate the 'state' to only deal with the > > raise_softirq and softirq_dpci. And then add a new (old) 'masked' to > > dea

Re: [Xen-devel] [PATCH v9 12/13] swiotlb-xen: pass dev_addr to xen_dma_unmap_page and xen_dma_sync_single_for_cpu

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 10:47:51AM +, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Stefano Stabellini wrote: > > On Wed, 19 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > On Wed, Nov 12, 2014 at 11:40:53AM +, Stefano Stabellini wrote: > > > > xen_dma_unmap_page and xen_dma_sync_single_for

Re: [Xen-devel] [PATCH v2 for 4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 05:36:03PM +, Julien Grall wrote: > The current script is setting $email_remove_duplicates to 1 by default, on > complex patch (see [1]), this will result to ommitting randomly some > maintainers. One could see that as feature - the emails about bugs or patches to revie

Re: [Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 03:48:47PM +, Ian Campbell wrote: > The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which > is freed by xc_dom_release. However the various xc_try_*_decode routines > (other > than the gzip one) just use plain malloc/realloc and therefore the buf

Re: [Xen-devel] [for-xen-4.5 PATCH v2 2/2] dpci: Add ZOMBIE state to allow the softirq to finish with the dpci_pirq.

2014-11-20 Thread Sander Eikelenboom
Thursday, November 20, 2014, 8:51:33 PM, you wrote: > Ah crud. > So a simple fix could be to seperate the 'state' to only deal with the > raise_softirq and softirq_dpci. And then add a new (old) 'masked' to > deal between hvm_dirq_assist, pt_irq_guest_eoi and hvm_do_IRQ_dpci. > From 94a98e20a8

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 04:47:42PM +, Ian Campbell wrote: > On Thu, 2014-11-20 at 10:53 +, Stefano Stabellini wrote: > > UIE being set can cause maintenance interrupts to occur when Xen writes > > to one or more LR registers. The effect is a busy loop around the > > interrupt handler in Xen

Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

2014-11-20 Thread Konrad Rzeszutek Wilk
> Jan are you OK with this? In previous approach we reserved all the > RMRR regions so hotplug scenario is covered automatically. Now since > we want to do BDF specific filtering, this new interface is actually > necessary for hotplug support. If OK, Tiejun will send out a new > series to see whet

Re: [Xen-devel] Regression, host crash with 4.5rc1

2014-11-20 Thread Steve Freitas
Hi Jan, Thanks for all your help so far! Here's my latest update. On 11/17/2014 23:54, Jan Beulich wrote: Plus, without said adjustment, first just disable the MWAIT CPU idle driver ("mwait-idle=0") and then, if that didn't make a difference, use of C states altogether ("cpuidle=0"). If any of

Re: [Xen-devel] [for-xen-4.5 PATCH v2 2/2] dpci: Add ZOMBIE state to allow the softirq to finish with the dpci_pirq.

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 11:55:43AM +0100, Jan Beulich wrote: > >>> On 19.11.14 at 23:21, wrote: > > Leaving aside the question of whether this is the right approach, in > case it is a couple of comments: > > > @@ -85,7 +91,7 @@ static void raise_softirq_for(struct hvm_pirq_dpci > > *pirq_dpci)

Re: [Xen-devel] [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 03:47:04PM +, Ian Campbell wrote: > On Mon, 2014-11-17 at 12:36 +, George Dunlap wrote: > > On 11/14/2014 11:12 AM, Ian Campbell wrote: > > > On Thu, 2014-11-13 at 19:04 +, George Dunlap wrote: > > >> Return proper error codes on failure so that scripts can tell

Re: [Xen-devel] [PATCH] set pv guest default video_memkb to 0

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 03:48:17PM +, Wei Liu wrote: > On Thu, Nov 20, 2014 at 03:29:51PM +, Ian Campbell wrote: > > On Wed, 2014-11-19 at 21:24 +, Wei Liu wrote: > > > On Wed, Nov 19, 2014 at 04:08:46PM -0500, Konrad Rzeszutek Wilk wrote: > > > > On Tue, Nov 18, 2014 at 03:57:08PM -050

Re: [Xen-devel] [PATCH 0/5 v2 for-4.5] xen: arm: xgene bug fixes + support for McDivitt

2014-11-20 Thread Konrad Rzeszutek Wilk
On Thu, Nov 20, 2014 at 03:58:37PM +, Ian Campbell wrote: > On Wed, 2014-11-19 at 16:27 -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Nov 19, 2014 at 03:27:48PM +, Ian Campbell wrote: > > > These patches: > > > > > > * fix up an off by one bug in the xgene mapping of additional PCI

[Xen-devel] Buggy interaction of live migration and p2m updates

2014-11-20 Thread Andrew Cooper
Hello, Tim, David and I were discussing this over lunch. This email is a (hopefully accurate) account of our findings, and potential solutions. (If I have messed up, please shout.) Currently, correct live migration of PV domains relies on the toolstack (which has a live mapping of the guests p2

[Xen-devel] [OSSTEST PATCH] README.planner: Document the resource planning system

2014-11-20 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README.planner | 181 +++- 1 file changed, 180 insertions(+), 1 deletion(-) diff --git a/README.planner b/README.planner index de8b962..ec4dce8 100644 --- a/README.planner +++ b/README.planner @@ -1,4 +1,183 @@ -

[Xen-devel] [PATCH OSSTEST v3 00/15] support for ARM32 arndale and cubietruck platforms

2014-11-20 Thread Ian Campbell
I'm preparing a bunch of each of these boards to be racked for inclusion in osstest. This series adds the necessary osstest support: * Support for platforms which require us to supply a Device Tree * Removing various hardcoded midway assumptions * Some new features needed to work

Re: [Xen-devel] [OSSTEST PATCH] linux-next tests: Use correct branch for baseline

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 13:51 +, Ian Jackson wrote: > Make cr-daily-branch honour an environment or setting variable > EXTRA_SGR_ARGS. In branch-settings.linux-next set it appropriately to > arrange that the linux-next test reports consider linux-linus tests as > interesting as well as just linu

[Xen-devel] [PATCH v2 for 4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
The current script is setting $email_remove_duplicates to 1 by default, on complex patch (see [1]), this will result to ommitting randomly some maintainers. This is because, the script will: 1) Get the list of maintainers of the file (incidentally all the maintainers in "THE REST" role

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:30 PM, Ian Campbell wrote: > On Thu, 2014-11-20 at 16:15 +, Julien Grall wrote: >> Hi Ian, >> >> On 11/20/2014 04:08 PM, Ian Campbell wrote: >>> On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: By default, the script get_maintainer.pl will remove duplicates email as

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:57 PM, Ian Campbell wrote: > On Thu, 2014-11-20 at 16:52 +, Ian Campbell wrote: >> On Thu, 2014-11-20 at 16:43 +, Julien Grall wrote: >>> On 11/20/2014 04:29 PM, Ian Campbell wrote: > Forgot to add, the example above show the difference without and with > the patch.

Re: [Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Frediano Ziglio
2014-11-20 15:48 GMT+00:00 Ian Campbell : > The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which > is freed by xc_dom_release. However the various xc_try_*_decode routines > (other > than the gzip one) just use plain malloc/realloc and therefore the buffer ends > up leaked

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 16:52 +, Ian Campbell wrote: > On Thu, 2014-11-20 at 16:43 +, Julien Grall wrote: > > On 11/20/2014 04:29 PM, Ian Campbell wrote: > > >> Forgot to add, the example above show the difference without and with > > >> the patch. The list is correct because both ARM and x86

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 16:43 +, Julien Grall wrote: > On 11/20/2014 04:29 PM, Ian Campbell wrote: > >> Forgot to add, the example above show the difference without and with > >> the patch. The list is correct because both ARM and x86 maintainers > >> should be CC. Because of this all "THE REST"

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 10:53 +, Stefano Stabellini wrote: > UIE being set can cause maintenance interrupts to occur when Xen writes > to one or more LR registers. The effect is a busy loop around the > interrupt handler in Xen > (http://marc.info/?l=xen-devel&m=141597517132682): everything gets

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-20 Thread Julien Grall
Hi Stefano, On 11/20/2014 03:54 PM, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Julien Grall wrote: >> On 11/20/2014 11:02 AM, Julien Grall wrote: >>> Hi Stefano, >>> >>> On 11/20/2014 10:53 AM, Stefano Stabellini wrote: UIE being set can cause maintenance interrupts to occur when Xen wr

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Andrii Tseglytskyi
OK - I see. thanks a lot. On Thu, Nov 20, 2014 at 6:15 PM, Stefano Stabellini < stefano.stabell...@eu.citrix.com> wrote: > Already posted: > > http://marc.info/?l=xen-devel&m=141648092100568 > > Ian hasn't provided any feedback yet. > > On Thu, 20 Nov 2014, Andrii Tseglytskyi wrote: > > I think I

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:29 PM, Ian Campbell wrote: >> Forgot to add, the example above show the difference without and with >> the patch. The list is correct because both ARM and x86 maintainers >> should be CC. Because of this all "THE REST" maintainers are added. > > Just to be clear, you mean that eve

Re: [Xen-devel] [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-20 Thread Boris Ostrovsky
On 11/20/2014 11:15 AM, Ian Campbell wrote: On Thu, 2014-11-20 at 16:08 +, Andrew Cooper wrote: On 20/11/14 16:00, Ian Campbell wrote: On Mon, 2014-11-17 at 15:19 +, Andrew Cooper wrote: c/s d1b93ea causes substantial functional regressions in pygrub's ability to parse bootloader confi

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 16:15 +, Julien Grall wrote: > Hi Ian, > > On 11/20/2014 04:08 PM, Ian Campbell wrote: > > On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: > >> By default, the script get_maintainer.pl will remove duplicates email as > >> soon > >> as it appends the list of mainta

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 16:21 +, Julien Grall wrote: > On 11/20/2014 04:15 PM, Julien Grall wrote: > > Hi Ian, > > > > On 11/20/2014 04:08 PM, Ian Campbell wrote: > >> On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: > >>> By default, the script get_maintainer.pl will remove duplicates ema

[Xen-devel] Xen Security Advisory 113 - Guest effectable page reference leak in MMU_MACHPHYS_UPDATE handling

2014-11-20 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xen Security Advisory XSA-113 Guest effectable page reference leak in MMU_MACHPHYS_UPDATE handling ISSUE DESCRIPTION = An error handling path in the processing of MMU_MACHPHYS_UPDATE failed to drop a page refere

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
On 11/20/2014 04:15 PM, Julien Grall wrote: > Hi Ian, > > On 11/20/2014 04:08 PM, Ian Campbell wrote: >> On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: >>> By default, the script get_maintainer.pl will remove duplicates email as >>> soon >>> as it appends the list of maintainers of a new

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Stefano Stabellini
Already posted: http://marc.info/?l=xen-devel&m=141648092100568 Ian hasn't provided any feedback yet. On Thu, 20 Nov 2014, Andrii Tseglytskyi wrote: > I think I'll debug this a bit later - unfortunately, now don't have > time for this. But I want to get rid of spurious interrupt here. > > BTW -

Re: [Xen-devel] [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 16:08 +, Andrew Cooper wrote: > On 20/11/14 16:00, Ian Campbell wrote: > > On Mon, 2014-11-17 at 15:19 +, Andrew Cooper wrote: > >> c/s d1b93ea causes substantial functional regressions in pygrub's ability > >> to > >> parse bootloader configuration files. > >> > >> c

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Stefano Stabellini
On Thu, 20 Nov 2014, Ian Campbell wrote: > On Thu, 2014-11-20 at 14:46 +, Stefano Stabellini wrote: > > On Thu, 20 Nov 2014, Ian Campbell wrote: > > > There is, it's the romfile option to -device e.g. > > > -device $NICMODEL,vlan=0,romfile=$ROMFILE > > > > > > where NICMODEL i

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Julien Grall
Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: > On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: >> By default, the script get_maintainer.pl will remove duplicates email as soon >> as it appends the list of maintainers of a new file, and therefore override >> the role of the developper

Re: [Xen-devel] [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-20 Thread Andrew Cooper
On 20/11/14 16:00, Ian Campbell wrote: > On Mon, 2014-11-17 at 15:19 +, Andrew Cooper wrote: >> c/s d1b93ea causes substantial functional regressions in pygrub's ability to >> parse bootloader configuration files. >> >> c/s d1b93ea itself changed an an interface which previously used exclusivel

Re: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

2014-11-20 Thread Ian Campbell
On Tue, 2014-11-18 at 20:03 +, Julien Grall wrote: > By default, the script get_maintainer.pl will remove duplicates email as soon > as it appends the list of maintainers of a new file, and therefore override > the role of the developper. > > On complex patch (see [1]), this will result to omm

Re: [Xen-devel] [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread George Dunlap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/20/2014 03:56 PM, Ian Campbell wrote: > On Thu, 2014-11-20 at 15:51 +, George Dunlap wrote: >> On 11/20/2014 03:47 PM, Ian Campbell wrote: >>> On Mon, 2014-11-17 at 12:36 +, George Dunlap wrote: On 11/14/2014 11:12 AM, Ian Campbell

Re: [Xen-devel] [PATCH for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread George Dunlap
On Wed, Nov 12, 2014 at 5:31 PM, George Dunlap wrote: > Return proper error codes on failure so that scripts can tell whether > the command completed properly or not. How about changing this to something like: --- Return proper error codes on failure so that scripts can tell whether the command

Re: [Xen-devel] Xen 4.5 random freeze question

2014-11-20 Thread Andrii Tseglytskyi
I think I'll debug this a bit later - unfortunately, now don't have time for this. But I want to get rid of spurious interrupt here. BTW - Stefano are you going to post the patch that we created yesterday ? Will Ian accept it? Regards, Andrii On Thu, Nov 20, 2014 at 1:15 PM, Julien Grall wrote:

Re: [Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Wei Liu
On Thu, Nov 20, 2014 at 03:48:47PM +, Ian Campbell wrote: > The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which > is freed by xc_dom_release. However the various xc_try_*_decode routines > (other > than the gzip one) just use plain malloc/realloc and therefore the buf

Re: [Xen-devel] [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2

2014-11-20 Thread Ian Campbell
On Mon, 2014-11-17 at 15:19 +, Andrew Cooper wrote: > c/s d1b93ea causes substantial functional regressions in pygrub's ability to > parse bootloader configuration files. > > c/s d1b93ea itself changed an an interface which previously used exclusively > integers, to using strings in the case o

Re: [Xen-devel] [PATCH for-4.5 v2] docs/commandline: Fix formatting issues

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 15:22 +, Andrew Cooper wrote: > For 'dom0_max_vcpus' and 'hvm_debug', markdown was interpreting the text as > regular text, and reflowing it as a regular paragraph, leading to a single > line as output. Reformat them as code blocks inside blockquote blocks, which > causes

Re: [Xen-devel] [PATCH 0/5 v2 for-4.5] xen: arm: xgene bug fixes + support for McDivitt

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 16:27 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 19, 2014 at 03:27:48PM +, Ian Campbell wrote: > > These patches: > > > > * fix up an off by one bug in the xgene mapping of additional PCI > > bus resources, which would cause an additional extra page t

Re: [Xen-devel] Strangeness in generated xen-command-line.html

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 06:11 -0500, Konrad Rzeszutek Wilk wrote: > On November 19, 2014 6:05:33 AM EST, Andrew Cooper > wrote: > >On 19/11/14 11:04, Ian Campbell wrote: > >> Signed-off-by: Ian Campbell > > > >Reviewed-by: Andrew Cooper > > Release-Acked-by: Konrad Rzeszutek Wilk (konrad.w...@or

Re: [Xen-devel] [PATCH for-4.5] libxl: remove existence check for PCI device hotplug

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 16:28 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 19, 2014 at 09:21:23PM +, Wei Liu wrote: > > On Wed, Nov 19, 2014 at 04:01:54PM -0500, Konrad Rzeszutek Wilk wrote: > > > On Mon, Nov 17, 2014 at 12:10:34PM +, Wei Liu wrote: > > > > The existence check is to make

Re: [Xen-devel] [PATCH] libxl: Document device parameter of libxl_device__add functions

2014-11-20 Thread Ian Campbell
On Tue, 2014-11-18 at 13:19 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 18, 2014 at 05:44:20PM +, Ian Jackson wrote: > > Euan Harris writes ("[PATCH] libxl: Document device parameter of > > libxl_device__add functions"): > > > The device parameter of libxl_device__add is an in/out parame

Re: [Xen-devel] [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 14:45 -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 14, 2014 at 10:10:58AM +, Ian Campbell wrote: > > (CCing some more maintainers and the release manager) > > > > On Wed, 2014-11-12 at 15:43 +, Ian Campbell wrote: > > > On Wed, 2014-11-12 at 09:38 -0600, Clark La

Re: [Xen-devel] [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 15:51 +, George Dunlap wrote: > On 11/20/2014 03:47 PM, Ian Campbell wrote: > > On Mon, 2014-11-17 at 12:36 +, George Dunlap wrote: > >> On 11/14/2014 11:12 AM, Ian Campbell wrote: > >>> On Thu, 2014-11-13 at 19:04 +, George Dunlap wrote: > Return proper error

Re: [Xen-devel] [PATCH v2 for-4.5] xen/arm: clear UIE on hypervisor entry

2014-11-20 Thread Stefano Stabellini
On Thu, 20 Nov 2014, Julien Grall wrote: > On 11/20/2014 11:02 AM, Julien Grall wrote: > > Hi Stefano, > > > > On 11/20/2014 10:53 AM, Stefano Stabellini wrote: > >> UIE being set can cause maintenance interrupts to occur when Xen writes > >> to one or more LR registers. The effect is a busy loop

Re: [Xen-devel] [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread George Dunlap
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/20/2014 03:47 PM, Ian Campbell wrote: > On Mon, 2014-11-17 at 12:36 +, George Dunlap wrote: >> On 11/14/2014 11:12 AM, Ian Campbell wrote: >>> On Thu, 2014-11-13 at 19:04 +, George Dunlap wrote: Return proper error codes on failure

[Xen-devel] [PATCH for-4.5 v2] libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-20 Thread Ian Campbell
The libxc xc_dom_* infrastructure uses a very simple malloc memory pool which is freed by xc_dom_release. However the various xc_try_*_decode routines (other than the gzip one) just use plain malloc/realloc and therefore the buffer ends up leaked. The memory pool currently supports mmap'd buffers

Re: [Xen-devel] [PATCH] set pv guest default video_memkb to 0

2014-11-20 Thread Wei Liu
On Thu, Nov 20, 2014 at 03:29:51PM +, Ian Campbell wrote: > On Wed, 2014-11-19 at 21:24 +, Wei Liu wrote: > > On Wed, Nov 19, 2014 at 04:08:46PM -0500, Konrad Rzeszutek Wilk wrote: > > > On Tue, Nov 18, 2014 at 03:57:08PM -0500, Zhigang Wang wrote: > > > > Before this patch, pv guest video_

Re: [Xen-devel] [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

2014-11-20 Thread Ian Campbell
On Mon, 2014-11-17 at 12:36 +, George Dunlap wrote: > On 11/14/2014 11:12 AM, Ian Campbell wrote: > > On Thu, 2014-11-13 at 19:04 +, George Dunlap wrote: > >> Return proper error codes on failure so that scripts can tell whether > >> the command completed properly or not. > >> > >> Also whi

[Xen-devel] [PATCH v2 3/3] x86/HVM: don't crash guest upon problems occurring in user mode

2014-11-20 Thread Jan Beulich
This extends commit 5283b310 ("x86/HVM: only kill guest when unknown VM exit occurred in guest kernel mode") to a few more cases, including the failed VM entry one that XSA-110 was needed to be issued for. Signed-off-by: Jan Beulich --- v2: - s/crash_or_gp/crash_or_fault/ - drop changes to sv

Re: [Xen-devel] [PATCH v2 3/3] x86/HVM: don't crash guest upon problems occurring in user mode

2014-11-20 Thread Andrew Cooper
On 20/11/14 15:37, Jan Beulich wrote: > This extends commit 5283b310 ("x86/HVM: only kill guest when unknown VM > exit occurred in guest kernel mode") to a few more cases, including the > failed VM entry one that XSA-110 was needed to be issued for. > > Signed-off-by: Jan Beulich Reviewed-by: And

Re: [Xen-devel] [PATCH v2 3/3] x86/HVM: don't crash guest upon problems occurring in user mode

2014-11-20 Thread Tim Deegan
At 16:37 +0100 on 20 Nov (1416497837), Jan Beulich wrote: > This extends commit 5283b310 ("x86/HVM: only kill guest when unknown VM > exit occurred in guest kernel mode") to a few more cases, including the > failed VM entry one that XSA-110 was needed to be issued for. > > Signed-off-by: Jan Beuli

Re: [Xen-devel] [PATCH] set pv guest default video_memkb to 0

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 21:24 +, Wei Liu wrote: > On Wed, Nov 19, 2014 at 04:08:46PM -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Nov 18, 2014 at 03:57:08PM -0500, Zhigang Wang wrote: > > > Before this patch, pv guest video_memkb is -1, which is an invalid value. > > > And it will cause the xe

Re: [Xen-devel] [PATCH] set pv guest default video_memkb to 0

2014-11-20 Thread Ian Campbell
On Tue, 2014-11-18 at 15:57 -0500, Zhigang Wang wrote: > Before this patch, pv guest video_memkb is -1, which is an invalid value. > And it will cause the xenstore 'memory/targe' calculation wrong: > > memory/target = info->target_memkb - info->video_memkb > > Signed-off-by: Zhigang Wang Ac

Re: [Xen-devel] [PATCH 0/2 V3] fix rename: xenstore not fully updated

2014-11-20 Thread Ian Campbell
On Wed, 2014-11-19 at 16:25 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 19, 2014 at 11:26:32AM +, Ian Jackson wrote: > > Hi Konrad, I have another release ack request: > > > > Chunyan Liu writes ("[PATCH 0/2 V3] fix rename: xenstore not fully > > updated"): > > > Currently libxl__domain

[Xen-devel] [PATCH for-4.5 v2] docs/commandline: Fix formatting issues

2014-11-20 Thread Andrew Cooper
For 'dom0_max_vcpus' and 'hvm_debug', markdown was interpreting the text as regular text, and reflowing it as a regular paragraph, leading to a single line as output. Reformat them as code blocks inside blockquote blocks, which causes them to take their precise whitespace layout. For 'psr', the b

[Xen-devel] Processed: Re: Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread xen
Processing commands for x...@bugs.xenproject.org: > create ^ Created new bug #46 rooted at `<1416474814.29243.59.ca...@citrix.com>' Title: `Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)' > titl

Re: [Xen-devel] [RFC for 4.6] xen: Extend DOMCTL createdomain to support arch configuration

2014-11-20 Thread Julien Grall
Hi Jan, On 11/20/2014 02:37 PM, Jan Beulich wrote: On 18.11.14 at 20:20, wrote: >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -540,6 +540,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) >> int i, j, e820_warn = 0, bytes = 0; >> bool_t acpi_boot_table_

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Ian Campbell
create ^ title it qemu-upstream: limitation on 4 emulated NICs prevents guest from starting unless PV override is used. thanks ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 14:46 +, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Ian Campbell wrote: > > There is, it's the romfile option to -device e.g. > > -device $NICMODEL,vlan=0,romfile=$ROMFILE > > > > where NICMODEL is e100, rtl8139, virtio-blah > > and ROMFILE is e.g.

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Stefano Stabellini
On Thu, 20 Nov 2014, Ian Campbell wrote: > On Thu, 2014-11-20 at 11:39 +, Stefano Stabellini wrote: > > On Thu, 20 Nov 2014, Ian Campbell wrote: > > > On Mon, 2014-11-17 at 13:00 +, Stefano Stabellini wrote: > > > > On Mon, 17 Nov 2014, Ian Campbell wrote: > > > > > On Sat, 2014-11-15 at 10

Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

2014-11-20 Thread Jan Beulich
>>> On 20.11.14 at 15:40, wrote: >> From: Tian, Kevin >> Sent: Thursday, November 20, 2014 4:51 PM >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: Thursday, November 20, 2014 4:04 PM >> > >>> On 20.11.14 at 08:45, wrote: >> > > Current option sounds a reasonable one, i.e. passing a

Re: [Xen-devel] [PATCH] Ignore non-zero data in unused xsave area.

2014-11-20 Thread Jan Beulich
>>> On 20.11.14 at 15:35, wrote: > On Tue, 18 Nov 2014 10:26:31 -0500 > Don Koch wrote: > >> If we restore an xsave area from an older xen that has a larger >> size than the xcr0 bit call for, it is possible to have non-zero >> data in the unused area if an xsave has ever been done that used >>

Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

2014-11-20 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, November 20, 2014 4:51 PM > > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: Thursday, November 20, 2014 4:04 PM > > > > >>> On 20.11.14 at 08:45, wrote: > > > Yang and I did some discussion here. We understand your point to > > > avoid introducing

Re: [Xen-devel] [RFC for 4.6] xen: Extend DOMCTL createdomain to support arch configuration

2014-11-20 Thread Jan Beulich
>>> On 18.11.14 at 20:20, wrote: > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -540,6 +540,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > int i, j, e820_warn = 0, bytes = 0; > bool_t acpi_boot_table_init_done = 0; > struct domain *dom0; > +struct a

Re: [Xen-devel] [PATCH] Ignore non-zero data in unused xsave area.

2014-11-20 Thread Don Koch
This change can be ignored. Details below. On Tue, 18 Nov 2014 10:26:31 -0500 Don Koch wrote: > If we restore an xsave area from an older xen that has a larger > size than the xcr0 bit call for, it is possible to have non-zero > data in the unused area if an xsave has ever been done that used >

Re: [Xen-devel] Xen-4.5 Testing - Cache Monitoring Technology

2014-11-20 Thread Andrew Cooper
On 20/11/14 10:23, Andrew Cooper wrote: > On 20/11/14 10:15, Chao Peng wrote: >> On Thu, Nov 20, 2014 at 09:58:37AM +, Andrew Cooper wrote: >>> Hi, >>> >>> I have found myself a PSR-capable server and have been having a play >>> with Xen-4.5 >>> >>> At a first pass, I can get some numbers out:

[Xen-devel] DRAFT: XSA-113: Guest effectable page reference leak in MMU_MACHPHYS_UPDATE handling

2014-11-20 Thread Jan Beulich
Xen Security Advisory XSA-113 Guest effectable page reference leak in MMU_MACHPHYS_UPDATE handling *** EMBARGOED UNTIL 2014-11-27 12:00 UTC *** ISSUE DESCRIPTION = An error handling path in the processing of MMU_MACHPHYS_UPDATE failed to drop

[Xen-devel] [qemu-upstream-unstable test] 31688: regressions - FAIL

2014-11-20 Thread xen . org
flight 31688 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/31688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 5 xen-build fail REGR. vs. 31647 Tests whic

[Xen-devel] [OSSTEST PATCH] linux-next tests: Use correct branch for baseline

2014-11-20 Thread Ian Jackson
Make cr-daily-branch honour an environment or setting variable EXTRA_SGR_ARGS. In branch-settings.linux-next set it appropriately to arrange that the linux-next test reports consider linux-linus tests as interesting as well as just linux-next ones. (We already use a flight from linux-linus for se

Re: [Xen-devel] [PATCH 3/3] x86/HVM: don't crash guest upon problems occurring in user mode

2014-11-20 Thread Jan Beulich
>>> On 20.11.14 at 12:34, wrote: > At 11:13 +0100 on 20 Nov (1416478386), Jan Beulich wrote: >> This extends commit 5283b310 ("x86/HVM: only kill guest when unknown VM >> exit occurred in guest kernel mode") to further cases, including the >> failed VM entry one that XSA-110 was needed to be issue

Re: [Xen-devel] [PATCH 3/3] x86/HVM: don't crash guest upon problems occurring in user mode

2014-11-20 Thread Tim Deegan
At 11:13 +0100 on 20 Nov (1416478386), Jan Beulich wrote: > This extends commit 5283b310 ("x86/HVM: only kill guest when unknown VM > exit occurred in guest kernel mode") to further cases, including the > failed VM entry one that XSA-110 was needed to be issued for. > > Signed-off-by: Jan Beulich

Re: [Xen-devel] [Vote] Confirm Konrad Rzeszutek Wilk as Xen project Hypervisor Committer (please vote by Nov 30th)

2014-11-20 Thread Tim Deegan
At 16:26 + on 17 Nov (1416237976), Lars Kurth wrote: > last week Ian Jackson nominated Konrad as Xen Project Hypervisor committer. > > Our governance process requires a formal vote by existing committers > to confirm Konrad and for me to set up a voting form. Existing > committers are: Keir Fr

Re: [Xen-devel] [Vote] Confirm Konrad Rzeszutek Wilk as Xen project Hypervisor Committer (please vote by Nov 30th)

2014-11-20 Thread Ian Jackson
Lars Kurth writes ("[Xen-devel] [Vote] Confirm Konrad Rzeszutek Wilk as Xen project Hypervisor Committer (please vote by Nov 30th)"): > The voting form is at https://docs.google.com/forms/d/ > 1Hpoda2VjdMMGDsz1zh01tkHPR1vUsVeUVAR0DWhlgik/viewform but if you want to vote > in public feel free to ju

[Xen-devel] [PATCH 4/4] x86/xen: assume a 64-bit DMA mask is required

2014-11-20 Thread David Vrabel
On a Xen PV guest the DMA addresses and physical addresses are not 1:1 (such as Xen PV guests) and the generic dma_get_required_mask() does not return the correct mask (since it uses max_pfn). Some device drivers (such as mptsas, mpt2sas) use dma_get_required_mask() to set the device's DMA mask to

[Xen-devel] [PATCH 1/4] dma: add dma_get_required_mask_from_max_pfn()

2014-11-20 Thread David Vrabel
A generic dma_get_required_mask() is useful even for architectures (such as ia64) that define ARCH_HAS_GET_REQUIRED_MASK. Signed-off-by: David Vrabel Reviewed-by: Stefano Stabellini --- drivers/base/platform.c | 10 -- include/linux/dma-mapping.h |1 + 2 files changed, 9 inser

[Xen-devel] [PATCH 2/4] ia64: use common dma_get_required_mask_from_pfn()

2014-11-20 Thread David Vrabel
Signed-off-by: David Vrabel Reviewed-by: Stefano Stabellini Cc: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org --- arch/ia64/include/asm/machvec.h |2 +- arch/ia64/include/asm/machvec_init.h |1 - arch/ia64/pci/pci.c | 20 3 files c

[Xen-devel] [PATCH 3/4] x86: allow dma_get_required_mask() to be overridden

2014-11-20 Thread David Vrabel
Use dma_ops->get_required_mask() if provided, defaulting to dma_get_requried_mask_from_max_pfn(). This is needed on systems (such as Xen PV guests) where the DMA address and the physical address are not equal. ARCH_HAS_DMA_GET_REQUIRED_MASK is defined in asm/device.h instead of asm/dma-mapping.h

[Xen-devel] [PATCHv4 0/4]: dma, x86, xen: reduce SWIOTLB usage in Xen guests

2014-11-20 Thread David Vrabel
On systems where DMA addresses and physical addresses are not 1:1 (such as Xen PV guests), the generic dma_get_required_mask() will not return the correct mask (since it uses max_pfn). Some device drivers (such as mptsas, mpt2sas) use dma_get_required_mask() to set the device's DMA mask to allow t

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Ian Campbell
On Thu, 2014-11-20 at 11:39 +, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Ian Campbell wrote: > > On Mon, 2014-11-17 at 13:00 +, Stefano Stabellini wrote: > > > On Mon, 17 Nov 2014, Ian Campbell wrote: > > > > On Sat, 2014-11-15 at 10:16 +0800, hanyandong wrote: > > > > > By the way,

Re: [Xen-devel] [PATCH 4/4] x86/xen: use the maximum MFN to calculate the required DMA mask

2014-11-20 Thread David Vrabel
On 19/11/14 17:51, Stefano Stabellini wrote: > On Wed, 19 Nov 2014, David Vrabel wrote: >> >> +u64 >> +xen_swiotlb_get_required_mask(struct device *dev) >> +{ >> +unsigned long max_mfn; >> + >> +max_mfn = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL); > > As Jan pointed out, I think

Re: [Xen-devel] Number of NICs per VM with qemu-upstream (Was: Re: Re: [Xen-users] libvirt /usr/local/lib/xen/bin/qemu-dm did not work on xen-4.4)

2014-11-20 Thread Stefano Stabellini
On Thu, 20 Nov 2014, Ian Campbell wrote: > On Mon, 2014-11-17 at 13:00 +, Stefano Stabellini wrote: > > On Mon, 17 Nov 2014, Ian Campbell wrote: > > > On Sat, 2014-11-15 at 10:16 +0800, hanyandong wrote: > > > > By the way, how many NICs can I apply to a VM? > > > > > > > > On xen-4.4.0, Using

Re: [Xen-devel] [PATCH V3] Decouple SnadyBridge quirk form VTd timeout

2014-11-20 Thread Jan Beulich
>>> On 19.11.14 at 20:46, wrote: > @@ -237,6 +248,42 @@ > } > } > > +static void __init parse_snb_timeout(const char *s) > +{ > + int not; > + > + switch (*s) { > + > + case '\0': > + snb_igd_timeout = SNB_IGD_TIMEOUT_LEGACY; > + break; > + > + case

  1   2   >