On Thu, 2014-11-20 at 16:43 +0000, Julien Grall wrote: > On 11/20/2014 04:29 PM, Ian Campbell wrote: > >> Forgot to add, the example above show the difference without and with > >> the patch. The list is correct because both ARM and x86 maintainers > >> should be CC. Because of this all "THE REST" maintainers are added. > > > > Just to be clear, you mean that everyone under THE REST is added solely > > because they also happen to be maintainers of some other relevant bit of > > code, not that THE REST is explicitly added in this case, right? > > Yes, my description was confusing. With setting $email_remove_duplicates > to 0, the script will: > 1) Append the list of maintainers for every file > 2) Filter the list to remove the entry with "THE REST" role > 3) Remove duplicated address > > The previous behavior was: > 1) Get the list of maintainers of the file (incidentally all the > maintainers in "THE REST" role are added). If the email address already > exists in the global list, skip it. > 2) Filter the list to remove the entry with "THE REST" role > > So if a maintainers is marked on the "THE REST" on the first file and > actually be an x86 maintainers on the second file, the scripts will only > retain the "THE REST" role. > > If it's more clear, I can add the explanation above in the commit message.
It is, please do. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
